[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This might be a little light on the testing side. Repository: rG LLVM

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/Sema/SemaChecking.cpp:6773 + bool CallerHasZAState = false; + if (auto *CallerFD = dyn_cast(CurContext))

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

aaron.ballman added reviewers: efriedma, rjmccall, rsmith. aaron.ballman added a comment. Adding codegen and ubsan code owners for opinions. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1791 + // Try to eliminate overflow check. + if (auto *VCI = dyn_cast(ArgValue)) { +if

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit extends ClangAttrEmitter of tablegen to generate Attr*::getVariety

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

paulwalker-arm added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6762 +Context.getFunctionFeatureMap(CallerFeatureMap, CallerFD); +if (!CallerFeatureMap.count("sme")) + Diag(Loc, diag::err_sme_call_in_non_sme_target); `co

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

aaron.ballman added a comment. I'm not qualified to give a review of the functional changes, but the intent for the changes SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 _

[PATCH] D157011: [Clang][Tooling] Accept preprocessed input files

This revision was automatically updated to reflect the committed changes. Closed by commit rG241cceb9af84: [Clang][Tooling] Accept preprocessed input files (authored by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157011/new/ https://revie

[clang] 241cceb - [Clang][Tooling] Accept preprocessed input files

Author: J. Ryan Stinnett Date: 2023-08-08T12:44:48+01:00 New Revision: 241cceb9af844ef7d7a87124407a04b0a64991fe URL: https://github.com/llvm/llvm-project/commit/241cceb9af844ef7d7a87124407a04b0a64991fe DIFF: https://github.com/llvm/llvm-project/commit/241cceb9af844ef7d7a87124407a04b0a64991fe.di

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

aaron.ballman added a comment. In D142609#4568095 , @xgupta wrote: > In D142609#4566418 , @aaron.ballman > wrote: > >> Concerns have been raised in >> https://github.com/llvm/llvm-project/issues/64356 that this

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc, diag::warn_int

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. BEFORE: overflow.cpp:1:21: warning: overflow in expression; result is -2147483648 with type 'int' [

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

This revision was automatically updated to reflect the committed changes. yronglin marked 2 inline comments as done. Closed by commit rGa2132d72bed1: [Clang] Fix the do while statement disappearing in AST when an error occurs in… (authored by yronglin). Repository: rG LLVM Github Monorepo CHAN

[clang] a2132d7 - [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

Author: yrong Date: 2023-08-08T19:34:43+08:00 New Revision: a2132d72bed153a3347763dfaa7e699de7128647 URL: https://github.com/llvm/llvm-project/commit/a2132d72bed153a3347763dfaa7e699de7128647 DIFF: https://github.com/llvm/llvm-project/commit/a2132d72bed153a3347763dfaa7e699de7128647.diff LOG: [C

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548148. victorkingi added a comment. from CamelCase to camelCase variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Opt

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

donat.nagy added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + Szelethus wrote:

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arrive in

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

balazske added a comment. This fix can cause problems because the depth comparison is omitted all times. It would be better to omit depth check if the imported template is a friend, and has a `ClassTemplateSpecializationDecl` as context. Probably even then it is possible to construct cases wher

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi updated this revision to Diff 548142. victorkingi added a comment. fixing failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D155824: [LoongArch] Support -march=native and -mtune=

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. This still LGTM, @steven_wu would you please take another look so this can get re-landed if confirmed working? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo added a comment. In D157332#4568341 , @efriedma wrote: > I see what you're getting at here... but I don't think this works quite > right. If the empty class has a non-trivial constructor, we have to pass the > correct "this" address to that co

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen updated this revision to Diff 548131. sdesmalen added a comment. Added test-cases for indirect calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157270/new/ https://reviews.llvm.org/D157270 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

sdesmalen updated this revision to Diff 548130. sdesmalen added a comment. - (Clang) Added test-cases for indirect calls. - (LLVM) Moved the pseudo definition out of the 'let Predicates = [HasSME] {}' block as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D157270: [Clang][AArch64] Add diagnostic for calls from non-ZA to shared-ZA functions.

sdesmalen added inline comments. Comment at: clang/test/Sema/aarch64-sme-func-attrs.c:181 +void non_za_definition(void) { + sme_arm_new_za(); // OK rsandifo-arm wrote: > sdesmalen wrote: > > rsandifo-arm wrote: > > > sdesmalen wrote: > > > > rsandifo-arm wrote

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. In D156537#4554413 , @v.g.vassilev wrote: > In D156537#4554052 , @Hahnfeld > wrote: > >> @v.g.vassilev do we have a means to detect this case? In D156897 >>

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reemission is only needed in incremental mode. With this early

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

Szelethus added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1189 +``onwership_returns``: Functions with this annotation return dynamic memory. +The second annotation parameter is the size of the returned memory in bytes. + aaron.ballman wro

[PATCH] D156787: [analyzer][attr] Add docs to ownership_* attributes

Szelethus updated this revision to Diff 548116. Szelethus marked 4 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156787/new/ https://reviews.llvm.org/D156787 Files: clang/include/clang/Basic/Att

[PATCH] D157376: [clang-tidy] Ignore unevaluated context in cppcoreguidelines-pro-type-vararg

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[clang-tools-extra] 7899d2a - [clang-tidy][NFC] Remove trailing whitespaces from ProTypeVarargCheck

Author: Piotr Zegar Date: 2023-08-08T08:56:41Z New Revision: 7899d2aa666359adc6b1d3a66e36f07c2130eb6c URL: https://github.com/llvm/llvm-project/commit/7899d2aa666359adc6b1d3a66e36f07c2130eb6c DIFF: https://github.com/llvm/llvm-project/commit/7899d2aa666359adc6b1d3a66e36f07c2130eb6c.diff LOG: [

[PATCH] D156320: [FLang] Add support for Rpass flag

victorkingi added a comment. In D156320#4560839 , @awarzynski wrote: > Hey @victorkingi , thank you for working on this :) > > There's quite a lot going on here and I am thinking that it might be good to > split this into a few patches? Also, please not

[PATCH] D157374: [clang-tidy] Ignore decltype in misc-redundant-expression

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Modify check to ignor

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548103. Herald added a subscriber: jplehr. Herald added a reviewer: kiranchandramohan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. `test/Driver/openmp-offload-jit.c` was still failing for me with CUDA installed, so I pushed rGcb3136b0d3596f5c3984e4fb49359e2a1a28a547 to add an explicit `--cuda-path` and make it return exit code 0

[clang] cb3136b - [clang] Pass --cuda-path to fix test/Driver/openmp-offload-jit.c

Author: Jonas Hahnfeld Date: 2023-08-08T10:21:55+02:00 New Revision: cb3136b0d3596f5c3984e4fb49359e2a1a28a547 URL: https://github.com/llvm/llvm-project/commit/cb3136b0d3596f5c3984e4fb49359e2a1a28a547 DIFF: https://github.com/llvm/llvm-project/commit/cb3136b0d3596f5c3984e4fb49359e2a1a28a547.diff

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. This checker was originally in the "unix" package. I agree that this is not exact and `core` can be better, the checked functions should be available in any default C library on UNIX, OSX, Windows or other platforms too, even the POSIX ones at least in some cases. Re

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf47f037b2: [clang] Error on substitution failure within lambda body inside a requires… (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 38cf47f - [clang] Error on substitution failure within lambda body inside a requires-expression

Author: Podchishchaeva, Mariya Date: 2023-08-08T01:08:38-07:00 New Revision: 38cf47f037b2504a57ba5673f507241af1d6e19d URL: https://github.com/llvm/llvm-project/commit/38cf47f037b2504a57ba5673f507241af1d6e19d DIFF: https://github.com/llvm/llvm-project/commit/38cf47f037b2504a57ba5673f507241af1d6e

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

hokein added a comment. Thanks for exploring all the options. For case 1) > Note that CXXMemberCallExpr 0x55d106716260 > relies on > RParenLoc directly. Coroutine is implemented as member call so I think RParen > is intended and should exist and be correct. Yeah, I think this is because we do

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

donat.nagy added a comment. Why is this checker placed in the "unix" group (instead of e.g. "core")? As far as I understand it can check some POSIX-specific functions with a flag (that's off by default) but the core functionality checks platform-independent standard library functions. Moreover

[PATCH] D156878: [OpenMP][OMPD][Doc] Update the implementation details of OMPD

This revision was automatically updated to reflect the committed changes. Closed by commit rG658490abc97a: [OpenMP][OMPD][Doc] Update OMPD implementations details. (authored by Vignesh Balasubramanian ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 658490a - [OpenMP][OMPD][Doc] Update OMPD implementations details.

Author: Vignesh Balasubramanian Date: 2023-08-08T13:11:35+05:30 New Revision: 658490abc97a291fc01e463599404f28e2126335 URL: https://github.com/llvm/llvm-project/commit/658490abc97a291fc01e463599404f28e2126335 DIFF: https://github.com/llvm/llvm-project/commit/658490abc97a291fc01e463599404f28e212

[PATCH] D157362: [RISCV] Add Zicfilp extension.

fakepaper56 updated this revision to Diff 548088. fakepaper56 added a comment. Also support pseudo instruction lpad. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 Files: clang/test/Preprocessor/riscv-

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28b5f3087a3f: [Clang][AArch64] Add/implement ACLE keywords for SME. (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D12

[clang] 28b5f30 - [Clang][AArch64] Add/implement ACLE keywords for SME.

Author: Sander de Smalen Date: 2023-08-08T07:00:59Z New Revision: 28b5f3087a3fcd39c80e2b1470a950da17e4cd08 URL: https://github.com/llvm/llvm-project/commit/28b5f3087a3fcd39c80e2b1470a950da17e4cd08 DIFF: https://github.com/llvm/llvm-project/commit/28b5f3087a3fcd39c80e2b1470a950da17e4cd08.diff L

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm ok with this if @owenpan is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-c

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:841 const auto *ParamTy = - Method->getParamDecl(0)->getType()->getAs(); + Method->getNonObjectParameter(0)->getType()->getAs(); if (!ParamTy || ParamTy->getPointeeType().isConst

[PATCH] D157367: [clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri updated this revision to Diff 548082. sandeepkosuri added a comment. - Updated `SemaOpenMP.cpp` to support `thread_limit` clause on the newly allowed directives. - This update is to fix the newly added LIT tests' failures (which were occurring only on debug build) CHANGES SINCE

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. In D152495#4566634 , @aaron.ballman wrote: > In D152495#4563520 , @hazohelet > wrote: > >> I reverted this change because it broke sanitizer buildbots. >> https://lab.llvm.org/buildbot

<    1   2   3