[compiler-rt] [libc] [clang] [llvm] [clang-tools-extra] [flang] [libcxx] [openmp] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-12-08 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 6d5d35e1273f595e8a0382053d5183cbce7a9d8a Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 1/5] [clang-tidy] Add bugprone-move-shared-pointer-contents

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
https://github.com/knightXun updated https://github.com/llvm/llvm-project/pull/74885 >From 12cc1fe332fbab94c1368ea95374d5a1289a22f8 Mon Sep 17 00:00:00 2001 From: knightXun Date: Sat, 9 Dec 2023 04:57:15 +0800 Subject: [PATCH] [Clang][Sema] Check the number of lambda non-concept tempate

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
https://github.com/knightXun updated https://github.com/llvm/llvm-project/pull/74885 >From 12cc1fe332fbab94c1368ea95374d5a1289a22f8 Mon Sep 17 00:00:00 2001 From: knightXun Date: Sat, 9 Dec 2023 04:57:15 +0800 Subject: [PATCH 1/2] [Clang][Sema] Check the number of lambda non-concept tempate

[clang] [clang] Adjust TargetInfo bitfield (PR #74893)

2023-12-08 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan created https://github.com/llvm/llvm-project/pull/74893 An 8 bit bitfield with preferred bool type? Seems confused. >From f7cac332123f6ea6c78dcffbcac2d58f356b6396 Mon Sep 17 00:00:00 2001 From: Nathan Sidwell Date: Fri, 8 Dec 2023 17:43:22 -0500 Subject: [PATCH]

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
https://github.com/knightXun updated https://github.com/llvm/llvm-project/pull/74885 >From 12cc1fe332fbab94c1368ea95374d5a1289a22f8 Mon Sep 17 00:00:00 2001 From: knightXun Date: Sat, 9 Dec 2023 04:57:15 +0800 Subject: [PATCH] [Clang][Sema] Check the number of lambda non-concept tempate

[clang-tools-extra] [llvm] [compiler-rt] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread David Li via cfe-commits
david-xl wrote: > > > . For IR PGO, there is basically no need to do so as the instrumentation > > > and profile-use should be in-sync. For front-end instrumentation, there > > > seem to be some use cases to use out of sync profile: > > > https://reviews.llvm.org/D51240. > > > > > > Thanks

[clang] [clang] NFCI: Make `ModuleFile::File` non-optional (PR #74892)

2023-12-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/74892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: Make `ModuleFile::File` non-optional (PR #74892)

2023-12-08 Thread Jan Svoboda via cfe-commits
@@ -441,22 +434,19 @@ void ModuleManager::visit(llvm::function_ref Visitor, bool ModuleManager::lookupModuleFile(StringRef FileName, off_t ExpectedSize, time_t ExpectedModTime, OptionalFileEntryRef ) {

[clang-tools-extra] [llvm] [compiler-rt] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: > > . For IR PGO, there is basically no need to do so as the instrumentation > > and profile-use should be in-sync. For front-end instrumentation, there > > seem to be some use cases to use out of sync profile: > > https://reviews.llvm.org/D51240. > > Thanks for double

[clang] [clang] NFCI: Make `ModuleFile::File` non-optional (PR #74892)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes AFAICT, `ModuleFile::File` can be `std::nullopt` only for PCM files loaded from the standard input. This patch starts setting that variable to `FileManager::getSTDIN()` in that case, which makes it

[clang] [clang] NFCI: Make `ModuleFile::File` non-optional (PR #74892)

2023-12-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/74892 AFAICT, `ModuleFile::File` can be `std::nullopt` only for PCM files loaded from the standard input. This patch starts setting that variable to `FileManager::getSTDIN()` in that case, which makes it

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
@@ -2822,13 +2825,18 @@ bool UnwindCursor::setInfoForSigReturn(Registers_s390x &) { // onto the stack. const pint_t pc = static_cast(this->getReg(UNW_REG_IP)); // The PC might contain an invalid address if the unwind info is bad, so - // directly accessing it could

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google updated https://github.com/llvm/llvm-project/pull/74791 >From 1f4df1b82970c95684eed93c8f6bcaa6d6507b88 Mon Sep 17 00:00:00 2001 From: Jordan R Abrahams-Whitehead Date: Fri, 8 Dec 2023 00:09:59 + Subject: [PATCH 1/2] [libunwind] Replace process_vm_readv

[flang] [clang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2023-12-08 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/74377 From 1eefb9136ea042e44ada4be66a18b4bf69c18fe3 Mon Sep 17 00:00:00 2001 From: Andrzej Warzynski Date: Sat, 2 Dec 2023 14:01:02 + Subject: [PATCH 1/3] [flang][driver] Rename `flang-new` as `flang` This

[clang-tools-extra] [llvm] [clang] [Clang] Generate the GEP instead of adding AST nodes (PR #73730)

2023-12-08 Thread Bill Wendling via cfe-commits
@@ -4022,8 +4169,36 @@ LValue CodeGenFunction::EmitArraySubscriptExpr(const ArraySubscriptExpr *E, ArrayLV = EmitArraySubscriptExpr(ASE, /*Accessed*/ true); else ArrayLV = EmitLValue(Array); + auto *Idx = EmitIdxAfterBase(/*Promote*/true); +if

[lld] [llvm] [mlir] [lldb] [flang] [clang] [openmp] [clang-tools-extra] [libcxx] [libcxxabi] [compiler-rt] [libc] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/11] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=

[clang-tools-extra] [clang-tidy] Fix missing parentheses in readability-implicit-bool-conversion fixes (PR #74891)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Piotr Zegar (PiotrZSL) Changes Check now more properly add missing parentheses to code like this: 'bool bar = true ? 1 : 0 != 0;'. Closes #71867 --- Patch is 31.07 KiB, truncated to 20.00 KiB below, full version:

[clang-tools-extra] [clang-tidy] Fix missing parentheses in readability-implicit-bool-conversion fixes (PR #74891)

2023-12-08 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/74891 Check now more properly add missing parentheses to code like this: 'bool bar = true ? 1 : 0 != 0;'. Closes #71867 >From 8c3b797f1f34d18c1e9211898f7d1a5697251317 Mon Sep 17 00:00:00 2001 From: Piotr Zegar

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
https://github.com/knightXun updated https://github.com/llvm/llvm-project/pull/74885 >From 4b5f4c6a15e84a9c3025a241cc5e11ad768dfdda Mon Sep 17 00:00:00 2001 From: knightXun Date: Sat, 9 Dec 2023 04:57:15 +0800 Subject: [PATCH] [Clang][Sema] Check the number of lambda non-concept tempate

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > > Probably would be good to introduce the `-v1` version and require it > > > first, then eventually change the default - so people don't get a silent > > > behavior change? Even the existing users only using `*` and `.` need to > > > change their syntax to migrate to v2,

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-08 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: My first version of the test put backslashes into the source file (i.e. `#include "C:\foo\bar"`) which doesn't really work, because Clang treats those as string escape sequences. Instead of trying to replace `\` with `\\` in the test, I chose to use forward slashes, which

[clang] [RISCV] Enable target attribute when invoked through clang driver (PR #74889)

2023-12-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 05420a17547e495f5748e9662150d6eb931e2c28 65707b837a8bb7283896d2c9d4933a17e02a20b9 --

[clang] [RISCV] Enable target attribute when invoked through clang driver (PR #74889)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Philip Reames (preames) Changes d80e46d added support for the target function attribute. However, it turns out that commit has a nasty bug/oversight. As the tests in that revision show, everything works if clang -cc1 is directly

[clang] [RISCV] Enable target attribute when invoked through clang driver (PR #74889)

2023-12-08 Thread Philip Reames via cfe-commits
https://github.com/preames created https://github.com/llvm/llvm-project/pull/74889 d80e46d added support for the target function attribute. However, it turns out that commit has a nasty bug/oversight. As the tests in that revision show, everything works if clang -cc1 is directly invoked. I

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-08 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/74782 >From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Dec 2023 15:15:16 -0800 Subject: [PATCH 1/4] [clang][lex] Fix non-portability diagnostics with

[clang-tools-extra] [compiler-rt] [clang] [flang] [libc] [lld] [openmp] [mlir] [lldb] [libcxxabi] [llvm] [libcxx] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=

[clang] [flang] [llvm] [lld] [libcxxabi] [libc] [lldb] [openmp] [compiler-rt] [libcxx] [clang-tools-extra] [mlir] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w closed https://github.com/llvm/llvm-project/pull/74886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c9b4bb9 - [Fix] Disable fdefine-target-os-macros for now (#74886)

2023-12-08 Thread via cfe-commits
Author: Zixu Wang Date: 2023-12-08T13:07:29-08:00 New Revision: c9b4bb9ff9b65a741c558bfb93719df95272c2e1 URL: https://github.com/llvm/llvm-project/commit/c9b4bb9ff9b65a741c558bfb93719df95272c2e1 DIFF: https://github.com/llvm/llvm-project/commit/c9b4bb9ff9b65a741c558bfb93719df95272c2e1.diff

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/74886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/74886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread Florian Hahn via cfe-commits
https://github.com/fhahn approved this pull request. LGTM, thanks! For reference, this is breaking llvm-test-suite builds, e.g. see https://green.lab.llvm.org/green/job/lnt-ctmark-aarch64-Os/15893/console https://github.com/llvm/llvm-project/pull/74886

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: flyingcat (knightXun) Changes Check that the number of non-concept template parameters is greater than zero during lambda template instantiation to aviod panic Fix issue: https://github.com/llvm/llvm-project/issues/70601 --- Full diff:

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Zixu Wang (zixu-w) Changes https://github.com/llvm/llvm-project/pull/74676 landed the work to implement `-fdefine-target-os-macros` and enabled the extension for the Darwin driver. However it is breaking

[clang] [Fix] Disable fdefine-target-os-macros for now (PR #74886)

2023-12-08 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w created https://github.com/llvm/llvm-project/pull/74886 https://github.com/llvm/llvm-project/pull/74676 landed the work to implement `-fdefine-target-os-macros` and enabled the extension for the Darwin driver. However it is breaking some test builds. Leave the

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-08 Thread via cfe-commits
https://github.com/knightXun created https://github.com/llvm/llvm-project/pull/74885 Check that the number of non-concept template parameters is greater than zero during lambda template instantiation to aviod panic Fix issue: https://github.com/llvm/llvm-project/issues/70601 >From

[clang] [compiler-rt] [clang-tools-extra] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Mingming Liu via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2023-12-08 Thread Florian Hahn via cfe-commits
fhahn wrote: Please also see the failures on GreenDragon: https://green.lab.llvm.org/green/job/lnt-ctmark-aarch64-Os/15893/console https://github.com/llvm/llvm-project/pull/74676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][PP] Add extension to predefine target OS macros (PR #74676)

2023-12-08 Thread Florian Hahn via cfe-commits
fhahn wrote: It looks like this breaks building at least `MultiSource` from https://github.com/llvm/llvm-test-suite/. The first failure I see is when building `llvm-test-suite/MultiSource/Applications/ClamAV/zlib_zutil.c` ``` In file included from

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
RIscRIpt wrote: Thank you! https://github.com/llvm/llvm-project/pull/71300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
@@ -2884,6 +2884,12 @@ def warn_cxx11_compat_constexpr_body_multiple_return : Warning< InGroup, DefaultIgnore; def note_constexpr_body_previous_return : Note< "previous return statement is here">; +def err_ms_constexpr_not_distinct : Error< + "[[msvc::constexpr]] cannot

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2023-12-08 Thread John McCall via cfe-commits
@@ -6,14 +7,80 @@ float z(); #pragma float_control(except, on) class ON { float w = 2 + y() * z(); - // CHECK-LABEL: define {{.*}} @_ZN2ONC2Ev{{.*}} - // CHECK: llvm.experimental.constrained.fmul{{.*}}tonearest{{.*}}strict }; ON on; #pragma float_control(except, off)

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2023-12-08 Thread John McCall via cfe-commits
@@ -5587,10 +5593,12 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo , !isa_and_nonnull(TargetDecl)) EmitKCFIOperandBundle(ConcreteCallee, BundleList); +#if 0 // XXX Why is this here? Duplicate! if (const FunctionDecl *FD =

[llvm] [flang] [clang-tools-extra] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
@@ -6,6 +6,37 @@ // //===--===// +// character.h yi-wu-arm wrote: Replaced by a comment https://github.com/llvm/llvm-project/pull/74628 ___

[llvm] [flang] [clang-tools-extra] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
@@ -37,5 +77,30 @@ void FORTRAN_PROCEDURE_NAME(getarg)( (void)RTNAME(GetCommandArgument)( n, , nullptr, nullptr, __FILE__, __LINE__); } + +// CALL GETLOG(USRNAME) +void FORTRAN_PROCEDURE_NAME(getlog)(std::int8_t *arg, std::int64_t length) { yi-wu-arm

[flang] [clang] [clang-tools-extra] [llvm] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74628 >From 0e98aa7ca15b05b91813eaeeb6ae1305e5f5384d Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:49:13 + Subject: [PATCH 01/26] GETLOG runtime and extension implementation: get login username

[clang] [clang-tools-extra] [llvm] [flang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
@@ -6,6 +6,37 @@ // //===--===// +// character.h yi-wu-arm wrote: It actually meant to match the `CHARCHTER_H` in the end of `#endif`, but I guess that create a confusion and should be

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kevin P. Neal (kpneal) Changes Some C++ constructors require the strictfp attribute on all function calls but don't get it because the comstructor lacks a FunctionDecl. Use the IRBuilder's strictfp mode to communicate that the strictfp

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2023-12-08 Thread Kevin P. Neal via cfe-commits
https://github.com/kpneal created https://github.com/llvm/llvm-project/pull/74883 Some C++ constructors require the strictfp attribute on all function calls but don't get it because the comstructor lacks a FunctionDecl. Use the IRBuilder's strictfp mode to communicate that the strictfp

[llvm] [flang] [clang-tools-extra] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
@@ -10,10 +10,50 @@ // extensions that will eventually be implemented in Fortran. #include "flang/Runtime/extensions.h" +#include "flang/Runtime/character.h" #include "flang/Runtime/command.h" #include "flang/Runtime/descriptor.h" #include "flang/Runtime/io-api.h"

[llvm] [flang] [clang-tools-extra] [clang] [flang] GETLOG runtime and extension implementation: get login username (PR #74628)

2023-12-08 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/74628 >From 0e98aa7ca15b05b91813eaeeb6ae1305e5f5384d Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:49:13 + Subject: [PATCH 01/25] GETLOG runtime and extension implementation: get login username

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/71300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
@@ -3657,6 +3657,21 @@ an error: }]; } +def MSConstexprDocs : Documentation { + let Category = DocCatStmt; + let Content = [{ +The ``[[msvc::constexpr]]`` attribute can be applied only to a function +definition or a ``return`` statement. It does not impact function

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
@@ -5546,11 +5563,14 @@ static EvalStmtResult EvaluateStmt(StmtResult , EvalInfo , case Stmt::LabelStmtClass: return EvaluateStmt(Result, Info, cast(S)->getSubStmt(), Case); - case Stmt::AttributedStmtClass: -// As a general principle, C++11 attributes can be

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
@@ -235,6 +235,7 @@ Non-comprehensive list of changes in this release except that it returns the size of a type ignoring tail padding. * ``__builtin_classify_type()`` now classifies ``_BitInt`` values as the return value ``18`` and vector types as return value ``19``, to

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
RIscRIpt wrote: > Also, please don't 'force-push', just push an additional commit to your > review. It erases history and makes reviewing it about 3x harder since > history/context gets lost. Sorry. I did this, because I am used to such workflow and reviewing

[clang] [clang-cl] Add support for [[msvc::constexpr]] C++11 attribute (PR #71300)

2023-12-08 Thread Richard Dzenis via cfe-commits
https://github.com/RIscRIpt updated https://github.com/llvm/llvm-project/pull/71300 >From 3be36c6100801195f8f1f5167bdaa289bc8cb175 Mon Sep 17 00:00:00 2001 From: Richard Dzenis Date: Thu, 20 Jul 2023 00:18:50 +0300 Subject: [PATCH 1/4] [clang-cl] Add support for [[msvc::constexpr]] C++11

[compiler-rt] [clang-tools-extra] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Teresa Johnson via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [clang-format][NFC] Clean up the driver and getStyle() in Format.cpp (PR #74794)

2023-12-08 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/74794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Always clear UndefinedButUsed (PR #73955)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. I'm okay landing these changes without test coverage, though tests are always preferred. LGTM https://github.com/llvm/llvm-project/pull/73955 ___ cfe-commits mailing list

[llvm] [compiler-rt] [clang-tools-extra] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Ellis Hoag via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-08 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: > I assume that /volatile:ms is a legacy behavior that non-Windows OSes likely > don't want to adopt. That is correct, it is legacy behavior. However, I think this flag has potential porting applications, similar to `-fshort-wchar`. I also think operating

[llvm] [compiler-rt] [clang-tools-extra] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-08 Thread Mingming Liu via cfe-commits
@@ -1,39 +1,45 @@ -; Do setup work for all below tests: generate bitcode and combined index -; RUN: opt -module-summary %s -o %t.bc -; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o %t2.bc +; The raw profiles and reduced IR inputs are generated from

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
https://github.com/ajordanr-google edited https://github.com/llvm/llvm-project/pull/74791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > Probably would be good to introduce the `-v1` version and require it first, > > then eventually change the default - so people don't get a silent behavior > > change? Even the existing users only using `*` and `.` need to change their > > syntax to migrate to v2, right?

[flang] [compiler-rt] [lldb] [libc] [openmp] [libcxx] [llvm] [libcxxabi] [clang-tools-extra] [mlir] [lld] [clang] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-08 Thread Hristo Hristov via cfe-commits
@@ -8,10 +8,7 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 -// sentinel() = default; -// constexpr explicit sentinel(sentinel_t end); -// constexpr sentinel(sentinel s) -// requires Const && convertible_to, sentinel_t>; +// constexpr sentinel_t base() const;

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Ellis Hoag via cfe-commits
ellishg wrote: > Probably would be good to introduce the `-v1` version and require it first, > then eventually change the default - so people don't get a silent behavior > change? Even the existing users only using `*` and `.` need to change their > syntax to migrate to v2, right? They'll

[compiler-rt] [openmp] [lldb] [polly] [mlir] [lld] [llvm] [clang] [flang] [VPlan] Initial modeling of VF * UF as VPValue. (PR #74761)

2023-12-08 Thread Florian Hahn via cfe-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread safety analysis: Fix a bug in handling temporary constructors (PR #74020)

2023-12-08 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/74020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a341e17 - Thread safety analysis: Fix a bug in handling temporary constructors (#74020)

2023-12-08 Thread via cfe-commits
Author: Ziqing Luo Date: 2023-12-08T10:29:37-08:00 New Revision: a341e177cea1cee800793d357264f6f46a3b4979 URL: https://github.com/llvm/llvm-project/commit/a341e177cea1cee800793d357264f6f46a3b4979 DIFF: https://github.com/llvm/llvm-project/commit/a341e177cea1cee800793d357264f6f46a3b4979.diff

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread David Blaikie via cfe-commits
dwblaikie wrote: Probably would be good to introduce the `-v1` version and require it first, then eventually change the default - so people don't get a silent behavior change? Even the existing users only using `*` and `.` need to change their syntax to migrate to v2, right? They'll need to

[compiler-rt] [libcxx] [lldb] [libcxxabi] [clang-tools-extra] [lld] [llvm] [clang] [flang] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-08 Thread Stanislav Mekhanoshin via cfe-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +

[libunwind] [libunwind] Replace process_vm_readv with pipe (PR #74791)

2023-12-08 Thread Jordan R AW via cfe-commits
@@ -2700,19 +2701,18 @@ bool UnwindCursor::setInfoForSigReturn(Registers_arm64 &) { // [1] https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/vdso/sigreturn.S const pint_t pc = static_cast(this->getReg(UNW_REG_IP)); // The PC might contain an invalid

[clang] [clang] Better bitfield access units (PR #65742)

2023-12-08 Thread Nathan Sidwell via cfe-commits
urnathan wrote: > I'm planning to take a closer look at this when I have more time. Sorry I > haven't been more responsive here. When might that be? https://github.com/llvm/llvm-project/pull/65742 ___ cfe-commits mailing list

[clang] 94c8373 - [NFC] A few whitespace changes.

2023-12-08 Thread Paul Walker via cfe-commits
Author: Paul Walker Date: 2023-12-08T18:01:12Z New Revision: 94c837345c27e173284a85471d4efda19eded08e URL: https://github.com/llvm/llvm-project/commit/94c837345c27e173284a85471d4efda19eded08e DIFF: https://github.com/llvm/llvm-project/commit/94c837345c27e173284a85471d4efda19eded08e.diff LOG:

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. LGTM assuming no surprises come up from the additional test coverage. https://github.com/llvm/llvm-project/pull/70772 ___ cfe-commits

[clang] [clang][Interp] Handle std::move etc. builtins (PR #70772)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -378,3 +378,92 @@ namespace Packs { static_assert(foo() == 2, ""); static_assert(foo<>() == 0, ""); } + +namespace std { +template struct remove_reference { using type = T; }; +template struct remove_reference { using

[clang] [clang][Interp] Diagnose reads from non-const global variables (PR #71919)

2023-12-08 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1005,12 +1008,23 @@ bool SetThisField(InterpState , CodePtr OpPC, uint32_t I) { template ::T> bool GetGlobal(InterpState , CodePtr OpPC, uint32_t I) { const Block *B = S.P.getGlobal(I); + + if (!CheckConstant(S, OpPC,

[clang] bbb8a0d - [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

2023-12-08 Thread Shafik Yaghmour via cfe-commits
Author: Shafik Yaghmour Date: 2023-12-08T09:38:59-08:00 New Revision: bbb8a0df7367068e1cf2fc54edd376beb976b430 URL: https://github.com/llvm/llvm-project/commit/bbb8a0df7367068e1cf2fc54edd376beb976b430 DIFF:

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM with a testing nit https://github.com/llvm/llvm-project/pull/72660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
@@ -27,6 +27,9 @@ static_assert(foo[2][3] == , ""); static_assert(foo[2][4] == nullptr, ""); +const int SomeInt[] = {1}; +int getSomeInt() { return *SomeInt; } AaronBallman wrote: ```suggestion constexpr int SomeInt[] = {1}; constexpr int getSomeInt() {

[clang] [clang][Interp] Decay arrays to the first element (PR #72660)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/72660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix float->int casts overflowing (PR #72658)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/72658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-12-08 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, but please wait until sometime mid-next week to land in case Richard has concerns. https://github.com/llvm/llvm-project/pull/70829 ___ cfe-commits mailing list

[clang] 731361c - [OpenACC] Fix bug with directive name being a 'special token'

2023-12-08 Thread via cfe-commits
Author: erichkeane Date: 2023-12-08T09:32:49-08:00 New Revision: 731361cd1540d0e729633833e6f3a670443c4b84 URL: https://github.com/llvm/llvm-project/commit/731361cd1540d0e729633833e6f3a670443c4b84 DIFF: https://github.com/llvm/llvm-project/commit/731361cd1540d0e729633833e6f3a670443c4b84.diff

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -500,6 +506,12 @@ bool ClangTableGenMain(raw_ostream , RecordKeeper ) { case GenArmSmeRangeChecks: EmitSmeRangeChecks(Records, OS); break; + case GenArmSmeStreamingAttrs: SamTebbs33 wrote: Done https://github.com/llvm/llvm-project/pull/74064

[clang] [llvm] [clang-tools-extra] [Clang][AArch64] Add fix vector types to header into SVE (PR #73258)

2023-12-08 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/73258 >From e0f245e8d6a395afac5de471b55358c7b730a170 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 22 Nov 2023 10:03:50 + Subject: [PATCH 1/8] [Clang][AArch64] Add fix vector types to

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: It seems that is the only HIP test that still uses %T. https://github.com/llvm/llvm-project/pull/74872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes Replace %T with %t since %T is deprecated. --- Full diff: https://github.com/llvm/llvm-project/pull/74872.diff 1 Files Affected: - (modified) clang/test/Driver/rocm-detect.hip (+17-17)

[clang] Fix test rocm-detect.hip (PR #74872)

2023-12-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/74872 Replace %T with %t since %T is deprecated. >From 91160285c17ef9ba2b35e6e8c4a8eb433ec5ad8a Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 8 Dec 2023 12:24:19 -0500 Subject: [PATCH] Fix test

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-08 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg approved this pull request. Looks good to me. Thanks for following up! https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [clang][RISCV] Change default abi with f extension but without d extension (PR #73489)

2023-12-08 Thread Alex Bradbury via cfe-commits
asb wrote: > > I think the conclusion from the LLVM sync-up call was that everyone happy > > to move in this direction, so please add the release note and we can do a > > final review. Thanks! > > Done, added release note. Thanks! Sorry I wasn't specific about this, but we need a Clang

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -20,3 +21,23 @@ int16x8_t incompat_neon_smc(int16x8_t splat) __arm_streaming_compatible { // expected-warning@+1 {{builtin call has undefined behaviour when called from a streaming compatible function}} return (int16x8_t)__builtin_neon_vqaddq_v((int8x16_t)splat,

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-08 Thread Sam Tebbs via cfe-commits
@@ -3168,11 +3168,70 @@ static void checkArmStreamingBuiltin(Sema , CallExpr *TheCall, << TheCall->getSourceRange() << "streaming compatible"; return; } + + if (FnType == ArmNonStreaming && BuiltinType == ArmStreaming) { +S.Diag(TheCall->getBeginLoc(),

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > %T is deprecated in lit. You may want to migrate other `%T` related to AMDGPU. Thanks. I will try cleaning them up. https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread 徐持恒 Xu Chiheng via cfe-commits
https://github.com/xu-chiheng updated https://github.com/llvm/llvm-project/pull/74868 From 680b2b48925d52c006eee5f26b1173856dfcf376 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BE=90=E6=8C=81=E6=81=92=20Xu=20Chiheng?= Date: Sat, 9 Dec 2023 00:59:00 +0800 Subject: [PATCH 1/2] [Cygwin] Cygwin

[clang] Fix tests hip-offload-compress-zlib/zstd.hip (PR #74783)

2023-12-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/74783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b842b1b - Fix tests hip-offload-compress-zlib/zstd.hip (#74783)

2023-12-08 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2023-12-08T12:04:01-05:00 New Revision: b842b1b65aab3bff2c3dbf439054aa8fe63f8400 URL: https://github.com/llvm/llvm-project/commit/b842b1b65aab3bff2c3dbf439054aa8fe63f8400 DIFF:

[clang] [Cygwin] Cygwin basic support (PR #74868)

2023-12-08 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 49b27b150b97c190dedf8b45bf991c4b811ed953 680b2b48925d52c006eee5f26b1173856dfcf376 --

<    1   2   3   4   >