[libcxx] [flang] [compiler-rt] [libc] [clang-tools-extra] [llvm] [clang] [libcxxabi] [lld] [lldb] [mlir] [Mips] Fix unable to handle inline assembly ends with compat-branch o… (PR #77291)

yingopq wrote: > What assembly does GCC emit, and how does GNU as deal with that assembly? > That is, how do those two tools interact in the GNU world when dealing with > forbidden slots? All results were same: add nop after beqzc. ``` $ cat a.s .set reorder bbb: beqzc $t1, bbb

[libcxx] [flang] [compiler-rt] [libc] [clang-tools-extra] [llvm] [clang] [libcxxabi] [lld] [lldb] [mlir] [Mips] Fix unable to handle inline assembly ends with compat-branch o… (PR #77291)

yingopq wrote: > What assembly does GCC emit, and how does GNU as deal with that assembly? > That is, how do those two tools interact in the GNU world when dealing with > forbidden slots? All results were same: add nop after beqzc. ``` $ cat a.s .set reorder bbb: beqzc $t1, bbb

[llvm] [clang-tools-extra] [compiler-rt] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

@@ -139,20 +139,79 @@ enum ProcessorFeatures { FEATURE_AVX512BITALG, FEATURE_AVX512BF16, FEATURE_AVX512VP2INTERSECT, + // Below Features has many missings comparing to gcc, it's because gcc has + // some LLVM doesn't include, e.g. FEATURE_ABM, FEATURE_HLE, ... + FEATUR

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [compiler-rt] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

@@ -139,20 +139,88 @@ enum ProcessorFeatures { FEATURE_AVX512BITALG, FEATURE_AVX512BF16, FEATURE_AVX512VP2INTERSECT, - - FEATURE_CMPXCHG16B = 46, - FEATURE_F16C = 49, + // FIXME: Below Features has some missings comparing to gcc, it's because gcc + // has some not one

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

owenca wrote: /cherry-pick f826f55b2ab6 https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

llvmbot wrote: /pull-request llvm/llvm-project#80591 https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

https://github.com/owenca unassigned https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [compiler-rt] [clang] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/79086 >From b5c8579c5c8e7ea1e8436348bbf60ecee9c3c799 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 19 Jan 2024 09:22:27 +0800 Subject: [PATCH 1/7] [X86] Support more ISAs to enable __builtin_cpu_supports This

[clang-tools-extra] [compiler-rt] [clang] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

@@ -139,20 +139,88 @@ enum ProcessorFeatures { FEATURE_AVX512BITALG, FEATURE_AVX512BF16, FEATURE_AVX512VP2INTERSECT, - - FEATURE_CMPXCHG16B = 46, - FEATURE_F16C = 49, + // FIXME: Below Features has some missings comparing to gcc, it's because gcc + // has some not one

[clang] [clang-format] Fix a bug in AnnotatingParser::rParenEndsCast() (PR #79549)

https://github.com/owenca demilestoned https://github.com/llvm/llvm-project/pull/79549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

https://github.com/144026 created https://github.com/llvm/llvm-project/pull/80592 Extract directive branches information from DirectiveTree, fold branches that don't end with eof. Fixes https://github.com/clangd/clangd/issues/1661 Examples: Folded: https://github.com/llvm/llvm-project/asset

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

llvmbot wrote: @llvm/pr-subscribers-clangd Author: Ruihua Dong (144026) Changes Extract directive branches information from DirectiveTree, fold branches that don't end with eof. Fixes https://github.com/clangd/clangd/issues/1661 Examples: Folded: [clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

2024-02-04 Thread via cfe-commits

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Ruihua Dong (144026) Changes Extract directive branches information from DirectiveTree, fold branches that don't end with eof. Fixes https://github.com/clangd/clangd/issues/1661 Examples: Folded: [clang] [compiler-rt] [clang-tools-extra] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Phoebe Wang via cfe-commits

@@ -217,10 +217,11 @@ enum ProcessorFeatures { FEATURE_SM3, FEATURE_SHA512, FEATURE_SM4, - // FEATURE_APX_F, - FEATURE_USERMSR = 112, - // FEATURE_AVX10_1_256, - // FEATURE_AVX10_1_512, + //FIXME: gcc used string "apxf" instead of "egpr" phoebewang w

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

2024-02-04 Thread Younan Zhang via cfe-commits

zyn0217 wrote: Note that clang-pseudo is deprecated and will soon get [removed](https://github.com/llvm/llvm-project/pull/80081) from the repository. I have no idea about the replacement, and I'm not sure if it makes sense to evolve the feature with it. I invited some folks (who may be in ch

[clang] [compiler-rt] [clang-tools-extra] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Shengchen Kan via cfe-commits

@@ -217,10 +217,11 @@ enum ProcessorFeatures { FEATURE_SM3, FEATURE_SHA512, FEATURE_SM4, - // FEATURE_APX_F, - FEATURE_USERMSR = 112, - // FEATURE_AVX10_1_256, - // FEATURE_AVX10_1_512, + //FIXME: gcc used string "apxf" instead of "egpr" KanRobert wr

[compiler-rt] [llvm] [clang] [clang-tools-extra] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Freddy Ye via cfe-commits

@@ -217,10 +217,11 @@ enum ProcessorFeatures { FEATURE_SM3, FEATURE_SHA512, FEATURE_SM4, - // FEATURE_APX_F, - FEATURE_USERMSR = 112, - // FEATURE_AVX10_1_256, - // FEATURE_AVX10_1_512, + //FIXME: gcc used string "apxf" instead of "egpr" FreddyLeaf w

[clang] [Clang] Fix a crash when dumping a pack indexing type. (PR #80439)

2024-02-04 Thread Björn Pettersson via cfe-commits

bjope wrote: Seems like this didn't really solve the problem reported by @bevin-hansson (at least not completely). The new test case fails for us: ``` FAIL: Clang :: AST/ast-dump-pack-indexing-crash.cpp (401 of 78930) TEST 'Clang :: AST/ast-dump-pack-indexing-crash.cpp' FA

[compiler-rt] [llvm] [clang] [clang-tools-extra] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Shengchen Kan via cfe-commits

@@ -173,85 +173,86 @@ X86_FEATURE_COMPAT(AVX512VNNI, "avx512vnni", 34) X86_FEATURE_COMPAT(AVX512BITALG,"avx512bitalg", 35) X86_FEATURE_COMPAT(AVX512BF16, "avx512bf16",36) X86_FEATURE_COMPAT(AVX512VP2INTERSECT, "avx512vp2intersect",

[compiler-rt] [llvm] [clang] [clang-tools-extra] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Shengchen Kan via cfe-commits

@@ -1845,6 +1845,7 @@ bool sys::getHostCPUFeatures(StringMap &Features) { Features["prefetchi"] = HasLeaf7Subleaf1 && ((EDX >> 14) & 1); Features["usermsr"] = HasLeaf7Subleaf1 && ((EDX >> 15) & 1); Features["avx10.1-256"] = HasLeaf7Subleaf1 && ((EDX >> 19) & 1); + Feat

[llvm] [clang] [clang-tools-extra] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-04 Thread via cfe-commits

cor3ntin wrote: > > Thanks for the patch! > > Requires Expressions should be in an unevaluated context, so we should > > never try to capture variables they mentioned. > > Maybe we need to test the evaluation context in either `tryCaptureVariable` > > or `NeedToCaptureVariable`, rather than a s

[clang] [concepts] Fixes for gh72557 (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/80594 Draft for CI. >From c04bb951d35e0f767ea9b0fed8e200b161d646e1 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 4 Feb 2024 17:35:16 +0800 Subject: [PATCH] [concepts] Fixes for gh72557 --- clang/docs/Releas

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

2024-02-04 Thread Ruihua Dong via cfe-commits

144026 wrote: @zyn0217 Thanks for the information, seems like a completed removal of pseudo parser has been decided in this [discourse thread](https://discourse.llvm.org/t/removing-pseudo-parser/71131), and shifting back to AST parser for foldingRange support would only lose a marginal multi

[clang-tools-extra] [clangd] Implement simple folding of preprocessor branches (PR #80592)

2024-02-04 Thread Ruihua Dong via cfe-commits

144026 wrote: The build pipeline failure is on Windows x64, and appears to be some random error irrelevant to this patch: ``` MT: command "C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe /nologo /manifest bin\dexp.exe.manifest /outputresource:bin\dexp.exe;#1" failed (exit co

[clang] [Clang] Fix a crash when dumping a pack indexing type. (PR #80439)

2024-02-04 Thread via cfe-commits

cor3ntin wrote: @bjope thanks for letting me know. A reproduction would really help, as upstream bots do not exhibit this behavior at all. https://github.com/llvm/llvm-project/pull/80439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1513,6 +1580,11 @@ static void handleNoSuspendCoroutine(coro::Shape &Shape) { // the coroutine and if that is the case we cannot eliminate the suspend point. static bool hasCallsInBlockBetween(Instruction *From, Instruction *To) { for (Instruction *I = From; I != To; I =

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1575,6 +1650,36 @@ static bool hasCallsBetween(Instruction *Save, Instruction *ResumeOrDestroy) { return false; } +// Check if await-suspend helper is "simple". +// The conditions are: +// 1. The return result is exactly coroutine frame parameter, passed to helper +// 2

[clang] [concepts] Fixes for gh72557 (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/80594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/80594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80594 >From c04bb951d35e0f767ea9b0fed8e200b161d646e1 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 4 Feb 2024 17:35:16 +0800 Subject: [PATCH 1/2] [concepts] Fixes for gh72557 --- clang/docs/ReleaseNotes.rst

[clang-tools-extra] [clang] [llvm] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80594 >From c04bb951d35e0f767ea9b0fed8e200b161d646e1 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 4 Feb 2024 17:35:16 +0800 Subject: [PATCH 1/2] [concepts] Fixes for gh72557 --- clang/docs/ReleaseNotes.rst

[clang-tools-extra] [clang] [llvm] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/80594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread via cfe-commits

llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Before the constraint substitution, we employ `getTemplateInstantiationArgs`, which in turn attempts to inspect `TemplateArgument`s from the function template. For parameter packs from their parent contexts,

[clang-tools-extra] [clang] [llvm] [concepts] Extract function template pack arguments from the current instantiation if possible (PR #80594)

2024-02-04 Thread Younan Zhang via cfe-commits

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/80594 >From c04bb951d35e0f767ea9b0fed8e200b161d646e1 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 4 Feb 2024 17:35:16 +0800 Subject: [PATCH 1/3] [concepts] Fixes for gh72557 --- clang/docs/ReleaseNotes.rst

[compiler-rt] [clang-tools-extra] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Freddy Ye via cfe-commits

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/79086 >From b5c8579c5c8e7ea1e8436348bbf60ecee9c3c799 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 19 Jan 2024 09:22:27 +0800 Subject: [PATCH 1/8] [X86] Support more ISAs to enable __builtin_cpu_supports This

[compiler-rt] [clang-tools-extra] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Phoebe Wang via cfe-commits

@@ -217,8 +217,7 @@ enum ProcessorFeatures { FEATURE_SM3, FEATURE_SHA512, FEATURE_SM4, - //FIXME: gcc used string "apxf" instead of "egpr" - FEATURE_EGPR, + // FEATURE_APXF, FEATURE_USERMSR, phoebewang wrote: You need to change the number then. ht

[llvm] [clang] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Freddy Ye via cfe-commits

https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/79086 >From b5c8579c5c8e7ea1e8436348bbf60ecee9c3c799 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 19 Jan 2024 09:22:27 +0800 Subject: [PATCH 1/9] [X86] Support more ISAs to enable __builtin_cpu_supports This

[compiler-rt] [clang-tools-extra] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Phoebe Wang via cfe-commits

https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/79086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [compiler-rt] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Freddy Ye via cfe-commits

FreddyLeaf wrote: Thanks review! https://github.com/llvm/llvm-project/pull/79086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7210560 - [X86] Support more ISAs to enable __builtin_cpu_supports (#79086)

2024-02-04 Thread via cfe-commits

Author: Freddy Ye Date: 2024-02-04T21:21:12+08:00 New Revision: 72105605d1fbc816c1219bb1d719693291322011 URL: https://github.com/llvm/llvm-project/commit/72105605d1fbc816c1219bb1d719693291322011 DIFF: https://github.com/llvm/llvm-project/commit/72105605d1fbc816c1219bb1d719693291322011.diff LOG

[clang-tools-extra] [clang] [compiler-rt] [llvm] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-02-04 Thread Freddy Ye via cfe-commits

https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/79086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-04 Thread Shourya Goel via cfe-commits

https://github.com/Sh0g0-1758 edited https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-02-04 Thread Shourya Goel via cfe-commits

Sh0g0-1758 wrote: gentle ping. Please check the mergeability of this PR. https://github.com/llvm/llvm-project/pull/78338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-02-04 Thread Mark de Wever via cfe-commits

mordante wrote: Thanks for reverting @AaronBallman I somehow missed this comment. @kaz7 it should work on all platforms AFAIK. I don't have access to a VE system. Looking at some VE tests I wonder whether the following patch would work. [patch.txt](https://github.com/llvm/llvm-project/files/14

[clang] [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (PR #68515)

2024-02-04 Thread Yaxun Liu via cfe-commits

https://github.com/yxsamliu approved this pull request. LGTM. Thanks https://github.com/llvm/llvm-project/pull/68515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AMDGPU][CUDA] Handle __builtin_printf for device printf (PR #68515)

2024-02-04 Thread Yaxun Liu via cfe-commits

yxsamliu wrote: > It looks reasonable to me, although I'm not really an AMDGPU person. /me > summons @arsenm ? AMDGPU backend relies on LLVM passes to translate printf at IR level. __builtin_printf and printf should be equivalent other than the name. https://github.com/llvm/llvm-project/pull/

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread via cfe-commits

@@ -24160,6 +24160,14 @@ TEST_F(FormatTest, AlternativeOperators) { verifyFormat("int a compl(5);"); verifyFormat("int a not(5);"); + verifyFormat("v(not)"); + verifyFormat("v(not!)"); + verifyFormat("Symbol(not, None)"); + verifyFormat("Symbol(not!, None)"); + + veri

[clang-tools-extra] [clang] [libcxx] [libc++] Implement `views::join_with` (PR #65536)

2024-02-04 Thread Jakub Mazurkiewicz via cfe-commits

https://github.com/JMazurkiewicz ready_for_review https://github.com/llvm/llvm-project/pull/65536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [clang] reject to capture variable in `RequiresExprBodyDecl` (PR #78598)

2024-02-04 Thread Congcong Cai via cfe-commits

HerrCai0907 wrote: > You have an example of that? There may be further bugs there. > id-expression that appear in any unevaluated context should not be captured ( > typeid being an exception I think it is from standard, but from user-friendly site. Now clang will hint user some variables is no

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-02-04 Thread Bhuminjay Soni via cfe-commits

11happy wrote: Humble Ping! (as per the rules ping after week of inactivity) @PiotrZSL , @5chmidti , @felix642 , @EugeneZelenko , I think its nearly done. https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Owen Pan via cfe-commits

@@ -1909,6 +1909,14 @@ TEST_F(FormatTestComments, ReflowsComments) { "// @param arg", getLLVMStyleWithColumns(20))); + // Don't reflow lines starting with '\'. + EXPECT_EQ("// long long long\n" +"// long\n" +"// \

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Owen Pan via cfe-commits

@@ -1909,6 +1909,14 @@ TEST_F(FormatTestComments, ReflowsComments) { "// @param arg", getLLVMStyleWithColumns(20))); + // Don't reflow lines starting with '\'. + EXPECT_EQ("// long long long\n" owenca wrote: Can you use

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Owen Pan via cfe-commits

https://github.com/owenca deleted https://github.com/llvm/llvm-project/pull/80381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Owen Pan via cfe-commits

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/80381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

2024-02-04 Thread Andrzej Warzyński via cfe-commits

banach-space wrote: Thank you for your continued effort to improve this! > Anyone knows if this is expected and Visibility should be explicitly > specified in each alias, to add support to flang-new, or is this an issue and > the alias should have the same visibility as the original option? I

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Fernando Tagawa via cfe-commits

https://github.com/XDeme updated https://github.com/llvm/llvm-project/pull/80381 >From efd816282e5f5b71d6f88038a2121fa698becf7a Mon Sep 17 00:00:00 2001 From: XDeme Date: Fri, 2 Feb 2024 00:27:57 -0300 Subject: [PATCH 1/2] [clang-format] Handle doxygen comments starting with \ --- clang/lib/Fo

[clang] [clang-format] Handle doxygen commands starting with \ (PR #80381)

2024-02-04 Thread Owen Pan via cfe-commits

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/80381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [polly] [clang-format] Add Automatic and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-02-04 Thread Björn Schäpers via cfe-commits

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2562007 - [clang-format] Add Automatic and ExceptShortType options for AlwaysBreakAfterReturnType. (#78011)

2024-02-04 Thread via cfe-commits

Author: rmarker Date: 2024-02-04T12:26:32-08:00 New Revision: 256200732111afd03bb7437564f3a3d77c0ec3f5 URL: https://github.com/llvm/llvm-project/commit/256200732111afd03bb7437564f3a3d77c0ec3f5 DIFF: https://github.com/llvm/llvm-project/commit/256200732111afd03bb7437564f3a3d77c0ec3f5.diff LOG:

[clang] [polly] [clang-format] Add Automatic and ExceptShortType options for AlwaysBreakAfterReturnType. (PR #78011)

2024-02-04 Thread Owen Pan via cfe-commits

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Owen Pan via cfe-commits

@@ -24160,6 +24160,14 @@ TEST_F(FormatTest, AlternativeOperators) { verifyFormat("int a compl(5);"); verifyFormat("int a not(5);"); + verifyFormat("v(not)"); + verifyFormat("v(not!)"); + verifyFormat("Symbol(not, None)"); + verifyFormat("Symbol(not!, None)"); + + veri

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-02-04 Thread Piotr Zegar via cfe-commits

https://github.com/PiotrZSL approved this pull request. LGTM. The only thing that I'm still thinking is if std is needed in name, and maybe it should be like just use-min-max. https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing lis

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Frontend: sink vendor definitions from Basic to Frontend (PR #80364)

2024-02-04 Thread Saleem Abdulrasool via cfe-commits

https://github.com/compnerd updated https://github.com/llvm/llvm-project/pull/80364 >From c895dff0e59b9d851c15e5b3b25a735478b811fc Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Thu, 1 Feb 2024 15:37:39 -0800 Subject: [PATCH] Frontend: sink vendor definitions from Basic to Frontend Th

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[llvm] [clang] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -5036,14 +5036,17 @@ class CoroutineSuspendExpr : public Expr { Stmt *SubExprs[SubExpr::Count]; OpaqueValueExpr *OpaqueValue = nullptr; + OpaqueValueExpr *OpaqueFramePtr = nullptr; fpasserby wrote: Now `__builtin_coro_frame` is used. https://github.c

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -232,16 +237,59 @@ static LValueOrRValue emitSuspendExpression(CodeGenFunction &CGF, CGCoroData &Co auto *NullPtr = llvm::ConstantPointerNull::get(CGF.CGM.Int8PtrTy); auto *SaveCall = Builder.CreateCall(CoroSave, {NullPtr}); - CGF.CurCoro.InSuspendBlock = true; - aut

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -79,6 +79,73 @@ using namespace llvm; namespace { +// Created on demand if the coro-early pass has work to do. +class Lowerer : public coro::LowererBase { fpasserby wrote: Yes, it is possible. Switched to a simple function. https://github.com/llvm/llvm-p

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -79,6 +79,73 @@ using namespace llvm; namespace { +// Created on demand if the coro-early pass has work to do. +class Lowerer : public coro::LowererBase { + IRBuilder<> Builder; + void lowerAwaitSuspend(CoroAwaitSuspendInst *CB); + +public: + Lowerer(Module &M) : Lowere

[llvm] [clang] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -79,6 +79,73 @@ using namespace llvm; namespace { +// Created on demand if the coro-early pass has work to do. +class Lowerer : public coro::LowererBase { + IRBuilder<> Builder; + void lowerAwaitSuspend(CoroAwaitSuspendInst *CB); + +public: + Lowerer(Module &M) : Lowere

[llvm] [clang] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -79,6 +79,73 @@ using namespace llvm; namespace { +// Created on demand if the coro-early pass has work to do. +class Lowerer : public coro::LowererBase { + IRBuilder<> Builder; + void lowerAwaitSuspend(CoroAwaitSuspendInst *CB); + +public: + Lowerer(Module &M) : Lowere

[llvm] [clang] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-02-04 Thread via cfe-commits

@@ -1744,6 +1744,273 @@ a call to ``llvm.coro.suspend.retcon`` after resuming abnormally. In a yield-once coroutine, it is undefined behavior if the coroutine executes a call to ``llvm.coro.suspend.retcon`` after resuming in any way. +.. _coro.await.suspend: + +'llvm.coro.awa

[clang] [Clang] Fix a crash when dumping a pack indexing type. (PR #80439)

2024-02-04 Thread Björn Pettersson via cfe-commits

bjope wrote: @cor3ntin , our downstream code is doing some extra semantic checks using code like this in Sema::CheckVariableDeclarationType: ``` if (!T->isIncompleteType() && !isDependentOrGNUAutoType(T) && !T->isPlaceholderType()) { uint64_t Size = Context.getTypeSizeInChars(T).getQuant

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Richard Smith via cfe-commits

@@ -4842,7 +4842,7 @@ bool TokenAnnotator::spaceRequiredBefore(const AnnotatedLine &Line, return true; } if (Left.is(TT_UnaryOperator)) { -if (Right.isNot(tok::l_paren)) { +if (!Right.isOneOf(tok::r_paren, tok::l_paren, tok::exclaim)) { zygoloi

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Richard Smith via cfe-commits

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/78176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Richard Smith via cfe-commits

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/78176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Richard Smith via cfe-commits

https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/78176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] adds a space after not inside macros (PR #78176)

2024-02-04 Thread Richard Smith via cfe-commits

@@ -4842,7 +4842,7 @@ bool TokenAnnotator::spaceRequiredBefore(const AnnotatedLine &Line, return true; } if (Left.is(TT_UnaryOperator)) { -if (Right.isNot(tok::l_paren)) { +if (!Right.isOneOf(tok::r_paren, tok::l_paren, tok::exclaim)) { zygoloi

[llvm] [clang] [RISCV] Add support for RISC-V Pointer Masking (PR #79929)

2024-02-04 Thread Michael Maitland via cfe-commits

https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/79929 >From bc844fb4e033063c0d7b5ab361c44e4823e76fa3 Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Mon, 29 Jan 2024 12:33:59 -0800 Subject: [PATCH 1/3] [RISCV] Add support for RISC-V Pointer Masking Th

[clang] ffaedc2 - [Basic] Simplify uses of StringRef::consume_front (NFC)

2024-02-04 Thread Kazu Hirata via cfe-commits

Author: Kazu Hirata Date: 2024-02-04T14:57:26-08:00 New Revision: ffaedc2735cfcf2595fe65a75ed910a9c661391b URL: https://github.com/llvm/llvm-project/commit/ffaedc2735cfcf2595fe65a75ed910a9c661391b DIFF: https://github.com/llvm/llvm-project/commit/ffaedc2735cfcf2595fe65a75ed910a9c661391b.diff L

[clang-tools-extra] 92d5f64 - [clang-tidy] Use StringRef::contains (NFC)

2024-02-04 Thread Kazu Hirata via cfe-commits

Author: Kazu Hirata Date: 2024-02-04T14:57:30-08:00 New Revision: 92d5f644281cba56baa9b42dfc298db7f2c30003 URL: https://github.com/llvm/llvm-project/commit/92d5f644281cba56baa9b42dfc298db7f2c30003 DIFF: https://github.com/llvm/llvm-project/commit/92d5f644281cba56baa9b42dfc298db7f2c30003.diff L

[clang] [Clang] Fix a crash when dumping a pack indexing type. (PR #80439)

2024-02-04 Thread Björn Pettersson via cfe-commits

@@ -0,0 +1,25 @@ +// RUN: not %clang_cc1 -std=c++2c -ast-dump %s | FileCheck %s + +namespace InvalidPacksShouldNotCrash { + +struct NotAPack; +template typename Tp> +void not_pack() { +int i = 0; +i...[0]; // expected-error {{i does not refer to the name of a parameter

[clang] [Format] Fix detection of languages when reading from stdin (PR #79051)

2024-02-04 Thread Owen Pan via cfe-commits

owenca wrote: @bhamiltoncx Thanks for the fix! Nevertheless, it seems that this triggered a new regression. See #80621. https://github.com/llvm/llvm-project/pull/79051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang-tools-extra] [clangd] Add 'apply all clangd fixes' and 'apply all '_' fixes' QuickFixes (PR #79867)

2024-02-04 Thread Tor Shepherd via cfe-commits

torshepherd wrote: Also pinging @kadircet who recently worked on Include Cleaner's similar batch fixes https://github.com/llvm/llvm-project/pull/79867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] [clang] [llvm] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

@@ -526,12 +542,13 @@ bool VPInstruction::onlyFirstLaneUsed(const VPValue *Op) const { case Instruction::ICmp: // TODO: Cover additional opcodes. return vputils::onlyFirstLaneUsed(this); + case VPInstruction::ComputeReductionResult: +return true; ---

[llvm] [clang] [clang-tools-extra] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

@@ -512,7 +518,17 @@ void VPInstruction::execute(VPTransformState &State) { if (!hasResult()) continue; assert(GeneratedValue && "generateInstruction must produce a value"); -State.set(this, GeneratedValue, Part); +if (GeneratedValue->getType()->isVectorTy

[clang] [clang-tools-extra] [llvm] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

https://github.com/ayalz commented: > At the moment, some VPInstructions create only a single scalar value, but use > VPTransformatState's 'vector' storage for this value. Those values are > effectively uniform-per-VF (or in some cases uniform-across-VF-and-UF). Using > the vector/per-part sto

[clang] [clang-tools-extra] [llvm] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/80271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

@@ -213,8 +213,13 @@ VPBasicBlock::iterator VPBasicBlock::getFirstNonPhi() { } Value *VPTransformState::get(VPValue *Def, const VPIteration &Instance) { - if (Def->isLiveIn()) -return Def->getLiveInIRValue(); + if (Def->isLiveIn()) { +if (Value *V = Def->getLiveInIRV

[clang-tools-extra] [clang] [llvm] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

@@ -1389,6 +1389,13 @@ class VPScalarCastRecipe : public VPSingleDefRecipe { /// Returns the result type of the cast. Type *getResultType() const { return ResultTy; } + + bool onlyFirstLaneUsed(const VPValue *Op) const override { +// At the moment, only scalar codegen

[llvm] [clang] [clang-tools-extra] [VPlan] Consistently use (Part, 0) for first lane scalar values (PR #80271)

2024-02-04 Thread via cfe-commits

@@ -116,8 +116,7 @@ define void @test_widen(ptr noalias %a, ptr readnone %b) #4 { ; TFA_INTERLEAVE-NEXT:[[TMP18:%.*]] = getelementptr inbounds i64, ptr [[TMP15]], i64 [[TMP17]] ; TFA_INTERLEAVE-NEXT:call void @llvm.masked.store.nxv2i64.p0( [[TMP13]], ptr [[TMP15]], i32

  1   2   >