[clang] 07ec9a3 - [clang][NFC] Partially annotate `CGFunctionInfo.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T10:58:03+03:00 New Revision: 07ec9a3799fa1e80888f8bd0c1101ad6dd546842 URL: https://github.com/llvm/llvm-project/commit/07ec9a3799fa1e80888f8bd0c1101ad6dd546842 DIFF: https://github.com/llvm/llvm-project/commit/07ec9a3799fa1e80888f8bd0c1101ad6dd546842.

[clang] [Clang][Sema] fix crash in codegen stage when an lambda expression declared in an unevaluated context (PR #80802)

2024-02-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/80802 >From 0063efb61d8076d46289f76a490c28f2ca7f Mon Sep 17 00:00:00 2001 From: huqizhi Date: Tue, 6 Feb 2024 14:06:40 +0800 Subject: [PATCH] [Clang][Sema] fix crash in codegen stage when an lambda expression decla

[clang] c0ed1b2 - [clang][NFC] Annotate `Basic/Visibility.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T10:47:45+03:00 New Revision: c0ed1b2c08ab3b75e79d90fcda7e949ca50400a5 URL: https://github.com/llvm/llvm-project/commit/c0ed1b2c08ab3b75e79d90fcda7e949ca50400a5 DIFF: https://github.com/llvm/llvm-project/commit/c0ed1b2c08ab3b75e79d90fcda7e949ca50400a5.

[clang] [clang-format] NEVER allow && to be an unary operator. (PR #78852)

2024-02-10 Thread Emilia Kond via cfe-commits
rymiel wrote: I'm sorry, I do not have the time for this right now, and I'd rather not leave this open for no reason https://github.com/llvm/llvm-project/pull/78852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang-format] NEVER allow && to be an unary operator. (PR #78852)

2024-02-10 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/78852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d912433 - [clang][NFC] Annotate `Sema/DelayedDiagnostic.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T10:40:05+03:00 New Revision: d9124332aa3b95725b149617066fdd1f525b530d URL: https://github.com/llvm/llvm-project/commit/d9124332aa3b95725b149617066fdd1f525b530d DIFF: https://github.com/llvm/llvm-project/commit/d9124332aa3b95725b149617066fdd1f525b530d.

[clang] [clang][NFC] Refactor `Sema::TemplateDeductionResult` (PR #81398)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Since this patch is rather large, I left two comments highlighting potentially interesting parts of it. https://github.com/llvm/llvm-project/pull/81398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [clang][NFC] Refactor `Sema::TemplateDeductionResult` (PR #81398)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
@@ -11445,11 +11452,16 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, (ParamD = Param.dyn_cast()) || (ParamD = Param.dyn_cast()) || (ParamD = Param.dyn_cast()); - switch (DeductionFailure.Result) { - case Sema::TDK_Success: -llvm_un

[clang] [clang][NFC] Refactor `Sema::TemplateDeductionResult` (PR #81398)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
@@ -295,6 +297,10 @@ struct DeductionFailureInfo { /// Free any memory associated with this deduction failure. void Destroy(); + + TemplateDeductionResult getResult() const { +return static_cast(Result); Endilll wrote: @erichkeane This is also worth

[clang] [clang][NFC] Refactor `Sema::TemplateDeductionResult` (PR #81398)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/81398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix crash in codegen stage when an lambda expression declared in an unevaluated context (PR #80802)

2024-02-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/80802 >From 59fb684ff051dc50eb6f8e4e1c294fd5a2dc55d0 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Tue, 6 Feb 2024 14:06:40 +0800 Subject: [PATCH] [Clang][Sema] fix crash in codegen stage when an lambda expression decla

[clang] [clang-format][NFC] Make LangOpts global in namespace Format (PR #81390)

2024-02-10 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/81390 >From 37a6723b2c9b95c0556ca53992192795e74c27ce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 10 Feb 2024 17:14:19 -0800 Subject: [PATCH 1/3] [clang-format][NFC] Make LangOpts global in namespace Format ---

[clang] [clang][NFC] Refactor `Sema::TemplateDeductionResult` (PR #81398)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch converts `Sema::TemplateDeductionResult` into a scoped enum in namespace scope, making it eligible for forward declaring. This is useful in certain contexts, such as `preferred_type` annotat

[clang] [Clang][Sema] fix crash in codegen stage when an lambda expression declared in an unevaluated context (PR #80802)

2024-02-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/80802 >From 78c54ee65b16d33a3c9b19c453ded69adfe62732 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Tue, 6 Feb 2024 14:06:40 +0800 Subject: [PATCH] [Clang][Sema] fix crash in codegen stage when an lambda expression decla

[clang] [Clang][Sema] fix crash in codegen stage when an lambda expression declared in an unevaluated context (PR #80802)

2024-02-10 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/80802 >From 95f7690ccc843a5878ac212f467693877c40b232 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Tue, 6 Feb 2024 14:06:40 +0800 Subject: [PATCH] [Clang][Sema] fix crash in codegen stage when an lambda expression decla

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-02-10 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/74927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c2f9885 - [SPARC] Support reserving arbitrary general purpose registers (#74927)

2024-02-10 Thread via cfe-commits
Author: Koakuma Date: 2024-02-11T02:04:18-05:00 New Revision: c2f9885a8aa3a820eefdacccf3fcc6b9d87e3284 URL: https://github.com/llvm/llvm-project/commit/c2f9885a8aa3a820eefdacccf3fcc6b9d87e3284 DIFF: https://github.com/llvm/llvm-project/commit/c2f9885a8aa3a820eefdacccf3fcc6b9d87e3284.diff LOG:

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-02-10 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: Still LGTM https://github.com/llvm/llvm-project/pull/74927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

2024-02-10 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/80760 >From 8000459a247317400eda6213a23f32ac89e1ea75 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 5 Feb 2024 14:57:17 -0800 Subject: [PATCH 1/3] [RISCV] Add -march string as Module metadata in IR. In an LTO

[clang] [flang] [flang][driver] Rename `flang-new` as `flang` (PR #74377)

2024-02-10 Thread Brad Smith via cfe-commits
brad0 wrote: > ok, but is there some threshold of percent that pass, or a specific list that > we want to be sure pass? My understanding is that we've been running (at > least a subset of) the gfortran test suite for a while now. What makes the > current results not sufficient? I think it's m

[clang] [llvm] [SPARC] Support reserving arbitrary general purpose registers (PR #74927)

2024-02-10 Thread Brad Smith via cfe-commits
brad0 wrote: @s-barannikov How does that look? https://github.com/llvm/llvm-project/pull/74927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2024-02-10 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 03d3310ca300630a94517fa300858d1f2645e843 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 01/16] [clang][MBD] set up module build daemon infrastructure The mo

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-02-10 Thread Nathan Ridge via cfe-commits
@@ -648,6 +649,27 @@ tweakSelection(const Range &Sel, const InputsAndAST &AST, return std::move(Result); } +// Some fixes may perform local renaming, we want to convert those to clangd +// rename commands, such that we can leverage the index for more accurate +// results. +s

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-02-10 Thread Nathan Ridge via cfe-commits
@@ -648,6 +649,27 @@ tweakSelection(const Range &Sel, const InputsAndAST &AST, return std::move(Result); } +// Some fixes may perform local renaming, we want to convert those to clangd +// rename commands, such that we can leverage the index for more accurate +// results. +s

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-02-10 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/78454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-02-10 Thread Nathan Ridge via cfe-commits
@@ -648,6 +649,27 @@ tweakSelection(const Range &Sel, const InputsAndAST &AST, return std::move(Result); } +// Some fixes may perform local renaming, we want to convert those to clangd +// rename commands, such that we can leverage the index for more accurate +// results. +s

[clang-tools-extra] [clangd] forward clang-tidy's readability-identifier-naming fix to textDocument/rename (PR #78454)

2024-02-10 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Ok, I had a more detailed look at the implementation. Still looks good overall, just have some minor comments. https://github.com/llvm/llvm-project/pull/78454 ___ cfe-commits ma

[clang] [clang-format][NFC] Make LangOpts global in namespace Format (PR #81390)

2024-02-10 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/81390 >From 37a6723b2c9b95c0556ca53992192795e74c27ce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 10 Feb 2024 17:14:19 -0800 Subject: [PATCH 1/2] [clang-format][NFC] Make LangOpts global in namespace Format ---

[clang] [clang-format][NFC] Make LangOpts global in namespace Format (PR #81390)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/81390.diff 7 Files Affected: - (modified) clang/include/clang/Format/Format.h (+1-5) - (modified) clang/lib/Format/Format.cpp (-30) - (modified

[clang] [clang-format][NFC] Make LangOpts global in namespace Format (PR #81390)

2024-02-10 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/81390 None >From 37a6723b2c9b95c0556ca53992192795e74c27ce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 10 Feb 2024 17:14:19 -0800 Subject: [PATCH] [clang-format][NFC] Make LangOpts global in namespace Format ---

[clang] Avoid printing overly large integer. (PR #75902)

2024-02-10 Thread Yueh-Shun Li via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: @@ -17146,7 +17146,13 @@ static bool ConvertAPValueToString(const APValue &V, QualType T, break; } } - V.getInt().toString

[clang] Avoid printing overly large integer. (PR #75902)

2024-02-10 Thread Yueh-Shun Li via cfe-commits
=?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= , =?utf-8?q?=E2=80=9CNhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee requested changes to this pull request. https://github.com/llvm/llvm-project/pull/75902 ___

[clang] Avoid printing overly large integer. (PR #75902)

2024-02-10 Thread Yueh-Shun Li via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/ShamrockLee edited https://github.com/llvm/llvm-project/pull/75902 ___ cfe-commits mailing list cfe-commits@

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class layout can be statically known (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: Sorry, that was codegen, I meant ![image](https://github.com/llvm/llvm-project/assets/83477269/cd59af73-2f4a-48b6-b847-0994c8191ab2) https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: Layout before and after my change: https://github.com/llvm/llvm-project/assets/83477269/6e45ad11-16e8-4dcc-8d7b-f8e29a1a9cc0";> https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 3287e1ddb572f73ca774e50323b037d50b600e34 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
https://github.com/44-2-Kupa-Martin closed https://github.com/llvm/llvm-project/pull/81389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
44-2-Kupa-Martin wrote: Got the formatter wrong https://github.com/llvm/llvm-project/pull/81389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 4bdf6f78a595e7e33387a1b4f1f80286b0163d47 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 4bdf6f78a595e7e33387a1b4f1f80286b0163d47 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b17348c3b541d7fc7ec441c98db75c18d8959910 b256939140c99356f2ab41e2c69f3d218ffc81a6 --

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 527e24ae4d6f662c2bee1a281914df028bcd01e1 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (44-2-Kupa-Martin) Changes …C mode Factored logic from `CheckImplicitConversion` into new methods `Expr::getEnumConstantDecl` and `Expr::getEnumCoercedType` for use in `checkEnumArithmeticConversions`. Fix #29217 --- Patch is 650

[clang] [Clang][Sema] Fix missing warning when comparing mismatched enums in … (PR #81389)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 527e24ae4d6f662c2bee1a281914df028bcd01e1 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: > test seems completely inadequate — you need to test that we're doing the > static layout properly, and you need to test with ivars coming from a variety > of different places, including: > > * ivars declared in the `@interface` > * ivars declared in the `@implementation` >

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: > Okay, your description of the change here is very misleading; it doesn't even > mention that this is specific to having an `@implementation` for every > intermediate class. > > Your test seems completely inadequate — you need to test that we're doing the > static layout p

[clang] 6a7cf80 - [clang][NFC] Annotate `Sema/ParsedAttr.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:21:37+03:00 New Revision: 6a7cf806a66c67df01818fda01116a2dd2d90b0d URL: https://github.com/llvm/llvm-project/commit/6a7cf806a66c67df01818fda01116a2dd2d90b0d DIFF: https://github.com/llvm/llvm-project/commit/6a7cf806a66c67df01818fda01116a2dd2d90b0d.

[clang] 425fd3e - [clang][NFC] Rename FirstCoroutineStmtKind enumerators

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:15:25+03:00 New Revision: 425fd3eb10f29e73d722b4c2bc9cb50798de18e8 URL: https://github.com/llvm/llvm-project/commit/425fd3eb10f29e73d722b4c2bc9cb50798de18e8 DIFF: https://github.com/llvm/llvm-project/commit/425fd3eb10f29e73d722b4c2bc9cb50798de18e8.

[clang] d2812d2 - [clang][NFC] Annotate `Sema/Overload.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-11T00:11:13+03:00 New Revision: d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec URL: https://github.com/llvm/llvm-project/commit/d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec DIFF: https://github.com/llvm/llvm-project/commit/d2812d2d1a9b4edb64e95a9a86a2599a24bcb5ec.

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-02-10 Thread via cfe-commits
wheatman wrote: @AaronBallman I am a little confused about what is the correct behavior for one the the cases in the test file for c. ```cpp enum PR4515 {PR4515a=1u,PR4515b=(PR4515a-2)/2}; int CheckPR4515[PR4515b==0?1:-1]; ``` At present since everything is ints this works fine, but some things

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Dimitry Andric via cfe-commits
DimitryAndric wrote: Ah that was my error, I hadn't used the regenerated `*-driver.cpp` files. These indeed should contain the `InitLLVM` call. https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 4e16a75 - [clang][NFC] Annotate `Sema/ScopeInfo.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-10T23:58:26+03:00 New Revision: 4e16a75902d5718f4932fae9b2a07c410cd0ba34 URL: https://github.com/llvm/llvm-project/commit/4e16a75902d5718f4932fae9b2a07c410cd0ba34 DIFF: https://github.com/llvm/llvm-project/commit/4e16a75902d5718f4932fae9b2a07c410cd0ba34.

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread John McCall via cfe-commits
https://github.com/rjmccall requested changes to this pull request. Okay, your description of the change here is very misleading; it doesn't even mention that this is specific to having an `@implementation` for every intermediate class. Your test seems completely inadequate — you need to test

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: llvm-driver-template.cpp.in is what should be generating the real main for Clang (and call clang_main), and that was patched in this commit. https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [lld] [llvm] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

2024-02-10 Thread Dimitry Andric via cfe-commits
DimitryAndric wrote: Maybe I'm doing something wrong, but after this commit (and its merge to 18.x) I don't see to get stack traces from clang anymore after assertions? How is this supposed to work? https://github.com/llvm/llvm-project/pull/76306 _

[clang] 3a05e76 - [clang][NFC] Annotate `Sema/DeclSpec.h` with `preferred_type`

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-02-10T23:37:00+03:00 New Revision: 3a05e7651bc71b3c71757bb406f211645c1c1a37 URL: https://github.com/llvm/llvm-project/commit/3a05e7651bc71b3c71757bb406f211645c1c1a37 DIFF: https://github.com/llvm/llvm-project/commit/3a05e7651bc71b3c71757bb406f211645c1c1a37.

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
@@ -1720,6 +1720,12 @@ void StmtPrinter::VisitInitListExpr(InitListExpr* Node) { OS << "{"; for (unsigned i = 0, e = Node->getNumInits(); i != e; ++i) { if (i) OS << ", "; +// TODO: There is duplicated functionality in APValue::printPretty. +// Would be good to

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
@@ -138,15 +138,9 @@ std::string getNamespaceScope(const Decl *D) { std::string printDefinition(const Decl *D, PrintingPolicy PP, const syntax::TokenBuffer &TB) { - if (auto *VD = llvm::dyn_cast(D)) { -if (auto *IE = VD->getInit()) { - //

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 3ad404a10c3def9f92f399774f9f1507442bca1b Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 1739d0a4fd079d2201e63166fbaba60644c52297 Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang-tools-extra] [clangd] Prevent printing huge initializer lists in hover definitions (PR #79746)

2024-02-10 Thread Raoul Wols via cfe-commits
https://github.com/rwols updated https://github.com/llvm/llvm-project/pull/79746 >From 8c850241cedeaad1bcc91c68ad7558f485d212e8 Mon Sep 17 00:00:00 2001 From: Raoul Wols Date: Sat, 10 Feb 2024 20:52:03 +0100 Subject: [PATCH] [clangd] Do not render large initializer expressions from the preamble

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/4] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang] [llvm] [HLSL] Implementation of dot intrinsic (PR #81190)

2024-02-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/81190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` (PR #71709)

2024-02-10 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/71709 >From 2823d38544d18213b5bf48c67e4eedd52acce850 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 8 Nov 2023 20:30:37 +0300 Subject: [PATCH 1/4] [clang] Refactor `IdentifierInfo::ObjcOrBuiltinID` This

[clang] bc034ba - [clang][Interp] Protect InitPtr from non-initializable pointers

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T19:45:10+01:00 New Revision: bc034baaff1f6ce4e18b68c20df3be45bfb5104f URL: https://github.com/llvm/llvm-project/commit/bc034baaff1f6ce4e18b68c20df3be45bfb5104f DIFF: https://github.com/llvm/llvm-project/commit/bc034baaff1f6ce4e18b68c20df3be45bfb5104f.diff LO

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: > Shorts are half an int, so HalfWidth and HalfAlign apply here. This is not true for our downstream target where `short` has the same width as `int` (note that the standard allows it). It would be better to introduce `ShortWidth` / `ShortAlign` fields and initialize them t

[clang] ba451c8 - [clang][Interp][NFC] Only set result invalid if empty

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T19:45:10+01:00 New Revision: ba451c80ba67ab6834305f35d47e36b6b446ce83 URL: https://github.com/llvm/llvm-project/commit/ba451c80ba67ab6834305f35d47e36b6b446ce83 DIFF: https://github.com/llvm/llvm-project/commit/ba451c80ba67ab6834305f35d47e36b6b446ce83.diff LO

[clang] Avoid printing overly large integer. (PR #75902)

2024-02-10 Thread Nhat Nguyen via cfe-commits
=?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= , =?utf-8?q?“Nhat?= Message-ID: In-Reply-To: https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/75902 >From 4939edb1cb2b73f9c60c4cce0803fab4888beb6e Mon Sep 17 00:00:00 2001 From:

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 70c646a54852f33306ff567b5cb125558e2b9529 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81367 >From ebd724f537fe0f7c1ad468d15bb13245c7d56d9f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10 Feb 2024 12:35:20 -0500 Subject: [PATCH] [clang] Resolve FIXME:

[clang] [clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From cb57948468634e952d0c953fe0215fa15f030e28 Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 071f8df3f82798255bcc0e2787fd7167b607d59f Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (Overhatted) Changes I haven't finished all of the tests and formatting so it's a bit in a POC stage but I would like to know if this change would be accepted. The change is to support relative paths in the "directory" fi

[clang] [clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2024-02-10 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 071f8df3f82798255bcc0e2787fd7167b607d59f Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Fri, 15 Dec 2023 15:53:56 + Subject: [PATCH] In compilation data

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81367 >From f12c08eb449781e782f84fc534d0bc6f8483e14f Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10 Feb 2024 12:35:20 -0500 Subject: [PATCH] Resolve FIXME: Use Half

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-em

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: AtariDreams (AtariDreams) Changes Shorts are half an int, so HalfWidth and HalfAlign apply here. --- Full diff: https://github.com/llvm/llvm-project/pull/81367.diff 1 Files Affected: - (modified) clang/include/clang/Basic/TargetInfo.h (

[clang] Resolve FIXME: Use HalfWidth and HalfAlign for shorts (PR #81367)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams created https://github.com/llvm/llvm-project/pull/81367 Shorts are half an int, so HalfWidth and HalfAlign apply here. >From b7c50bfa24abe51e73852667a6d972780dbf8cc2 Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Sat, 10

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-02-10 Thread Jon Roelofs via cfe-commits
@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: I think they are part of ABI, and givin

[clang] d2e4a72 - [clang] Update Clang version from 18 to 19 in scan-build.1.

2024-02-10 Thread Frederic Cambus via cfe-commits
Author: Frederic Cambus Date: 2024-02-10T18:16:08+01:00 New Revision: d2e4a725da5b4cbef8b5c1446f29fed1487aeab0 URL: https://github.com/llvm/llvm-project/commit/d2e4a725da5b4cbef8b5c1446f29fed1487aeab0 DIFF: https://github.com/llvm/llvm-project/commit/d2e4a725da5b4cbef8b5c1446f29fed1487aeab0.dif

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-02-10 Thread Mark de Wever via cfe-commits
mordante wrote: @kaz7 ping https://github.com/llvm/llvm-project/pull/76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b4c6ab6 - [clang][Interp][NFC] Don't use visitLocalInitializer in visitExpr

2024-02-10 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-02-10T18:01:30+01:00 New Revision: b4c6ab600f2ef6f3a842afee569dcf86bce7a43a URL: https://github.com/llvm/llvm-project/commit/b4c6ab600f2ef6f3a842afee569dcf86bce7a43a DIFF: https://github.com/llvm/llvm-project/commit/b4c6ab600f2ef6f3a842afee569dcf86bce7a43a.diff LO

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
AtariDreams wrote: @rjmccall Do you think this is acceptable? https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Make `MCDCParams` as `std::variant` (PR #81227)

2024-02-10 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81227 >From c2b49a5317bf5b8af419cba814f95cc9305bec21 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Thu, 8 Feb 2024 23:12:54 +0900 Subject: [PATCH 1/2] [MC/DC] Refactor: Make `MCDCParams` as `std::variant` Intro

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/81335 >From 18987af24d2f53d00e2ac42998a8f1580e35afdf Mon Sep 17 00:00:00 2001 From: Rose <83477269+ataridre...@users.noreply.github.com> Date: Fri, 9 Feb 2024 17:51:15 -0500 Subject: [PATCH 1/2] [ObjC] Add pre-commi

[clang] [ObjC] Check entire chain of superclasses to see if class has fixed offsets (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vadim D. (vvd170501) Changes Fixes #68933. #56628 changed the behavior of `-Wmissing-field-initializers`, which introduces many new warnings in C++ code that uses partial designated initializers. If such code is being built with `-Wextr

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 ready_for_review https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ObjC] Recursively check superclasses to see if any inherit from NSObject (PR #81335)

2024-02-10 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/81335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wmissing-designated-field-initializers (PR #81364)

2024-02-10 Thread Vadim D. via cfe-commits
https://github.com/vvd170501 edited https://github.com/llvm/llvm-project/pull/81364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >