llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (dhruvachak)
Changes
A kernel implicit parameter (dyn_ptr) was introduced some time back. This patch
increments the kernel args version for a compiler supporting dyn_ptr. The
version will be used by the runtime to determine whether t
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Author: None (dhruvachak)
Changes
A kernel implicit parameter (dyn_ptr) was introduced some time back. This patch
increments the kernel args version for a compiler supporting dyn_ptr. The
version will be used by the runtime to determine wh
https://github.com/SixWeining approved this pull request.
LGTM from LoongArch side as GCC only have `-m[no-]strict-align`.
BTW, should clang release notes be updated for this change?
https://github.com/llvm/llvm-project/pull/85350
___
cfe-commits maili
wangpc-pp wrote:
> Should we use strings like ARM does so we can get register by name?
Good point! We may provide two kinds of builtins: one by name, and another by
CSR number.
We should continue @lenary's proposal and discuss it in
https://github.com/riscv-non-isa/riscv-toolchain-conventions
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
A name is not a FunctionDeclarationName if it's preceded by an Objective-C
keyword.
---
Full diff: https://github.com/llvm/llvm-project/pull/85361.diff
2 Files Affected:
- (modified) clang/lib/Format/To
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/85361
A name is not a FunctionDeclarationName if it's preceded by an Objective-C
keyword.
>From fa46932f5f0c0281d75907a3da795b2f343a8e70 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 14 Mar 2024 20:16:39 -0700
Su
owenca wrote:
Can you add lit test cases?
https://github.com/llvm/llvm-project/pull/84346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1090,7 +1090,8 @@ static bool isStandardNewDelete(const FunctionDecl *FD) {
// If the header for operator delete is not included, it's still defined
// in an invalid source location. Check to make sure we don't crash.
return !L.isValid() ||
- FD->getASTContext
topperc wrote:
Should we use strings like ARM does so we can get register by name?
https://github.com/llvm/llvm-project/pull/85091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tstellar approved this pull request.
Good catch.
https://github.com/llvm/llvm-project/pull/85354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wangpc-pp approved this pull request.
LGTM. cc @asb @topperc
Some context of RISCV target:
https://github.com/riscv-non-isa/riscv-c-api-doc/pull/62
https://github.com/llvm/llvm-project/pull/85350
___
cfe-commits mailing list
cfe-co
wangpc-pp wrote:
GCC gained its `__arm_rsr` and `__arm_wsr` support last year (October, 2023):
https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631855.html. So there is
no stable released GCC version that supports these builtins.
Clang supported these builtins about nine years ago:
https
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c3a1eb6207d85cb37ea29306481b40c9f6402309
b035993b477160d9ac6ef01c8d27e6681682f251 --
llvmbot wrote:
@llvm/pr-subscribers-objectyaml
@llvm/pr-subscribers-mc
@llvm/pr-subscribers-clang-driver
Author: None (quic-areg)
Changes
Defines a subset of attributes and emits them to a section called
.hexagon.attributes.
The current attributes recorded are the attributes needed by ll
https://github.com/quic-areg created
https://github.com/llvm/llvm-project/pull/85359
Defines a subset of attributes and emits them to a section called
.hexagon.attributes.
The current attributes recorded are the attributes needed by llvm-objdump to
automatically determine target features and
https://github.com/yonghong-song created
https://github.com/llvm/llvm-project/pull/85358
Alexei added may_goto insn in [1]. The asm syntax for may_goto looks like
may_goto
The instruction represents a conditional branch but the condition is implicit.
Later in bpf kernel verifier, the 'may_g
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load instr
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load inst
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-llvm-ir
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the inte
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: William Junda Huang (huangjd)
Changes
Such expression does not correspond to a variable in the source code thus does
not have a debug location. When the user collects perf data on the program, if
the intermediate memory load instruction
https://github.com/sam-mccall approved this pull request.
Thank you, and sorry for piling on extra errors...
https://github.com/llvm/llvm-project/pull/85310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mehdi Amini (joker-eph)
Changes
Clang has a custom separate pipeline integrated with libc++ that only runs in
release mode. It means that changes which touches only clang won't run the
clang tests in the configuration used by LLVM premerg
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/85354
Clang has a custom separate pipeline integrated with libc++ that only runs in
release mode. It means that changes which touches only clang won't run the
clang tests in the configuration used by LLVM premerge a
llvmbot wrote:
@llvm/pr-subscribers-backend-loongarch
Author: Fangrui Song (MaskRay)
Changes
GCC ports only supports one of the options, with -mstrict-align
preferred by newer ports. And they reject adding such aliases
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111555).
We should not s
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/85350
GCC ports only supports one of the options, with -mstrict-align
preferred by newer ports. And they reject adding such aliases
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111555).
We should not support aliases,
pulehui wrote:
> @pulehui I will not merge this patch now since it does not really solve the
> whole riscv issue. As @4ast commented above, the verifier made btf_func_model
> to jit.
> [snip]
> So you will know whether it is a struct or signed or not. If you feel you
> need explicit UNSIGNED f
pulehui wrote:
> The `r1` would be zero extended, while to be ABI conformant it has to be sign
> extended, as for RV64 the 31-st bit should be the same as upper 32 bits. The
> fact that decision to zero or sign extend the argument depends on the
> architecture means that this extension has to
Prabhuk wrote:
> I am debugging an assertion failure regression in one of our projects that
> uses the FlatMap data structure implemented here:
>
> https://pigweed.googlesource.com/pigweed/pigweed/+/refs/heads/main/pw_containers/public/pw_containers/flat_map.h#180
>
> The regression was that t
Sirraide wrote:
List of issues that may be fixed by this:
- #71858
https://github.com/llvm/llvm-project/pull/84934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sirraide wrote:
Seeing as there are now two places where we want to adjust function types but
also preserve sugar, I’ve gone ahead and added a generic `adjustType()`
function that handles all of the sugar and takes a `function_ref` to perform
the actual adjustment.
The intent here is that, i
Sirraide wrote:
> Just tried. In C mode, it works to do nothing about effect changes in
> isFunctionConversion (!).
I would maybe try going with that then for now (and maybe add a comment about
that too); I’m not sure my function pointer example is really the same
situation, but I remember fi
dougsonos wrote:
> > have you tried maybe simply not setting `Changed` to `true` (perhaps only
> > in C mode)?
Just tried. In C mode, it works to do nothing about effect changes in
isFunctionConversion (!).
https://github.com/llvm/llvm-project/pull/84983
__
Sirraide wrote:
> Adapted from `test/Sema/initialize-noreturn.c`
Seeing as that test does check that we’re issuing an error for this, and seeing
that this seems to be handled in `isFunctionConversion()`, it really just seems
like that function is supposed to error if there is a conversion (i.e
Sirraide wrote:
>
> I was testing with `noreturn` earlier. It's hard to compare, because (at
> least in C23):
>
> ```
> ../clang/test/Sema/attr-nolock-wip.cpp:15:19: error: 'noreturn' attribute
> cannot be applied to types
>15 | void noret(int) [[noreturn]];
> | ^
rupprecht wrote:
Thanks! Sorry about the delay, we should get the bzl tree setup for automatic
assignment to reviewers.
https://github.com/llvm/llvm-project/pull/81556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
dougsonos wrote:
> > have you tried maybe simply not setting `Changed` to `true` (perhaps only
> > in C mode)?
>
> It’s worth pointing out that C also warns (and C23 straight-up _errors_) if
> you replace `nolock` w/ `noreturn` iirc, so either that’s also a bug or
> that’s intended; I think I
Sirraide wrote:
> swapping the two didn’t seem to change anything
In one specific place where this is called in C mode, that is. From what I
could see, the ordering seems to be correct for other calls to this function.
https://github.com/llvm/llvm-project/pull/84983
___
github-actions[bot] wrote:
@josh11b Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
Sirraide wrote:
> have you tried maybe simply not setting `Changed` to `true` (perhaps only in
> C mode)?
It’s worth pointing out that C also warns (and C23 straight-up *errors*) if you
replace `nolock` w/ `noreturn` iirc, so either that’s also a bug or that’s
intended; I think I was going to
Sirraide wrote:
> the naming of "From" and "To" seems backwards.
I noticed that as well; as I recall, swapping the two didn’t seem to change
anything. I might open a pr or issue about this to either fix this or at least
get some clarification as to whether that was really intended. I got a bit
Sirraide wrote:
> I've probably been staring at this way too long, but here's what's going on.
> My test is:
My bad, I remember looking into this yesterday or the day before; from what I
could tell, it seems I may have forgotten to share what I found here: I think
the problem is that the code
dougsonos wrote:
> > * Conversions between functions / function pointers with and without the
> > attribute work in C++ but not in C and I'm a bit lost (there's a bunch of
> > debug logging around this e.g. Sema::IsFunctionConversion and
> > Sema::ImpCastExprToType)
I've probably been staring
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Joshua Batista (bob80905)
Changes
Previously, the clang compiler with the dxc driver would accept the
-enable-16bit-types flag without checking to see if the required conditions are
met for proper process
https://github.com/bob80905 created
https://github.com/llvm/llvm-project/pull/85340
Previously, the clang compiler with the dxc driver would accept the
-enable-16bit-types flag without checking to see if the required conditions are
met for proper processing of the flag.
Specifically, -enable-
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From 474d15b0454ecfef5ce4802b2df071daa136122c Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From ea3a9ee76249bd1216bc6aa16dcec6008f12a19b Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From 10d544d35261a6ee6719ea38c22f3117ca8bf422 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
https://github.com/AtariDreams updated
https://github.com/llvm/llvm-project/pull/85316
>From 7a88cbf69e455434d4433e52eff9230780ede065 Mon Sep 17 00:00:00 2001
From: Rose
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bde7a6b791872b63456cb4e50e63046728a65196
d6a57b5a5aa123cf38ce3657b764c74c4c5a86f7 --
@@ -1537,6 +1537,12 @@ class CodeGenModule : public CodeGenTypeCache {
void printPostfixForExternalizedDecl(llvm::raw_ostream &OS,
const Decl *D) const;
+ /// Under debug mode, print status of target teams loop transformation,
+ /// w
@@ -11311,6 +11311,10 @@ class Sema final {
OpenMPDirectiveKind &Kind,
OpenMPDirectiveKind &PrevMappedDirective);
+ /// [target] teams loop is equivalent to parallel for if associated loop
+ /// nest meets certain critera.
+ b
