@@ -792,13 +792,14 @@ EncompassingIntegerType(ArrayRef Types) {
Value *CodeGenFunction::EmitVAStartEnd(Value *ArgValue, bool IsStart) {
Intrinsic::ID inst = IsStart ? Intrinsic::vastart : Intrinsic::vaend;
- return Builder.CreateCall(CGM.getIntrinsic(inst), ArgValue);
+ re
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/86217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrtc27 wrote:
This probably also needs to tweak LangRef
https://github.com/llvm/llvm-project/pull/85460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
> > > > Do you want to rename intrinsics as well? Because now intrinsic names
> > > > do not match builtin names.
> > >
> > >
> > > Do we have to match builtins with intrinsics? Renaming intrinsics here
> > > means we will have to duplicate the intrinsics.
> >
> >
> > Is tha
https://github.com/aheejin approved this pull request.
https://github.com/llvm/llvm-project/pull/84137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/86217
>From 722b8b454d652b3d52e20b9bacff58e096cc7feb Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 21 Mar 2024 18:25:35 -0500
Subject: [PATCH] [Clang] Make '-frtlib-add-rpath' include the standard library
dir
changpeng wrote:
> I don't think intrinsics are meant for users. Builtins are the user-facing
> front. :-)
Then renaing the intrinsics should be relatively at a lower priority. We may do
it in a separate patch once we have reached an agreement.
https://github.com/llvm/llvm-project/pull/86202
https://github.com/thetruestblue approved this pull request.
Thanks for looking into this.
https://github.com/llvm/llvm-project/pull/86220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
smanna12 wrote:
> If you read the code, it should be obvious the pointer is in fact non-null.
> Please don't insert null checks into the code just to address static analyzer
> false positives.
Thank you @efriedma-quic for reviews! I misunderstood some of the code parts.
https://github.com/l
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/86018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
@@ -0,0 +1,82 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1069,6 +1069,10 @@ Address X86_32ABIInfo::EmitVAArg(CodeGenFunction &CGF,
auto TypeInfo = getContext().getTypeInfoInChars(Ty);
+ // Empty records are ignored for parameter passing purposes on non-Windows.
+ if (!IsWin32StructABI && isEmptyRecord(getContext(), Ty, true
https://github.com/hach-que created
https://github.com/llvm/llvm-project/pull/86228
This adds a 'refersToPack' AST matcher, which can be used to match against
template arguments that are inside parameter packs. The inner matcher is
evaluated against each argument in the parameter pack, such th
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: June Rhodes (hach-que)
Changes
This adds a 'refersToPack' AST matcher, which can be used to match against
template arguments that are inside parameter packs. The inner matcher is
evaluated against each argument in the parameter pack, such
https://github.com/hach-que created
https://github.com/llvm/llvm-project/pull/86230
This adds a `forNone` AST matcher, which matches only if there are no immediate
children of the current node that match the inner matcher. For example, given:
```cpp
class F
{
public:
int A;
F() {};
};
```
https://github.com/hach-que edited
https://github.com/llvm/llvm-project/pull/86230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 718fbbef5f18a2b7e7fc4f842b1452ae9bee581a
b0ef223dfab9c8ebc67601ccfbbe0ce3abe15f12 --
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/hach-que updated
https://github.com/llvm/llvm-project/pull/86230
>From bf78fb2172048c703824698b839e20ad1b8bf0b2 Mon Sep 17 00:00:00 2001
From: June Rhodes
Date: Fri, 22 Mar 2024 13:07:57 +1100
Subject: [PATCH] Add 'forNone' AST matcher
---
clang/include/clang/ASTMatchers/AS
https://github.com/hach-que updated
https://github.com/llvm/llvm-project/pull/86230
>From 9b04a03646992a3366022dd7022858c98f7560e7 Mon Sep 17 00:00:00 2001
From: June Rhodes
Date: Fri, 22 Mar 2024 13:07:57 +1100
Subject: [PATCH] Add 'forNone' and 'forNoDescendant' AST matchers
---
clang/inclu
https://github.com/hach-que edited
https://github.com/llvm/llvm-project/pull/86230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hach-que edited
https://github.com/llvm/llvm-project/pull/86230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hach-que edited
https://github.com/llvm/llvm-project/pull/86230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hach-que created
https://github.com/llvm/llvm-project/pull/86233
This adds an `isPODType` AST matcher which matches if the matched type is a
Plain Old Data (POD) type.
Given:
```cpp
class Y
{
public:
int a;
std::string b;
};
```
the matcher `fieldDecl(hasType(qual
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: June Rhodes (hach-que)
Changes
This adds an `isPODType` AST matcher which matches if the matched type is a
Plain Old Data (POD) type.
Given:
```cpp
class Y
{
public:
int a;
std::string b;
};
```
the matcher `fieldDecl(hasType(q
https://github.com/hach-que updated
https://github.com/llvm/llvm-project/pull/86230
>From 25e3b11324ba4fc43e36035d357d1aa785898bbc Mon Sep 17 00:00:00 2001
From: June Rhodes
Date: Fri, 22 Mar 2024 13:07:57 +1100
Subject: [PATCH] Add 'forNone' and 'forNoDescendant' AST matchers
---
clang/inclu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: June Rhodes (hach-que)
Changes
This adds a `forNone` AST matcher, which matches only if there are no immediate
children of the current node that match the inner matcher. For example, given:
```cpp
class F
{
public:
int A;
F() {};
};
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 718fbbef5f18a2b7e7fc4f842b1452ae9bee581a
87d02c2278e023b9439be96c2d34e934bcb57a26 --
https://github.com/hach-que updated
https://github.com/llvm/llvm-project/pull/86233
>From 0e6cfaba6ab55166b7b08eecb28714c0746707f1 Mon Sep 17 00:00:00 2001
From: June Rhodes
Date: Fri, 22 Mar 2024 13:36:54 +1100
Subject: [PATCH] Add 'isPODType' AST matcher
---
clang/include/clang/ASTMatchers/
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/paperchalice updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/2] [clang-tidy] add new check readability-enum-initial-value
https://github.com/hach-que updated
https://github.com/llvm/llvm-project/pull/86230
>From 941ac5286c0e5f859ae832dc397a55a9d21221c9 Mon Sep 17 00:00:00 2001
From: June Rhodes
Date: Fri, 22 Mar 2024 13:07:57 +1100
Subject: [PATCH] Add 'forNone' and 'forNoDescendant' AST matchers
---
clang/inclu
@@ -21,10 +27,76 @@ struct __attribute((packed, aligned(4))) { char a; int x;
char z[]; } e = { 1, 2
struct { int x; char y[]; } f = { 1, { 13, 15 } };
// CHECK: @f ={{.*}} global <{ i32, [2 x i8] }> <{ i32 1, [2 x i8] c"\0D\0F" }>
-union {
- struct {
-int a;
-char b
https://github.com/16bit-ykiko updated
https://github.com/llvm/llvm-project/pull/86143
>From 32d4fc35f3d52b54e308b76c00c292497afe9621 Mon Sep 17 00:00:00 2001
From: ykiko
Date: Fri, 22 Mar 2024 00:00:30 +0800
Subject: [PATCH 1/4] add `clang_getCursorCallExprKind` to get the underlying
type of
atetubou wrote:
@MaskRay could you review this?
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Abhinkop wrote:
I think that this would occur primarily in the whole code base. Because a
compilation that has added -Wextra diagnostic group would provide new warnings
and coupling, this with -Werror would break the build. I think we have to take
a look at these builds and investigate why it
rampitec wrote:
> I don't think intrinsics are meant for users. Builtins are the user-facing
> front. :-)
Depending on who you consider an user. Are folks writing MLIR generators users?
https://github.com/llvm/llvm-project/pull/86202
___
cfe-commits
piotrAMD wrote:
The change LG - thanks for adding support for bf16.
Agreed that the intrinsics should match the builtins for consistency (now or in
a follow-up commit).
These intrinsics were added for the upcoming generation - it should be fine to
rename them at this stage.
https://github.com
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #85761.
---
Full diff: https://github.com/llvm/llvm-project/pull/86253.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+19-12)
- (modified) clang/unittests/Format/FormatTe
301 - 340 of 340 matches
Mail list logo
