MikeWeller wrote:
Sorry, didn't realize there are release notes I can updated in the change
itself. Will do this Monday.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -7735,7 +7735,8 @@ ExprResult Sema::BuildResolvedCallExpr(Expr *Fn,
NamedDecl *NDecl,
}
if (CXXMethodDecl *Method = dyn_cast_or_null(FDecl))
-if (Method->isImplicitObjectMemberFunction())
+if (!isa(CurContext) &&
jcsxky wrote:
And if only chec
Endilll wrote:
@fhahn Yeah, that's theoretically possible. I'll look into it today.
https://github.com/llvm/llvm-project/pull/88559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
I'm not sure this is testable, but if you can think of a test, that would be
nice.
Can you also add a release note to `clang/ReleaseNotes.rst`?
https://github.com/llvm/llvm-project/pull/88637
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/87933
>From 9fba6da7cb1ffbc7d46b69c6ac0cfd15a89c4b56 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Mon, 8 Apr 2024 01:38:23 +0800
Subject: [PATCH] [Clang] Support lifetime extension of temporary created by
aggregate
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -831,7 +831,7 @@ class PackDeductionScope {
if (IsPartiallyExpanded)
PackElements += NumPartialPackArgs;
else if (IsExpanded)
- PackElements += *FixedNumExpansions;
+ PackElements += FixedNumExpansions.value_or(1);
Sirraide wrote:
Th
Sirraide wrote:
> I can supply the exact code that causes this issue if needed, but I would
> appreciate if you frends can point me to any tools that can generate an
> obfuscated minimal reproducible example.
There’s `creduce` and `cvise` from what I recall, but I’m not particularly good
at u
llvmbot wrote:
@llvm/pr-subscribers-openmp
Author: Vlad Serebrennikov (Endilll)
Changes
This patch moves OpenMP-related entities out of `Sema` to a newly created
`SemaOpenMP` class. This is a part of the effort to split `Sema` up, and
follows the recent example of CUDA, OpenACC, SYCL, HL
Endilll wrote:
I intentionally split formatting changes into a separate commit if reviewers
want to look at changes without formatting noise.
If, given the volume of changes here, there is an appetite to remove `OpenMP`
and `OMP` from names inside `SemaOpenMP` right in this patch, I can do tha
owenca wrote:
> I wish we'd made this removal an option rather than just removing it, what we
> are seeing is reasonably formatted json or xml being streamed out is now
> poorly written
>
> ```c++
> osjson << "{\n"
><<" \"name\": \"value\",\n"
><<" \"key\": \"abc\", \n"
>
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/88596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
https://github.com/Sirraide requested changes to this pull request.
Not too familiar w/ the overall context of this, so I can only comment on the
implementation.
This should also add some tests that actually use experimentally late-parsed
attributes w/ the flag explicilty enabled/disabled.
ht
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
Sirraide wrote:
T
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -2101,9 +2179,20 @@ bool PragmaClangAttributeSupport::isAttributedSupported(
return SpecifiedResult;
// Opt-out rules:
- // An attribute requires delayed parsing (LateParsed is on)
- if (Attribute.getValueAsBit("LateParsed"))
+
+ // An attribute requires delayed pa
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -2885,8 +2974,23 @@ static void emitAttributes(RecordKeeper &Records,
raw_ostream &OS,
return;
}
OS << "\n : " << SuperName << "(Ctx, CommonInfo, ";
- OS << "attr::" << R.getName() << ", "
- << (R.getValueAsBit("LateParsed") ? "true" : "fal
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -2885,8 +2974,23 @@ static void emitAttributes(RecordKeeper &Records,
raw_ostream &OS,
return;
}
OS << "\n : " << SuperName << "(Ctx, CommonInfo, ";
- OS << "attr::" << R.getName() << ", "
- << (R.getValueAsBit("LateParsed") ? "true" : "fal
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
Endilll wrote:
I think I exposed a name conflict with a system header on AIX by including
`Cuda.h` in `Sema.h`. Given that this name conflict potentially affects both
enum definition and its usage, how should we resolve this?
https://github.com/llvm/llvm-project/pull/88559
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
delcypher wrote:
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
Sirraide wrote:
I
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -2101,9 +2179,20 @@ bool PragmaClangAttributeSupport::isAttributedSupported(
return SpecifiedResult;
// Opt-out rules:
- // An attribute requires delayed parsing (LateParsed is on)
- if (Attribute.getValueAsBit("LateParsed"))
+
+ // An attribute requires delayed pa
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
@@ -2101,9 +2179,20 @@ bool PragmaClangAttributeSupport::isAttributedSupported(
return SpecifiedResult;
// Opt-out rules:
- // An attribute requires delayed parsing (LateParsed is on)
- if (Attribute.getValueAsBit("LateParsed"))
+
+ // An attribute requires delayed pa
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/88644
Fixes clang-ppc64-aix bot failure after #88559
(0a6f6df5b0c3d0f2a42f013bf5cafb9b5020dcac)
https://lab.llvm.org/buildbot/#/builders/214/builds/11887
>From 9d46b1ed31d2acbb772f9bb4b139fa1ec36a65ab Mon Sep 17 00:0
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
Fixes clang-ppc64-aix bot failure after #88559
(0a6f6df5b0c3d0f2a42f013bf5cafb9b5020dcac)
https://lab.llvm.org/buildbot/#/builders/214/builds/11887
---
Full diff: https://github.com/llvm/llvm-project/
delcypher wrote:
@Sirraide
Thanks for the feedback.
> This should also add some tests that actually use experimentally late-parsed
> attributes w/ the flag explicilty enabled/disabled.
The intention is for the functionality being added to be used in a subsequent
PR. This is currently sketch
https://github.com/delcypher updated
https://github.com/llvm/llvm-project/pull/88596
>From 554287a724361a510389d7f34f9b57cf434b9657 Mon Sep 17 00:00:00 2001
From: Dan Liew
Date: Fri, 12 Apr 2024 17:36:19 -0700
Subject: [PATCH 1/2] [Attributes] Support Attributes being declared as only
supporti
@@ -1822,28 +1822,106 @@ void WriteSemanticSpellingSwitch(const std::string
&VarName,
OS << " }\n";
}
+enum class LateAttrParseKind {
+ LateAttrParsingNever = 0,
+ LateAttrParsingAlways = 1,
+ LateAttrParsingExperimentalOnly = 2
+};
+
+static LateAttrParseKind getLateAt
Sirraide wrote:
> Given that a subsequent patch will add the necessary test coverage and the
> above problems I think it is reasonable for explicit tests for
> `LateAttrParsingExperimentalOnly` to be omitted
Yeah, if it’s not used anywhere or if both prs are merged at the same time,
then that
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new
Author: Chris Copeland
Date: 2024-04-14T08:37:58+02:00
New Revision: 09327efdf0f02c4f865a4536db96cac539bb1c01
URL:
https://github.com/llvm/llvm-project/commit/09327efdf0f02c4f865a4536db96cac539bb1c01
DIFF:
https://github.com/llvm/llvm-project/commit/09327efdf0f02c4f865a4536db96cac539bb1c01.diff
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@chrisnc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/HighCommander4 created
https://github.com/llvm/llvm-project/pull/88645
Fixes https://github.com/clangd/clangd/issues/1821
>From 42ee794d3de89241fae7314db2202cac32af469b Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sun, 14 Apr 2024 02:41:48 -0400
Subject: [PATCH] [clang]
101 - 145 of 145 matches
Mail list logo