[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 874dcae - [Serialization] Use stable hash functions

2024-06-20 Thread via cfe-commits
Author: Fangrui Song Date: 2024-06-20T23:53:07-07:00 New Revision: 874dcaea09171100de02fa6d5c0af0669aea900f URL: https://github.com/llvm/llvm-project/commit/874dcaea09171100de02fa6d5c0af0669aea900f DIFF: https://github.com/llvm/llvm-project/commit/874dcaea09171100de02fa6d5c0af0669aea900f.diff

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-06-20 Thread Timm Baeder via cfe-commits
@@ -215,6 +215,18 @@ def FminF16F128 : Builtin, F16F128MathTemplate { let Prototype = "T(T, T)"; } +def FmaximumNumF16F128 : Builtin, F16F128MathTemplate { + let Spellings = ["__builtin_fmaximum_num"]; + let Attributes = [FunctionWithBuiltinPrefix, NoThrow, Const, Constexp

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM then. https://github.com/llvm/llvm-project/pull/96136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-20 Thread Nikita Popov via cfe-commits
nikic wrote: It looks like this PR was merged without being approved, and I also couldn't find the corresponding RFC for this addition on discourse. I've reverted it for now. https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing lis

[clang] [llvm] [AArch64] Fix argument passing in reserved registers for preserve_nonecc (PR #96259)

2024-06-20 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss approved this pull request. LGTM, Thanks! https://github.com/llvm/llvm-project/pull/96259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > > This looks generally good. > > Which tests are still failing? OK. 12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e has fixed these failures. If this PR is applied as well, applying https://github.com/MaskRay/llvm-project/tree/hashing-seed will not cause `check-clang` failures. h

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: YunQiang Su (wzssyqa) Changes We just introduce llvm.minimumnum and llvm.maximumnum intrinsics support to llvm. Let's support them in Clang. See: #93033 --- Full diff: https://github.com/llvm/llvm-project/pull/96281.diff 6 Files Affect

[clang] Clang: Support minimumnum and maximumnum intrinsics (PR #96281)

2024-06-20 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa created https://github.com/llvm/llvm-project/pull/96281 We just introduce llvm.minimumnum and llvm.maximumnum intrinsics support to llvm. Let's support them in Clang. See: #93033 >From 5605426ee61ec58cad701103a43922b67792ccaf Mon Sep 17 00:00:00 2001 From: YunQiang

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-06-20 Thread Timm Baeder via cfe-commits
tbaederr wrote: > I tried out this WIP on our codebase after we ran into a problem where an > annotation was added to a definition rather than a declaration, leading to a > (silently) missed capability check. > > This addition seems to work fine, but it triggers warnings when annotations > ar

[clang] [clang-tools-extra] Reland [clang][Sema, Lex, Parse] Preprocessor embed in C and C++ (PR #95802)

2024-06-20 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: According to the bots that worked! https://github.com/llvm/llvm-project/pull/95802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 12c0281 - [Lex] Replace hash_combine with a stable hash

2024-06-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-20T23:26:15-07:00 New Revision: 12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e URL: https://github.com/llvm/llvm-project/commit/12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e DIFF: https://github.com/llvm/llvm-project/commit/12c0281f8c73bc1aa20d1517357e0e12c3f8bb4e.diff

[clang] 62abd9a - [Lex] HeaderSearchOptions: Remove unused hash_value overloads

2024-06-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-20T22:46:47-07:00 New Revision: 62abd9a6f6fecaebb5aaac7720622f4ca13b3e45 URL: https://github.com/llvm/llvm-project/commit/62abd9a6f6fecaebb5aaac7720622f4ca13b3e45 DIFF: https://github.com/llvm/llvm-project/commit/62abd9a6f6fecaebb5aaac7720622f4ca13b3e45.diff

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-20 Thread Pranav Bhandarkar via cfe-commits
bhandarkar-pranav wrote: @Meinersbur, @ergawy, @skatrak - Could you please give this another look. I have updated the testcase `target-depend.f90` because the previous version was flaky; I had used `depend` incorrectly which I have fixed now. (Previously, `depend` was used on tasks that were

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-20 Thread Pranav Bhandarkar via cfe-commits
https://github.com/bhandarkar-pranav edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[X86] Add support for MS inp functions." (PR #95890)

2024-06-20 Thread Malay Sanghi via cfe-commits
https://github.com/MalaySanghi closed https://github.com/llvm/llvm-project/pull/95890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86]Add support for __outbyte/word/dword and __inbyte/word/dword (PR #93774)

2024-06-20 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/93774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3482403 - [X86]Add support for __outbyte/word/dword and __inbyte/word/dword (#93774)

2024-06-20 Thread via cfe-commits
Author: Malay Sanghi Date: 2024-06-21T13:09:47+08:00 New Revision: 348240362f9673c824c0ad22fd9e13ae3f937864 URL: https://github.com/llvm/llvm-project/commit/348240362f9673c824c0ad22fd9e13ae3f937864 DIFF: https://github.com/llvm/llvm-project/commit/348240362f9673c824c0ad22fd9e13ae3f937864.diff

[clang] cfd2021 - [clang][dataflow] Add a callback run on the pre-transfer state. (#96140)

2024-06-20 Thread via cfe-commits
Author: martinboehme Date: 2024-06-21T06:52:31+02:00 New Revision: cfd202141069809c3c65b8b49d3896f44ff10a6a URL: https://github.com/llvm/llvm-project/commit/cfd202141069809c3c65b8b49d3896f44ff10a6a DIFF: https://github.com/llvm/llvm-project/commit/cfd202141069809c3c65b8b49d3896f44ff10a6a.diff

[clang] [clang][dataflow] Add a callback run on the pre-transfer state. (PR #96140)

2024-06-20 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/96140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 255986e - [Driver] BuildOffloadingActions: Stabilize iteration order

2024-06-20 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-20T21:45:40-07:00 New Revision: 255986e27fcf9f0b36f7a23fbe030fcca1ba0249 URL: https://github.com/llvm/llvm-project/commit/255986e27fcf9f0b36f7a23fbe030fcca1ba0249 DIFF: https://github.com/llvm/llvm-project/commit/255986e27fcf9f0b36f7a23fbe030fcca1ba0249.diff

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-20 Thread via cfe-commits
https://github.com/dyung edited https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-20 Thread via cfe-commits
@@ -798,6 +804,12 @@ # DEBUG-NEXT: .. opcode {{[0-9]+}} is aliased to {{[0-9]+}} # DEBUG-NEXT: .. type index coverage check SKIPPED: user-defined predicate detected # DEBUG-NEXT: .. imm index coverage check SKIPPED: user-defined predicate detected +# DEBUG-NEXT: G_VECREDUCE_F

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: - [ ] Clang :: APINotes/module-cache.m - [ ] Clang :: Driver/cuda-bindings.cu - [ ] Clang :: Driver/cuda-phases.cu - [ ] Clang :: Driver/hip-phases.hip - [ ] Clang :: Driver/hip-toolchain-no-rdc.hip - [ ] Clang :: Driver/openmp-system-arch.c - [ ] Clang :: Modules/Rmodule-bu

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-20 Thread YunQiang Su via cfe-commits
https://github.com/wzssyqa closed https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Clarify diagnostic notes for implicitly generated deduction guides (PR #96084)

2024-06-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/96084 >From 23844cd8b8fad07bce0c34f58430322090c5a793 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 19 Jun 2024 23:25:13 +0800 Subject: [PATCH 1/3] [Clang] Add diagnostic notes for implcitly generated deductio

[clang] [Clang] Clarify diagnostic notes for implicitly generated deduction guides (PR #96084)

2024-06-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/96084 >From 23844cd8b8fad07bce0c34f58430322090c5a793 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 19 Jun 2024 23:25:13 +0800 Subject: [PATCH 1/3] [Clang] Add diagnostic notes for implcitly generated deductio

[clang] [Clang] Clarify diagnostic notes for implicitly generated deduction guides (PR #96084)

2024-06-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/96084 >From 23844cd8b8fad07bce0c34f58430322090c5a793 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 19 Jun 2024 23:25:13 +0800 Subject: [PATCH 1/2] [Clang] Add diagnostic notes for implcitly generated deductio

[clang] [lld] [llvm] [RISCV] Make M imply Zmmul (PR #95070)

2024-06-20 Thread Jianjian Guan via cfe-commits
https://github.com/jacquesguan closed https://github.com/llvm/llvm-project/pull/95070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7625465 - [RISCV] Make M imply Zmmul (#95070)

2024-06-20 Thread via cfe-commits
Author: Jianjian Guan Date: 2024-06-21T11:11:10+08:00 New Revision: 762546565173e27b1851dfd1f3bfcc7fc847a2f9 URL: https://github.com/llvm/llvm-project/commit/762546565173e27b1851dfd1f3bfcc7fc847a2f9 DIFF: https://github.com/llvm/llvm-project/commit/762546565173e27b1851dfd1f3bfcc7fc847a2f9.diff

[clang] e648603 - [C++20] [Modules] Reference all the possible declarations for ADL

2024-06-20 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-21T11:04:53+08:00 New Revision: e6486030340ea5756bec43a633567ed6411668c3 URL: https://github.com/llvm/llvm-project/commit/e6486030340ea5756bec43a633567ed6411668c3 DIFF: https://github.com/llvm/llvm-project/commit/e6486030340ea5756bec43a633567ed6411668c3.diff LO

[libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-20 Thread via cfe-commits
h-vetinari wrote: > Actually, I think some of the libunwind failures on BuildKite are legitimate. > See https://buildkite.com/llvm-project/libcxx-ci/builds/35920. Yeah, it looks like the picolib-noexceptions build is _still_ trying to actually build the exceptions, and then fails to find the s

[clang] [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling for pointer types (PR #92477)

2024-06-20 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 closed https://github.com/llvm/llvm-project/pull/92477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7b906d4 - [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling for pointer types (#92477)

2024-06-20 Thread via cfe-commits
Author: Max Winkler Date: 2024-06-20T19:49:17-07:00 New Revision: 7b906d46f6e6915f32718dd5b313ba47a7cec259 URL: https://github.com/llvm/llvm-project/commit/7b906d46f6e6915f32718dd5b313ba47a7cec259 DIFF: https://github.com/llvm/llvm-project/commit/7b906d46f6e6915f32718dd5b313ba47a7cec259.diff L

[clang] [llvm] [Serialization] Use stable hash functions (PR #96136)

2024-06-20 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > This looks generally good. > > > Some check-clang-modules tests still fail (@ChuanqiXu9) > > > > > > What does this mean? Do you mean there are some failures after this patch? > > What are they? Or are these tests failing before this patch? > > When https://github.com/Ma

[clang] [clang-format] Annotate r_paren before braced list as TT_CastRParen (PR #96271)

2024-06-20 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/96271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate r_paren before braced list as TT_CastRParen (PR #96271)

2024-06-20 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/96271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate r_paren before braced list as TT_CastRParen (PR #96271)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/96271.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+5) - (modified) clang/unittests/Format/TokenAnnotatorTest.cpp (+

[clang] [clang-format] Annotate r_paren before braced list as TT_CastRParen (PR #96271)

2024-06-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/96271 None >From 44eec3e8d4bec1de03428d42dce98a998f282825 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 20 Jun 2024 19:38:38 -0700 Subject: [PATCH] [clang-format] Annotate r_paren before braced list as TT_CastRPa

[clang] [TBAA] Emit int TBAA metadata on FP math libcalls (PR #96025)

2024-06-20 Thread via cfe-commits
vfdff wrote: hi @efriedma-quic, I surprise to find there are 4 new failed tests with new commit 9990877a2 because **timeout**, but the change seems tiny, need some time to figure out the reason. If you have any suggestions, it's also very welcome. https://github.com/llvm/llvm-project/pull/9602

[clang] [clang-format[NFC] Clean up AnnotatingParser::rParenEndsCast() (PR #96128)

2024-06-20 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/96128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 749876e - [clang-format[NFC] Clean up AnnotatingParser::rParenEndsCast() (#96128)

2024-06-20 Thread via cfe-commits
Author: Owen Pan Date: 2024-06-20T18:59:23-07:00 New Revision: 749876e8e5e505c2c635ab37d2006d7d0ea87f37 URL: https://github.com/llvm/llvm-project/commit/749876e8e5e505c2c635ab37d2006d7d0ea87f37 DIFF: https://github.com/llvm/llvm-project/commit/749876e8e5e505c2c635ab37d2006d7d0ea87f37.diff LOG:

[clang] [Clang] resolve record declaration of defaulted comparison method by using the first argument (PR #96228)

2024-06-20 Thread Younan Zhang via cfe-commits
@@ -9192,7 +9194,7 @@ ComputeDefaultedComparisonExceptionSpec(Sema &S, SourceLocation Loc, EnterExpressionEvaluationContext Context( S, Sema::ExpressionEvaluationContext::Unevaluated); -CXXRecordDecl *RD = cast(FD->getLexicalParent()); +auto RD = getRecord

[clang] [Serialization] Don't read all declaration id eagerly when merge the tables (PR #95506)

2024-06-20 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > Yeah, I think this patch may be conceptually good except the extra memory > > using. But benchmarking, I tried it locally but didn't find observable > > effects. So I'd like to land this after 19's branching to give it more > > baking time. > > Do you mean that no large

[clang] [serialization] No transitive type change (PR #92511)

2024-06-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/92511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 03921b9 - [serialization] No transitive type change (#92511)

2024-06-20 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-06-21T09:21:40+08:00 New Revision: 03921b979d67657bfc9cf8240add2484cc4df6a7 URL: https://github.com/llvm/llvm-project/commit/03921b979d67657bfc9cf8240add2484cc4df6a7 DIFF: https://github.com/llvm/llvm-project/commit/03921b979d67657bfc9cf8240add2484cc4df6a7.diff LO

[clang] [serialization] No transitive type change (PR #92511)

2024-06-20 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Thanks for reviewing https://github.com/llvm/llvm-project/pull/92511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable ASAN in amdgpu toolchain for OpenCL (PR #96262)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/96262.diff 3 Files Affected: - (modified) clang/lib/Driver/ToolChains/AMDGPU.cpp (+6) - (modified) clang/lib/Driver/ToolChains/AMDGPU.h (+3)

[clang] Enable ASAN in amdgpu toolchain for OpenCL (PR #96262)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/96262.diff 3 Files Affected: - (modified) clang/lib/Driver/ToolChains/AMDGPU.cpp (+6) - (modified)

[clang] Enable ASAN in amdgpu toolchain for OpenCL (PR #96262)

2024-06-20 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/96262 None >From 16659ca492234b234cc5da2f36563e1d8009620f Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 20 Jun 2024 21:00:58 -0400 Subject: [PATCH] Enable ASAN in amdgpu toolchain for OpenCL --- clang

[clang] [llvm] [AArch64] Fix argument passing in reserved registers for preserve_nonecc (PR #96259)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes These registers include: - X19, used by LLVM as the base pointer - X15 on Windows, where it is used for stack allocation. It can still be used on Linux/Darwin - Adjust FrameLowering scratch register code to not ass

[clang] [llvm] [AArch64] Fix argument passing in reserved registers for preserve_nonecc (PR #96259)

2024-06-20 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/96259 These registers include: - X19, used by LLVM as the base pointer - X15 on Windows, where it is used for stack allocation. It can still be used on Linux/Darwin - Adjust FrameLowering scratch register code to not

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Vlad Serebrennikov via cfe-commits
@@ -241,6 +238,13 @@ TPLa a; } // namespace Thirteen +namespace Fourteen { +template +int A = T(); + +using enum A; // expected-error {{A is not an enumerated type}} +} // namespace Fourteen Endilll wrote: Yes. If you look at the rest of the file, you'll see

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Vlad Serebrennikov via cfe-commits
@@ -148,13 +148,10 @@ template struct C { enum class D { d, e, f }; - using enum D; - - static constexpr int W = int(f) + I; + using enum D; // expected-error {{using-enum cannot name a dependent type}} Endilll wrote: Ye

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-06-20 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson commented: Since I believe the CMake minimum version supports this, I don't see why we shouldn't submit this cleanup. Whether to change the flag detection logic can be a separate discussion IMO. https://github.com/llvm/llvm-project/pull/96171

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-20 Thread David Blaikie via cfe-commits
dwblaikie wrote: I think my last comment/question is still open? How/why did the symbol name end up dropping any llvm/clang component to avoid collisions with other names? https://github.com/llvm/llvm-project/pull/79230 ___ cfe-commits mailing list cf

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/95399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
@@ -148,13 +148,10 @@ template struct C { enum class D { d, e, f }; - using enum D; - - static constexpr int W = int(f) + I; + using enum D; // expected-error {{using-enum cannot name a dependent type}} shafik wrote: It

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
@@ -241,6 +238,13 @@ TPLa a; } // namespace Thirteen +namespace Fourteen { +template +int A = T(); + +using enum A; // expected-error {{A is not an enumerated type}} +} // namespace Fourteen shafik wrote: What does `Fourteen` stand for here or is it just a u

[clang] [clang] Implement CWG2877 "Type-only lookup for using-enum-declarator" (PR #95399)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/95399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

2024-06-20 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/15] implement binding type error for t/cbuffers and rwbuffers

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

2024-06-20 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/15] implement binding type error for t/cbuffers and rwbuffers

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-06-20 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/96171 >From 1df587efeb71fb1929667f008d7e9b251863d9d8 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Thu, 20 Jun 2024 21:43:31 +1100 Subject: [PATCH 1/3] [cmake] switch to CMake's native check_linker_flag, delet

[clang] [BoundsSafety][doc] Make it clear that the feature is work-in-progress (PR #95964)

2024-06-20 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna closed https://github.com/llvm/llvm-project/pull/95964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f477784 - [BoundsSafety][doc] Make it clear that the feature is work-in-progress (#95964)

2024-06-20 Thread via cfe-commits
Author: Yeoul Na Date: 2024-06-20T15:54:25-07:00 New Revision: f47778455d28285341d0eeceb53ae7cd95d07d36 URL: https://github.com/llvm/llvm-project/commit/f47778455d28285341d0eeceb53ae7cd95d07d36 DIFF: https://github.com/llvm/llvm-project/commit/f47778455d28285341d0eeceb53ae7cd95d07d36.diff LOG:

[clang] Add support for builtin_verbose_trap (PR #79230)

2024-06-20 Thread Konstantin Varlamov via cfe-commits
var-const wrote: @dwblaikie @ahatanak Is there anything we can do to move this patch forward? It seems like it's almost ready to go with perhaps one remaining thread of conversation to address. We badly need this functionality in libc++, the lack of error messages when a hardening check is tri

[clang] [Clang] Reuse tail-padding for more types that are not POD for the purpose of layout (PR #90462)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Looks like this is ready to land, if you have reached out to the Fuchsia and XL folks you should be good. https://github.com/llvm/llvm-project/pull/90462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [llvm] Remove mmx 3dnow (PR #96246)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang-driver Author: James Y Knight (jyknight) Changes Remove support for 3DNow!, both intrinsics and builtins. This set of instructions was only supported by AMD chips starting in the K6-2 (introduced 1998), and befor

[clang] [clang] Implement CWG2851: floating-point conversions in converted constant expressions (PR #90387)

2024-06-20 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Is this ready to land? https://github.com/llvm/llvm-project/pull/90387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-06-20 Thread John McCall via cfe-commits
@@ -2012,26 +2015,27 @@ llvm::Value *CodeGenFunction::EmitLoadOfScalar(Address Addr, bool Volatile, } llvm::Value *CodeGenFunction::EmitToMemory(llvm::Value *Value, QualType Ty) { - // Bool has a different representation in memory than in registers. - if (hasBooleanRepresen

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-20 Thread Nico Weber via cfe-commits
nico wrote: Looks Like this might break tests: http://45.33.8.238/linux/141118/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/94717 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-06-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,174 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-06-20 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,174 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-20 Thread Dan McArdle via cfe-commits
https://github.com/dmcardle edited https://github.com/llvm/llvm-project/pull/95290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ThreadSafety] Warn when constructor is trylock (PR #95290)

2024-06-20 Thread Dan McArdle via cfe-commits
https://github.com/dmcardle updated https://github.com/llvm/llvm-project/pull/95290 >From dc8e7b16d5e7318819e61223aa2fc9f483998806 Mon Sep 17 00:00:00 2001 From: Dan McArdle Date: Thu, 20 Jun 2024 17:43:16 -0400 Subject: [PATCH] [clang][ThreadSafety] Check trylock function success and return t

[clang] [clang][ThreadSafety] Warn when constructor is trylock (PR #95290)

2024-06-20 Thread Dan McArdle via cfe-commits
@@ -614,9 +619,23 @@ static bool checkTryLockFunAttrCommon(Sema &S, Decl *D, const ParsedAttr &AL, return false; } - // check that all arguments are lockable objects + // Check that all remaining arguments are lockable objects. checkAttrArgsAreCapabilityObjs(S, D,

[clang] [clang][ThreadSafety] Warn when constructor is trylock (PR #95290)

2024-06-20 Thread Dan McArdle via cfe-commits
@@ -614,9 +619,23 @@ static bool checkTryLockFunAttrCommon(Sema &S, Decl *D, const ParsedAttr &AL, return false; } - // check that all arguments are lockable objects + // Check that all remaining arguments are lockable objects. checkAttrArgsAreCapabilityObjs(S, D,

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer @llvm/pr-subscribers-clang-codegen Author: None (earnol) Changes Without this patch compiler-rt ubsan library has a bug displaying incorrect values for variables of the _BitInt (previously called _ExtInt) type. This patch affects

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-06-20 Thread via cfe-commits
https://github.com/earnol created https://github.com/llvm/llvm-project/pull/96240 Without this patch compiler-rt ubsan library has a bug displaying incorrect values for variables of the _BitInt (previously called _ExtInt) type. This patch affects affects both: generation of metadata inside cod

[clang] [compiler-rt] Revert "[ubsan] Display correct runtime messages for negative _BitInt" (PR #96239)

2024-06-20 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [compiler-rt] Revert "[ubsan] Display correct runtime messages for negative _BitInt" (PR #96239)

2024-06-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer @llvm/pr-subscribers-clang-codegen Author: None (earnol) Changes Reverts llvm/llvm-project#93612 due to the issues with ppc64le platform. --- Full diff: https://github.com/llvm/llvm-project/pull/96239.diff 5 Files Affected: - (m

[clang] [compiler-rt] Revert "[ubsan] Display correct runtime messages for negative _BitInt" (PR #96239)

2024-06-20 Thread via cfe-commits
https://github.com/earnol created https://github.com/llvm/llvm-project/pull/96239 Reverts llvm/llvm-project#93612 due to the issues with ppc64le platform. >From 508bc2e44b59c26955e9b1226f84b4ff2cc05fee Mon Sep 17 00:00:00 2001 From: earnol Date: Thu, 20 Jun 2024 17:39:06 -0400 Subject: [PATCH]

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-06-20 Thread via cfe-commits
earnol wrote: Yes. It is indeed the cause. Already created a code to address the the issue. https://github.com/llvm/llvm-project/pull/93612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: I have lost my upstream commit privileges due to inactivity, so once this is fully approved, could someone merge it on my behalf? Thank you. https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@l

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/95043 >From 2312d31b14aecc6eeea2e81d221ee004e5de3efc Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 6 Jun 2024 14:02:52 -0600 Subject: [PATCH 01/10] [flang] Add basic -mtune support --- clang/includ

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry edited https://github.com/llvm/llvm-project/pull/95043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: I hear you. I modeled this test closely after target-features-*.f90 in that same directory, which is why I put it in flang/test/Lower. I am willing to move it to flang/test/Driver, but if I do so should I also move the target-features-*.f

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
@@ -411,6 +412,13 @@ void Flang::addTargetOptions(const ArgList &Args, } // TODO: Add target specific flags, ABI, mtune option etc. + if (const Arg *A = Args.getLastArg(options::OPT_mtune_EQ)) { +CmdArgs.push_back("-tune-cpu"); +if (strcmp(A->getValue(), "native")

[clang] [flang] [mlir] [flang] Add basic -mtune support (PR #95043)

2024-06-20 Thread Alexis Perry-Holby via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s + +; CHECK-LABEL: llvm.func @tune_cpu() +; CHECK-SAME: tune_cpu = "pentium4" AlexisPerry wrote: >From what I can see, L1685 of ModuleImport.cpp has tune-cpu listed among the

[clang] [Clang][AArch64] Expose compatible SVE intrinsics with only +sme (PR #95787)

2024-06-20 Thread Amara Emerson via cfe-commits
@@ -17,7 +25,7 @@ // CPP-CHECK-NEXT:[[TMP1:%.*]] = shl nuw nsw i64 [[TMP0]], 4 // CPP-CHECK-NEXT:ret i64 [[TMP1]] // -uint64_t test_svcntb() +uint64_t test_svcntb(void) MODE_ATTR aemerson wrote: Why is that restriction there? We often run into confusio

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-06-20 Thread via cfe-commits
@@ -0,0 +1,141 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -verify %s +// RUN: %clang_cc1 -fsyntax-only -fblocks -verify -x c -std=c23 %s + +#if !__has_attribute(nonblocking) +#error "the 'nonblocking' attribute is not available" +#endif + +// --- ATTRIBUTE SYNT

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-06-20 Thread Florian Mayer via cfe-commits
fmayer wrote: Breakage looks related: https://lab.llvm.org/buildbot/#/builders/72/builds/265 ``` FAIL: UBSan-MemorySanitizer-powerpc64le :: TestCases/Integer/bit-int.c (4716 of 4745) TEST 'UBSan-MemorySanitizer-powerpc64le :: TestCases/Integer/bit-int.c' FAILED ***

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-06-20 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,141 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -verify %s +// RUN: %clang_cc1 -fsyntax-only -fblocks -verify -x c -std=c23 %s + +#if !__has_attribute(nonblocking) +#error "the 'nonblocking' attribute is not available" +#endif + +// --- ATTRIBUTE SYNT

[clang] [Clang][Sanitizers] Enable NSAN on Linux only (PR #96120)

2024-06-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/96120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-06-20 Thread Gedare Bloom via cfe-commits
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-06-20 Thread via cfe-commits
github-actions[bot] wrote: @earnol Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-06-20 Thread via cfe-commits
https://github.com/earnol closed https://github.com/llvm/llvm-project/pull/93612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49001d5 - [ubsan] Display correct runtime messages for negative _BitInt (#93612)

2024-06-20 Thread via cfe-commits
Author: earnol Date: 2024-06-20T16:31:32-04:00 New Revision: 49001d584c69726eb7b5069468c5216da3fc3263 URL: https://github.com/llvm/llvm-project/commit/49001d584c69726eb7b5069468c5216da3fc3263 DIFF: https://github.com/llvm/llvm-project/commit/49001d584c69726eb7b5069468c5216da3fc3263.diff LOG: [

[clang] [Clang] skip alignment checks on incomplete types to avoid an assertion failure while parsing lambda used as default argument (PR #94542)

2024-06-20 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @AaronBallman Thank you for your feedback. Do you think this needs to be reviewed by someone else? I can't add reviewers myself :) https://github.com/llvm/llvm-project/pull/94542 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [WebAssembly] Re-enable reference types by default (PR #93261)

2024-06-20 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin closed https://github.com/llvm/llvm-project/pull/93261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >