[clang] Implement diagnostics for why `std::is_standard_layout` is false (PR #144161)

2025-06-13 Thread Samarth Narang via cfe-commits
@@ -2276,6 +2277,134 @@ static void DiagnoseNonTriviallyCopyableReason(Sema &SemaRef, SemaRef.Diag(D->getLocation(), diag::note_defined_here) << D; } +static bool hasMixedAccessSpecifier(const CXXRecordDecl *D) { + AccessSpecifier FirstAccess = AS_none; + for (const Field

[clang] Implement diagnostics for why `std::is_standard_layout` is false (PR #144161)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/144161 >From 10b723750e120420970f864ebda05e0495d4632f Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Fri, 13 Jun 2025 23:22:18 +0200 Subject: [PATCH 1/2] Implement diagnostics for why `std::is_standard_layout`

[clang] [clang] fix infinite recursion (PR #143244)

2025-06-13 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/143244 >From a14625ba505416df42fb785f9205e56b408473b8 Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sat, 7 Jun 2025 16:15:04 +0800 Subject: [PATCH 1/4] add visit check --- clang/lib/Sema/SemaDeclCXX.cpp | 14

[clang-tools-extra] [clang-tidy] add 'IgnoreMarcos' option to 'avoid-goto' check (PR #143554)

2025-06-13 Thread Baranov Victor via cfe-commits
@@ -132,8 +133,41 @@ void jump_out_backwards() { for (int j = 0; j < 10; ++j) { if (i * j > 80) goto before_the_loop; - // CHECK-NOTES: [[@LINE-1]]:9: warning: avoid using 'goto' for flow control - // CHECK-NOTES: [[@LINE-8]]:1: note: label defined

[clang] [clang][Preprocessor] Add peekNextPPToken, makes look ahead next token without side-effects (PR #143898)

2025-06-13 Thread via cfe-commits
yronglin wrote: Do we also need to update `peekNextToken` in Lexer/TokenLexer? > so the return value std::nullopt and tok::eof have two different meanings. We depent std::nullopt to walk up in macro stack in `isNextTokenOneOf`. https://github.com/llvm/llvm-project/pull/143898

[clang-tools-extra] [clang-tidy] add 'IgnoreMarcos' option to 'avoid-goto' check (PR #143554)

2025-06-13 Thread Congcong Cai via cfe-commits
@@ -132,8 +133,41 @@ void jump_out_backwards() { for (int j = 0; j < 10; ++j) { if (i * j > 80) goto before_the_loop; - // CHECK-NOTES: [[@LINE-1]]:9: warning: avoid using 'goto' for flow control - // CHECK-NOTES: [[@LINE-8]]:1: note: label defined

[clang] [clang][Preprocessor] Add peekNextPPToken, makes look ahead next token without side-effects (PR #143898)

2025-06-13 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/143898 >From 373daed324ca99f0b327c424c64a101f7d0f99a3 Mon Sep 17 00:00:00 2001 From: yronglin Date: Thu, 12 Jun 2025 21:46:13 +0800 Subject: [PATCH 1/2] [Clang] Add peekNextPPToken, makes peek next token without side

[clang] [clang][Preprocessor] Add peekNextPPToken, makes look ahead next token without side-effects (PR #143898)

2025-06-13 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/143898 >From 373daed324ca99f0b327c424c64a101f7d0f99a3 Mon Sep 17 00:00:00 2001 From: yronglin Date: Thu, 12 Jun 2025 21:46:13 +0800 Subject: [PATCH 1/2] [Clang] Add peekNextPPToken, makes peek next token without side

[clang] Implement diagnostics for why `std::is_standard_layout` is false (PR #144161)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 edited https://github.com/llvm/llvm-project/pull/144161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

2025-06-13 Thread Samarth Narang via cfe-commits
snarang181 wrote: Closing in favor of https://github.com/llvm/llvm-project/pull/144161 https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 closed https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [REAPPLY][Clang-Repl] Add support for out-of-process execution. #110418 (PR #144064)

2025-06-13 Thread via cfe-commits
https://github.com/SahilPatidar updated https://github.com/llvm/llvm-project/pull/144064 >From 05943c9542cd89ae672ddc0f14514e0c7b1e0bd7 Mon Sep 17 00:00:00 2001 From: SahilPatidar Date: Tue, 3 Dec 2024 15:07:56 +0530 Subject: [PATCH 1/3] Re-Land: [Clang-Repl] Add support for out-of-process exe

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -1590,25 +1590,70 @@ namespace { void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF, tahonermann wrote: This function is only ever called for a deleting destructor (and when `CXXStructorImplicitParamValue` is non-null). I don't think there is a reaso

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -194,9 +217,31 @@ I::~I() { call_in_dtor(); } // CHECK-MSABI32-LABEL: define {{.*}} @"??_GI@@UAEPAXI@Z"( // CHECK-MSABI-NOT: call{{ }} // CHECK-MSABI: load i32 -// CHECK-MSABI: icmp eq i32 {{.*}}, 0 -// CHECK-MSABI: br i1 +// CHECK-MSABI-NEXT: and i32 %[[IMP_PARAM:.*]], 4 +/

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -46,6 +46,16 @@ Potentially Breaking Changes ``endbr64`` instruction at the labels named as possible branch destinations, so it is not safe to use a register-controlled branch instruction to branch to one. (In line with gcc.) +- Scalar deleting destructors emitted by c

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -2886,6 +2887,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
@@ -11139,6 +11139,21 @@ bool Sema::CheckDestructor(CXXDestructorDecl *Destructor) { DiagnoseUseOfDecl(OperatorDelete, Loc); MarkFunctionReferenced(Loc, OperatorDelete); Destructor->setOperatorDelete(OperatorDelete, ThisArg); + + if (isa(OperatorDelete)

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann requested changes to this pull request. Thanks for working on this @Fznamznon! I added some suggestions and comments, most of which are minor. There are two concerns that must be addressed. - The ABI impact suggests this change should be tied to `-fclang-abi-compat

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-13 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/139566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sirui Mu (Lancern) Changes This patch adds `side_effect` attribute to `cir.call` operation. Other function call attributes will be added in later patches. --- Patch is 23.70 KiB, truncated to 20.00 KiB below, full version: https://githu

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-13 Thread Sirui Mu via cfe-commits
https://github.com/Lancern created https://github.com/llvm/llvm-project/pull/144201 This patch adds `side_effect` attribute to `cir.call` operation. Other function call attributes will be added in later patches. >From ccf7371db9793ac980093fb3a43f24a7e9b176e7 Mon Sep 17 00:00:00 2001 From: Siru

[clang] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be a sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be sugar types instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be typedefs instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Make the result type of sizeof/pointer subtraction/size_t literals be typedefs instead of built-in types (PR #143653)

2025-06-13 Thread via cfe-commits
https://github.com/YexuanXiao edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang Dependency Scanning] Enhance File Caching Diagnostics (PR #144105)

2025-06-13 Thread Qiongsi Wu via cfe-commits
@@ -107,31 +107,39 @@ DependencyScanningFilesystemSharedCache::getShardForUID( return CacheShards[Hash % NumShards]; } -std::vector -DependencyScanningFilesystemSharedCache::getInvalidNegativeStatCachedPaths( +std::vector +DependencyScanningFilesystemSharedCache::getInvalidE

[clang-tools-extra] [clang-tidy] Add performance-bool-bitwise-operation check (PR #142324)

2025-06-13 Thread Denis Mikhailov via cfe-commits
denzor200 wrote: ping https://github.com/llvm/llvm-project/pull/142324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][performance-unnecessary-value-param] Avoid in coroutines (PR #140912)

2025-06-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/140912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement diagnostics for why `std::is_standard_layout` is false (PR #144161)

2025-06-13 Thread Yanzuo Liu via cfe-commits
@@ -2276,6 +2277,134 @@ static void DiagnoseNonTriviallyCopyableReason(Sema &SemaRef, SemaRef.Diag(D->getLocation(), diag::note_defined_here) << D; } +static bool hasMixedAccessSpecifier(const CXXRecordDecl *D) { + AccessSpecifier FirstAccess = AS_none; + for (const Field

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/144160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json + +template +concept Addable = requires(T a, T b) { + { a + b }; +}; + +templat

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json --executor=standalone %s ilovepi wrote: Let’s try to mark it fail with filecheck. If that’s doesn’t work, I’m ok with this. https://github.c

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Let, module some minor comments. https://github.com/llvm/llvm-project/pull/144160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/144160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-06-13 Thread Reid Kleckner via cfe-commits
rnk wrote: > Would it make sense to have a custom main for AllClangUnitTests and register > all targets, just like clang driver does? That sounds reasonable. I toyed with the idea of putting the registration into a static initializer, but it raises the question of where you put it. Putting it

[clang-tools-extra] [clang-doc] remove default label on some switches (PR #143919)

2025-06-13 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/143919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 7f69cd5 - [clang-doc] remove default label on some switches (#143919)

2025-06-13 Thread via cfe-commits
Author: Erick Velez Date: 2025-06-13T16:35:30-07:00 New Revision: 7f69cd578de899f8b00525a02d1fe25dab567bcf URL: https://github.com/llvm/llvm-project/commit/7f69cd578de899f8b00525a02d1fe25dab567bcf DIFF: https://github.com/llvm/llvm-project/commit/7f69cd578de899f8b00525a02d1fe25dab567bcf.diff L

[clang-tools-extra] [clang-doc] remove default label on some switches (PR #143919)

2025-06-13 Thread Erick Velez via cfe-commits
evelez7 wrote: ### Merge activity * **Jun 13, 11:33 PM UTC**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/143919). https://github.com/llvm/llvm-project/pull/143919 ___

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/144172 >From f2800e445bc739aa23523bc92ea317b12755cbd1 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 13 Jun 2025 16:21:24 -0700 Subject: [PATCH] [clang][ARM] Include arm_acle.h in intrin.h on supported platfo

[clang] [clang] Check constexpr int->enum conversions consistently. (PR #143034)

2025-06-13 Thread Lei Wang via cfe-commits
wlei-llvm wrote: > Internally, we discovered that this patch breaks Boost as used by MySQL. I > don't have a full external reproducer at the moment and I don't know whether > the code is valid or not, but I wanted to give a heads up that we may need to > revisit this. This seems like the kind

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex edited https://github.com/llvm/llvm-project/pull/144172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks, made https://github.com/llvm/llvm-project/pull/144172, will publish it early next week. https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang][ARM] Include arm_acle.h in intrin.h on supported platforms (PR #144172)

2025-06-13 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/144172 None >From 7c5edb1f1140dc0d51a4b26be2e300a1eb6c5f43 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Fri, 13 Jun 2025 16:21:24 -0700 Subject: [PATCH] [clang][ARM] Include arm_acle.h in intrin.h on supported

[clang] [clang] Check constexpr int->enum conversions consistently. (PR #143034)

2025-06-13 Thread Reid Kleckner via cfe-commits
rnk wrote: Internally, we discovered that this patch breaks Boost as used by MySQL. I don't have a full external reproducer at the moment and I don't know whether the code is valid or not, but I wanted to give a heads up that we may need to revisit this. This seems like the kind of incompatibi

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-13 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/138972 >From a684405f4986e72d78dcfcf6accf4c3ae26b35f1 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Thu, 3 Apr 2025 16:10:50 -0700 Subject: [PATCH 1/3] Windows hotpatching support --- clang/include/clang/Basic/

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-13 Thread Reid Kleckner via cfe-commits
rnk wrote: > To be clear you mean modify Clang's intrin.h to include arm_acle.h when on > supported targets Yep! https://github.com/llvm/llvm-project/pull/140910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread Amr Hesham via cfe-commits
@@ -329,6 +329,222 @@ emitArrayConstant(CIRGenModule &cgm, mlir::Type desiredType, return {}; } +//===--===// +// ConstantLValueEmitter +//===---

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/144165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/144165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SPIRV][AMDGPU] Override `supportsLibCall` for AMDGCNSPIRV (PR #143814)

2025-06-13 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/143814 >From a976da9d6033a252fab75de216fe6580d6e3e6ff Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 12 Jun 2025 00:47:43 +0100 Subject: [PATCH 1/2] Override `SPIRVTargetCodeGenInfo::supportsLibCall()` in order

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread Andy Kaylor via cfe-commits
@@ -329,6 +329,222 @@ emitArrayConstant(CIRGenModule &cgm, mlir::Type desiredType, return {}; } +//===--===// +// ConstantLValueEmitter +//===---

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change introduces a ConstantLValueEmitter class, which will be needed for emitting CIR for non-trivial constant pointers. This change introduces the class with most branch

[clang] [CIR][NFC] Refactor constant pointer l-value handling (PR #144165)

2025-06-13 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/144165 This change introduces a ConstantLValueEmitter class, which will be needed for emitting CIR for non-trivial constant pointers. This change introduces the class with most branches reaching an NYI diagnostic.

[clang] [clang-scan-deps] Implement P2223R2 for DependencyDirectiveScanner.cpp (PR #143950)

2025-06-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `clang` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/30747

[clang] [clang][scan-deps] Add option to disable caching stat failures (PR #144000)

2025-06-13 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > LGTM. I think I would slightly prefer for > `DependencyScanningWorkerFilesystem` to accept the entire service instead of > its members (for the same reasons we do that in the worker, action, etc.) I changed this, although now the tests need a service. I don't think that's a

[clang-tools-extra] [clang-doc] remove default label on some switches (PR #143919)

2025-06-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/143919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] remove default label on some switches (PR #143919)

2025-06-13 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/143919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][scan-deps] Add option to disable caching stat failures (PR #144000)

2025-06-13 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese updated https://github.com/llvm/llvm-project/pull/144000 >From d07ccf298fd3755036ec90e4cd7f1d1408c4506e Mon Sep 17 00:00:00 2001 From: Michael Spencer Date: Thu, 12 Jun 2025 17:13:52 -0700 Subject: [PATCH] [clang][scan-deps] Add option to disable caching stat failu

[clang] [llvm] [RISCV] Remove B and Zbc extension from Andes series cpus. (PR #144022)

2025-06-13 Thread Craig Topper via cfe-commits
topperc wrote: > I think this feature is really tough, the arm/aarch64 backends have got too > much complexity from similar features, mostly because their cpus have all > their optional features enabled by default. > > I think if you can only enable additional extensions, that proposed syntax

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang,llvm` at step 7 "test-build-unified-tree-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/30205 Here is t

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/28377 Here is th

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-13 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/138972 >From a684405f4986e72d78dcfcf6accf4c3ae26b35f1 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Thu, 3 Apr 2025 16:10:50 -0700 Subject: [PATCH 1/2] Windows hotpatching support --- clang/include/clang/Basic/

[clang] [llvm] [HLSL][SPIRV] Use resource names (PR #143412)

2025-06-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/2

[clang] [clang] Fix -fclang-abi-compat for clang 20 (PR #144109)

2025-06-13 Thread Pranav Kant via cfe-commits
https://github.com/pranavk approved this pull request. https://github.com/llvm/llvm-project/pull/144109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Erick Velez via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json --executor=standalone %s evelez7 wrote: FileCheck is omitted here because since nothing is mapped, no file is created. https://github.com/llvm

[clang] [clang-format] Fix a bug in annotating braces (PR #144095)

2025-06-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/144095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][scan-deps] Add option to disable caching stat failures (PR #144000)

2025-06-13 Thread Michael Spencer via cfe-commits
@@ -1081,7 +1084,8 @@ int clang_scan_deps_main(int argc, char **argv, const llvm::ToolContext &) { }; DependencyScanningService Service(ScanMode, Format, OptimizeArgs, -EagerLoadModules, /*TraceVFS=*/Verbose); +

[clang] 8229628 - [Clang] Relax DICompileUnit producer check in debug-info-coff.cpp test (NFC)

2025-06-13 Thread Jacek Caban via cfe-commits
Author: Jacek Caban Date: 2025-06-13T23:29:03+02:00 New Revision: 8229628cf1812e126ff72ee9f4b5f267db4c91da URL: https://github.com/llvm/llvm-project/commit/8229628cf1812e126ff72ee9f4b5f267db4c91da DIFF: https://github.com/llvm/llvm-project/commit/8229628cf1812e126ff72ee9f4b5f267db4c91da.diff L

[clang] Implement diagnostics for why `std::is_standard_layout` is false (PR #144161)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 created https://github.com/llvm/llvm-project/pull/144161 None >From 10b723750e120420970f864ebda05e0495d4632f Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Fri, 13 Jun 2025 23:22:18 +0200 Subject: [PATCH] Implement diagnostics for why `std::is_standard_layout

[clang] [flang] [llvm] Fix and reapply IR PGO support for Flang (PR #142892)

2025-06-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-release` running on `linaro-flang-aarch64-release` while building `clang,flang,llvm` at step 6 "test-build-unified-tree-check-flang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/172/b

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Erick Velez via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --extra-arg -std=c++20 --output=%t --format=json --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json + +template +concept Addable = requires(T a, T b) { + { a + b }; +}; + +templat

[clang] [llvm] [RISCV] Remove B and Zbc extension from Andes series cpus. (PR #144022)

2025-06-13 Thread Sam Elliott via cfe-commits
lenary wrote: I think this feature is really tough, the arm/aarch64 backends have got too much complexity from similar features, mostly because their cpus have all their optional features enabled by default. I think if you can only enable additional extensions, that proposed syntax would prob

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/144160.diff 3 Files Affected: - (added) clang-tools-extra/test/clang-doc/json/class-requires.cpp (+29) - (added) clang-tools-extra/test

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Erick Velez via cfe-commits
evelez7 wrote: * **#144160** https://app.graphite.dev/github/pr/llvm/llvm-project/144160?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1441

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Erick Velez via cfe-commits
https://github.com/evelez7 ready_for_review https://github.com/llvm/llvm-project/pull/144160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Precommit concept tests (PR #144160)

2025-06-13 Thread Erick Velez via cfe-commits
https://github.com/evelez7 created https://github.com/llvm/llvm-project/pull/144160 None >From ad20a26907b065ae6977dab7e0f5c2ef5e0c7ef0 Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Fri, 13 Jun 2025 14:16:17 -0700 Subject: [PATCH] [clang-doc] Precommit concept tests --- .../test/clang-doc

[clang] [clang][CodeGen] Added SanitizerHandler mapping, trap messages in debug info, and corresponding test cases. (PR #143758)

2025-06-13 Thread via cfe-commits
https://github.com/anthonyhatran edited https://github.com/llvm/llvm-project/pull/143758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/143722 >From 6f787e1997f53968e23586b4eb03c45e6559ebbf Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 2 Jun 2025 19:30:39 -0400 Subject: [PATCH 1/2] Add std layout diagnostics Add diagnostic test cases ---

[clang] [clang][CodeGen] Added SanitizerHandler mapping, trap messages in debug info, and corresponding test cases. (PR #143758)

2025-06-13 Thread via cfe-commits
https://github.com/anthonyhatran edited https://github.com/llvm/llvm-project/pull/143758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-13 Thread via cfe-commits
sivadeilra wrote: I've added 2 cases that cover global redirection around phi nodes. And thankfully it exposed one bug, which I've fixed. For the rest of the constants, I think it's time to declare this a starting point PR and not a final endpoint PR. It's not necessary for this to support

[clang] [clang][ARM][AArch64] Reapply "Define intrinsics guarded by __has_builtin on all platforms (#128222)" (PR #140910)

2025-06-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: @rnk To be clear you mean modify Clang's `intrin.h` to include `arm_acle.h` when on supported targets, not the application code including `arm_acle.h` directly right? If so I can make that change. Thanks. https://github.com/llvm/llvm-project/pull/140910 __

[clang] [clang][CodeGen] Added SanitizerHandler mapping, trap messages in debug info, and corresponding test cases. (PR #143758)

2025-06-13 Thread via cfe-commits
@@ -4051,6 +4144,14 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked, llvm::BasicBlock *&TrapBB = TrapBBs[CheckHandlerID]; + llvm::DILocation *TrapLocation = Builder.getCurrentDebugLocation(); + llvm::StringRef Category = GetTrapMessageForHandler(CheckHandlerID

[clang] [CIR] Extend VecShuffleOp verifier to catch invalid index (PR #143262)

2025-06-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/143262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f62a8ab - [CIR] Extend VecShuffleOp verifier to catch invalid index (#143262)

2025-06-13 Thread via cfe-commits
Author: Amr Hesham Date: 2025-06-13T22:51:33+02:00 New Revision: f62a8ab9304fb8b8b3ac3519a7addd7d3d234b04 URL: https://github.com/llvm/llvm-project/commit/f62a8ab9304fb8b8b3ac3519a7addd7d3d234b04 DIFF: https://github.com/llvm/llvm-project/commit/f62a8ab9304fb8b8b3ac3519a7addd7d3d234b04.diff LO

[clang] [llvm] [CodeGen][COFF] Always emit CodeView compiler info on Windows targets (PR #142970)

2025-06-13 Thread Jacek Caban via cfe-commits
cjacek wrote: Merged, thanks! https://github.com/llvm/llvm-project/pull/142970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][COFF] Always emit CodeView compiler info on Windows targets (PR #142970)

2025-06-13 Thread Jacek Caban via cfe-commits
https://github.com/cjacek closed https://github.com/llvm/llvm-project/pull/142970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] be5c96b - [CodeGen][COFF] Always emit CodeView compiler info on Windows targets (#142970)

2025-06-13 Thread via cfe-commits
Author: Jacek Caban Date: 2025-06-13T22:48:29+02:00 New Revision: be5c96bfac328fed548c532bbe1710fe23460a85 URL: https://github.com/llvm/llvm-project/commit/be5c96bfac328fed548c532bbe1710fe23460a85 DIFF: https://github.com/llvm/llvm-project/commit/be5c96bfac328fed548c532bbe1710fe23460a85.diff L

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

2025-06-13 Thread Samarth Narang via cfe-commits
snarang181 wrote: Something broke while resolving merge conflicts. Getting it back to a steady state and will mark it ready for review again. Apologies. https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

2025-06-13 Thread Samarth Narang via cfe-commits
https://github.com/snarang181 converted_to_draft https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-13 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/138972 >From a684405f4986e72d78dcfcf6accf4c3ae26b35f1 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Thu, 3 Apr 2025 16:10:50 -0700 Subject: [PATCH] Windows hotpatching support --- clang/include/clang/Basic/Code

  1   2   3   4   >