[clang] [clang-tools-extra] Remove delayed typo expressions (PR #143423)

2025-06-16 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: https://github.com/llvm/llvm-project/blob/b5dbf8210a57b986b9802304745f4c5c108cf37b/libcxx/test/libcxx/language.support/support.c.headers/support.c.headers.other/math.lerp.verify.cpp#L9 Looks like this has occurred before and is just handled by disabling the test on the lib

[clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Subsumed by 1fd7e4c517141ddfb527e7560e02fd5856244971. https://github.com/llvm/llvm-project/pull/136078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] Test "Revert "[CI] monolithic-linux improvements"" (PR #136078)

2025-04-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/136078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Fix demangler invariant comment assertion (PR #130522)

2025-03-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/130522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Fix demangler invariant comment assertion (PR #130522)

2025-03-09 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/130522 This patch makes the assertion (that is currently in a comment) that validates that names mangled by clang can be demangled by LLVM actually compile/work. There were some minor issues that needed to be f

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-22 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. Changes to `__cpuidex_conflict.c` LGTM. I will put that on my TODO list. https://github.com/llvm/llvm-project/pull/121839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-22 Thread Aiden Grossman via cfe-commits
@@ -1818,8 +1819,21 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { // usual allocation and deallocation functions. Required by libc++ return 201802; default: +// We may get here because of aux builtins which may not be +

[clang] [clang-format] Add --strip-trailing-cr to diff in docs_updated.test (PR #119666)

2024-12-12 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. Is the cleanup just running `black`? Would be better committed separately in my opinion. Either way, LGTM for both the cleanup and the test change. https://github.com/llvm/llvm-project/pull/119666

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-12-05 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Hm, or it's not related to the testcase, but it happens every time we build > now due to > https://github.com/llvm/llvm-project/commit/6bec1806c9cc90f6e72fc04698f4221c86c5f95e That's more likely to be due to #111513. That got reverted. If it's still an issue here, let

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-12-04 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/118154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-12-04 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 ready_for_review https://github.com/llvm/llvm-project/pull/118154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-12-04 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Closing in favor of #111513 / #118154. https://github.com/llvm/llvm-project/pull/113739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-12-04 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/113739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-12-01 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > That and to also ensure that the edited Format.h doesn't break the python > script. Makes sense. #118154 would cover that too. > If we are to leave the generated part of the rst file in the repo, > https://github.com/llvm/llvm-project/pull/111513 would satisfy my > re

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-11-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Whenever I review a pull request that has edited Format.h, I always fetch the > PR and run the python script to ensure that the generated rst file matches > the one in git. I don't think there's a way around that. Thinking about this a bit more, I think we can probably

[clang] [clang-format] Add test to ensure formatting options docs are updated (PR #118154)

2024-11-29 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/118154 This patch adds a lit test to clang format to ensure that the ClangFormatStyleOptions doc page has been updated appropriately. The test just runs the automatic update script and diffs the outputs to ensu

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-11-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > I'd personally like a solution that doesn't remove the > ClangFormatStyleOptions.rst from the review Could we just test that the output looks as expected? I think it would be pretty easy to write a lit test that asserts all of the output is as expected. That would then

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-11-10 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > I'm not concerned about how much time it takes to run. I want to add it to > clangFormat's dependencies if it doesn't run every time I do ninja > FormatTests. I've updated the patch so that we only rerun the python script if the dependencies change. I've added a `.temp

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-31 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > can we have clang-format-style-options rebuilt only when it's outdated, i.e. > only if at least one of the following has been updated? We can, but it requires more changes that I'm not sure are worth doing given that this step takes essentially zero time compared to reg

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-30 Thread Aiden Grossman via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-30 Thread Aiden Grossman via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-25 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: #113739 should fix this problem by just adding the options as part of the build and omitting them from the documentation source. https://github.com/llvm/llvm-project/pull/111513 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 commented: Two minor comments. Script otherwise seems reasonable enough to me. https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > True, however for libc++ the benefits are smaller because we run only libc++ > specific job in the BuildKite job. I've never had trouble with figuring out > what part of a job has caused failures. Either way, like I said I'm fine with > the patch, it seems like an impro

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > I'd rather not do that. Commenting on the PR should be done very rarely, > especially for CI failures, since it clutters the PR and Github already has a > builtin system for presenting CI failures. I think this is something that needs to be discussed further when we act

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][RFC] Refactor the SSE intrinsics constexpr tests to simplify future expansion (PR #112578)

2024-10-19 Thread Aiden Grossman via cfe-commits
@@ -6,13 +6,23 @@ #include +#if defined(__cplusplus) && (__cplusplus >= 201103L) +constexpr bool match_m128(__m128 v, float x, float y, float z, float w) { + return v[0] == x && v[1] == y && v[2] == z && v[3] == w; +} +#define TEST_CONSTEXPR(...) static_assert(__VA_ARGS__)

[clang] [X86][RFC] Refactor the SSE intrinsics constexpr tests to simplify future expansion (PR #112578)

2024-10-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/112578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][RFC] Refactor the SSE intrinsics constexpr tests to simplify future expansion (PR #112578)

2024-10-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. This seems reasonable enough modulo refactoring test macros to a common spot if reasonable. This is certainly a lot cleaner than throwing all the constant expression tests at the end of the file. https://github.com/llvm/llvm-projec

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-19 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Because only part of the doc is generated by dump_format_style.py. It should still be possible to only include the non-generated parts in the repo and then modify the script to add all the generated components on afterwards as a build step? Not sure if I'm missing somet

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-18 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM. Adding this to the default perf training I think makes quite a bit of sense given the numbers reported. Not sure what thoughts others have on that though. https://github.com/llvm/llvm-project/pull/111625 __

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-10 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,2 @@ +RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir -DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang -DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release boomanaiden154 wrote: Ah, makes sense. Seems reasonable enough to me!

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 commented: This looks very interesting! Thanks for taking the time to collect all the numbers. It definitely seems like collecting proper profiles for BOLT is something that we want to do, at least for the CI compiler, given the numbers here. I'm assuming you

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,2 @@ +RUN: %cmake -G %cmake_generator -B %t -S %llvm_src_dir -DCMAKE_C_COMPILER=%clang -DCMAKE_CXX_COMPILER=%clang -DCMAKE_CXX_FLAGS="--driver-mode=g++" -DCMAKE_BUILD_TYPE=Release boomanaiden154 wrote: Why the `--driver-mode=g++` flag here? https://

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
@@ -34,8 +34,12 @@ config.test_format = lit.formats.ShTest(use_lit_shell == "0") config.substitutions.append( ('%clang_cpp_skip_driver', ' %s %s %s ' % (cc1_wrapper, config.clang, sysroot_flags))) config.substitutions.append( ('%clang_cpp', ' %s --driver-mode=g++ %s ' % (confi

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-08 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/111625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > That's an excellent question, maybe @owenca will know! I should have asked in > https://github.com/llvm/llvm-project/pull/96804#discussion_r1718407404; what > I did instead was try to reason out an explanation based on what I could see, > and I came up with two theories

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-08 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 requested changes to this pull request. The documentation build workflow is not really the correct place to put this. Also, why can't we just run the python script as part of building the docs instead of committing the result of the script to the repository? h

[clang] [libcxx] Revert "[libc++][modules] Rewrite the modulemap to have fewer top-level modules (#107638)" (PR #110384)

2024-09-28 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM, assuming precommit CI passes. https://github.com/llvm/llvm-project/pull/110384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: Oh, looks like I missed it. Sorry about that! There's https://github.com/llvm/

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: I posted some patches a while ago to start unifying things so that there's a s

[clang] [compiler-rt] [llvm] [X86] AMD Zen 5 Initial enablement (PR #107964)

2024-09-09 Thread Aiden Grossman via cfe-commits
@@ -1151,6 +1151,25 @@ static const char *getAMDProcessorTypeAndSubtype(unsigned Family, break; // "znver4" } break; // family 19h + case 26: boomanaiden154 wrote: Can you bump the equivalent code in `compiler-rt` too? https://github.com/llvm

[clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > That PR is 3 months old? What are the odds or the timeline of it getting > merged? Probably whenever the author gets back to reviewers. There might be a couple rounds of review before things get pushed through, but patches for two subprojects have landed already. The

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-08-15 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/80713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-11 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/97785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-11 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/97785 >From 38325cbf03e5013056dfc1b7939ec7c9738f9fe2 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 19 Aug 2023 13:37:21 -0700 Subject: [PATCH 1/2] [clang][X86] Add __cpuidex function to cpuid.h MSVC

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-11 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/97785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-05 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Thanks - I think this is fine with me. In > https://github.com/mingw-w64/mingw-w64/commit/a4c0c1d00d140d69a2c72f6ca0d49c91bdb2b08c > we adjusted the mingw-w64 headers in anticipation that this gets merged in > Clang 19, so it'd be good to have it settled before the 19.x

[clang] [clang][X86] Add __cpuidex function to cpuid.h (PR #97785)

2024-07-04 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/97785 MSVC has a __cpuidex function implemented to call the underlying cpuid instruction which accepts a leaf, subleaf, and data array that the output data is written into. This patch adds this functionality in

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: In what configuration are you seeing these errors? I believe most of the issues got resolved by this morning (PST) for the buildbots. https://github.com/llvm/llvm-project/pull/97129 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang-tools-extra] [flang] [llvm] [mlir] [polly] [test]: fix filecheck annotation typos (PR #91854)

2024-05-13 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Were these found manually or using some automated tooling? Based on the Rust PR, it seems like these were found by just manually going through the results from a regex? https://github.com/llvm/llvm-project/pull/91854 ___ cfe-com

[clang] [CMake][Release] Disable PGO (PR #88465)

2024-04-12 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM. I've run into the issue where profile data is generated again where it shouldn't be. I've meant to open up an issue and look into it at some point, but haven't had time to do so. I haven't previously run into this causing rec

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Looks like there was a transient failure in the stage2 build while loading the container image. I've restarted it and everything seems to be going fine. Hopefully that's not an issue going forward. https://github.com/llvm/llvm-project/pull/80713 __

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,13 @@ +diff --git a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +index 1a04ca9a74e5..d092820e4115 100644 +--- a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS + stage2-

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,13 @@ +diff --git a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +index 1a04ca9a74e5..d092820e4115 100644 +--- a/clang/cmake/caches/BOLT-PGO.cmake b/clang/cmake/caches/BOLT-PGO.cmake +@@ -4,6 +4,8 @@ set(CLANG_BOOTSTRAP_TARGETS + stage2-

[llvm] [clang] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/80713 >From bef28f6d909060aeb4993866fad52dbe8a897d20 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 3 Feb 2024 20:46:57 -0800 Subject: [PATCH 1/2] [Github] Use building LLVM as perf-training for CI co

[clang] [llvm] [Github] Use building LLVM as perf-training for CI container (PR #80713)

2024-02-05 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/80713 This patch adjusts the build process for building the toolchain for the CI container to perform more rigorous perf-training for PGO, particularly building the entirety of LLVM as that is what showed the b

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-02-01 Thread Aiden Grossman via cfe-commits
@@ -73,68 +83,89 @@ FileHeader: Sections: - Name:.text.foo Type:SHT_PROGBITS -Address: [[FOO_ADDR]] +Address: 0x4000 Flags: [SHF_ALLOC, SHF_EXECINSTR] -Content: '503b050520907d02ebf5c3' +Content: '503b050530907d08ebf50f8dee1fc3'

[llvm] [clang] [clang-tools-extra] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > It's a single line of code so it probably can stay there for backwards > compatibility :) Sounds good. https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Replace --num-repetitions with --min-

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: @legrosbuffle This is ready for review when you have a chance. Thanks! https://github.com/llvm/llvm-project/pull/77153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/4] [llvm-exegesis] Replace --num-repetitions with --min-

[clang] [clang-tools-extra] [llvm] [llvm-exegesis] Replace --num-repetitions with --min-instructions (PR #77153)

2024-02-01 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77153 >From 1a86a03fdc9d6eee08830ff2f113c39e6096d564 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 5 Jan 2024 14:40:26 -0800 Subject: [PATCH 1/3] [llvm-exegesis] Replace --num-repetitions with --min-

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [compiler-rt] [clang-tools-extra] [flang] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-30 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

2024-01-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > In general, CSSPGO is meant as a more practical alternative for IRPGO thanks > to i) the use of sampled profile, ii) context-sensitivity. However, IRPGO is > still expected to provide better performance in all cases where it's > applicable thanks to accurate profile inf

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

2024-01-29 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Do you have benchmarks on how well this performs relative to standard IRPGO (or on top of it)? https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: @legrosbuffle This should be ready to again when you have a chance to take a look. Thanks! https://github.com/llvm/llvm-project/pull/77020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/6] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/5] [llvm-exegesis] Add middle half repetition mode This

[clang] [libc] [llvm] [clang-tools-extra] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/4] [llvm-exegesis] Add middle half repetition mode This

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -455,6 +466,26 @@ static void runBenchmarkConfigurations( Measurement.PerSnippetValue, NewMeasurement.PerSnippetValue); } } +} else if (RepetitionMode == boomanaiden154 wrote: Moved them to `ResultAggregator.cpp` and added un

[llvm] [clang-tools-extra] [clang] [libc] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/3] [llvm-exegesis] Add middle half repetition mode This

[clang-tools-extra] [libc] [llvm] [clang] [llvm-exegesis] Add middle half repetition mode (PR #77020)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/77020 >From c5bac325802c65f65a8d99e8d82a7e8079c21fb4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Thu, 4 Jan 2024 01:47:49 -0800 Subject: [PATCH 1/2] [llvm-exegesis] Add middle half repetition mode This

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -73,68 +83,89 @@ FileHeader: Sections: - Name:.text.foo Type:SHT_PROGBITS -Address: [[FOO_ADDR]] +Address: 0x4000 Flags: [SHF_ALLOC, SHF_EXECINSTR] -Content: '503b050520907d02ebf5c3' +Content: '503b050530907d08ebf50f8dee1fc3'

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -172,6 +172,105 @@ class OtoolOptTable : public CommonOptTable { "Mach-O object file displaying tool") {} }; +struct BBAddrMapLabel { + std::string BlockLabel; + std::string PGOAnalysis; +}; + +// This class represents the BBAddrMap and PGOMap assoc

[clang] [llvm] [lld] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -172,6 +172,105 @@ class OtoolOptTable : public CommonOptTable { "Mach-O object file displaying tool") {} }; +struct BBAddrMapLabel { + std::string BlockLabel; + std::string PGOAnalysis; +}; + +// This class represents the BBAddrMap and PGOMap assoc

[llvm] [lld] [clang] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
@@ -1693,24 +1750,21 @@ disassembleObject(ObjectFile &Obj, const ObjectFile &DbgObj, LLVM_DEBUG(LVP.dump()); - std::unordered_map AddrToBBAddrMap; - std::unordered_map AddrToPGOAnalysisMap; + BBAddrMapInfo FullAddrMap; auto ReadBBAddrMap = [&](std::optional SectionIn

[clang] [lld] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. Just nits/minor questions from me, code otherwise LGTM. Sorry for the delay in review. I didn't realize you explicitly wanted me to review portions of the code. https://github.com/llvm/llvm-project/pull/74128 ___

[lld] [clang] [llvm] [SHT_LLVM_BB_ADDR_MAP] Allow basic-block-sections and labels be used together by decoupling the handling of the two features. (PR #74128)

2024-01-26 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/74128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [AsmPrinter] Remove mbb-profile-dump flag (PR #76595)

2024-01-23 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [AsmPrinter] Remove mbb-profile-dump flag (PR #76595)

2024-01-23 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/76595 >From 55cf94d98c38cd2b5cd8fbf76e5fd83b5a47f4af Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Fri, 29 Dec 2023 16:14:15 -0800 Subject: [PATCH] [AsmPrinter] Remove mbb-profile-dump flag Now that the w

[clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/78880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [mlir] [libc] [libcxx] [llvm] [lldb] [MLGO] Remove absl dependency from scripts (PR #78880)

2024-01-21 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/78880 >From 80c9507d7f49ddbc5f2554f597950f797355c255 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sun, 21 Jan 2024 03:53:03 + Subject: [PATCH 1/7] Add make_corpus script test --- .../tests/corpus/ma

[clang] [CMake][PGO] Add libunwind to list of stage1 runtimes (PR #78869)

2024-01-21 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: This fixes #78487. https://github.com/llvm/llvm-project/pull/78869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/72319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [libc] [lldb] [compiler-rt] [libcxxabi] [flang] [lld] [libcxx] [clang] [clang-tools-extra] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-19 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-18 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: I believe this is ready to go now. All the tests have been converted to lit-style tests and everything has been wired up into a `check-mlgo-utils` CMake target. I talked with Mircea about the absl dependency. It's not in the tests anymore and the plan is to refactor in a

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,6 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. boomanaiden154 wrote: Looks like all the other Python tests within the monorepo are pretty much lit tests. I'll work on converting these tests to lit tests later tod

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,6 @@ +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. boomanaiden154 wrote: Or what's probably better for structuring is we can do `mlgo/mlgo/corpus` and then the package would be accessed as `mlgo.corpus` while still k

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
@@ -0,0 +1,12 @@ +# MLGO Python Library + +This folder contains the MLGO python library. This library consists of telling boomanaiden154 wrote: Updated it to calling this the folder for MLGO Python Utilities. Good catch on the first line. Not sure exactly what h

[clang] [libclang/python] Bump minimum compatibility to Python 3.6 (PR #77228)

2024-01-17 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/77228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [MLGO] Upstream the corpus extraction tooling (PR #72319)

2024-01-17 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: > Would it be also possible to remove the dependency on > [Abseil](https://github.com/abseil/abseil-py)? None of the existing scripts > in LLVM use it and I don't think we should be introducing this dependency. It > looks like Abseil is only used for flag parsing, logging

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. https://github.com/llvm/llvm-project/pull/69523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [llvm] [clang-tools-extra] [compiler-rt] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-16 Thread Aiden Grossman via cfe-commits
@@ -26,21 +35,26 @@ jobs: prepare: name: Prepare to build binaries runs-on: ubuntu-22.04 -if: github.repository == 'llvm/llvm-project' outputs: - release-version: ${{ steps.validate-tag.outputs.release-version }} - flags: ${{ steps.validate-tag.outp

[clang] [libcxx] [lld] [libc] [compiler-rt] [clang-tools-extra] [llvm] [flang] [lldb] [libcxxabi] [llvm-exegesis] Add support for validation counters (PR #76653)

2024-01-16 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 edited https://github.com/llvm/llvm-project/pull/76653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] workflows: Refactor release-tasks.yml (PR #69523)

2024-01-15 Thread Aiden Grossman via cfe-commits
@@ -10,112 +10,70 @@ on: - 'llvmorg-*' jobs: - release-tasks: -permissions: - contents: write # To upload assets to release. + validate-tag: +name: Validate Tag runs-on: ubuntu-latest if: github.repository == 'llvm/llvm-project' +outputs: +

  1   2   >