boomanaiden154 wrote: > Whenever I review a pull request that has edited Format.h, I always fetch the > PR and run the python script to ensure that the generated rst file matches > the one in git. I don't think there's a way around that.
Thinking about this a bit more, I think we can probably satisfy all the constraints if we write a lit test that ensures the in-tree `ClangFormatStyleOptions.rst` matches what the script will produce (https://github.com/llvm/llvm-project/pull/118154)? That solves the original problem that #111513 set out to solve (if I remember correctly) and will show up as a failure in CI if not done. That doesn't get rid of the generated code being in the repo, but it seems like that is an essential part of some review workflows currently. I'm also planning on making the documentation build action upload the built docs as artifacts, which would also let reviewers just download the built HTML files and inspect those if that's easier/useful. https://github.com/llvm/llvm-project/pull/113739 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
