[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 tra wrote: > bader wrote: > > @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? > Done in d028188412fa54774

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147097/new/ https://reviews.llvm.org/D147097

[PATCH] D147097: [SYCL] Always set NoUnwind attribute for SYCL.

bader added a comment. @hvdijk, thanks a lot for fixing this. In D147097#4229121 , @hvdijk wrote: > Is the rationale I gave in the description correct, or would it be better for > SYCL device code to unconditionally build without `-fexceptions` and get

[PATCH] D129507: [OffloadPackager] Add option to extract files from images

bader added inline comments. Comment at: clang/test/Driver/offload-packager.c:2-3 +// REQUIRES: x86-registered-target +// REQUIRES: nvptx-registered-target +// REQUIRES: amdgpu-registered-target +// UNSUPPORTED: system-windows Are nvptx and amdgpu target required

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits mailing list cfe-co

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

bader added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float nounde

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

bader added a comment. "[SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets." -> "[SPIR] Add support for __arithmetic_fence builtin for SPIR target." Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:16 +// Test with fast math on spir target +// RUN: %

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to validate function attributes other than `convergent`? It's not obvious that presence of `nounwind` attribute is valida

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. I expect this to be a common issue for all single-source offloading programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP offload). Probably we can generalize the code patt

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

bader added inline comments. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:40 +static llvm::Type *getSPIRVType(llvm::LLVMContext &Ctx, StringRef BaseType, +StringRef OpenCLName, StringRef ReadSuffix) { + SmallVector IntParams = {0, 0, 0, 0, 0,

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

bader added a comment. @jcranmer-intel, thanks a lot for working on this. I'm so excited to see these changes! Overall, it looks good to me, but I'd like to avoid some runtime computations if possible. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:40 +static llvm::Type *g

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https://reviews.llvm.org/D138284 __

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( arichardson wrote:

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

bader added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1635 + Context.getTargetInfo().getConstantAddressSpace().value_or( + LangAS::Default)); llvm::Constant *GlobalConstStr = Builder.CreateGlobalStringPtr( > This changes the

[PATCH] D137154: Adding nvvm_reflect clang builtin

bader added a comment. Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ 20 different architectures each, so I want my app/library to run on any GPU from these vendors (which is quite reasonable expectation), I'll need to have/distribute ~ 60 different binaries. libde

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66bd6074c133: [Attr][Doc] Fix pragma unroll documentation. (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136160/new/ https://reviews.ll

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

bader updated this revision to Diff 468487. bader added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136160/new/ https://reviews.llvm.org/D136160 Files: clang/include/clang/Basic/AttrDocs.td Index: clang/incl

[PATCH] D136160: [Attr][Doc] Fix pragma unroll documentation.

bader created this revision. bader added a reviewer: aaron.ballman. Herald added a subscriber: ebevhan. Herald added a project: All. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a contradiction in the #pragma unroll behavi

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

bader added inline comments. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to other external Anastasia wrote: > bader wrote: > >

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

bader added a comment. > The way I understand a bitcast instruction in SPIR-V (`OpBitcast` in > https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) > is that it can only apply to pointer types which are distinct from function > types. Note that I believe

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

bader added a comment. In D127579#3585516 , @beanz wrote: > @nikic the most important thing you need to know about SPIR-V is that it is a > virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just > like LLVM IR would. And in additi

[PATCH] D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

This revision was automatically updated to reflect the committed changes. Closed by commit rG87b28f5092f2: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member (authored by psamolysov-intel, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D118935: [SYCL] Disallow explicit casts between mismatching address spaces

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118935/new/ https://reviews.llvm.org/D118935

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, just one suggestion. It would be great to get @aaron.ballman approve too. Comment at: clang/lib/Sema/SemaDecl.cpp:16690 + diag::err_sycl_special_type_missing_

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

bader added inline comments. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to other external @Anastasia, sorry for late feedback.

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10981

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

bader added a comment. In D110622#3174113 , @tra wrote: > The patch looks OK for the time being. That said, I do have concerns that we > may be organically growing something that will be troublesome to deal with > long-term. > > TBH, I still can't quite

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

bader added a comment. In D109818#3169531 , @linjamaki wrote: > The patch is ready to land. @Anastasia, @bader, could you commit this patch > to the LLVM for us? Thanks. Could you rebase on the tip of the main branch, please? I see a couple of conflict

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

bader added a comment. LGTM, with a couple of minor suggestions. Comment at: clang/lib/Sema/SemaSYCL.cpp:68-75 +bool ErrorFound = false; +if (isZeroSizedArray(*this, TypeToCheck)) { + SYCLDiagIfDeviceCode(UsedAt, diag::err_sycl_zero_array_size); + ErrorFound =

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

bader added a comment. Herald added subscribers: carlosgalvezp, asavonic. @tra, ping. @steffenlarsen, does it make sense to add support for recently released 11.5 as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107054/new/ https://reviews.llvm.org/D107054 __

[PATCH] D112404: [SPIR-V] Add translator tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG49682f14bf3f: [SPIR-V] Add translator tool (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://re

[PATCH] D112404: [SPIR-V] Add translator tool

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. This part looks good to me. Just a couple of minor style comments. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation &C,

[PATCH] D111566: [SYCL] Fix function pointer address space

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. @vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue r

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063762 , @tschuett wrote: > Would a codegenSYCL directory help you to separate Sema from code generation? Moving wrapper kernel function generation to CodeGen library make sense to me. > Doesn't this make AST non-represe

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added a comment. In D71016#3063457 , @tschuett wrote: > It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL > kernels the only approach. We need to update the description of the patch to clarify that it applies to other GPU prog

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:45 + /// accessor class. + static bool isSyclAccessorType(const QualType &Ty); + erichkeane wrote: > Isn't there a big rewrite going on downstream of these with > `sycl_special_class`? Why a

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

bader added a comment. In D109144#3042247 , @Anastasia wrote: > 1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we > add `spirv` triple to clang and map it into SPIR taget or do you suggest > something different? What I have i

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

bader added a comment. In D109144#3032865 , @Anastasia wrote: > It would be good to get closure on this asap. > > @bader We had related discussions on the other reviews about the approach in > this patch. If you have any concerns/suggestions can you plea

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling

bader added a comment. LGTM, just one typo in addition to linter reports and I'd like John to take a look. Comment at: clang/docs/LanguageExtensions.rst:2524 mangling scheme at runtime. The mangler marks all the lambdas required to name -the SYCL kernel and emits a stable loc

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10224 +// pointers for HIPSPV. When the language mode is HIP, the SPIRTargetInfo +// maps cuda_device to SPIR-V's CrossWorkGroup address space. +llvm::Type *LTy = CGT.ConvertType(Ty); --

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in keryell wr

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/SPIR.h:146 +// See comment on the SPIRDefIsGenMap table. +bool IsHIPSPV = Opts.HIP && Opts.CUDAIsDevice; // FIXME: SYCL s

[PATCH] D108020: [NFC] Drop idle compiler option from the test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd754b970eddb: [NFC] Drop idle compiler option from the test. (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108020: [NFC] Drop idle compiler option from the test.

bader created this revision. bader added a reviewer: erichkeane. Herald added a subscriber: ebevhan. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108020 Files: cla

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader closed this revision. bader added a comment. Herald added subscribers: ebevhan, arphaman. Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28080/new/ https://reviews.llvm.org/D28080 __

[PATCH] D102261: Introduce SYCL 2020 mode

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Sorry for the delay. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commit

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 345806. bader marked an inline comment as done. bader added a comment. Added documentation to cover conversion rules and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.l

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 344399. bader marked an inline comment as done. bader added a comment. Added explicit cast checks to Sema tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files:

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/address-space-conversions.cpp:74 + GLOB = GLOB_DEVICE; + GLOB_DEVICE = GLOB; // expected-error {{assigning '__global int *' to '__global_device int *' changes address space of

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 344393. bader added a comment. Apply code review suggestions and rebase on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/docs/SYCLSupport.rst cl

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

This revision was automatically updated to reflect the committed changes. Closed by commit rG76f84e772978: [Doc] Fix sphinx warnings about wrong code-block format (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101549/new/ https:/

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader abandoned this revision. bader added a comment. Herald added a subscriber: ldrumm. Committed alternative version - https://reviews.llvm.org/D89909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80932

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

bader added a comment. Thanks! I've uploaded this version to https://reviews.llvm.org/D101549. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 ___ cfe-commits mai

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

bader created this revision. bader added a reviewer: Anastasia. Herald added a subscriber: ebevhan. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101549 Files: clan

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

bader added a comment. In D99488#2725435 , @Anastasia wrote: > If I build docs now I get the following output: > > llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error > in "code-block" directive: > 1 argument(s) required, 0 sup

[PATCH] D99488: [SYCL][Doc] Add design document for SYCL mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb52e69c42681: [SYCL][Doc] Add design document for SYCL mode (authored by bader). Changed prior to commit: https://reviews.llvm.org/D99488?vs=34052

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 340528. bader added a comment. Rebase on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Address

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 340526. bader added a comment. Rebased patch to unblock commit. This patch had a dependency on D99190 , which adds SYCLSupport.rst document. To unblock commit of D99488 , I switched the order o

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. bader marked an inline comment as done. Closed by commit rG7818906ca134: [SYCL] Implement SYCL address space attributes handling (authored by bader). Changed prior to

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 5 inline comments as done. bader added a comment. @Anastasia, I've updated https://reviews.llvm.org/D99488 and refactored `getStringLiteralAddressSpace` to handle non-string constants as well. Please, take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 340011. bader added a comment. Incorporate https://reviews.llvm.org/D89909 review feedback. Allow one way implicit conversion only for now. >From named address space to default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339973. bader marked an inline comment as done. bader added a comment. Generalize getStringLiteralAddressSpace to GetGlobalConstantAddressSpace Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:140 +// space must be compatible with the generic address space +return LangAS::sycl_global; + } Anastasia wrote: > This needs a language guar

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339515. bader marked an inline comment as done. bader added a comment. Added SYCL address spaces mangling for targets without address space map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://rev

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 339484. bader marked 7 inline comments as done. bader added a comment. Applied more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/includ

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9985 + "Address space agnostic languages only"); + LangAS DefaultGlobalAS = getLangASFromTargetAS( + CGM.getContext().getTargetAddressSpace(LangAS::sycl_global)); Anastasia wr

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASString

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 337441. bader marked 5 inline comments as done. bader added a comment. Applied more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader created this revision. Herald added subscribers: Naghasan, ldrumm, dexonsmith, kerbowa, Anastasia, ebevhan, yaxunl, nhaehnle, jvesely, jholewinski. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 337180. bader marked 16 inline comments as done. bader added a comment. Applied more code review suggestions. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 336543. bader marked 32 inline comments as done. bader added a comment. Applied code review suggestions. Rebased on ToT and updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https:

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added a comment. In D99488#2671906 , @Anastasia wrote: > LGTM! Thanks for working on this. The expected sematic seems fairly clear now. Thanks for review! I also fixed external hyperlinks formatting. > We might add a few more details while refining

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 335596. bader marked 7 inline comments as done. bader added a comment. Add ReST marks to hyperlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/S

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader marked 4 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.rst:243 +Similar to other single-source C++-based GPU programming modes like +OpenMP/CUDA/HIP, SYCL uses clang's "default" address space for types with no +explicit address spa

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334927. bader marked 4 inline comments as done. bader added a comment. Address comments from @Anastasia. - Removed controversial clarifications. - Reshuffled text to keep language semantics clarifications closer to each other. Repository: rG LLVM Github Mo

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:51 +virtual calls), generates LLVM IR for the device code only and an "integration +header" which provides information like kernel name, parameters order and data +type for

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader marked an inline comment as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. +

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334689. bader marked 3 inline comments as done. bader added a comment. Applied code review suggestions from @Naghasan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Fil

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added inline comments. Comment at: clang/docs/SYCLSupport.md:123 +traverse all symbols accessible from kernel functions and add them to the +"device part" of the code marking them with the new SYCL device attribute. + Naghasan wrote: > ABataev wrote: > > ba

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334433. bader added a comment. Convert document to ReST format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.rst Index: clang/docs/SYC

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added inline comments. Comment at: clang/docs/SYCLSupport.md:821 +SYCL compiler toolchain. Section 3.8.2 of SYCL 2020 specification defines +[memory model](https://www.khronos.org/registry/SYCL/specs/sycl-2020/html/sycl-2020.html#_sycl_device_memory_model), +section 4.7.7

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 334420. bader marked 24 inline comments as done. bader added a comment. Applied code review suggestions Resolved merge conflicts with D99190 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader added a subscriber: ABataev. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + Naghas

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader marked 8 inline comments as done. bader added a comment. @Anastasia, I've addressed the comments for the address space section in https://reviews.llvm.org/D99488. Let's move discussion there. Comment at: clang/docs/SYCLSupport.md:861 +space for types with no address spac

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader updated this revision to Diff 333853. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99488/new/ https://reviews.llvm.org/D99488 Files: clang/docs/SYCLSupport.md Index: clang/docs/SYCLSup

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

bader added a comment. In D99488#2655326 , @Anastasia wrote: > Thanks. I am guessing you will address relevant review comments from D99190 > in here? Yes. I'm working on it. I wanted to make it in a separate update, so i

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

bader updated this revision to Diff 333780. bader added a comment. Move address space handling section to https://reviews.llvm.org/D99488 to address https://reviews.llvm.org/D89909#2653452. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99190/new/

  1   2   3   4   >