[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cd90fd1a823: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only (authored by alvinhochun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun updated this revision to Diff 520158. alvinhochun added a comment. Apply suggestions: remove TODO, put negative tests in the same file as positive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149579/new/

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun marked an inline comment as not done. alvinhochun added a comment. In D149579#4320765 , @MaskRay wrote: > OK. I think after D149695 (landed), > D149920 , and this patch

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

alvinhochun updated this revision to Diff 519869. alvinhochun edited the summary of this revision. alvinhochun added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and add test cases with `offset` operator, and some TODOs/FIXMEs for comment Repository:

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

This revision was automatically updated to reflect the committed changes. Closed by commit rG81358e9193a9: [clang][MinGW] Add asan DLL lib before other libs and objects (authored by alvinhochun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:2 +// RUN: touch %t.a +// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address -lcomponent %/t.a 2>&1 | FileCheck --check-prefixes=ASAN-ALL,ASAN-I686 -DINPUT=%/t.a %s +// RUN: %clang

[PATCH] D146908: [clang][MinGW] Add asan DLL lib before other libs and objects

alvinhochun updated this revision to Diff 509030. alvinhochun retitled this revision from "[clang][MinGW] Add asan link flags before other libs and objects" to "[clang][MinGW] Add asan DLL lib before other libs and objects". alvinhochun added a comment. Updated per comments. Repository: rG

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sanitizers.c:1 -// RUN: %clang -target i686-windows-gnu %s -### -fsanitize=address 2>&1 | FileCheck --check-prefix=ASAN-I686 %s -// ASAN-I686: "{{.*}}libclang_rt.asan_dynamic-i386.dll.a" -// ASAN-I686:

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun added a comment. In D146908#4226926 , @mstorsjo wrote: > I tested this, and this does fix the repro from the linked issue. Thanks for testing! > I wonder if we do want to move all of these before the app itself, or if it's > enough to just

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun updated this revision to Diff 508751. alvinhochun added a comment. Trying to fix the test... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146908/new/ https://reviews.llvm.org/D146908 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun created this revision. alvinhochun added reviewers: mstorsjo, MaskRay. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As stated in https://github.com/llvm/llvm-project/issues/61685, by

[PATCH] D142346: [docs] Add release notes for news in 16.x done by me, or otherwise relating to MinGW targets

alvinhochun accepted this revision. alvinhochun added a comment. Thanks, LGTM for the parts I touched and also the rest of the stuff (but I didn't proofread carefully). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142346/new/

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun accepted this revision. alvinhochun added a comment. Also lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141206/new/ https://reviews.llvm.org/D141206 ___ cfe-commits mailing list

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added a comment. The idea sounds reasonable. I don't know mingw-w64 toolchains well enough, but I'll try: How does it interact with the following conditions (lines 469-475)? They look like they may be looking for a mingw-w64 sysroot, which may be ignored by the new check. else

[PATCH] D135027: [Clang][MinGW][cygwin] Fix __declspec with -fdeclspec enabled

alvinhochun created this revision. alvinhochun added reviewers: rnk, mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/49958 Repository:

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. The literal dots have not been escaped as `\.`, but the current change works anyway and the chance of false positives here should be very low. I guess this is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. In D133773#3786602 , @mstorsjo wrote: > In D133773#3786484 , @alvinhochun > wrote: > >> Ah sorry about that, I didn't realize the command includes `.exe` on >> Windows. (For the

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. Ah sorry about that, I didn't realize the command includes `.exe` on Windows. (For the record, `ld"` matches both `ld` and `ld.lld`.) Comment at: clang/test/Driver/mingw-cfguard.c:6 // NO_CF-NOT: "-cfguard-no-checks" -// NO_CF-NEXT: ld" +//

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

alvinhochun updated this revision to Diff 458392. alvinhochun added a comment. Fixed `--target=` option for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llvm.org/D132810 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

alvinhochun updated this revision to Diff 457523. alvinhochun added a comment. Applied suggestions. Thanks for the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132810/new/ https://reviews.llvm.org/D132810 Files:

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

alvinhochun created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. alvinhochun published this revision for review. alvinhochun added reviewers: rnk, ajpaverd, mstorsjo, aaron.ballman. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

alvinhochun updated this revision to Diff 455820. alvinhochun added a comment. Applied suggestions and added test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132661/new/ https://reviews.llvm.org/D132661 Files:

[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

alvinhochun created this revision. alvinhochun added reviewers: rnk, ajpaverd, mstorsjo, aaron.ballman. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Control Flow Guard is only supported on

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454798. alvinhochun marked an inline comment as done. alvinhochun added a comment. Rebased and added a release note entry. @mstorsjo would you mind landing this for me? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454559. alvinhochun edited the summary of this revision. alvinhochun added a comment. Applied suggestions from Aaron. Thanks for the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132302/new/

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun updated this revision to Diff 454280. alvinhochun added a comment. Specify x86_64-w64-windows-gnu in tests instead of using %itanium_abi_triple because it doesn't work on Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132302/new/

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

alvinhochun created this revision. Herald added subscribers: pengfei, mstorsjo. Herald added a reviewer: aaron.ballman. Herald added a project: All. alvinhochun added reviewers: ajpaverd, rnk. alvinhochun updated this revision to Diff 454274. alvinhochun edited the summary of this revision.