[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski marked 3 inline comments as done. awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:43 using namespace Fortran::frontend; +using namespace llvm; schweitz wrote: > You'll want to keep in mind that some class names

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski created this revision. awarzynski added reviewers: rovka, clementval, schweitz, Leporacanthicus. Herald added subscribers: Chia-hungDuan, mehdi_amini, dang, rriddle, pengfei, kristof.beyls, mgorny. Herald added a reviewer: sscalpone. Herald added a project: Flang. awarzynski requested

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added a comment. Thank you all for taking a look! I've just realised this: "This revision was not accepted when it landed; it landed in state Needs Review." Just to clarify, I merged this as two reviewers accepted this in comments (with "LGTM"). Also, I believe that I addressed all

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9439e4891c: [flang][driver] Add support for

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410836. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files: clang/include/clang/Driver/Options.td

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4815 -} +} // let Flags = [CC1Option, CC1AsOption, NoDriverOption] + schweitz wrote: > Is this comment something left over from edits? This is intentional (there's already a [[

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski added a comment. Thank you both for taking a look! In D120246#3339284 , @rovka wrote: > Nit: Should we also have a test for print-effective-triple? Added. > I'm not sure that -emit-llvm is necessarily something we'd want flang users > to

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410826. awarzynski added a comment. Add a test for `--print-effective-triple` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files:

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski updated this revision to Diff 410469. awarzynski added a comment. Add TargetOptions.h (that I forgot to add earlier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120246/new/ https://reviews.llvm.org/D120246 Files:

[PATCH] D120246: [flang][driver] Add support for `--target`/`--triple`

awarzynski created this revision. awarzynski added reviewers: rovka, clementval, schweitz, Leporacanthicus. Herald added subscribers: dang, usaxena95, kadircet. Herald added a reviewer: sscalpone. Herald added a project: Flang. awarzynski requested review of this revision. Herald added

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe993b20c049d: [flang][driver] Add support for `-emit-llvm` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. A believe that all of Kiran's comments have been addressed and pre-merge CI is also passing now (that was one of the concerns). Kiran has not accepted this yet, but he will be away for a few weeks. I will merge this as is to unblock further work. I more than happy

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 409401. awarzynski added a comment. Rebase on top of `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407139. awarzynski added a comment. Remove the change from `fir::CodeGenSpecifics::get` (this was uploaded as a seperate patch: https://reviews.llvm.org/D119332) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407130. awarzynski added a comment. Herald added a subscriber: mehdi_amini. Updated `fir::CodeGenSpecifics::get` to see whether the unit tests pass on Windows. If they do, I'll create a seperate patch with this change. Repository: rG LLVM Github

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 407070. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files: clang/include/clang/Driver/Options.td

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c3309d4545: [flang][driver] Add support for `-emit-mlir` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406832. awarzynski added a comment. Disable the LIT test on Windows, simplify how output is dumped in `EmitLLVMAction::ExecuteAction`, remove `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. I believe that Windows failures are due to the missing support here: https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf473825ae8a/flang/lib/Optimizer/CodeGen/Target.cpp#L290. I can disable the LIT test on Windows, but I'm not sure how to do it

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406828. awarzynski added a comment. - Add a test to verify that an `.mlir` file is created - Set the target triple to `native` (as opposed to relying on it being set elsewhere, e.g.

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:419 + + // ... otherwise, print to a file. + auto os{ci.CreateDefaultOutputFile( kiranchandramohan wrote: > awarzynski wrote: > > kiranchandramohan wrote: > > > Nit: Should we

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406428. awarzynski added a comment. Remove the calls to `setTargetTriple` and `setKindMapping`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files:

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406425. awarzynski marked 2 inline comments as done. awarzynski added a comment. Update comments + add an `assert` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto = ci.invocation().semanticsContext().defaultKinds(); rovka wrote: > Nit: Should

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406398. awarzynski added a comment. Remove `auto`, update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:69 + + // Create a LoweringBridge + auto = ci.invocation().semanticsContext().defaultKinds(); kiranchandramohan wrote: > Nit: Can we remove the three autos below? Sure!

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. This has been extracted from `fir-dev`. Original PR: https://github.com/flang-compiler/f18-llvm-project/pull/1113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406380. awarzynski added a comment. Rebase, remove trailing "_" from member variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/ https://reviews.llvm.org/D119012 Files:

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406377. awarzynski added a comment. Removed trailing "_" from member variable names, added a comment, updated CMake dependencies (needed after https://reviews.llvm.org/D118966) @schweitz, thank you for reviewing! If there are no new comments, I'll merge

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:150 +//===--===// +class CodeGenAction : public FrontendAction { + schweitz wrote: > This appears in

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406005. awarzynski added a comment. Add missing CMake dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/ https://reviews.llvm.org/D118985 Files: clang/include/clang/Driver/Options.td

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a project: Flang. awarzynski requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski added a comment. `fir-dev` PR: https://github.com/flang-compiler/f18-llvm-project/pull/1008. I've also incorporated a few small changes from the subsequent PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118985/new/

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, clementval, schweitz. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, dang, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:89 + /// These values are found in the preprocessor options. + void setFortranOpts(); }; clementval wrote: > @awarzynski I was looking at this file recently and I

[PATCH] D116395: [Clang] Emit warning for -x option without effects

awarzynski added inline comments. Comment at: clang/test/Driver/redundant-args.c:2 +// RUN: %clang -target x86_64-apple-darwin10 -Werror -x c -x c -fsyntax-only %s +// RUN: %clang -target x86_64-apple-darwin10 %s -### -x c 2>&1 | FileCheck %s + hans wrote: >

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd9879d6f43: [Clang] Make Clang copy its CMake modules into the build dir (authored by awarzynski). Changed prior to commit:

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski added a comment. @PeteSteinfeld , thank you for testing this change! I want to make sure that people who are just back from their breaks get a chance to take a look, so I'll wait another day or two before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski added a comment. For a bit of context - this came up in a discussion for https://reviews.llvm.org/D116566/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116731/new/ https://reviews.llvm.org/D116731

[PATCH] D116731: [Clang] Make Clang copy its CMake modules into the build dir

awarzynski created this revision. Herald added subscribers: Chia-hungDuan, rriddle, mgorny. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, stephenneuendorffer. Herald added a project: clang. LLVM has a documented mechanism for passing configuration

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. In D106137#2941616 , @DavidSpickett wrote: > This has broken cmake config on the out of tree flang bot: > https://lab.llvm.org/buildbot/#/builders/175/builds/2026 > > (with perhaps the least helpful cmake error I've ever

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf52fc591fa34: [flang][driver] Add support for Frontend Plugins (authored by stuartellis, committed by awarzynski). Repository: rG LLVM Github

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106137/new/ https://reviews.llvm.org/D106137

[PATCH] D105881: [flang][driver] Refactor boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55a961559954: [flang][driver] Refactor boolean options (authored by awarzynski). Changed prior to commit:

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski updated this revision to Diff 364220. awarzynski added a comment. Remove `EmptyKPM`, introduce `OptOutFC1FFlag` and `OptInFC1FFlag` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105881/new/ https://reviews.llvm.org/D105881 Files:

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. In D105881#2919575 , @jansvoboda11 wrote: > The `clang` driver always accepts both the positive and negative options, and > it always only considers the argument that appeared last on the command-line > (using

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a subscriber: rsmith. awarzynski added a comment. In D99353#2919774 , @tstellar wrote: > This is something we could merge, just need a code owner ack. Let me add @rsmith as a reviewer. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. In D99353#2918629 , @protze.joachim wrote: > Any chance that we get this into llvm/13? Given that Release-13 branch has already been created (https://lists.llvm.org/pipermail/llvm-dev/2021-July/151956.html), this is very

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. I think that this is almost ready to be merged. Just a couple more comments. Comment at: flang/examples/CMakeLists.txt:1 # This test is not run by default as it requires input. add_executable(external-hello-world Could you add the

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Thank you for your detailed reply! In D105881#2904699 , @jansvoboda11 wrote: > Sorry, I'm not sure I follow. OK, let me try to clarify. I've tried to split this into threads. (flag == OptionFlag

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski updated this revision to Diff 360100. awarzynski added a comment. Switch from `BoolFOption` to `OptInFFlag`/`OptOutFFlag` I've refactored `OptInFFlag`/`OptOutFFlag` a tiny bit and created specialisations for `clang -cc1` (`OptInCC1FFlag`/`OptOutCC1FFlag`). I have added some comments

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Apologies, it has taken me a bit longer to get back to this. @jansvoboda11 , now I'm realising the key disadvantage of using `OptInFFlag/OptOutFFlag` - it's impossible to express the `opt-in`/`opt-out` semantics in TableGen. In fact, only the contents of `clang -cc1

[PATCH] D106137: [flang][driver] Add support for Frontend Plugins

awarzynski added a comment. @stuartellis , thank you for working on this! I've left a few comments - mostly nits. Comment at: flang/examples/HelloWorld/CMakeLists.txt:1-5 +add_llvm_library( +flangHelloWorldPlugin +MODULE +HelloWorldPlugin.cpp +) I

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts jansvoboda11 wrote: > awarzynski wrote: > > @jansvoboda11 , is this the right approach here? I'd like

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:246 +class EmptyKPM : KeyPathAndMacro<"", "", ""> {} class DiagnosticOpts @jansvoboda11 , is this the right approach here? I'd like use `BoolFOption` in Flang, but we don't

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski created this revision. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For boolean options, e.g. `-fxor-operator/-fno-xor-operator`, we ought to be using TableGen multiclasses. This

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

awarzynski added a comment. I pushed a fix without a review: https://reviews.llvm.org/rGc3ebb53eabb7f851687f66ada88aa16f768d76ce. Please let me know if you prefer such changes to go through a regular review in the future! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

awarzynski added a comment. In D103612#2840886 , @klausler wrote: > This patch may have broken the shared library buildbots. Sorry about that. A fix is on its way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a7bb8494e9c: [flang][driver] Add `-fno-analyzed-objects-for-unparse` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D103612?vs=354294=354474#toc Repository: rG LLVM

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski updated this revision to Diff 354294. awarzynski added a subscriber: PeteSteinfeld. awarzynski added a comment. Rename the new flag as `-fno-analyzed-objects-for-unparse` Based on the discussion, I've renamed the flag to better reflect the intention. Does it make more sense now?

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski added a comment. In D103612#2827468 , @klausler wrote: > Kind suffixes are described in subclause 7.4.3 of Fortran 2018, e.g. R708 on > p. 58. Many thanks for this reference. So when calling `Unparse,` one specifes

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski added a comment. In D103612#2827444 , @klausler wrote: >> The default behaviour is to always decorate unparsed typed expression with >> e.g. their KIND. The new flag can be used to turn this off, so that the >> generated output uses valid

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 353032. awarzynski added a comment. Refine the semantics after some discussion offline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files:

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski added a comment. Apologies, this is my fault. Should be fixed: https://github.com/llvm/llvm-project/commit/46446e398b5202303280d9e18676c07529f1d0b0. I pushed it without a review as it felt rather straightforward and I wanted to make sure that you are unblocked. If for whatever

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 352403. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang/Driver/Options.td

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6be6e31f181: [flang][driver] Add `-fdebug-dump-all` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D104305?vs=352234=352364#toc Repository: rG LLVM Github Monorepo

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski updated this revision to Diff 352234. awarzynski added a comment. Add missing test (forgot to add when making the submission) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305 Files:

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new option will run the semantic checks and then dump the parse tree and

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1da3297d253: [flang][driver] Add support for the -init-only option (authored by stuartellis, committed by awarzynski). Changed prior to commit:

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349881. awarzynski added a comment. Fix build and test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang/Driver/Options.td

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349868. awarzynski added a comment. Rebase on top of main, revert one small change uploaded accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files:

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

This revision was automatically updated to reflect the committed changes. Closed by commit rG20bd2142d465: [flang][driver] Add support for `-module-suffix` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349598. awarzynski added a comment. Rebased on top of D103613 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files:

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

awarzynski updated this revision to Diff 349595. awarzynski added a comment. Minor tweaks (different suffix in test, updated help text) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/ https://reviews.llvm.org/D103613 Files:

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option is required in order to call `flang-new` from the `flang` bash

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new option for the new Flang driver:

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

awarzynski added a comment. Hi @stuartellis , Thank you for preparing this! This looks good to me, but I would appreciate a comment somewhere (e.g. in the commit message) comparing `-init-only` and `-test-io`. Essentially, both options are for testing purposes only. IMHO, we should only

[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

awarzynski added a comment. In D101387#2730043 , @nickdesaulniers wrote: > @FarisRehman when I run `llvm-lit -vv > flang/test/Driver/fixed-line-length.f90` I see: > > UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1) > > This is with

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc256a443a45: [flang][driver] Add support for `-fget-definition` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

awarzynski updated this revision to Diff 337747. awarzynski added a comment. Rebase on top of D100556 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100558/new/ https://reviews.llvm.org/D100558 Files:

[PATCH] D100558: [flang][driver] Add support for `-fget-definition`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds `-fget-definition` to `flang-new`. The semantics

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. I've just send an RFC for this change to cfe-dev: https://lists.llvm.org/pipermail/cfe-dev/2021-April/067981.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 336075. awarzynski added a comment. Refine comments, remove code for aliases (which didn't work anyway) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 Files:

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added a comment. In D99645#2674496 , @kiranchandramohan wrote: > LGTM. > > Might be good to have a test for fdebug-dump-parse-tree-no-sema. Good point, added before merging into main! Thank you for reviewing. Repository: rG LLVM Github

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe81b3401177a: [flang][driver] Add debug options not requiring semantic checks (authored by awarzynski). Changed prior to commit:

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. In D99353#2672503 , @protze.joachim wrote: > In D99353#2669046 , @awarzynski > wrote: > >> Btw, how important are these aliases for you? > > It's just not obvious from `flang --help`

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335820. awarzynski added a comment. Add DocBrief descriptions in Options.td I added the descriptions so that it's documented what the options are intended for and to avoid confusion in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski added a comment. As there have been no new comments and this patch has already been accepted, I decided to merge it without waiting for more reviews. Please leave post-commit comments if I missed anything and I will address them. Thank you all for reviewing! Repository: rG LLVM

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb83a4450c216: [flang][driver] Add support for `-cpp/-nocpp` (authored by awarzynski). Changed prior to commit:

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:127 + + auto {*ci.parsing().parseTree()}; + ashermancinelli wrote: > Is this variable unused? How did it get here? :) Thank you, updated! Repository: rG LLVM Github

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335587. awarzynski added a comment. Remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99645/new/ https://reviews.llvm.org/D99645 Files: clang/include/clang/Driver/Options.td

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: flang/test/Parser/omp-allocate-unparse.f90:1 -! RUN: %f18 -fdebug-no-semantics -funparse -fopenmp %s | FileCheck %s +! RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp %s | FileCheck %s ! Check Unparsing of OpenMP Allocate directive

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski updated this revision to Diff 335566. awarzynski added a comment. Update `f18.cpp` and driver-help.f90 to improve testing - added -fdebug-unparse-no-sema and -fdebug-dump-parse-tree-no-sema in f18.cpp (for compatibility with flang-new) - updated driver-help.f90 with the new options

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added inline comments. Comment at: clang/lib/Driver/Driver.cpp:294-297 +// TODO: This currently doesn't work as information about aliases is +// lost when generating "unknown" options. +if (auto Alias = A->getAlias()) +

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 335275. awarzynski added a comment. Add more reviewers and remove unrelated changes (apologies for the noise!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski updated this revision to Diff 335270. awarzynski added a comment. Herald added subscribers: jansvoboda11, dang. Refine the behaviour when using diag options and add tests - `-Werror` will now elevate the warning generated here to an error. This is consistent with `gcc`. To this end I

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. Hi @protze.joachim , thank you for testing this so thoroughly! In D99353#2656215 , @protze.joachim wrote: > I tested with `-Werror`: > > $ flang -fopenmp test-f77.f -ffree-form -c > $ clang -fopenmp test-f77.o -ffree-form

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you for addressing my comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657

<    1   2   3   4   5   6   7   >