r299543 - clang-format-vsix: Add "Format on Save" feature

2017-04-05 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Wed Apr 5 09:13:45 2017 New Revision: 299543 URL: http://llvm.org/viewvc/llvm-project?rev=299543=rev Log: clang-format-vsix: Add "Format on Save" feature This change adds a feature to the clang-format VS extension that optionally enables the automatic formatting of

r292787 - clang-format: remove tests that assume no config file will be found as this is not always the case

2017-01-23 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Mon Jan 23 07:20:23 2017 New Revision: 292787 URL: http://llvm.org/viewvc/llvm-project?rev=292787=rev Log: clang-format: remove tests that assume no config file will be found as this is not always the case These tests fail for developers who place their build directories

Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via cfe-commits
On Fri, 20 Jan 2017 at 11:26 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: ioeric added a comment. In https://reviews.llvm.org/D28943#651536, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > > > In https://reviews.llvm.org/D28943#651488, @amaiorano

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Antonio Maiorano via cfe-commits
om here > > > > // RUN: clang-format -style="{BasedOnStyle: Google, IndentWidth: 8}" > > %s | > > > > ^ > > > > :61:16: note: possible intended match here > > > >// CHECK10: {{^int\* i;$}} >

Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

2017-01-20 Thread Antonio Maiorano via cfe-commits
You mean you build a modified version of clang-format where Style is initialized to getGoogleStyle()? I had wondered whether adding a -defaultStyle argument might be useful, specifically in the case where you want to pass in yaml that simply tweaks the default style, but I figured it's not much

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-20 Thread Antonio Maiorano via cfe-commits
^ > > > > I suppose it works for you... Any idea what the problem can be? > > > > Regards, > > Mikael > > > On 01/20/2017 02:22 AM, Antonio Maiorano via cfe-commits wrote: > > > Author: amaiorano > > > Date: Thu Jan 19 19:22:42 2017 &g

r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-19 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Jan 19 19:22:42 2017 New Revision: 292562 URL: http://llvm.org/viewvc/llvm-project?rev=292562=rev Log: clang-format: fix fallback style set to "none" not always formatting This fixes clang-format not formatting if fallback-style is explicitly set to "none", and either

[clang-tools-extra] r292175 - Update tools to use new getStyle API

2017-01-16 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Mon Jan 16 18:13:32 2017 New Revision: 292175 URL: http://llvm.org/viewvc/llvm-project?rev=292175=rev Log: Update tools to use new getStyle API Depends on https://reviews.llvm.org/D28081 Differential Revision: https://reviews.llvm.org/D28315 Modified:

r292174 - clang-format: Make GetStyle return Expected instead of FormatStyle

2017-01-16 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Mon Jan 16 18:12:27 2017 New Revision: 292174 URL: http://llvm.org/viewvc/llvm-project?rev=292174=rev Log: clang-format: Make GetStyle return Expected instead of FormatStyle Change the contract of GetStyle so that it returns an error when an error occurs (i.e. when it

r290319 - Make FormatStyle.GetStyleOfFile test work on MSVC

2016-12-21 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Wed Dec 21 23:10:07 2016 New Revision: 290319 URL: http://llvm.org/viewvc/llvm-project?rev=290319=rev Log: Make FormatStyle.GetStyleOfFile test work on MSVC Modify getStyle to use vfs::FileSystem::makeAbsolute just like FS.addFile does, rather than sys::fs::make_absolute.

r289910 - clang-format-vsix: add command to format document

2016-12-15 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Dec 15 19:51:43 2016 New Revision: 289910 URL: http://llvm.org/viewvc/llvm-project?rev=289910=rev Log: clang-format-vsix: add command to format document Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the extension to the Readme. Differential

r289909 - clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

2016-12-15 Thread Antonio Maiorano via cfe-commits
Author: amaiorano Date: Thu Dec 15 19:37:01 2016 New Revision: 289909 URL: http://llvm.org/viewvc/llvm-project?rev=289909=rev Log: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability Presently, the version number of the VSIX matches the LLVM version number.

Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Antonio Maiorano via cfe-commits
thanks for working on this. If you submit the patches via > phabricator (http://llvm.org/docs/Phabricator.html) I'll get to it faster > :) Feel free to directly add me as reviewer, btw (add 'klimek'). > > On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits < > cf

Re: clang-format-vsix: versioning patch and show stderrors patch

2016-12-05 Thread Antonio Maiorano via cfe-commits
ll get to it faster :) Feel free to directly add me as reviewer, btw (add 'klimek'). On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits < cfe-commits@lists.llvm.org> wrote: Hello, I have two patches for clang-format-vsix to offer up for review: 0001-clang-format-vsix-versioning.patch

clang-format-vsix: versioning patch and show stderrors patch

2016-12-02 Thread Antonio Maiorano via cfe-commits
Hello, I have two patches for clang-format-vsix to offer up for review: 0001-clang-format-vsix-versioning.patch clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability Presently, the version number of the VSIX matches the LLVM version number. However, as this

Re: Upgrade and fix clang-format-vs

2016-12-02 Thread Antonio Maiorano via cfe-commits
t; >>>>>> 'nuget.exe > >> >>> >> >> >>>>>> restore ClangFormat.sln' before running msbuild (or > >> >>> >> >> >>>>>> devenv.exe > >> >>> >> >>

Re: Upgrade and fix clang-format-vs

2016-12-02 Thread Antonio Maiorano via cfe-commits
t; >> >> >>>>>> > >>> >> >> >>>>>> devenv "${CMAKE_CURRENT_SOURCE_DIR}/ClangFormat.sln" > /Build > >>> >> >> >>>>>> Release > >>> >> >&g

Re: Upgrade and fix clang-format-vs

2016-12-02 Thread Antonio Maiorano via cfe-commits
>>> you a > >> >> >>>>>> patch of what I've got so far if that helps. > >> >> >>>>>> > >> >> >>>>>> Thanks, > >> >> >>>>>> > >> >> >>>>>> Antonio

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
> >> >> >>>>>> patch of what I've got so far if that helps. > >> >> >>>>>> > >> >> >>>>>> Thanks, > >> >> >>>>>> > >> >> >>

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
; > You may need to install the Visual Studio SDK. Did you do that > >>>>>>>>> > when you > >>>>>>>>> > initially installed VS 2015? > >>>>>>>>> > > >>>>>>>>> > On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
; Options -> > Projects > >> >>>>>>>> and > >> >>>>>>>> Solutions -> Build and Run and choose either Normal, Detailed, > or > >> >>>>>>>> Diagnostic > >> &g

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
>> >> fine > >> >> On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano < > amaior...@gmail.com> > >> >> wrote: > >> >>> > >> >>> Hi, > >> >>> > >> >>> What I meant by upgrade was simply makin

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
t; >>> What I meant by upgrade was simply making it build in VS 2015. > >> >>> However, > >> >>> you bring up a valid point about making sure the extension will > >> >>> continue to > >> >>> work in VS 2012. I will l

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
s via NuGet. I'll take a closer look. >> >>> >> >>> Part of my change, however, seems to imply that the extension (vsix) >> >>> project would not build correctly even in VS 2012. For instance, the >> >>> missing >> >>> Key.snk file. I don't ha

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
>>> Hi, > >> >>> > >> >>> What I meant by upgrade was simply making it build in VS 2015. > >> >>> However, > >> >>> you bring up a valid point about making sure the extension will > >> >>> continue to >

Re: Upgrade and fix clang-format-vs

2016-11-28 Thread Antonio Maiorano via cfe-commits
extension will > >> >>> continue to > >> >>> work in VS 2012. I will look into that. Like those references that > go > >> >>> from > >> >>> 10 to 14 that point out; I wonder if instead I should be able to >

Re: Upgrade and fix clang-format-vs

2016-09-15 Thread Antonio Maiorano via cfe-commits
into that. Like those references that >> go >> >> >>> from >> >> >>> 10 to 14 that point out; I wonder if instead I should be able to >> bring >> >> >>> in >> >> >>> those version 10 assemblies via NuGet. I'll take

Re: Upgrade and fix clang-format-vs

2016-08-19 Thread Antonio Maiorano via cfe-commits
. Thanks, Antonio On Thu, 18 Aug 2016 at 19:38 Hans Wennborg <h...@chromium.org> wrote: > Hi Antonio, > > On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > This patch for clang-format-vs includes the following

Upgrade and fix clang-format-vs

2016-08-17 Thread Antonio Maiorano via cfe-commits
Hello, This patch for clang-format-vs includes the following: - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and upgrading Microsoft.VisualStudio references to v14 versions - Fix build by removing dependency on "Key.snk" file which was never checked in (and not really