belleyb added a comment.
@chh I had a chance to try out your proposed changes. It's not causing us any
trouble. In fact, __gcov_flush() is not even used at all (at least in LLVM
5.0.1).. I can recompile llvm, compiler_rt and clang and re-run all the tests
with __gcov_flush commented out! No
belleyb added inline comments.
Comment at: test/lit.cfg.py:52-57
+if platform.system() in ['Windows']:
+config.substitutions.append(('dos2unix', 'sed -b "s/\r$//"'))
+config.substitutions.append(('unix2dos', 'sed -b "s/\r*$/\r/"'))
+else:
+
belleyb added a comment.
@sylvestre.ledru Thanks for the test!
https://reviews.llvm.org/D38124
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
belleyb added a comment.
Autodesk would also like to see this fix merged into LLVM 5.0.1 and we also
agree about the importance of having a regression tests.
@sylvestre.ledru : Is someone on the Firefox team working on writing a unit
test for this ? Shall we jump-in and try to help ?
