Author: bruno
Date: Tue Jan 10 20:14:51 2017
New Revision: 291644
URL: http://llvm.org/viewvc/llvm-project?rev=291644&view=rev
Log:
[Modules] Support #import when entering files with modules
Textual headers and builtins that are #import'd from different
modules should get re-entered when these mo
ly -mmacosx-version-min=10.11. Any
> thoughts on what's going wrong?
>
> On Mon, Jan 9, 2017 at 11:21 AM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Mon Jan 9 13:21:48 2017
>> New Revision: 291466
>>
>> URL:
Author: bruno
Date: Mon Jan 9 18:51:02 2017
New Revision: 291517
URL: http://llvm.org/viewvc/llvm-project?rev=291517&view=rev
Log:
[Chrono][Darwin] Include header for gettimeofday
Followup on r291466 and include the proper header. This fixes:
https://build.chromium.org/p/chromium.fyi/builders/Cl
Author: bruno
Date: Mon Jan 9 13:21:48 2017
New Revision: 291466
URL: http://llvm.org/viewvc/llvm-project?rev=291466&view=rev
Log:
[Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW
Use CLOCK_UPTIME_RAW in case clock_gettime is available on Darwin.
On Apple platforms only CLOCK_UPTIME_RAW
Author: bruno
Date: Thu Dec 22 01:06:03 2016
New Revision: 290326
URL: http://llvm.org/viewvc/llvm-project?rev=290326&view=rev
Log:
[CrashReproducer] Add support for merging -ivfsoverlay
Merge all VFS mapped files inside -ivfsoverlay inputs into the vfs
overlay provided by the crash reproducer. T
Author: bruno
Date: Mon Dec 19 15:06:06 2016
New Revision: 290134
URL: http://llvm.org/viewvc/llvm-project?rev=290134&view=rev
Log:
[ASTReader] Sort RawComments before merging
`RawComments` are sorted by comparing underlying `SourceLocation`'s. This is
done by comparing `FileID` and `Offset`; whe
Author: bruno
Date: Mon Dec 12 17:22:30 2016
New Revision: 289494
URL: http://llvm.org/viewvc/llvm-project?rev=289494&view=rev
Log:
Revert "[Modules] Make header inclusion order from umbrella dirs deterministic"
Reverts commit r289478.
This broke
http://lab.llvm.org:8011/builders/clang-ppc64be-l
Author: bruno
Date: Mon Dec 12 17:06:58 2016
New Revision: 289487
URL: http://llvm.org/viewvc/llvm-project?rev=289487&view=rev
Log:
Revert "[Headers] Add #include_next for tgmath.h on Darwin"
Reverts r289181: it's currently breaking modules using simd.h in
10.12 SDK.
This reverts commit 6e73e346
Author: bruno
Date: Mon Dec 12 16:41:20 2016
New Revision: 289478
URL: http://llvm.org/viewvc/llvm-project?rev=289478&view=rev
Log:
[Modules] Make header inclusion order from umbrella dirs deterministic
Sort the headers by name before adding the includes in
collectModuleHeaderIncludes. This makes
Author: bruno
Date: Mon Dec 12 13:28:25 2016
New Revision: 289460
URL: http://llvm.org/viewvc/llvm-project?rev=289460&view=rev
Log:
[CrashReproducer] Collect PCH included via -include-pch
Collect the necessary input PCH files.
Do not try to validate the AST before copying it out because if the
c
Author: bruno
Date: Mon Dec 12 13:28:21 2016
New Revision: 289459
URL: http://llvm.org/viewvc/llvm-project?rev=289459&view=rev
Log:
[Frontend] Use vfs for directory iteration while searching PCHs. NFCI
Use the vfs lookup instead of real filesytem and handle the case where
-include-pch is a direct
Author: bruno
Date: Sat Dec 10 22:27:31 2016
New Revision: 289361
URL: http://llvm.org/viewvc/llvm-project?rev=289361&view=rev
Log:
[CrashReproducer] Setup a module collector callback for HeaderInclude
Collect missing include that cannot be fetched otherwise (e.g. when
using headermaps).
rdar://
Author: bruno
Date: Sat Dec 10 22:27:28 2016
New Revision: 289360
URL: http://llvm.org/viewvc/llvm-project?rev=289360&view=rev
Log:
[CrashReproducer] Collect headermap files
Include headermaps (.hmap files) in the .cache directory and
add VFS entries. All headermaps are known after HeaderSearch
s
Author: bruno
Date: Thu Dec 8 21:30:46 2016
New Revision: 289181
URL: http://llvm.org/viewvc/llvm-project?rev=289181&view=rev
Log:
[Headers] Add #include_next for tgmath.h on Darwin
Allow darwin to provide additional definitions and implementation
specifc values for tgmath.h on Apple platforms.
Author: bruno
Date: Thu Dec 8 21:11:48 2016
New Revision: 289176
URL: http://llvm.org/viewvc/llvm-project?rev=289176&view=rev
Log:
[CrashReproducer] Provide a clean dir path for -fmodules-cache-path
The most common workflow with module reproducers involves deleting the
module cache before runnin
Author: bruno
Date: Thu Dec 8 20:22:47 2016
New Revision: 289174
URL: http://llvm.org/viewvc/llvm-project?rev=289174&view=rev
Log:
[CrashReproducer] Rewrite relative include paths
When -fmodules is on, the reproducer invocation currently leave paths
for include-like flags as is. If the path is r
Author: bruno
Date: Wed Dec 7 20:13:56 2016
New Revision: 289018
URL: http://llvm.org/viewvc/llvm-project?rev=289018&view=rev
Log:
[Headers] Enable #include_next on Darwin
Allows darwin targets to provide additional definitions and
implementation specifc values for float.h
rdar://problem/219614
Author: bruno
Date: Wed Dec 7 18:22:06 2016
New Revision: 289005
URL: http://llvm.org/viewvc/llvm-project?rev=289005&view=rev
Log:
[Driver][Darwin] Disable default stack protector levels in freestanding mode.
Currently -fstack-protector is on by default when using -ffreestanding.
Change the defa
Author: bruno
Date: Wed Dec 7 17:20:30 2016
New Revision: 288994
URL: http://llvm.org/viewvc/llvm-project?rev=288994&view=rev
Log:
[Driver] Add tests for default stack protector values on Darwin
Modified:
cfe/trunk/test/Driver/stack-protector.c
Modified: cfe/trunk/test/Driver/stack-protecto
bruno added a comment.
LGTM! Please add this before https://reviews.llvm.org/D26850, which should
contain a testcase on top of this!
Thanks
https://reviews.llvm.org/D25869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:7978
+/// without causing truncation of Scalar.
+
+static bool tryGCCVectorConvertAndSpalt(Sema &S, ExprResult *Scalar,
Remove this empty line.
Comment at: lib/Sema/SemaExpr.cpp:799
Author: bruno
Date: Thu Nov 17 16:45:31 2016
New Revision: 287275
URL: http://llvm.org/viewvc/llvm-project?rev=287275&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Re-introduce r285411.
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preproc
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice! LGTM
https://reviews.llvm.org/D25949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Thu Nov 17 15:41:22 2016
New Revision: 287262
URL: http://llvm.org/viewvc/llvm-project?rev=287262&view=rev
Log:
[CrashReproducer][Darwin] Suggest attaching .crash diagnostic file
In addition to the preprocessed sources file and reproducer script, also
point to the .crash diagn
bruno added a comment.
Ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 76931.
bruno marked an inline comment as done.
bruno added a comment.
Update patch after Vassil's comments!
https://reviews.llvm.org/D26267
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/FrontendActions.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs
bruno marked an inline comment as done.
bruno added a comment.
In https://reviews.llvm.org/D26267#586971, @v.g.vassilev wrote:
> Could you include more context when creating the diff eg. git diff -U, or
> equivalent.
I did, -U9 actually, not sure why you're not getting it...
===
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, manmanren.
After r284797 builins are treated like textual includes. When compiling for
ObjC++, the in-memory header file generated for the modules is composed only of
#import's instead of includes.
bruno added a comment.
The test is failing on windows:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/141
I reverted the patch for now in r285416, can you take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D25153
___
Author: bruno
Date: Fri Oct 28 12:02:10 2016
New Revision: 285416
URL: http://llvm.org/viewvc/llvm-project?rev=285416&view=rev
Log:
Revert "[Preprocessor] Support for '-dI' flag"
This reverts r285411. Tests failing on
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/141
Remove
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285411: [Preprocessor] Support for '-dI' flag (authored by
bruno).
Changed prior to commit:
https://reviews.llvm.org/D25153?vs=75351&id=76210#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25153
Author: bruno
Date: Fri Oct 28 11:32:10 2016
New Revision: 285411
URL: http://llvm.org/viewvc/llvm-project?rev=285411&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preprocessing.
This change ai
Author: bruno
Date: Thu Oct 27 21:37:04 2016
New Revision: 285378
URL: http://llvm.org/viewvc/llvm-project?rev=285378&view=rev
Log:
[Modules] Make test from r285377 darwin specific
Appease buildbots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55876
Modified:
cfe/trunk/test/Mod
Author: bruno
Date: Thu Oct 27 21:30:45 2016
New Revision: 285377
URL: http://llvm.org/viewvc/llvm-project?rev=285377&view=rev
Log:
[Modules] Add testcase for builtins used in umbrella headers
This used to work before r284797 + r285152, which exposed something
interesting; some users include buil
bruno added a comment.
Hi,
Nice, thanks for working on this!
Comment at: lib/Sema/SemaExpr.cpp:8051
+ if (!LHSVecType) {
+assert(RHSVecType && "RHSVecType is not a vector!");
if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : &LHS),
`tryV
bruno added a comment.
This is great!
Comment at: unittests/Driver/ToolChainsTest.cpp:154
+
"BUG_REPORT_URL=\"https://bugs.debian.org/\"\n";));
+ ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem));
+}
Can
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith wrote:
> On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes
> wrote:
>>
>> > Sure, go ahead.
>>
>> I committed in r284797 and r284801 (libcxx). There's one minor issue
>> I've found: the changes for the builtins affecting non submodule local
>> vis
> Sure, go ahead.
I committed in r284797 and r284801 (libcxx). There's one minor issue
I've found: the changes for the builtins affecting non submodule local
visibility broke current users of plain "-fmodules" against our
frameworks in public SDKs, in 10.11 & 10.12. I've attached a patch to
work a
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3942
+ int Version;
+ if (SplitLine.first.trim() != "VERSION")
+continue;
mgorny wrote:
> bruno wrote:
> > You can check `Line.trim() != VERSION` before the `split` as to do not
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3942
+ int Version;
+ if (SplitLine.first.trim() != "VERSION")
+continue;
You can check `Line.trim() != VERSION` before the `split` as to do not try to
split unnecessary lines.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3937
+StringRef Data = File.get()->getBuffer();
+SmallVector Lines;
+Data.split(Lines, "\n");
This file usually has 5-6 lines, can you use 8 instead?
Comment at: lib
Thanks Ben!
On Fri, Oct 21, 2016 at 3:19 AM, Benjamin Kramer via cfe-commits
wrote:
> Author: d0k
> Date: Fri Oct 21 05:19:37 2016
> New Revision: 284815
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284815&view=rev
> Log:
> Remove non-existing file from modulemap.
>
> This picked up a builtin
Author: bruno
Date: Thu Oct 20 22:14:27 2016
New Revision: 284801
URL: http://llvm.org/viewvc/llvm-project?rev=284801&view=rev
Log:
[ModuleMap] Add more module entries to cover some non modular headers
These modules are necessary on Darwin to allow modules with
'no_undeclared_includes' (introduce
Author: bruno
Date: Thu Oct 20 20:49:14 2016
New Revision: 284798
URL: http://llvm.org/viewvc/llvm-project?rev=284798&view=rev
Log:
[Driver][Darwin] Pass -no_deduplicate to ld64
Recent versions of ld64 run a deduplicate pass, which is on by default.
Disable the pass by using -no_deduplicate in ce
Author: bruno
Date: Thu Oct 20 20:41:56 2016
New Revision: 284797
URL: http://llvm.org/viewvc/llvm-project?rev=284797&view=rev
Log:
[Modules] Add 'no_undeclared_includes' module map attribute
The 'no_undeclared_includes' attribute should be used in a module to
tell that only non-modular headers a
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Very nice!
LGTM
https://reviews.llvm.org/D25819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25696
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3903
+if (!Data.split('.').first.getAsInteger(10, MajorVersion)) {
+ switch (MajorVersion) {
+case 5:
clang-format the `switch`: `case`'s should be aligned with it.
bruno added a comment.
Thanks for looking into this. It's a nice FixIt to have.
I don't see any dep cycle; clangFormat depends on clangToolingCore, which also
depends clangRewrite, which means there are going to be 3 new dependencies for
libSema in the end: clangToolingCore, clangRewrite and cl
Hi Richard,
Turns out that the redefinition error was caused because libc++
modulemap lacked a module for its "string.h", and therefore it would
be textually included in more than one module, yielding the error.
With the attached patch for libc++ modulemap (extracted from parts of
a modulemap you
> @Bruno,
>
> Can you try "-fdiagnostics-show-note-include-stack” so we know the other path
> that leads to string.h?
Attached the complete error log (this snippet won't help without full
context anyway)
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
output.log
Description: Binary data
_
bruno accepted this revision.
bruno added a comment.
Ok, thanks! LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a reviewer: bruno.
bruno added a comment.
Can you add a testcase for that?
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Hi,
On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith wrote:
> On Fri, Oct 14, 2016 at 11:44 AM, Bruno Cardoso Lopes
> wrote:
>>
>> Hi Richard,
>>
>> I have a patch on top of your suggested patch from a year ago, that
>> break the cyclic dependency we're seeing, with this (and a few changes
>> to t
bruno added a comment.
> The long answer is that there is a history of problems regarding the
> intrinsic files:
> http://lists.llvm.org/pipermail/cfe-dev/2016-May/048837.html
> http://lists.llvm.org/pipermail/cfe-dev/2016-September/050943.html
> Mainly compatibility issues because MSVC make
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok, great!
LGTM
https://reviews.llvm.org/D24669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM!
https://reviews.llvm.org/D25641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bruno added a comment.
Nice! Thanks
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Looks that somehow the current directory doesn't exit anymore OR it's non empty
but only contains spaces or something like that. Besides the snippet below,
RedirectingFileSystem::lookupPath(llvm::Twine const&) also calls `makeAbsolute`
before `remove_dots`. Can you try to
bruno added a comment.
Krzysztof, do you have a backtrace that you can paste here or point me to the
buidbot stderr log? There's no point in looking for relative paths inside the
VFS, it would be nice if we fix the root cause here.
https://reviews.llvm.org/D25597
___
bruno added a comment.
One possible reason: remove_dots is called upon a path with a leading "..",
which then gets appended in front of another path to form the absolute path.
I'm taking a look right now to try to figure out if there's any code path that
might lead to this.
https://reviews.ll
Hi Richard,
I have a patch on top of your suggested patch from a year ago, that
break the cyclic dependency we're seeing, with this (and a few changes
to the SDK) we can bootstrap clang with submodule local visibility on
darwin. I've attached the patch with a reduced, standalone testcase
that does
Author: bruno
Date: Tue Oct 11 13:38:33 2016
New Revision: 283917
URL: http://llvm.org/viewvc/llvm-project?rev=283917&view=rev
Log:
[Driver] Use -fsyntax-only in test/Driver/show-option-names.c
Make the test less expensive, follow up from r283915.
Modified:
cfe/trunk/test/Driver/show-option-
Author: bruno
Date: Tue Oct 11 13:31:45 2016
New Revision: 283915
URL: http://llvm.org/viewvc/llvm-project?rev=283915&view=rev
Log:
[Driver] Fix test from r283913 to unbreak bots
Followup from r283913 & r283827
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55135
Modified:
cfe/tr
Let's see how it goes: Committed r283913
On Tue, Oct 11, 2016 at 11:13 AM, Bruno Cardoso Lopes
wrote:
> On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin
> wrote:
>> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
>> wrote:
>>> Thanks Renato!
>>
>> So, Daniel Jasper did a trick on r283853 (clang
Author: bruno
Date: Tue Oct 11 13:21:26 2016
New Revision: 283913
URL: http://llvm.org/viewvc/llvm-project?rev=283913&view=rev
Log:
Reapply [Driver][Diagnostics] Make 'show option names' default for driver
warnings
Reapply r283827 by fixing the tests to not be target specific
Currently, driver
On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin wrote:
> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
> wrote:
>> Thanks Renato!
>
> So, Daniel Jasper did a trick on r283853 (clang || true) to make it
> not fail when it returns on error. However, I wasn't able to make it
> return anything but
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > vbyakovlcl wrote:
> > > b
Thanks Renato!
On Tue, Oct 11, 2016 at 3:36 AM, Renato Golin wrote:
> On 11 October 2016 at 10:14, Renato Golin wrote:
>> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot]
>> error: unable to create target: 'No available targets are compatible
>> with this triple.'
>> 1 e
bruno closed this revision.
bruno added a comment.
Committed r283827
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CH
Author: bruno
Date: Mon Oct 10 19:01:22 2016
New Revision: 283827
URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev
Log:
[Driver][Diagnostics] Make 'show option names' default for driver warnings
Currently, driver level warnings do not show option names (e.g. warning:
complain about fo
bruno updated this revision to Diff 74185.
bruno added a comment.
Update after Vedant's review!
https://reviews.llvm.org/D24516
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Driver/show-option-names.c
Index: test/Driver/show-option-names.c
=
bruno added a reviewer: vsk.
bruno added a comment.
Ping!!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > Besides `__ext_vector_typ
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
mgorny wrote:
> bruno wrote:
> > You should kee
bruno added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
mgorny wrote:
> Is there a reason not to allow using the absolute path
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
You should keep
bruno accepted this revision.
bruno added a comment.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306
+ "vector operands do not have the same elements sizes (%0 and %1)">,
+ InGroup>, DefaultError;
def err_ext_vector_component_exceeds_length
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bruno added a reviewer: bruno.
bruno added a comment.
Testcase?
> clang.rst:398
> + Print the library path for the currently used compiler runtime library
> + ("libgcc.a" or "libclang_rt.builtins.*.a" appropriately).
>
You can probably drop the "appropriately"
> Options.td:1865
> + HelpT
bruno added a reviewer: bruno.
bruno added a comment.
Hi Elad,
Is there any reason why you can't explicit model this in your build system by
pre-building the intrinsics and pointing to a module cache path containing the
pcm files? By doing that we don't need to have a specific compile flag.
h
bruno added inline comments.
> eladcohen wrote in module.modulemap:133
> emmintrin.h is already included explicitly in wmmintrin.h & __wmmintrin_aes.h.
>
> If a user includes / there is no problem, since the
> intel submodule has an 'export *' directive and both aes & sse2 will be
> imported.
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Thanks Reid & Akira,
Committed r282968
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri Sep 30 17:19:38 2016
New Revision: 282968
URL: http://llvm.org/viewvc/llvm-project?rev=282968&view=rev
Log:
[Sema] Support lax conversions for compound assignments
Support lax convertions on compound assignment expressions like:
typedef __attribute__((vector_size(8))) d
bruno added a comment.
@rnk, do you have any concerns about this patch?
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a subscriber: bruno.
bruno added a comment.
Hi Daniel,
This is very nice.
In https://reviews.llvm.org/D24861#553606, @danielmarjamaki wrote:
> Compiling 2064 projects resulted in 904 warnings
>
> Here are the results:
> https://drive.google.com/file/d/0BykPmWrCOxt2N04tYl8zVHA3MXc/v
bruno added a subscriber: bruno.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
The mmx case above makes sense to me, but I find conceptually odd that we need
to re-
bruno added a comment.
Ping
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Matthias
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D24820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
ahatanak wrote:
> Sorry I wasn't clear, but I was asking whether you were plan
bruno added a comment.
Maybe add some docs to explain the new flags?
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
MatzeB wrote:
> bruno wrote:
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
Why removing StatsFile here? IIUC, at this point StatsFile is still the
bruno updated this revision to Diff 71870.
bruno added a comment.
Update again (now with the right patch) after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
==
bruno updated this revision to Diff 71869.
bruno marked an inline comment as done.
bruno added a comment.
Update after Akira's comment
https://reviews.llvm.org/D24472
Files:
lib/Sema/SemaExpr.cpp
test/Sema/vector-cast.c
Index: test/Sema/vector-cast.c
===
bruno marked an inline comment as done.
Comment at: lib/Sema/SemaExpr.cpp:8084
@@ +8083,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return LHSType;
+}
ahatanak wrote:
> My understanding is that, when we have a compound
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 545 matches
Mail list logo
