[PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno created this revision. bruno added reviewers: doug.gregor, rsmith. bruno added a subscriber: cfe-commits. If a closing ')' isn't found for a macro instantiation inside a '[', the next token is EOF, this leads to crashes if we try to look ahead of that. This could be triggered whenever

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

bruno added a subscriber: bruno. bruno added a comment. Hi Manman, Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name);

[PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly passed into the driver. OTOH, it works great for cc1 mode since

r269661 - [Modules] Use vfs for (recursive) directory iteration

Author: bruno Date: Mon May 16 11:46:01 2016 New Revision: 269661 URL: http://llvm.org/viewvc/llvm-project?rev=269661=rev Log: [Modules] Use vfs for (recursive) directory iteration Clang performs directory walk while searching headers inside modules by using the ::sys::fs instead of ::vfs. This

[PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. Clang performs directory walk while searching headers inside modules by using the ::sys::fs instead of ::vfs. This prevents any code that uses the VFS (e.g, reproducer scripts) to actually

r269520 - [VFS] Add level() method to vfs::recursive_directory_iterator

Author: bruno Date: Fri May 13 19:00:18 2016 New Revision: 269520 URL: http://llvm.org/viewvc/llvm-project?rev=269520=rev Log: [VFS] Add level() method to vfs::recursive_directory_iterator Unlike sys::fs::recursive_directory_iterator, vfs::recursive_directory_iterator does not implement the

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno closed this revision. bruno added a comment. Thanks Ben! Committed r269502 http://reviews.llvm.org/D20194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269502 - [ModuleMap][CrashReproducer] Collect headers from inner frameworks

Author: bruno Date: Fri May 13 17:21:51 2016 New Revision: 269502 URL: http://llvm.org/viewvc/llvm-project?rev=269502=rev Log: [ModuleMap][CrashReproducer] Collect headers from inner frameworks (1) Collect headers under inner frameworks (frameworks inside other other frameworks). (2) Make sure

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno updated this revision to Diff 57263. bruno added a comment. Updated after Ben's suggestions! http://reviews.llvm.org/D20194 Files: include/clang/Lex/ModuleMap.h lib/Frontend/ModuleDependencyCollector.cpp lib/Lex/ModuleMap.cpp

r269327 - [VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup

Author: bruno Date: Thu May 12 14:13:07 2016 New Revision: 269327 URL: http://llvm.org/viewvc/llvm-project?rev=269327=rev Log: [VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup Reapply r269100 and r269270, reverted due to https://llvm.org/bugs/show_bug.cgi?id=27725.

r269326 - [Unittests] Reverse the order of arguments for correct debug output

Author: bruno Date: Thu May 12 14:13:04 2016 New Revision: 269326 URL: http://llvm.org/viewvc/llvm-project?rev=269326=rev Log: [Unittests] Reverse the order of arguments for correct debug output Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

Re: r269270 - [VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup

On Thu, May 12, 2016 at 12:29 PM Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: bruno >> Date: Wed May 11 22:23:36 2016 >> New Revision: 269270 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=269270=rev >>

r269276 - Revert "[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup"

Author: bruno Date: Wed May 11 23:43:27 2016 New Revision: 269276 URL: http://llvm.org/viewvc/llvm-project?rev=269276=rev Log: Revert "[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup" Reverts r269270, buildbots still failing:

r269270 - [VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup

Author: bruno Date: Wed May 11 22:23:36 2016 New Revision: 269270 URL: http://llvm.org/viewvc/llvm-project?rev=269270=rev Log: [VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup The way we currently build the internal VFS overlay representation leads to inefficient

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

> What are the platform-specifics for crash reproducing? Shouldn't it > basically be saving some files and storing some data for reconstructing? Feature-wise the crash reproducer for modules could "just" work for windows, there should not be anything platform-specific, I never tested it on

[PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. (1) Collect headers under inner frameworks (frameworks inside other other frameworks). (2) Make sure we also collect the right header files inside them. More info on (2): Consider a dummy

r269234 - [VFS][Unittests] Make dir iteration tests depend only on content

Author: bruno Date: Wed May 11 15:58:47 2016 New Revision: 269234 URL: http://llvm.org/viewvc/llvm-project?rev=269234=rev Log: [VFS][Unittests] Make dir iteration tests depend only on content Do not rely on any specific order while comparing the results of directory iteration. Modified:

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

> I'm glad to help, but it makes me uneasy to have somebody working on a > filesystem abstraction that does not have ready access to test and debug > their changes across the major host platforms that LLVM supports (linux, > mac, windows). Is there any way you can get access? I don't think that >

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154 @@ -153,1 +153,3 @@ +def err_drv_cxx_not_supported : Error< + "C++ is not supported for target '%0'">; Are you sure there's no equivalente for this already? I'm

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Hi Sean, > So sorry! It had gone quiet for a few hours and I wanted to avoid leaving it > red any longer. No problem, the priority is to get bot greens! > Does any platform define a guaranteed directory iteration order? I feel like > depending on it in the first place is unwise (or maybe I'm

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

s fairly > high-level. Is there a missing layering or something? > > -- Sean Silva > > On Tue, May 10, 2016 at 11:43 AM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: bruno >> Date: Tue May 10 13:43:00 2016 >>

r269133 - [VFS] One more unittest change to fix win10 buildbot

Author: bruno Date: Tue May 10 17:30:01 2016 New Revision: 269133 URL: http://llvm.org/viewvc/llvm-project?rev=269133=rev Log: [VFS] One more unittest change to fix win10 buildbot http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5110 Follow up from

r269108 - [VFS] Change unittest to try appeasing win10 buildbot

Author: bruno Date: Tue May 10 15:20:55 2016 New Revision: 269108 URL: http://llvm.org/viewvc/llvm-project?rev=269108=rev Log: [VFS] Change unittest to try appeasing win10 buildbot http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5103 Follow up from

r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Author: bruno Date: Tue May 10 13:43:00 2016 New Revision: 269100 URL: http://llvm.org/viewvc/llvm-project?rev=269100=rev Log: [VFS] Reconstruct the VFS overlay tree for more accurate lookup The way we currently build the internal VFS overlay representation leads to inefficient path search and

r268825 - [CrashReproducer] Always use realpath for destination

Author: bruno Date: Fri May 6 18:58:58 2016 New Revision: 268825 URL: http://llvm.org/viewvc/llvm-project?rev=268825=rev Log: [CrashReproducer] Always use realpath for destination When running reproducer scripts we need that original symlinks from the source filesystem are reproduced in the VFS

r268819 - [CrashReproducer] Change module map callback signature. NFC

Author: bruno Date: Fri May 6 18:21:50 2016 New Revision: 268819 URL: http://llvm.org/viewvc/llvm-project?rev=268819=rev Log: [CrashReproducer] Change module map callback signature. NFC Use a StringRef instead of a FileEntry in the moduleMapAddHeader callback to allow more flexibility on what

r268820 - [VFS] Add dump methods to the VFS overlay tree

Author: bruno Date: Fri May 6 18:21:57 2016 New Revision: 268820 URL: http://llvm.org/viewvc/llvm-project?rev=268820=rev Log: [VFS] Add dump methods to the VFS overlay tree Useful when debugging issues within the VFS overlay. Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified:

r268297 - Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as"

Author: bruno Date: Mon May 2 15:20:49 2016 New Revision: 268297 URL: http://llvm.org/viewvc/llvm-project?rev=268297=rev Log: Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as" This reverts commit r264813 / 6484b95d634f53dd929c75265ef3c4decf397584. While using it

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

bruno added a subscriber: bruno. bruno added a reviewer: bruno. bruno added a comment. Hi Andrey, What about the code / tests that check for this flags? http://reviews.llvm.org/D19658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

bruno added a comment. LGTM http://reviews.llvm.org/D18398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno closed this revision. bruno added a comment. Committed r266245 http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266245 - [SemaObjC] Properly handle mix between type arguments and protocols.

Author: bruno Date: Wed Apr 13 15:59:07 2016 New Revision: 266245 URL: http://llvm.org/viewvc/llvm-project?rev=266245=rev Log: [SemaObjC] Properly handle mix between type arguments and protocols. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list when

r266233 - [VFS] Move default values to in-class member initialization. NFC

Author: bruno Date: Wed Apr 13 14:28:16 2016 New Revision: 266233 URL: http://llvm.org/viewvc/llvm-project?rev=266233=rev Log: [VFS] Move default values to in-class member initialization. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified:

r266234 - [CrashReproducer] Setup 'use-external-names' in YAML files.

Author: bruno Date: Wed Apr 13 14:28:21 2016 New Revision: 266234 URL: http://llvm.org/viewvc/llvm-project?rev=266234=rev Log: [CrashReproducer] Setup 'use-external-names' in YAML files. Hide the real paths when rebuilding from VFS by setting up the crash reproducer to use 'use-external-names' =

r266235 - [CrashReproducer] Add test to run the reproducer script + modules

Author: bruno Date: Wed Apr 13 14:28:24 2016 New Revision: 266235 URL: http://llvm.org/viewvc/llvm-project?rev=266235=rev Log: [CrashReproducer] Add test to run the reproducer script + modules Now that we have basic support in place, make sure the reproducer script works with modules for a

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno abandoned this revision. bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno updated this revision to Diff 53470. bruno added a comment. New patch after Manman's review. http://reviews.llvm.org/D18997 Files: include/clang/Sema/Sema.h lib/Parse/ParseObjc.cpp lib/Sema/SemaDeclObjC.cpp test/SemaObjC/parameterized_classes.m Index:

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested path. This is not true when

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno added a comment. Hi Manman, Comment at: lib/Parse/ParseObjc.cpp:1697 @@ -1696,3 +1696,3 @@ // We syntactically matched a type argument, so commit to parsing - // type arguments. + // type arguments. Finding protocol arguments after here is an error.

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno updated this revision to Diff 53363. bruno added a comment. Hi Richard & Ben, Thanks for the review! I've attached a new patch and changed the approach: made findUsableModuleForHeader receive a FileName instead of FileEntry. Answering the questions below: FileManager::getFile returns

[PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: manmanren, dexonsmith, cfe-commits. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list when type args and protocols are mixed in the same list. This happens when

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Ping! http://reviews.llvm.org/D18849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Didn't notice that yield an error, thanks again Sean! On Wed, Apr 6, 2016 at 7:04 PM, Sean Silva <chisophu...@gmail.com> wrote: > > > On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva <chisophu...@gmail.com> wrote: > >> >> >> On Wed, Apr 6, 2016 at 6:10 PM, Br

Re: r265630 - [CrashReproducer] Change std::toupper to ::toupper

Better yet. Committed r265632 Thanks Sean, On Wed, Apr 6, 2016 at 6:11 PM, Sean Silva <chisophu...@gmail.com> wrote: > We also have toUppercase in include/clang/Basic/CharInfo.h > > -- Sean Silva > > On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-co

r265632 - [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h

Author: bruno Date: Wed Apr 6 20:12:18 2016 New Revision: 265632 URL: http://llvm.org/viewvc/llvm-project?rev=265632=rev Log: [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h Use toUppercase instead of ::toupper() Modified:

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Attempt to fix in r265630. On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes <bruno.card...@gmail.com > wrote: > Thanks Hans, taking a look! > > On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg <h...@chromium.org> wrote: > >> On Wed, Apr 6, 2016 at 5:00 PM, Bruno

r265630 - [CrashReproducer] Change std::toupper to ::toupper

Author: bruno Date: Wed Apr 6 20:04:09 2016 New Revision: 265630 URL: http://llvm.org/viewvc/llvm-project?rev=265630=rev Log: [CrashReproducer] Change std::toupper to ::toupper Attempt to fix windows bots Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified:

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Thanks Hans, taking a look! On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg <h...@chromium.org> wrote: > On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: bruno > > Date: Wed Apr 6 19:00:57

[PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno created this revision. bruno added reviewers: rsmith, benlangmuir, klimek. bruno added subscribers: aprantl, dexonsmith, cfe-commits. The reproducer script (generated by the crash reproducer) invokes clang and tries to rebuild modules using the headers in the .cache/vfs directory. Depending

r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Author: bruno Date: Wed Apr 6 19:00:57 2016 New Revision: 265622 URL: http://llvm.org/viewvc/llvm-project?rev=265622=rev Log: [CrashReproducer] Setup 'case-sensitive' in YAML files. The crash reproducer was not setting up case sensitivity in the VFS yaml files, which defaults to true. Make the

r265621 - [CrashReproducer] Move ModuleDependencyCollector method around. NFC

Author: bruno Date: Wed Apr 6 19:00:42 2016 New Revision: 265621 URL: http://llvm.org/viewvc/llvm-project?rev=265621=rev Log: [CrashReproducer] Move ModuleDependencyCollector method around. NFC Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified:

r265343 - [CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when using modules/vfs

Author: bruno Date: Mon Apr 4 15:26:57 2016 New Revision: 265343 URL: http://llvm.org/viewvc/llvm-project?rev=265343=rev Log: [CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when using modules/vfs The reproducer should use -I/-F/-resource-dir in the same way as the

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

bruno added a subscriber: bruno. bruno added a comment. Hi Andrey, Comment at: include/clang/Driver/Options.td:1281 @@ -1280,1 +1280,3 @@ +def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption, CoreOption]>, + HelpText<"Use Intel MCU ABI.">; def malign_functions_EQ

r265162 - [CrashReproducer] Add -fmodule-cache-path to reproducer script

Author: bruno Date: Fri Apr 1 12:39:08 2016 New Revision: 265162 URL: http://llvm.org/viewvc/llvm-project?rev=265162=rev Log: [CrashReproducer] Add -fmodule-cache-path to reproducer script The cc1 invocation in the reproducer script should contain a valid path in -fmodule-cache-path; for that

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Committed r264987! Comment at: lib/Driver/Driver.cpp:2549-2550 @@ +2548,4 @@ + unsigned CurDigit = 0; + unsigned MaxDigits = Digits.size(); + while (CurDigit < MaxDigits) { +unsigned Digit = (unsigned)strtol(Str, , 10); rnk wrote:

r264987 - [DarwinDriver] Increase the number of valid digits for ld64 version string.

Author: bruno Date: Wed Mar 30 21:45:46 2016 New Revision: 264987 URL: http://llvm.org/viewvc/llvm-project?rev=264987=rev Log: [DarwinDriver] Increase the number of valid digits for ld64 version string. Previously only 3 digits were valid. Increase it to 5. Differential Revision:

r264970 - [VFS] Handle empty entries in directory traversal

Author: bruno Date: Wed Mar 30 18:54:00 2016 New Revision: 264970 URL: http://llvm.org/viewvc/llvm-project?rev=264970=rev Log: [VFS] Handle empty entries in directory traversal The VFS YAML files contain empty directory entries to describe that it's returning from a subdirectory before

r264813 - [Driver] Quote clang full version in dwarf producer when invoking cc1as

Author: bruno Date: Tue Mar 29 19:25:57 2016 New Revision: 264813 URL: http://llvm.org/viewvc/llvm-project?rev=264813=rev Log: [Driver] Quote clang full version in dwarf producer when invoking cc1as Convenience to allow easy copy-n-paste from clang -v output when reproducing cc1as comandline.

[PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. The current ModuleDependencyCollector has a AST listener to collect header files present in loaded modules, but this isn't enough to collect all headers needed in the crash reproducer.

r264808 - [CrashReproducer] Cleanup and move functionality around in ModuleDependencyCollector. NFC

Author: bruno Date: Tue Mar 29 18:47:40 2016 New Revision: 264808 URL: http://llvm.org/viewvc/llvm-project?rev=264808=rev Log: [CrashReproducer] Cleanup and move functionality around in ModuleDependencyCollector. NFC - Make ModuleDependencyCollector use the DependencyCollector interface - Move

r264788 - [Sema] Attempt [3] to fix tests for utf-8 invalid format string specifiers

Author: bruno Date: Tue Mar 29 16:30:58 2016 New Revision: 264788 URL: http://llvm.org/viewvc/llvm-project?rev=264788=rev Log: [Sema] Attempt [3] to fix tests for utf-8 invalid format string specifiers Make the tests darwin only. The bots complaining already output UTF-8 invalid specifiers, test

r264765 - [Sema] Attempt to fix tests for utf-8 invalid format string specifiers

Author: bruno Date: Tue Mar 29 13:38:44 2016 New Revision: 264765 URL: http://llvm.org/viewvc/llvm-project?rev=264765=rev Log: [Sema] Attempt to fix tests for utf-8 invalid format string specifiers Followup from r264752. Attempt to appease buildbots:

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno closed this revision. bruno added a comment. Thanks Richard. Applied your last comments and committed in r264752 http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r264752 - [Sema] Handle UTF-8 invalid format string specifiers

Author: bruno Date: Tue Mar 29 12:35:02 2016 New Revision: 264752 URL: http://llvm.org/viewvc/llvm-project?rev=264752=rev Log: [Sema] Handle UTF-8 invalid format string specifiers Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U.

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno updated this revision to Diff 51859. bruno added a comment. Update after Richard's review. - Handle scanf - Properly update `ConversionSpecifier` http://reviews.llvm.org/D18296 Files: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/FormatString.cpp

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. In http://reviews.llvm.org/D18296#384766, @rsmith wrote: > This patch builds a length-1 `ConversionSpecifier` but includes the complete > code point in the length of the overall format specifier, which is > inconsistent. Please either treat the trailing bytes as part of

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno updated this revision to Diff 51828. bruno added a comment. Thanks Reid. The original idea was to have MaxDigits despite the size of the input array (but bounded by its size). But since there are no other users up to this point, your suggestion seems better, updated the patch to reflect

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping :-) http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. Ping! http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping! http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno created this revision. bruno added reviewers: bob.wilson, dexonsmith. bruno added a subscriber: cfe-commits. Previously only 3 digits were valid. Increase it to 5. http://reviews.llvm.org/D18304 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp lib/Driver/Tools.cpp

Re: r263718 - Use a simpler set of mock headers for the vfs+modules crash recovery tests.

Nice! Thanks Benjamin On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Thu Mar 17 11:19:51 2016 > New Revision: 263718 > > URL: http://llvm.org/viewvc/llvm-project?rev=263718=rev > Log: > Use a simpler set of mock headers

r263750 - Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"

Author: bruno Date: Thu Mar 17 16:30:55 2016 New Revision: 263750 URL: http://llvm.org/viewvc/llvm-project?rev=263750=rev Log: Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files" Tests failing on http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102 This reverts commit

[PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is

r263748 - Reapply [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Thu Mar 17 16:11:23 2016 New Revision: 263748 URL: http://llvm.org/viewvc/llvm-project?rev=263748=rev Log: Reapply [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552. The VFS overlay mapping between virtual paths and real paths is done through the

r263691 - [VFS] Remove wrong header include

Author: bruno Date: Wed Mar 16 23:59:52 2016 New Revision: 263691 URL: http://llvm.org/viewvc/llvm-project?rev=263691=rev Log: [VFS] Remove wrong header include Follow up from r263686. Forgot to remove the wrong header file. Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp

r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Author: bruno Date: Wed Mar 16 21:20:43 2016 New Revision: 263686 URL: http://llvm.org/viewvc/llvm-project?rev=263686=rev Log: Reapply [2]: [VFS] Add support for handling path traversals This was applied twice r261551 and 263617 and later reverted because: (1) Windows bot failing on unittests.

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

Thanks! On Wed, Mar 16, 2016 at 5:35 AM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > chapuni added a comment. > > Excuse me, I have reverted it in r263636. > > > > Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65 > @@ +64,3 @@ >

r263617 - Reapply: [VFS] Add support for handling path traversals

Author: bruno Date: Tue Mar 15 23:39:38 2016 New Revision: 263617 URL: http://llvm.org/viewvc/llvm-project?rev=263617=rev Log: Reapply: [VFS] Add support for handling path traversals This is originally r261551, reverted because of windows bots failing on unittests. Change the current behavior to

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

lly fixed in r261556. >>>> >>>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva <chisophu...@gmail.com> wrote: >>>> > This or r261551 seem to be causing a build failure: >>>> > >>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x

r261654 - Revert "[VFS] Add support for handling path traversals"

Author: bruno Date: Tue Feb 23 11:06:50 2016 New Revision: 261654 URL: http://llvm.org/viewvc/llvm-project?rev=261654=rev Log: Revert "[VFS] Add support for handling path traversals" This reverts commit r261551 due to failing tests in windows bots:

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 >>> > >>> > -- Sean SIlva >>> > >>> > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits >>> > <cfe-commits@lists.llvm.org>

r261613 - Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests"

Author: bruno Date: Tue Feb 23 01:06:12 2016 New Revision: 261613 URL: http://llvm.org/viewvc/llvm-project?rev=261613=rev Log: Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call to getVFSFromYAML in unittests" This reverts commit r261552 and r261556 because of failing

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 >> > >> > -- Sean SIlva >> > >> > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits >> > <cfe-commits@lists.llvm.org> wrote: >> >> &g

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

> -- Sean SIlva > > On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: bruno >> Date: Mon Feb 22 12:41:09 2016 >> New Revision: 261552 >> >> URL: http://llvm.org/viewvc/llvm-project

Re: [PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno closed this revision. bruno added a comment. Committed r261552 / r261556 http://reviews.llvm.org/D17457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno closed this revision. bruno added a comment. Committed r261551 http://reviews.llvm.org/D17104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261556 - [VFS] Fix call to getVFSFromYAML in unittests

Author: bruno Date: Mon Feb 22 13:02:27 2016 New Revision: 261556 URL: http://llvm.org/viewvc/llvm-project?rev=261556=rev Log: [VFS] Fix call to getVFSFromYAML in unittests Follow up from r261552 Modified: cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp Modified:

r261552 - [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Mon Feb 22 12:41:09 2016 New Revision: 261552 URL: http://llvm.org/viewvc/llvm-project?rev=261552=rev Log: [VFS] Add 'overlay-relative' field to YAML files The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML

r261551 - [VFS] Add support for handling path traversals

Author: bruno Date: Mon Feb 22 12:41:01 2016 New Revision: 261551 URL: http://llvm.org/viewvc/llvm-project?rev=261551=rev Log: [VFS] Add support for handling path traversals Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory.

[PATCH] D17457: [VFS] Add 'overlay-relative' field to YAML files

bruno created this revision. bruno added reviewers: benlangmuir, bogner. bruno added subscribers: cfe-commits, dexonsmith. The VFS overlay mapping between virtual paths and real paths is done through the 'external-contents' entries in YAML files, which contains hardcoded paths to the real files.

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno updated this revision to Diff 48397. bruno added a comment. Updated the patch, with the following changes: Handle ".", ".." and "./" with trailing slashes while collecting files to be dumped into the vfs overlay directory. Include the support for symlinks into components. Given

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > Your two-path solution seems like it's on the right track but I don't like > that it brings us back to having ".." in the source path. Given the two-path solution, another thing we could do in the first path, is to default to the remove_dots() version for the source,

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > I'm not sure I understand how the 2nd path would cover the realpath case. It > is just an entry for the realpath itself; that doesn't help if the client > looks up "/install-dir/lib/clang/3.8.0" directly (not just from removing dots > from bin/..). What I was

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. > I don't think this is the right approach. If we don't canonicalize the > source path then: > > - looking up the path *without* the .. won't work, which means anything that > looks up a realpath will fail If we canonicalize, then it needs to be done in two places:

[PATCH] D17104: [VFS] Drop path traversal assertion

bruno created this revision. bruno added reviewers: bogner, benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This patch removes the path traversals check/assertion related with the presence of ".." in paths. The rationale is that if source and destination paths in the YAML file

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. In http://reviews.llvm.org/D17104#349141, @benlangmuir wrote: > Please clarify what you mean here: > > > The rationale is that if source and destination paths in the YAML file > > contain ".." this is enough > > > for the file manager to retrieve the right file, meaning

r259910 - [Parser] Perform CachedTokens update dependent on token consumption

Author: bruno Date: Fri Feb 5 13:36:39 2016 New Revision: 259910 URL: http://llvm.org/viewvc/llvm-project?rev=259910=rev Log: [Parser] Perform CachedTokens update dependent on token consumption In the context where we break one tok::greatergreater into two tok::greater in order to correctly

Re: [PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

bruno closed this revision. bruno added a comment. Committed r259910 http://reviews.llvm.org/D16906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

bruno created this revision. bruno added reviewers: rsmith, doug.gregor, akyrtzi. bruno added subscribers: cfe-commits, dexonsmith. In the context where we break one tok::greatergreater into two tok::greater in order to correctly update the cached tokens; update the CachedTokens with two

<    1   2   3   4   5   6   >