https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From a78545315baf3d920f7101f44c6dba05238dbcf7 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Fri, 26 Jan 2024 14:20:48 +
Subject: [PATCH] [clang] - Sema::isSimpleTypeSpecifier return true for
_Bo
carlos4242 wrote:
note: build kite is passing on linux but failing windows tests with an error
like "mt.exe : general error c101008d: Failed to write the updated manifest to
the resource of file "bin\llvm-symbolizer.exe". Operation did not complete
successfully because the file contains a viru
carlos4242 wrote:
> LGTM, but please rebase and resolve conflicts.
done, rebased, tests pass locally
https://github.com/llvm/llvm-project/pull/79037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From a78545315baf3d920f7101f44c6dba05238dbcf7 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Fri, 26 Jan 2024 14:20:48 +
Subject: [PATCH] [clang] - Sema::isSimpleTypeSpecifier return true for
_Bo
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From fdc1e0dbec6821e292ba3da7770dbae22923db20 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Fri, 26 Jan 2024 14:20:48 +
Subject: [PATCH 1/2] [clang] - Sema::isSimpleTypeSpecifier return true
for
carlos4242 wrote:
I think unit testing the bug fix to this function (the copy that is in Sema) is
going to be nearly impossible.
To prove the point, I tried hard coding the wrong return value for many types
just now...
```
switch (Kind) {
case tok::kw_bool:
case tok::kw_short:
case to
https://github.com/carlos4242 edited
https://github.com/llvm/llvm-project/pull/79037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlos4242 ready_for_review
https://github.com/llvm/llvm-project/pull/79037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlos4242 closed
https://github.com/llvm/llvm-project/pull/78903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlos4242 wrote:
closed in favour of https://github.com/llvm/llvm-project/pull/79037
https://github.com/llvm/llvm-project/pull/78903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From fdc1e0dbec6821e292ba3da7770dbae22923db20 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Fri, 26 Jan 2024 14:20:48 +
Subject: [PATCH] [clang] - Sema::isSimpleTypeSpecifier return true for
_Bo
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From 61a06b77e8e6f2b5c5a9a2aa0b7f46260545f5b4 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Mon, 22 Jan 2024 18:52:46 +
Subject: [PATCH 1/2] [clang] - Sema::isSimpleTypeSpecifier return true for
_Bool i
carlos4242 wrote:
@owenca ... is this better for you?
https://github.com/llvm/llvm-project/pull/79037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/79037
>From 61a06b77e8e6f2b5c5a9a2aa0b7f46260545f5b4 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Mon, 22 Jan 2024 18:52:46 +
Subject: [PATCH] [clang] - Sema::isSimpleTypeSpecifier return true for _Bool
in c9
https://github.com/carlos4242 created
https://github.com/llvm/llvm-project/pull/79037
- Sema::isSimpleTypeSpecifier return true for _Bool in c99 (currently returns
false for _Bool, regardless of C dialect). (Fixes #72203)
- move simple type decision code into shared location (IdentifierInfo)
-
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/78903
>From 2622ca430d7edb1c49cda9bbbf6145b60e2e37c4 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 03:50:14 +
Subject: [PATCH] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in
c99
https://github.com/carlos4242 created
https://github.com/llvm/llvm-project/pull/78903
Here's the sort of approach I"m looking at @owenca
>From 95eb591df3727dfefae5336f80e92046bff96f42 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 03:50:14 +
Subject: [PATCH 1/2] [clang] S
https://github.com/carlos4242 closed
https://github.com/llvm/llvm-project/pull/72298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlos4242 wrote:
That makes sense. I think I’ll close this PR for now and work on the apple fork
to get these issues resolved with them. Then I’ll come back once we have
squared off the edges. Cheers Ben.
https://github.com/llvm/llvm-project/pull/72298
carlos4242 wrote:
Sure thing @benshi001 ... I'll create tests. The Swift ABI is documented here:
https://github.com/apple/swift/blob/main/docs/ABI/CallingConvention.rst
I don't think this change will actually change any ABI. All my code uses the
normal avr-gcc ABI you referenced.
I'll work ou
carlos4242 wrote:
Hi @AaronBallman what do you think about this PR? Is it good to merge or is
there something else I can add?
https://github.com/llvm/llvm-project/pull/72204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
carlos4242 wrote:
@benshi001 Have you got any thoughts on this as the AVR maintainer? I've been
using various versions of this patch in my own branches for years. Should we
merge?
I think ultimately it's your call as you're the AVR backend owner?
https://github.com/llvm/llvm-project/pull/7229
carlos4242 wrote:
> This is less about the implementation weeds of LLVM and more about the actual
> details of your calling convention — the decisions about how arguments and
> results are passed that are ultimately downstream of the choices made here.
> Mostly, I'm encouraging you as a platfo
carlos4242 wrote:
The dup in Format seems to have already drifted from the one in Sema so
putting them together might be a significant change, a bit more than I'm
comfortable taking on... I don't want to break or alter behaviour for someone's
formatter just to fix a tiny issue I found in a ba
carlos4242 wrote:
Thanks, that sounds like it's worth looking into and might avoid issues with
AVR.
I'm still nowhere near enough of an LLVM expert to follow all the aspects of
the discussion. Although from our perspective, I've never seen an issue that I
know, using the above patch for the l
carlos4242 wrote:
@efriedma-quic Cool. So it sounds like it's worth parking this for now, until
Kuba's work #71986 is merged?
@rjmccall I'm not 100% sure I understand? The existing code in AVR.cpp handles
the standard AVR ABI, which has a few simple rules based on GCC behaviour. Here
we are
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/72298
>From 333916a07e90955564d03f14e004695802d9f618 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 17:27:37 +
Subject: [PATCH] [AVR] make the AVR ABI Swift compatible
This patch is needed to a
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/72298
>From fe214850572ba740c0027e8f2908cde0bae75517 Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 17:27:37 +
Subject: [PATCH] [AVR] make the AVR ABI Swift compatible
This patch is needed to a
https://github.com/carlos4242 created
https://github.com/llvm/llvm-project/pull/72298
This patch is needed to add support to clang's AVR ABI for the Swift language.
It is a pre-requisite for adding AVR support to the public Swift compiler
itself.
I'm open to any suggestions how I might create
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/72204
>From 26d40ec42af065fdeda6bdf679cc87928c81c97a Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 03:50:14 +
Subject: [PATCH] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in
c99
https://github.com/carlos4242 updated
https://github.com/llvm/llvm-project/pull/72204
>From 26d40ec42af065fdeda6bdf679cc87928c81c97a Mon Sep 17 00:00:00 2001
From: Carl Peto
Date: Tue, 14 Nov 2023 03:50:14 +
Subject: [PATCH 1/2] [clang] Sema::isSimpleTypeSpecifier return true for _Bool
in
https://github.com/carlos4242 created
https://github.com/llvm/llvm-project/pull/72204
Currently returns false for _Bool, regardless of C dialect.
Fixes #72203.
I'm unsure how to add a unit test for this?
I am open to suggestions!
@AaronBallman
>From 26d40ec42af065fdeda6bdf679cc87928c81c97a
32 matches
Mail list logo
