[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG086b65340cca: [OpenMP] atomic compare fail : Parser & AST support (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CH

[PATCH] D156894: [NFC] Update OpenMP Support page for Clang/LLVM 17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59fdd4c0715f: [NFC] Update OpenMP Support page for Clang/LLVM 17 (authored by cchen). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ab62da18d47: [Clang][OpenMP] Support for Code Generation of loop bind clause (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9babe757160: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D125669: Adding support for target in_reduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8322fe200d60: Adding support for target in_reduction (authored by RitanyaB, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D126494: [clang] avoid assert due to device treated long double as double

cchen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4654 + bool IsLongDouble = BType && BType->getKind() == BuiltinType::LongDouble; + bool IsDevice = getLangOpts().HIP || getLangOpts().CUDA || + getLangOpts().OpenMPIsDevice

[PATCH] D126494: [clang] avoid assert due to device treated long double as double

cchen created this revision. Herald added a project: All. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126494 Files: c

[PATCH] D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115901/new/ https://reviews.llvm.org/D115901 ___ cfe

[PATCH] D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault.

cchen added inline comments. Comment at: openmp/libomptarget/test/mapping/declare_mapper_nested_default_mappers_array.cpp:54 + sa[1].f.b == &x[0] ? 1 : 0); + // CHECK: 111 222 777 20.0 1 + Do we really expect `sa[1].f.b` be the same as `&x[0]`? Shou

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. The SystemZ issue is due to the fact that we assumed that `device(cpu)` should be evaluated to true and `device(gpu)` should be evaluated to false in the test so the test should be fixed by specifying the triple. (https://github.com/llvm/llvm-project/commit/3679d2001c87f3

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. In D91944#3009003 , @uweigand wrote: > Looks like this was committed again, breaking the SystemZ build bots once > again: > https://lab.llvm.org/buildbot/#/builders/94/builds/5661 I'm going to fix this issue now. Repository: rG

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. I reapplied the patch since I forgot to add author's name in the commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 ___ cfe-commits mai

[PATCH] D91944: OpenMP 5.0 metadirective

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7d7b98e5263: OpenMP 5.0 metadirective (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2908fc0d3f16: [OpenMP] Use irbuilder as default for masked and master construct (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373312. cchen added a comment. Fix tests and coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } ABataev wrote: > cchen wrote: > > ABataev wrote: > > > 1. Make it private, please >

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } ABataev wrote: > 1. Make it private, please > 2. Var names must start from capital

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373277. cchen added a comment. Fix tests for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Recu

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373139. cchen added a comment. Fix flang issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveA

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373125. cchen added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Rec

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373109. cchen added a comment. Fix ast errors and add some tiny fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/inclu

[PATCH] D109635: [OpenMP] Support construct trait set for Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG976d474bec35: [OpenMP] Support construct trait set for Clang (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372843. cchen added a comment. Add tests and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/li

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:746 +} + } + } jdoerfert wrote: > jdoerfert wrote: > > So, SmalVector has a pop_back_val which we could use to verify the > > properties are the ones we expect. However, we woul

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372584. cchen added a comment. Fix based on suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372531. cchen added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClaus

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372529. cchen added a comment. Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files:

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372347. cchen added a comment. Rebase and fix based on suggestions Haven't ConstructTrait to IRBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/i

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:737 + } + void eraseConstructTrait() { ConstructTraits.clear(); } + cchen wrote: > jdoerfert wrote: > > Modification was made to make it clear what happens but now I think this is > > not n

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added a comment. > One thing I wanted to do though is keep track of the constructs in the > OpenMPIRBuilder instead. So move the > > /// Vector of declare variant construct traits. > SmallVector ConstructTraits; > > into OpenMPIRBuilder and add/delete the things there. It's not a concep

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372038. cchen added a comment. Remove debug info and spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/A

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372034. cchen added a comment. Remove redundant file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Recu

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 372032. cchen added a comment. Herald added a reviewer: sscalpone. [OpenMP 5.0] metadirective This patch supports OpenMP 5.0 metadirective features. It is implemented keeping the OpenMP 5.1 features like dynamic user condition in mind. A new function, getBestW

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/test/OpenMP/declare_variant_construct_codegen_1.c:23 +#define N 100 + +void p_vxv(int *v1, int *v2, int *v3, int n); This test is from sollve test suite: https://github.com/SOLLVE/sollve_vv/blob/master/tests/5.0/dec

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2346 - VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); + // VMI.ConstructTraits.push_back(Selector.Properties.front().Kind); } I'm now removing this line sin

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen created this revision. cchen added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch supports construct trait set selector by using the existed

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. @alokmishra.besu do you mind if I push the patch for solving those assertions with rebase? The patch does not change the logic in your program and I've made sure that the tests could pass in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. I'm guessing the tests were not pass on buildbot but passed on the author's side is due to the assertion was disabled on the author's side. Here is the patch for avoiding all the assertion errors and I'm able to get all the metadirective tests passed (and no regression for

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen updated this revision to Diff 340641. cchen added a comment. This revision is now accepted and ready to land. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100874/new/ https://reviews.llvm.org/D100874 Files: clang/lib/CodeGen/CGStmt

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen added a comment. > what assertion? $ ":" "RUN: at line 1" $ "/mnt/disks/ssd0/agent/llvm-project/build/./bin/clang" "-fopenmp" "-pthread" "-fno-experimental-isel" "-I" "/mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test" "-I" "/mnt/disks/ssd0/agent/llvm-project/build/projects/op

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen added a comment. I mark this patch as "plan changed" since the assert message indicates that something wrong in IRBuilder or Codegen, however, main branch also have the same issue so I think this patch does not trigger the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen planned changes to this revision. cchen added a comment. This change seems to expose bugs in IRBuilder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100874/new/ https://reviews.llvm.org/D100874 __

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 ___ cfe-

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

cchen created this revision. cchen added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1008

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. > Initially we did not have an OMPIRBuilder object unconditionally, now we > have. Let's move over everything that is ready. So master and critical should > be good to go as well I suppose. While using OMPIRBuilder as default, do we want to just remove codegen in Clang o

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693601 , @jdoerfert wrote: > Also, don't forget to mark it as done in > https://clang.llvm.org/docs/OpenMPSupport.html :) I'll mark it as done after combined constructs are also done. Thanks! Repository: rG LLVM Gi

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693600 , @jdoerfert wrote: > Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, > many thanks for providing one!) > We have an OMPIRBuilder always around in clang's codegen, so there is little >

[PATCH] D100514: [OpenMP] Added codegen for masked directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c2125d1d1e: [OpenMP] Added codegen for masked directive (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen updated this revision to Diff 337797. cchen added a comment. Update test and fix code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100514/new/ https://reviews.llvm.org/D100514 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/li

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, hiraditya, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repos

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a43fd27691c: [OpenMP51] Initial support for masked directive and filter clause (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

cchen updated this revision to Diff 336537. cchen added a comment. Fix lit-test failure for dispatch_ast_print and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5/new/ https://reviews.llvm.org/D5 Files: clang/include/clang-c/Index

[PATCH] D99995: [OpenMP51] Initial support for masked directive and filter clause

cchen added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2814 } if (CKind == OMPC_ordered && PP.LookAhead(/*N=*/0).isNot(tok::l_paren)) ABataev wrote: > This can be simplified like this: > ``` > if (!FirstClause) { > Diag(Tok

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcba422264c7f: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334844. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_ast_print.cpp

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334720. cchen added a comment. Update codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_ast

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen added inline comments. Comment at: clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp:110-147 +// Test target codegen - host bc file has to be created first. +// RUN: %clang_cc1 -DCK2 -verify -fopenmp -fopenmp-version=45 -fopenmp-cuda-mode -x c++ -triple powerp

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334482. cchen added a comment. Add some codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/distribut

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Repository: rG

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen accepted this revision. cchen added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen added a comment. I think some existing Clang OpenMP codegen tests will break if they are testing against `__kmpc_push_target_tripcount`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 __

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. @alokmishra.besu, I'm trying to play/learn with your patch so I downloaded the diff and apply it to the master branch, however, I'm getting error messages everywhere if `llvm::omp::OMPD_metadirective` appears: llvm-project/clang/include/clang/AST/StmtOpenMP.h:384:43: er

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen_01.cpp:1523 -// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4096, i64 4, i64 {{.+}}] +// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4, i64 4096, i64 {{.+}}] // Map t

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91261/new/ https://reviews.llvm.org/D91261 ___ cf

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Below test asserts inside `generateInfoForComponentList`: Assertion failed: (!IsPointer && "Unexpected base element with the pointer type."), function generateInfoForComponentList, file /Users/cchen/workspace/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp, line 775

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Just tried this patch and found that below test abort inside `generateInfoCapture`. #include #define LEN 100 int buf[LEN]; int main() { int i; int *p = buf; for (i = 0; i < LEN; i++) { p[i] = 0; } #pragma omp target m

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen updated this revision to Diff 309292. cchen added a comment. Update based on comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def clang/lib/Sema

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } ABataev wrote: > Why need to add an empty `SourceLoc

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added a comment. I now only update `target_defaultmap_messages` test since I'm not sure what I've done is correct for the new version. Will add all other defaultmap_messages tests once corrected the stuff I added in `target_defaultmap_messages`. Repository: rG LLVM Github Monorepo CH

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen updated this revision to Diff 308760. cchen added a comment. Rebase and fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92427/new/ https://reviews.llvm.org/D92427 Files: clang/include/clang/Basic/OpenMPKinds.def clang/lib/

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Support present modifier in defaul

[PATCH] D91998: [OpenMP50][DOCS] Mark target data non-contiguous as done, NFC.

cchen added a comment. I think I'll just land it since it's an nfc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91998/new/ https://reviews.llvm.org/D91998 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D91998: [OpenMP50][DOCS] Mark target data non-contiguous as done, NFC.

cchen created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC] (authored by dreachem, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572 if (PartialStruct.Base.isValid()) +CurInfo.NonContigInfo.Dims.push_back(0); emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct); MaskRay wrote: >

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cab91140f61: [OpenMP5.0] map item can be non-contiguous for target update (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 303495. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/Diagnost

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d43b58b109: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts (authored by cchen). Repository: rG LLVM Github Mon

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302898. cchen added a comment. Refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302884. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302882. cchen edited the summary of this revision. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2958-2970 +auto PerDevice = OffloadEntriesTargetRegion.find(DeviceID); +if (PerDevice != OffloadEntriesTargetRegion.end()) { + auto PerFile = PerDevice->second.find(FileID); + if (Per

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added a comment. In D90704#2372303 , @ABataev wrote: > It would be good if you could identify the object which leads to a crash, I > mean a target region, variable, etc. 1void 2add_one(float *b, int dm) 3{ 4#pragma omp

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen added a comment. In D90704#2371938 , @jdoerfert wrote: > I do not understand the commit message. Can you try to make it clearer? Hi, sorry for the shabby commit message, I've updated it and use godbolt link instead of pasting the code snippet since

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen updated this revision to Diff 302672. cchen added a comment. Separate test to a independent file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90704/new/ https://reviews.llvm.org/D90704 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/

[PATCH] D90704: [OpenMP] target nested `use_device_ptr() if()` and is_device_ptr trigger asserts

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clang now asserts for the below ca

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

cchen added a comment. In D74144#2307494 , @ABataev wrote: > In D74144#2307454 , @cchen wrote: > >> @ABataev, the below test is extracted from Sollve test suite and Clang now >> emit: >> >> test.c:17:35: error: s

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

cchen added a comment. Herald added subscribers: sstefan1, yaxunl. @ABataev, the below test is extracted from Sollve test suite and Clang now emit: test.c:17:35: error: subscripted value is not an array or pointer #pragma omp target update to( (([N][N])foo)[1:M] )

[PATCH] D86239: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86239/new/ https://reviews.llvm.org/D86239 ___ cfe

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

cchen added a comment. In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there is a reduced test case that failed after adding this patch. The assertion is from OMPChildren::getInnermostCapturedStmt. Test case: #include #include #include class Myclass {

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adc9aeb250c: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator… (authored by cchen). Repository: rG LLVM Github Mono

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen updated this revision to Diff 284082. cchen added a comment. Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85563/new/ https://reviews.llvm.org/D85563 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_map_me

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen created this revision. cchen added reviewers: jdoerfert, ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a subscriber: sstefan1. LValue map checker should handle CXXOperatorCallExpr Repos

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks! Repository: rG LLVM Github Monorepo C

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 280474. cchen added a comment. Fix coding style and argument on getIntTypeForBitwidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/Ope

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, is there any other concern for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___ cfe-commits mailing list cfe-com

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2167649 , @ABataev wrote: > In D84192#2167636 , @cchen wrote: > > > In D84192#2165522 , @ABataev wrote: > > > > > In D84192#2165517

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165522 , @ABataev wrote: > In D84192#2165517 , @cchen wrote: > > > In D84192#2165438 , @ABataev wrote: > > > > > In D84192#2165396

  1   2   3   >