[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb added a comment. I'm going to keep this CL open till someone comments, but after reading the relevant GCC bug , I'm not sure it's worth committing anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147288: [clang][NFC] updates cxx_status for P2113R0

cjdb created this revision. cjdb added reviewers: erichkeane, aaron.ballman, shafik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Issue #61857 identifies that there are some edge cases that aren't

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

cjdb added a comment. In D146358#4229120 , @hazohelet wrote: > In D146358#4227938 , @cjdb wrote: > >> In D146358#4204412 , @tbaeder >> wrote: >> >>> "subobject named

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

cjdb added a comment. In D146358#4204412 , @tbaeder wrote: > "subobject named 'foo'" sounds a bit weird to me, I'd expect just "subobject > 'foo'", but that's just a suggestion and I'll wait for a native spearker to > chime in on this. My expert brain

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added a comment. In D145201#4216567 , @aaron.ballman wrote: > In D145201#4214395 , @cjdb wrote: > >> swaps commits to see if that fixes CI (part 1) > > Oh, if this is just stacked patches confusing our

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507511. cjdb edited the summary of this revision. cjdb added a comment. And on this CL's side too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507510. cjdb added a comment. I think this corrects everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files: clang/include/clang/Basic/Diagnostic.h

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507503. cjdb edited the summary of this revision. cjdb added a comment. rebasing continues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507497. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI (part 1) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb updated this revision to Diff 507494. cjdb edited the summary of this revision. cjdb added a comment. swaps commits to see if that fixes CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 Files:

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb created this revision. cjdb added reviewers: aaron.ballman, vaibhav.y, denik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per §3.27.5 and §3.27.7, the `rule.id` and `ruleId` properties need to be

[PATCH] D146376: Update static_assert message for redundant cases

cjdb added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:261-265 static_assert(invert(true) == invert(false), ""); // expected-error {{failed}} \ -// expected-note {{evaluates to 'false == true'}}

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 507137. cjdb added a comment. fixes breakage and adds FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:214 void SARIFDiagnostic::emitIncludeLocation(FullSourceLoc Loc, PresumedLoc PLoc) { - assert(false && "Not implemented in SARIF mode"); + SarifRule Rule =

[PATCH] D146376: Update static_assert message for redundant cases

cjdb added a comment. Thanks for working on this, it's much appreciated! :4:1: error: static assertion failed due to requirement 'is_gitlab' static_assert(is_gitlab and is_weekend); ^ ~ The arrow seems a bit off here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:110 + /// The file to serialise text diagnostics to (non-appending). + std::string FilePath; + erichkeane wrote: > I'm a touch

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

cjdb added a comment. Would you be able to update the commit message to include a description that explains why this commit is necessary please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145856/new/ https://reviews.llvm.org/D145856

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM pending other reviewers' commentary. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145793/new/

[PATCH] D145439: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb added a comment. D145438 was merged into D145284 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145439/new/ https://reviews.llvm.org/D145439

[PATCH] D145438: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb abandoned this revision. cjdb added a comment. Merged into D145284 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145438/new/ https://reviews.llvm.org/D145438 ___

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 504309. cjdb added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. merges in D145438 . This patch is ready for review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4179481 , @ldionne wrote: > In D129951#4179467 , @cjdb wrote: > >> I'm deeply disappointed that libc++ moved away from using `__function_like`: >> that was an important part of

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178949 , @philnik wrote: > In D129951#4178844 , @cjdb wrote: > >> In D129951#4178154 , @philnik >> wrote: >> >>> I don't think libc++

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. In D129951#4178154 , @philnik wrote: > I don't think libc++ can adopt this without having to essentially duplicate > our code, since GCC doesn't support `__disable_adl` (and AFAICT there is no > coordination between GCC and Clang

[PATCH] D145439: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is one of two alternative designs that Clang can adopt when writing SARIF to file. In this design, the Clang driver will

[PATCH] D145438: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is one of two alternative designs that Clang can adopt when writing SARIF to file. In this design, the Clang driver invokes

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502308. cjdb added a comment. tidies up some stuff that I overlooked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files:

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502305. cjdb edited the summary of this revision. cjdb added a comment. adds dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files:

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The original `-fdiagnostics-format=sarif` wrote

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502190. cjdb added a comment. fixes string goof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb added a comment. That test is kinda problematic because it seems that the artifacts aren't ordered. I think we should change this from a Comment at: clang/lib/Basic/Sarif.cpp:314-317 + llvm::sort(*Artifacts, [](const json::Value , const json::Value ) { +return

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502186. cjdb added a comment. Herald added a subscriber: mgrang. sorts artifacts so that they're output in index order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added a comment. In D145178#4167103 , @aaron.ballman wrote: > LGTM, this is incremental progress. Hopefully we won't be adding too many > more RUN lines to this file though (sticking too many tests into one file is > also tech debt). Thanks!

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502021. cjdb added a comment. fixes something that wasn't supposed to be changed in the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files:

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb updated this revision to Diff 502020. cjdb added a comment. actually commits the files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145201/new/ https://reviews.llvm.org/D145201 Files: clang/include/clang/Frontend/SARIFDiagnostic.h

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 502019. cjdb added a comment. removes something from a future commit This should be the final alteration pre-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Including headers used to fire an assertion; now they report a

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 501982. cjdb added a comment. removes redundant line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178 Files: clang/test/Frontend/sarif-diagnostics.cpp Index:

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb updated this revision to Diff 501955. cjdb added a comment. renames check identifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145178/new/ https://reviews.llvm.org/D145178 Files: clang/test/Frontend/sarif-diagnostics.cpp Index:

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:31 +// RUN: %clang -fsyntax-only -Wall -Wextra -fdiagnostics-format=sarif-stderr %s > %t.txt 2>&1 || true +// RUN: FileCheck -dump-input=always %s --input-file=%t.txt

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:31 +// RUN: %clang -fsyntax-only -Wall -Wextra -fdiagnostics-format=sarif-stderr %s > %t.txt 2>&1 || true +// RUN: FileCheck -dump-input=always %s --input-file=%t.txt

[PATCH] D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current FileCheck test output is very difficult to read, which makes

[PATCH] D137458: [clang] Add __decay as a builtin template

cjdb added subscribers: aaron.ballman, cjdb. cjdb added a comment. In D137458#3909343 , @troyj wrote: >> Also, it would be nice to have some numbers for the 'measurably faster' >> claim :) > > Sure. Here's an example of a library change that started

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4111673 , @ldionne wrote: > I've been looking at implementing `reference_constructs_from_temporary` & > friends and this would be sweet to have. Is this blocked on something > specific? This trait should be ready to

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4132 +def DisableADL : InheritableAttr { + let Spellings = [Keyword<"__disable_adl">]; + let Subjects = SubjectList<[Function]>; rsmith wrote: > Has this syntax been discussed already?

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492296. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 Files:

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12934-12936 +// else if (!CandidateSet.empty() && CandidateSet.begin()->FoundDecl->hasAttr()) { +// return; +// } This and below need to be deleted. Repository: rG LLVM

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492234. cjdb retitled this revision from "[clang] teaches Clang the special ADL rules for functions in std::ranges" to "adds `__disable_adl` attribute". cjdb edited the summary of this revision. cjdb added a comment. - updates patch so that it meets what Aaron

[PATCH] D142423: [clang-tidy] Fix segfault in bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG716469b6139a: [clang-tidy] Fix segfault in bugprone-standalone-empty (authored by denik, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] dont warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8effeb44f4a8: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address (authored by adriandole, committed by cjdb). Repository: rG LLVM

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< aaron.ballman

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< cjdb wrote: > It's

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added a comment. Thanks for working on this! Needs a bit of work, but we should be able to get this in very soon methinks. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Excellent, let's wait for @denik's feedback before merging, but this LGTM. Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb added a comment. LGTM, thanks for fixing! Please be sure to have your commit message have `Fixes #59517` instead of a link to the issue, as this will close the bug upon merging. Comment at:

[PATCH] D140125: [clang] splits diagnostic message into summary and reason

cjdb created this revision. cjdb added reviewers: dblaikie, erichkeane. Herald added subscribers: kadircet, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added projects: clang, libc++abi, clang-tools-extra. Herald added subscribers: cfe-commits,

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. In D128372#3991516 , @MyDeveloperDay wrote: > Ironically as an aside... looking back at the review because of the discource > article. > > The whole reason why I added the [[nodiscard]] checker to clang-tidy 4 years > ago was to

[PATCH] D128372: [Clang-Tidy] Empty Check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGec3f8feddf81: [Clang-Tidy] Empty Check (authored by abrahamcd, committed by cjdb). Repository: rG LLVM Github Monorepo

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 ___

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3967397 , @tschuett wrote: > I do not ask you to do anything! I just noticed that you add a lot of > `FormatXXXDiagnostic` functions. An alternativ design is to have one > `FormatDiagnostic` function with a mode

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3966938 , @tschuett wrote: > Maybe the kind/amount of information printed ( `DiagnosticMode` ) and the > output device (console/sarif) are orthogonal issues. > > Still it would nice to be able to toggle the diagnostic

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3965985 , @tschuett wrote: > Then Sarif was a distraction. Still to reduce boilerplate and for A/B testing: > > enum class DiagnosticMode { > Legacy, > UserOriented, > Default = Legacy > } It took a fair

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. In D138939#3964677 , @erichkeane wrote: > In D138939#3964439 , @erichkeane > wrote: > >> In D138939#3964404 , @cjdb wrote: >> >>> In

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb updated this revision to Diff 479492. cjdb marked 4 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138939/new/ https://reviews.llvm.org/D138939 Files:

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb marked 3 inline comments as done. cjdb added a comment. In D138939#3963496 , @erichkeane wrote: > In D138939#3963473 , @tschuett > wrote: > >> Maybe `void FormatDiagnostic(SmallVectorImpl , DiagnosticMode

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > though I find myself wondering if the "FormatDiagnostic" call should stay the > same, and choose the legacy-reason only when a sarif reason doesn't exist? Or > for some level of command line control? Hmm... isn't this the point of the diagnostic consumers? Repository:

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. > The clang-side interface to this seems a touch clunky, and I fear it'll make > continuing its use/generalizing its use less likely. Is this w.r.t. the `FormatDiagnostic` being split up, or is it something else? If it's the former: I'll be changing that to

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. I don't understand why `test_demangle.pass.cpp` was considered too big to upload. Here's the diff: diff --git a/libcxxabi/test/test_demangle.pass.cpp b/libcxxabi/test/test_demangle.pass.cpp index dce8e6c3..9da6fb7d2ad9 100644 ---

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @njames93 if you don't have any further concerns, I am going to merge this on Friday afternoon, as it will have been four months since there has been a maintainer's input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added subscribers: carlosgalvezp, kadircet, arphaman. Herald added a reviewer: njames93. Herald added projects: Flang, All. cjdb requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:556 static_assert(__is_aggregate(EmptyArMB), ""); static_assert(!__is_aggregate(void), ""); static_assert(!__is_aggregate(const volatile void), ""); shafik wrote: > Should this

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138603/new/ https://reviews.llvm.org/D138603

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3f7880a272: [clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/D135820?vs=467283=476793#toc Repository: rG LLVM

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @LegalizeAdulthood @njames93 is there anything actionable that's left for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb updated this revision to Diff 467283. cjdb added a comment. undoes an unnessecary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135820/new/ https://reviews.llvm.org/D135820 Files: clang/include/clang/Basic/Diagnostic.td

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a subscriber: arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The [Improving Clang's Diagnostics

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14e64cb8d594: [clang] makes `__is_destructible` KEYALL instead of KEYMS (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa089defa24dd: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable` (authored by cjdb). Repository: rG LLVM Github Monorepo

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3f48eefc11: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins (authored by cjdb). Repository: rG LLVM Github Monorepo

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1071 REVERTIBLE_TYPE_TRAIT(__is_base_of); + REVERTIBLE_TYPE_TRAIT(__is_bounded_array); REVERTIBLE_TYPE_TRAIT(__is_class); erichkeane wrote: > Can you just put

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:397 +def err_reserved_identifier_for_future_use : Error< + "%0 is a compiler-reserved identifier for a future feature">; } erichkeane wrote: > I don't think we should

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 466318. cjdb retitled this revision from "[clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`" to "[clang] adds `__reference_constructs_from_temporary`". cjdb added a comment. discards work on

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

cjdb updated this revision to Diff 466316. cjdb retitled this revision from "[clang] makes `__is_destructible` KEYCXX instead of KEYMS" to "[clang] makes `__is_destructible` KEYALL instead of KEYMS". cjdb edited the summary of this revision. cjdb added a comment. applies feedback, rebases

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 466315. cjdb marked 5 inline comments as done. cjdb added a comment. applies feedback, rebases, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135177

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb updated this revision to Diff 466314. cjdb marked 4 inline comments as done. cjdb added a comment. applies requested changes, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135175/new/ https://reviews.llvm.org/D135175

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb updated this revision to Diff 466088. cjdb added a comment. Gets `__reference_constructs_from_temporary` correct. Still WIP for the latter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files:

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added a subscriber: jwakely. cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible,

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb added a comment. In D135341#3841126 , @ldionne wrote: > Interesting, I actually wasn't even aware of that C++23 feature in the > library. FWIW, libc++ will be more than happy to use that builtin instead of > trying to figure it out inside the

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3840406 , @erichkeane wrote: > In D135339#3840323 , @cjdb wrote: > >> In D135339#3839876 , @erichkeane >> wrote: >> >>> This doesn't

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX)

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3839876 , @erichkeane wrote: > This doesn't cause us to lose this in Microsoft C mode, does it? Otherwise, > LGTM. Why is destructibility necessary in C? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb planned changes to this revision. cjdb added a comment. I learnt last night that this one is incredibly wrong and needs revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane, tcanens. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is information that the compiler already has, and should

<    1   2   3   4   5   >