[PATCH] D110017: [clang] Removes leak sanitizer support on FreeBSD since it is unsupported

devnexen created this revision. devnexen added a reviewer: emaste. devnexen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110017 Files: clang/lib/Driver/ToolChains/FreeBS

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13e22961f8b4: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89690/

[PATCH] D89690: [clang] update of the DragonFlyBSD's driver for the 5.8.x releases.

devnexen created this revision. devnexen added reviewers: sepavloff, jyknight. Herald added a project: clang. Herald added a subscriber: cfe-commits. devnexen requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89690 Files: clang/lib/Driver/ToolCh

[PATCH] D69373: [Clang] Fix Sema class build fix

devnexen created this revision. devnexen added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - DefaultedComparisonKind not being a classic enum, setting as a so small bitfield triggers gcc warning. Repository: rC Clang https://reviews.llvm.org/D69

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGbccbd74c6255: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD (authored by devnexen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66792/new/ htt

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

devnexen created this revision. devnexen added reviewers: sylvestre.ledru, kcc. devnexen created this object with visibility "All Users". Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D66792 Files: clang/docs/MemorySaniti

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

devnexen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:240 + +- The Static Analyzer recieved a + :ref:`developer documentation `. typo `recieved` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6676

[PATCH] D58324: Enable esan for the cache frag support

devnexen abandoned this revision. devnexen added a comment. Esan removed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58324/new/ https://reviews.llvm.org/D58324 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D58324: Enable esan for the cache frag support

devnexen created this revision. devnexen added a reviewer: bsdjhb. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D58324 Files: lib/Driver/ToolChains/FreeBSD

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE352031: [extra] unit tests enable crash-recovery cases on FreeBSD (authored by devnexen, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. I did filled the form already ... do not know if it needs days to take effects ... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. Seems I can t commit myself to the svn repo ... had moved to git ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 ___ cfe-commits mail

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. In D57102#1368373 , @steveire wrote: > The question was whether there is a build-bot for FreeBSD (if there is, then > it is covered by CI). > > Doesn't matter though. If no such bot exists, this isn't the commit to > enforce req

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen added a comment. In D57102#1368309 , @steveire wrote: > Is this covered by CI? The tests pass. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 _

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

devnexen created this revision. devnexen added a reviewer: steveire. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Seems the previous statement does not hold up anymore. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57102 Fil

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

This revision was automatically updated to reflect the committed changes. Closed by commit rL348884: [analyzer][CStringChecker] evaluate explicit_bzero (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54592?vs=177

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen added a comment. ping just want to put it behind :-) thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 177171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1405-1406 + clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}} + bzero(str + 2, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{FALSE

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen added a comment. In D54592#1319421 , @Szelethus wrote: > I hope you don't mind me changing the revision title -- many of us are > automatically subscribed to revisions with `analyzer` in the title, that also > helps with getting feedback sooner

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 176780. devnexen added a comment. - Using same type for zero as memset. - Updating slighty the unit tests with ptr/dynamic array for bzero. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/Stati

[PATCH] D54592: [analyzer][CStringChecker] evaluate explicit_bzero

devnexen marked an inline comment as done. devnexen added inline comments. Comment at: test/Analysis/string.c:1399 + bzero(str, 2); + clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}} +} NoQ wrote: > I suspect that the reason why this didn't

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

devnexen updated this revision to Diff 176722. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/string.c Index: test/Analysis/string.c

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

devnexen added a comment. ping @MaskRay my only hope seemingly :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

devnexen added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54592/new/ https://reviews.llvm.org/D54592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D54592: [CStringChecker] evaluate explicit_bzero

devnexen created this revision. devnexen added reviewers: george.karpenkov, dergachev.a. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - explicit_bzero has limited scope/usage only for security/crypto purposes but is non-optimisable version of m

[PATCH] D53922: [clangd] fix non linux build

devnexen added a comment. I thought applying this sort of change for BSD but SCHED_IDLE is a GNU extension and does not have equivalence per see. Repository: rL LLVM https://reviews.llvm.org/D53922 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D53922: [clangd] fix non linux build

This revision was automatically updated to reflect the committed changes. Closed by commit rL345700: [clangd] fix non linux build (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53922?vs=171870&id=171873#toc Rep

[PATCH] D53922: [clangd] fix non linux build

devnexen created this revision. devnexen added reviewers: kadircet, sammccall. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, krytarowski. There is no SCHED_IDLE semantic equivalent in BSD sy

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. Things might differ between NetBSD and FreeBSD about the feasibility. So maybe for the former it is more reachable (only would need to set specific application mappings maybe ?). - So once the non writable addresses are created, it processes the working sets to make i

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. - FreeBSD does not have real Linux's clone equivalent. - Hangs or crashes during the final report (the shadow mapping is similar as Linux's though). Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits m

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. ping working-set on FreeBSD does not seem doable. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. ping compiler-rt component committed :-) Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

devnexen added a comment. The compiler-rt part had been committed. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC342832: [CStringSyntaxChecker] Check strlcat sizeof check (authored by devnexen, committed by ). Repository: rC Clang

[PATCH] D52331: [Index] Report specialization bases as references when IndexImplicitInstantiation is true

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM to me Repository: rC Clang https://reviews.llvm.org/D52331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 166628. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275 +os << "sizeof(" << DstName << ")"; + else +os << "sizeof()"; MaskRay wrote: > devnexen wrote: > > MaskRay wrote: > > > Why can't this `else

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 166626. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:275 +os << "sizeof(" << DstName << ")"; + else +os << "sizeof()"; MaskRay wrote: > Why can't this `else if` case be folded into the `strlcpy` cas

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 165604. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199 +if (Append) + RemainingBufferLen -= 1; +if (RemainingBufferLen < ILRawVal) MaskRay wrote: > `RemainingBufferLen` is `uint64_t`. Can the

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 164355. devnexen added a comment. - Correcting misleading message and advising proper fix. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added inline comments. Comment at: test/Analysis/cstring-syntax.c:49 + strlcat(dest, "0123456789", badlen / 2); + strlcat(dest, "0123456789", badlen); // expected-warning {{The third argument allows to potentially copy more bytes than it should. Replace with the valu

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping @george.karpenkov after that I won t bother you for a long time :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51269: [Xray] Darwin - Enable in the driver side

This revision was automatically updated to reflect the committed changes. Closed by commit rL340712: [Xray] Darwin - Enable in the driver side (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51269?vs=162583&id=16

[PATCH] D51269: [Xray] Darwin - Enable in the driver side

devnexen added a comment. Good point :-) Repository: rL LLVM https://reviews.llvm.org/D51269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51269: [Xray] Enable in the driver side

devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D51269 Files: lib/Driver/ToolChains/Darwin.cpp lib/Driver/ToolChains/Darwin.h

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 162139. devnexen added a comment. - Returns immediately for both case when sizeof destination. - Adding few more cases. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: t

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

This revision was automatically updated to reflect the committed changes. Closed by commit rL339641: [CStringSyntaxChecker] Check strlcat sizeof check (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49722?vs=1602

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 160272. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping but will be for 8.0 :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen abandoned this revision. devnexen added a comment. Committed in the branch. Repository: rC Clang https://reviews.llvm.org/D49873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D49906: [Docs] Sanitizer update

devnexen abandoned this revision. devnexen added a comment. Commited in the branch. Repository: rC Clang https://reviews.llvm.org/D49906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D49873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49906: [Docs] Sanitizer update

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D49906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 158062. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping :) https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49906: [Docs] Sanitizer update

devnexen created this revision. devnexen added a reviewer: eugenis. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Adding new option detect_write_exec=1 available. Repository: rC Clang https://reviews.llvm.org/D49906 Files: docs/AddressS

[PATCH] D49873: [Docs] ReleasesNotes update / Static analyser

devnexen created this revision. devnexen added a reviewer: pcc. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49873 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst =

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen updated this revision to Diff 157381. https://reviews.llvm.org/D49722 Files: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp test/Analysis/cstring-syntax.c Index: test/Analysis/cstring-syntax.c === --- test/Analysi

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen closed this revision. devnexen added a comment. Exited too early fro the editor ,.. did not write all the lines but commited with https://reviews.llvm.org/rC337926 https://reviews.llvm.org/D49788 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen updated this revision to Diff 157237. https://reviews.llvm.org/D49788 Files: docs/AddressSanitizer.rst docs/MemorySanitizer.rst docs/SafeStack.rst docs/ThreadSanitizer.rst docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst =

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen added a comment. Ah I forgot NetBSD sorry yes you re right. Repository: rC Clang https://reviews.llvm.org/D49788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen created this revision. devnexen added reviewers: morehouse, krytarowski. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D49788 Files: docs/AddressSanitizer.rst docs/MemorySanitizer.rst

[PATCH] D49788: [Docs] Update supported oses for ubsan, asan and msan

devnexen added a comment. This is the first time I m involved into a release so I do not know if it s too early to update those docs but with the freeze incoming, I thought it was worth before it get forgotten. Repository: rC Clang https://reviews.llvm.org/D49788

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. Hopefully will try to push it before the freeze just announced, that s my last change in this area (except potential fixes) :) Repository: rC Clang https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commit

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen created this revision. devnexen added reviewers: george.karpenkov, NoQ. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Assuming strlcat is used with strlcpy we check as we can if the last argument does not equal os not larger than the

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

This revision was automatically updated to reflect the committed changes. Closed by commit rC335856: OpenBSD driver needs ld.lld in sanitizer context (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D48574 Files: lib/Driver/ToolChains/OpenBSD.cpp Index:

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen added a comment. In https://reviews.llvm.org/D48574#1146619, @dberris wrote: > LGTM > > PS. I really wish at some point this will lead to an OpenBSD build bot! Would be interesting, it can even launch ubsan minimal tests and this change will simplify things a bit. Repository: rC C

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D48574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Base GNU ld is pretty old and does not support --dynamic-list flag. - For conveniency we can add it automatically when compile wit

[PATCH] D47007: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rC333060: [analyzer] CStringChecker fix for strlcpy when no bytes are copied to the dest… (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D47007 Files: lib/StaticA

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103781, @alexfh wrote: > In https://reviews.llvm.org/D45177#1103774, @devnexen wrote: > > > In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > > > > > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. > > > > >

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. I admit I do not due to much longer compilation time, I ll recompile all with and will see tomorrow if I can reproduce. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. I was unable to reproduce both FreeBSD and Linux. Plus my changes come after checkNonNull. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen added a comment. In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote: > Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ? Nope. more for last NoQ comment. Will try for this one once I finish setting it up. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1102887, @alexfh wrote: > This is reproducible in r332425. I posted this PR https://reviews.llvm.org/D47007 hopes it helps. Repository: rC Clang https://reviews.llvm.org/D45177 ___ c

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen created this revision. devnexen added reviewers: NoQ, george.karpenkov. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Again strlc* does not return a pointer so the zero size case does not fit. Repository: rC Clang https://reviews.ll

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1560-1566 // If the size is known to be zero, we're done. if (StateZeroSize && !StateNonZeroSize) { StateZeroSize = StateZeroSize->BindExpr(CE, LCtx, DstVal);

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. Thanks ! I would be grateful if anybody could land it for me. https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. ping https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1485 + state = CheckOverlap(C, state, CE->getArg(2), Dst, srcExpr); + NoQ wrote: > This crashes on the old tests for the checker. I guess that's because the > normal `s

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 145352. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c === --- /dev/null +++ test/Analysi

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 144981. devnexen added a comment. New test to check the length https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.c =

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen added a comment. In https://reviews.llvm.org/D45149#1062279, @jdenny wrote: > Hi David. While I did make some superficial changes here recently, I'm no > authority on what belongs here. However, I would suggest that the > refactoring patch be split from the original patch. Thanks.

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen updated this revision to Diff 144952. devnexen added a comment. The returned value is the number of character copied to the dst buffer. https://reviews.llvm.org/D45177 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp test/Analysis/bsd-string.c Index: test/Analysis/bsd-string.

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. Sure ! looking into it. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. If anybody can land for me, I would appreciate. Thanks regardless :-) Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

[PATCH] D45662: OpenBSD add C++ runtime in a driver's standpoint

devnexen updated this revision to Diff 142811. devnexen retitled this revision from "Fuzzer, add libcxx for OpenBSD" to "OpenBSD add C++ runtime in a driver's standpoint". devnexen edited the summary of this revision. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp l

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if (Args.hasArg(options

  1   2   3   >