[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340666. dgoldman added a comment. Remove temporary comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files:

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman updated this revision to Diff 340665. dgoldman added a comment. Actually fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 Files:

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Addressing comments in https://reviews.llvm.org/D98984

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340659. dgoldman marked an inline comment as done. dgoldman added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files:

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman marked 3 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1048 )cpp", - "0: targets = {global}\n" - "1: targets = {param}\n" sammccall wrote: > there

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340653. dgoldman marked 2 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files:

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:152 // // TODO: Make previous parameters part of the signature for Objective-C // methods. sammccall wrote: > is this TODO handled now? No,

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 340619. dgoldman marked 4 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files:

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to the +// method. +// if

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman added a comment. Herald added a subscriber: cfe-commits. Friendly ping, not sure if there's something in here and https://reviews.llvm.org/D99975 that I'm missing to properly support the one decl/type loc to multiple references here Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

dgoldman added a comment. In D97617#2592424 , @sammccall wrote: > (not really sure why this suddenly seemed important to me, but if you don't > have semantic highlighting on, you're missing out!) Thanks! Comment at:

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2141e3a08c: [clangd] Improve document symbols support for Objective-C categories and methods (authored by dgoldman). Repository: rG LLVM Github

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 327146. dgoldman added a comment. Add comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/FindSymbols.cpp

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 326719. dgoldman marked an inline comment as done. dgoldman added a comment. Limit changes to document symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:228 +Out << (Method->isInstanceMethod() ? '-' : '+'); +Method->getSelector().print(Out); +return Out.str(); sammccall wrote: > in

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast()) +return printObjCContainer(*C); sammccall wrote: > I'm not sure this fits with the contract of

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 323443. dgoldman added a comment. - Add class method test case + swap to auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Categories will now be printed

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c5a800dc17: Improve hover scopes for Objective-C code (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323156. dgoldman marked an inline comment as done. dgoldman added a comment. - Support protocols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files:

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323151. dgoldman added a comment. - Move over to AST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; sammccall wrote: > this function's name doesn't really

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323141. dgoldman marked 7 inline comments as done. dgoldman added a comment. - Address review comments Will move over to AST.cpp in next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. Friendly ping, I think this is still worth merging in even without the QName changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D94919#2515987 , @adamcz wrote: > The crash happens while indexing the file, not during code completion. The > code completion tests generally

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman requested changes to this revision. dgoldman added a comment. This revision now requires changes to proceed. Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end It's hard to tell what Clang makes of this, I

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I messed around with qualified name changes - lots of things internally rely upon the qualified names so that will be best for a separate change. I could potentially handle `DocumentSymbol` fixes in here though - LMK if you think it makes sense to move some of this

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309987. dgoldman added a comment. Add protocol test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309983. dgoldman added a comment. Swap to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I think there's still some more work to be done after this which might move some of this around: - DocumentSymbol support: Currently categories show up as (anonymous) or (see here

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman updated this revision to Diff 309611. dgoldman added a comment. - Rebase + refactor, sorry for the long delay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files:

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c022d84699: [clangd][ObjC] Support nullability annotations (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299356. dgoldman added a comment. Revert to previous AttributedTypeLoc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files:

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. In D89579#2341513 , @sammccall wrote: > Yep, let's revert to the previous state and land that, and I'll puzzle over > the examples you give (because always returning false shouldn't affect > behavior, just performance). > > I

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:611 + // robust. + return false; if (!SelChecker.mayHit(S)) { sammccall wrote: > I'm not sure we actually want to *do it* at this point, as you're seeing we > may

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. With that change, somehow this extract test is now failing: - TEST 'Clangd Unit Tests :: ./ClangdTests/ExtractFunctionTest.FunctionTest' FAILED Note: Google Test filter = ExtractFunctionTest.FunctionTest [==] Running 1 test from 1 test

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299038. dgoldman marked 5 inline comments as done. dgoldman added a comment. Update with changes requested - Looking into extract failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298759. dgoldman added a comment. Fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298757. dgoldman added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:621-623 + if (auto AT = TL->getAs()) +S = AT.getModifiedLoc() +.getSourceRange(); // should we just return false? Let me know if you think it would be

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. dgoldman requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Nullability annotations are implmented using attributes; previusly

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb29c33984bf: [clangd][ObjC] Improve xrefs for protocols and classes (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 284788. dgoldman marked 3 inline comments as done. dgoldman added a comment. - Final touches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:614 + +TEST_F(SymbolCollectorTest, ObjCClassExtensions) { + Annotations Header(R"( sammccall wrote: > dgoldman wrote: > > sammccall wrote: > > > dgoldman

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 284425. dgoldman added a comment. Rebase + lint fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added a comment. In D83501#2173534 , @sammccall wrote: > (Sorry this has been pending a while - I think it's basically there. Only > things we really need to address to land this is have a consistent view of > what the canonical decl is for the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280930. dgoldman marked 7 inline comments as done. dgoldman added a comment. - More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280086. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde98c82c0ad: Fix issue in typo handling which could lead clang to hang (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278890. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278881. dgoldman added a comment. - CheckAndAdvanceTypoExprCorrectionStreams comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files:

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278876. dgoldman added a comment. - Minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to detect when certain TypoExprs are not being transformed due to invalid trees, otherwise we risk endlessly trying to fix it. Repository: rG LLVM

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 278752. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor test and formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2157957 , @sammccall wrote: > In D83501#2154300 , @dgoldman wrote: > > > In D83501#2153605 ,

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:614 + +TEST_F(SymbolCollectorTest, ObjCClassExtensions) { + Annotations Header(R"( Here's the ClassExtension that

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 278310. dgoldman marked an inline comment as done. dgoldman added a comment. SymbolCollector fixes + more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 7 inline comments as done. dgoldman added a comment. In D83501#2153605 , @sammccall wrote: > In D83501#2148671 , @dgoldman wrote: > > > I implemented goto-definition from Foo() --> Foo impl in

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277814. dgoldman added a comment. Minor lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277601. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 4 inline comments as done. dgoldman added a comment. In D83501#2146892 , @sammccall wrote: > In D83501#2144283 , @dgoldman wrote: > > > Looking further into the indexing support, I've questions: > >

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277582. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for ObjC in SymbolCollector as well as XRefs - Make sure ObjC indexing doesn't use the forward decls and doesn't treat the impl as the canonical decl - Don't treat ObjC

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:83 +return PD->getDefinition(); + // Objective-C classes can have three types of declarations: + // sammccall wrote: > sammccall

[PATCH] D83513: [AST][ObjC] Fix crash when printing invalid objc categories

This revision was automatically updated to reflect the committed changes. Closed by commit rGea201e83e292: [AST][ObjC] Fix crash when printing invalid objc categories (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D83513?vs=276841=277126#toc Repository: rG LLVM

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277105. dgoldman added a comment. rebase, phabricator keeps getting confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277103. dgoldman added a comment. Move up null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp Index:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277100. dgoldman added a comment. Find target fixes + symbol collector test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked 5 inline comments as done and an inline comment as not done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:273 Flags |= Rel::Underlying; // continue with the underlying decl. +} else if (const

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277084. dgoldman added a comment. Swap to getPreferredDecl and improve targetDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added a comment. In D83501#2144144 , @sammccall wrote: > I think without index changes this will still give the wrong answer for > go-to-definition if the @implementation is in a different file. > Do

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277054. dgoldman marked 2 inline comments as done. dgoldman added a comment. Add support for categories + fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277026. dgoldman added a comment. Fixes for getDefinition/getCanonicalDecl for ObjC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:88-92 + if (const auto *ID = dyn_cast(D)) { +if (const auto *IMD = ID->getImplementation()) + return IMD; +return ID->getDefinition(); + }

[PATCH] D83513: [AST][ObjC] Fix crash when printing invalid objc categories

dgoldman created this revision. dgoldman added reviewers: sammccall, gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. If no valid interface definition was found previously we would crash. With this change instead we just print `<>` in place of the NULL interface.

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:276 getDeclAtPosition(AST, CurLoc, Relations, NodeKind)) { // Special case: void foo() ^override: jump to the overridden method. if (const auto *CMD = llvm::dyn_cast(D)) {

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:88-92 + if (const auto *ID = dyn_cast(D)) { +if (const auto *IMD = ID->getImplementation()) + return IMD; +return ID->getDefinition(); + } Let me know if there's a

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously clangd would jump to forward declarations for protocols and classes instead of

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

This revision was automatically updated to reflect the committed changes. Closed by commit rGc61ef1f25c7f: [Sema][CodeComplete][ObjC] Dont split the first selector fragment (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

dgoldman created this revision. dgoldman added reviewers: sammccall, doug.gregor. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, ilya-biryukov. Herald added a project: clang. Standardize the formatting of selector fragments to include the ':', e.g. for `-

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ef65adb6f9d: [Sema][CodeComplete][ObjC] Dont include arrow/dot fixits (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269271. dgoldman added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269269. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for Objective-C + // objects. Since

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow, bool IncludeObjC, Optional AccessOpFixIt) -> bool {

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269192. dgoldman marked 4 inline comments as done. dgoldman added a comment. Remove stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269189. dgoldman added a comment. Check AccessOpFixIt.hasValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268818. dgoldman added a comment. - Fix broken diff base (due to lint fixes maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Exempt ObjC from arrow/dot fixits since this has

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. Submitted https://github.com/llvm/llvm-project/commit/7d91633a2b9b1f563dc14c632cc0c461c3651f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman added a comment. In D74790#1883466 , @dyung wrote: > `The test you added in this change seems to be failing on Windows, can you > take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/14409 > > FAIL: Clang ::

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50fe5eb6d2e: [Sema][CodeComplete] Handle symlinks for include code completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman marked 3 inline comments as done. dgoldman added a comment. In D74790#1881827 , @sammccall wrote: > Thanks! I can't see this being a performance problem (famous last words...) Technically it is capped at 2500 symlinks =) fingers crossed

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman added a comment. In D73916#1881396 , @nridge wrote: > Which client(s) use or plan to use this extension? SourceKit-LSP https://github.com/apple/sourcekit-lsp/pull/242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245415. dgoldman added a comment. - Fixes for Sam's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245256. dgoldman added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously any symlinks would be ignored since the directory traversal doesn't follow them. With this change we now follow symlinks (via a `stat` call in

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1874826 , @erik.pilkington wrote: > In D74417#1874747 , @dgoldman wrote: > > > Added but it's still failing due to a different assertion failure, do you > > think this could be

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244728. dgoldman added a comment. - Fix parameter abbreviation for ParamVarDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files:

<    1   2   3   4   5   6   >