[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

DiggerLin added inline comments. Comment at: clang/include/clang/Driver/Options.td:3405 +def mtocdata : Flag<["-"], "mtocdata">, + Visibility<[ClangOption, CLOption, DXCOption, CC1Option]>, + Flags<[TargetSpecific]>, do we need `CLOption, DXCOption` here ? thes

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158739/new/ https://reviews.llvm.org/D158739 ___ cfe-commits mailing list cfe-com

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

DiggerLin added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:566 static bool checkAliasedGlobal( -DiagnosticsEngine &Diags, SourceLocation Location, bool IsIFunc, -const llvm::GlobalValue *Alias, const llvm::GlobalValue *&GV, +ASTContext &Context,

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. @MaskRay, would you have any additional comments to share? If not, would it be appropriate for me to proceed with committing the patch? Your input would be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 550776. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: clang/test/lit.cfg.py:391 if "system-aix" in config.available_features: -config.substitutions.append(("llvm-nm", "env OBJECT_MODE=any llvm-nm")) -config.substitutions.append(("llvm-ar", "env OBJECT_MODE=any llvm-ar")) + conf

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 549938. DiggerLin marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546867. DiggerLin marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546444. DiggerLin marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/non-AIX-not-supportedwq-X-option.test:1 +## REQUIRES: !system-aix +## Test the -X option is not supported on non-AIX os. jhenderson wrote: > Looks

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546071. DiggerLin marked 5 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Dr

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. > I'd still rather the invalid OBJECT_MODE value be read and rejected upfront > before even parsing the -X option. as Stephen and me point out, if there is -X option, we do not care about the environment env `OBJECT-MODE` , when user input the -X option , it means ,

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 545392. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.py clang/tools/clang-offload-packager/Clan

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 545247. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.py clang/tools/clang-offload-packager/Clan

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 544804. DiggerLin added a comment. addressed comment and let llvm-ranlib supports -Xany option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/test/

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. > I do see the appeal of a single enum parameter in the meantime. I would > suggest it should be called SymtabWritingMode and have values NoSymtab, > NormalSymtab, BigArchive64Bit, BigArchive32Bit, and BigArchiveBoth. You could > optionally drop one of the BigArchive*

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 2 inline comments as done. DiggerLin added a comment. > As an alternative (but I think adds unnecessary complexity, due to needing an > extra variable), you could have both tools read the environment variable into > a string variable, then, if the -X option is present, overwrite

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 3 inline comments as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN: llvm-

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 544066. DiggerLin marked an inline comment as done. DiggerLin added a comment. addressed partial comment, after deciding whether to delete the `bool NeedSymbols parameter` from functions API,(writeArchiveToStream etc), I will upload a update patch. Re

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:17-18 +## Test the OBJECT_MODE environment variable when adding symbol table. +# RUN: unset OBJECT_MODE +# RUN: llvm-ranlib t_X32.a +# RUN: llvm-

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 3 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1463 + if (object::Archive::getDefaultKindForHost() == object::Archive::K_AIXBIG) { +// If not specify -X option, get BitMode from enviorment variable --

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 2 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1442 + +// -X option in ranlib do not accept "any" +if (BitMode == BitModeTy::Unknown || BitMode == BitModeTy::Any) jhe

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:237 static bool Verbose = false; ///< 'v' modifier -static bool Symtab = true;///< 's' modifier +static WriteSymTabType Symtab = t

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

DiggerLin added inline comments. Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was actually compiled successfully after using the +; -maix-small-local-exec-tls option. since the patch only add a new op

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 542660. DiggerLin added a comment. 1. rebase the code 2. for the `env OBJECT_MODE=` or is `env OBJECT_MODE=""` , the `ranlib` and `ar` in AIX OS , have different behaviors(ranlib looks as -X32 , but `ar` and `nm` output error ), I change `llvm-ranlib` as

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 542209. DiggerLin marked 5 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/test/l

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 10 inline comments as done. DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1394 object::Archive::K_AIXBIG) { Match = *(*ArgIt + 2) != '\0' ? *ArgIt + 2 : *(++ArgIt); BitMode = getBitMode(Match); --

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin marked 14 inline comments as done. DiggerLin added a comment. In D142660#4509464 , @jhenderson wrote: > I still have concerns about the option-parsing logic being duplicated, but > I'm out of time to review it now. I'll try to look tomorrow.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. Gentle ping , @jhenderson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

DiggerLin added inline comments. Comment at: clang/test/Driver/aix-integrated-as.c:9 +// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj" +// CHECK-IAS32: "aix-integrated-as.o" + both -fno-integrated-as and -fintegrated-as output the same file n

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 523759. DiggerLin added a comment. rebase to latest master after the patch https://reviews.llvm.org/D142479 [AIX] support 64bit global symbol table for big archive landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: llvm/test/tools/llvm-ranlib/aix-X-option.test:16 + +## Test OBJECT_MODE environment variable when adding symbol table +# RUN: env OBJECT_MODE=32 llvm-ranlib t_X32.a stephenpeckham wrote: > what about OBJECT_MODE= (defi

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 522625. DiggerLin marked 4 inline comments as done. DiggerLin added a reviewer: stephenpeckham. DiggerLin added a comment. address Stephen's comment, thanks Stephen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:237 static bool Verbose = false; ///< 'v' modifier -static bool Symtab = true;///< 's' modifier +static WriteSymTabType Symtab = true; ///< 's' modifier static bool Dete

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 517638. DiggerLin marked 9 inline comments as done. DiggerLin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comment and set option -Xany as invalid option and environment OBJECT-MODE=any as invalid too(let i

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

DiggerLin added a comment. In D142484#4080202 , @Jake-Egan wrote: > In D142484#4079909 , @jhuber6 wrote: > >> In D142484#4079869 , @Jake-Egan >> wrote: >> >>> Hi, this ne

[PATCH] D145600: [AIX] change "llvm-ar" to "env OBJECT_MODE=any llvm-ar" in clang/test for AIX OS

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, Jake-Egan, daltenty. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In patch https://reviews.llvm.org/D127864. we add a new opti

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461598. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py ===

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin updated this revision to Diff 461589. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134284/new/ https://reviews.llvm.org/D134284 Files: clang/test/lit.cfg.py Index: clang/test/lit.cfg.py

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802806 , @daltenty wrote: >> If OBJECT_MODE isn't an environment variable that clang uses, surely it >> should ignore it? > > The clang driver does in fact respect OBJECT_MODE on AIX, but I'm guessing it > doesn't

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802791 , @jhenderson wrote: > In D134284#3802766 , @DiggerLin > wrote: > >> In D134284#3802763 , @jhenderson >> wrote: >> >>> Wou

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin added a comment. In D134284#3802763 , @jhenderson wrote: > Wouldn't it be better to change the lit config to specify the `OBJECT_MODE` > environment variable on AIX? I have tried it before, I added the following in clang/test/lit.cfg.py if 's

[PATCH] D134284: [AIX] change the clang tests with llvm-nm -Xany

DiggerLin created this revision. DiggerLin added reviewers: jhenderson, daltenty, hubert.reinterpretcast. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 455758. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp clang/lib

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin added a comment. if there is no more comment. Can you help to approve it ?, thanks in advance. @MaskRay @daltenty Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 ___

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin updated this revision to Diff 427297. DiggerLin marked an inline comment as done. DiggerLin added a comment. address MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: cl

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin marked 8 inline comments as done. DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:985 +// CHECK-LD64-SHARED-EXPFULL: "-bM:SRE" +// CHECK-LD64-SHARED-EXPFULL: "-bnoentry" +// CHECK-LD64-SHARED-EXPFULL: "-b64" MaskRay w

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:675-676 +// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm" +// CHECK-LD32-SHARED-EXPORTS-NOT: "-X" +// CHECK-LD32-SHARED-EXPORTS-NOT: "32" +// CHECK-LD32-SHARED-EXP

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_t i = 0, Size = CmdArgs.size(); i < Size; ++i) { +llvm::StringRef ArgString(CmdArgs[i]); stev

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin updated this revision to Diff 423972. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/includ

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:609 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. -shared (with exp option strings in other opt). +// RUN: %clangxx -x c++ -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-resource-dir=%S/Inputs/resource_d

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 412516. DiggerLin marked an inline comment as done. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/J

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 411172. DiggerLin marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.c

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin marked 6 inline comments as done. DiggerLin added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_t i = 0; i < CmdArgs.size(); ++i) { +llvm::StringRef ArgString(Cmd

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 406560. DiggerLin added a comment. run git format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.c

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin created this revision. DiggerLin added reviewers: daltenty, hubert.reinterpretcast. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently only check driver Wl options and don't check for the plain -b, -Xlinker or

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 _

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1f1bff81bd9: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore… (authored by DiggerLin). Repository: rG LLVM Github

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/test/CodeGen/hidden-visibility.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %s -fvisibility default -emit-llvm -o - | FileCheck %s da

[PATCH] D98660: [AIX][XCOFF] Fixed the test case which failed at aix OS because enable -mignore-xcoff-visibility by default.

DiggerLin created this revision. DiggerLin added reviewers: hubert.reinterpretcast, jasonliu, sfertile, daltenty. Herald added a subscriber: arphaman. DiggerLin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. because we enable -mignore-xcof

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46d4d1fea401: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff… (authored by DiggerLin). Repository: rG LLVM Github Mon

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 329316. DiggerLin added a comment. slight change , move to if (Opts.IgnoreXCOFFVisibility) GenerateArg(Args, OPT_mignore_xcoff_visibility, SA); to position as comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added a comment. Gentle ping . @jansvoboda11 . Do you have any comment on it the last update on "added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/ne

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328998. DiggerLin marked an inline comment as done. DiggerLin added a comment. added extra comment back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clan

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added a comment. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || + !Args.hasArg(OPT_fvisibi

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328769. DiggerLin added a comment. added -round-trip-args functionality for the lang opt "-mignore-xcoff-visibility" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

DiggerLin added a comment. in your summary , it looks clang will emit "-fvisibility default" to cc1 even if there is no -fvisibility in the clang command ? I compiled the clang with your patch, it looks do not always emit "-fvisibility default" to cc1. I understand wrong on your summary ?

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328632. DiggerLin added a comment. rebase code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/c

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 327898. DiggerLin added a comment. modify a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 327804. DiggerLin added a comment. rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inc

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin added a comment. Herald added a subscriber: jansvoboda11. Gentle ping @sfertile , any new comment on the patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 ___