[PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4349291 , @asb wrote: > In D128612#4349259 , @djtodoro > wrote: > >> In D128612#4345912 , @asb wrote: >> >>> In D128612#4337037

[PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4345912 , @asb wrote: > In D128612#4337037 , @djtodoro > wrote: > >> Hi! I am wondering if someone knows what is the status of this. > > I've not seen any further progress. I

[PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. Herald added a subscriber: luke. Hi! I wondering if someone knows what is the status of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612

[PATCH] D115351: [Debugify] Port verify-debuginfo-preserve to NewPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b6d3a41b4e: [Debugify] Port verify-debuginfo-preserve to NewPM (authored by ntesic, committed by djtodoro). Herald added a project: clang. Herald a

[PATCH] D115622: [Debugify] Optimize debugify original mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73777b4c35a3: [Debugify] Optimize debugify original mode (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115622: [Debugify] Optimize debugify original mode

djtodoro updated this revision to Diff 416438. djtodoro added a comment. Herald added a project: All. - Move the skipping into the for-loop since we want to collect metadata for the functions that are not observed in the previous Pass (for example the function wasn't of interest due to having an

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

djtodoro added a comment. Hmmm... if this should be done within compiler side, I am wondering whether this should be resolved in AsmPrinter/DwarfDebug instead. @aprantl please let me know wyt? However, it looks like that after this hack the `name` here isn't the appropriate one... and it looks

[PATCH] D115510: [clang][OpenMP][DebugInfo] Debug support for variables in shared clause of OpenMP task construct

djtodoro accepted this revision. djtodoro added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:-4446 +// Generate llvm.dbg.declare for each shared variable and +// DIExpression = metadata !DIExp

[PATCH] D115622: [Debugify] Optimize debugify original mode

djtodoro created this revision. djtodoro added reviewers: Orlando, StephenTozer. djtodoro added projects: debug-info, LLVM. Herald added subscribers: ormris, hiraditya. djtodoro requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. B

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114631/new/ https://reviews.llvm.org/D114631 ___ cfe-commits mailing list

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114504/new/ https://reviews.llvm.org/D114504 ___ cfe-commits mailing list cfe-commi

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. This looks reasonable to me (some nits included). Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513 Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; }); +if (auto *DI = CGF.getDebugInfo()) { + DI->EmitDecla

[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

djtodoro added a comment. Thanks for doing this! Can you please update the summary, since it hard to read with the format like this (at least, just try to reformat the debugger output properly with the Phabricator formatters)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

djtodoro added a comment. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro abandoned this revision. djtodoro added a comment. In D108618#2968626 , @rjmccall wrote: > Does LLVM model `noinline` as a call-site attribute in the way that would be > necessary to get that effect? Also, are you actually having a problem here

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro added a comment. In D108618#2964265 , @rjmccall wrote: > Why do you want to add `noinline` to a function declaration that lacks a > definition? If this won't be used at all I guess the compiler should throw a warning at least. One example come

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

djtodoro created this revision. djtodoro added a reviewer: rjmccall. djtodoro added projects: clang, LLVM. djtodoro requested review of this revision. The `CodeGen` is missing to add the `NoInline` attribute to the target of a call, even the declaration has the __attribute__ presented. This fixes

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2669576 , @dblaikie wrote: > In D99160#2668977 , @djtodoro wrote: > >> I think that the Debug Entry Values feature should not be enabled by default >> for non optimized code, so

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. I think that the Debug Entry Values feature should not be enabled by default for non optimized code, so the `TargetOptions::ShouldEmitDebugEntryValues()` should be patched with checking of optimization level (it should be > 0). CHANGES SINCE LAST ACTION https://revi

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2666104 , @alok wrote: > In D99160#2666068 , @djtodoro wrote: > >> In D99160#2666066 , @alok wrote: >> >>> In D99160#2665580

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. In D99160#2666066 , @alok wrote: > In D99160#2665580 , @probinson wrote: > >> FastISel is normally used only at -O0, I wouldn't expect any parameters to >> be optimized out at -O0. >> The

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8420a5332486: [Debugify] Expose original debug info preservation check as CC1 option (authored by djtodoro). Repository:

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Thanks. I feel like this is ready to go. Any additional comment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

djtodoro added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) I am

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 332679. djtodoro added a comment. - addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h c

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added inline comments. Comment at: clang/include/clang/Driver/Options.td:4872 + "optimizations.">; +def fverify_debuginfo_preserve_export +: Joined<["-"], "fverify-debuginfo-preserve-export=">, jansvoboda11 wrote: > Please, update the n

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. Cool -- thanks for working on this! Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) I think t

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 329972. djtodoro added a comment. - rebase on top of trunk - refactor the code ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 326005. djtodoro retitled this revision from "[VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option" to "[Debugify] Expose original debug info preservation check as CC1 option". djtodoro added a comment. Herald added subscribers: jans

[PATCH] D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option

djtodoro updated this revision to Diff 294658. djtodoro added a comment. -Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/include

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 292469. djtodoro added a comment. - Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. nit included, otherwise lgtm, thanks! Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:45 + ~LiveDebugValues() + { +if (TheImpl) is

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 277781. djtodoro added a comment. Herald added a subscriber: dang. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 276398. djtodoro added a comment. - Rebase on top of D83391 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: djtodoro wrote: > vsk wrote: > > Please factor out OptCustomPassMa

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked 2 inline comments as done. djtodoro added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:855 +class ClangCustomPassManager : public legacy::PassManager { +public: vsk wrote: > Please factor out OptCustomPassManager from opt and g

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

djtodoro added a comment. Please add a test case for the Driver option (you can take a look into existing ones within `clang/test/Driver/`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83048/new/ https://reviews.llvm.org/D83048 __

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ aprantl wrote: > I think this is redundant?

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274690. djtodoro added a comment. - Remove redundant line from the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/Code

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274433. djtodoro added a comment. - Add the Driver test - Remove the old high level test in order to avoid troubles when someone updates an LLVM pass with the impact on Debugify output (e.g. a new debug info bugs) - clang-formatted CHANGES SINCE LAST ACTI

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Co

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > ap

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274054. djtodoro added a comment. -Update the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro created this revision. djtodoro added reviewers: vsk, aprantl, dblaikie, probinson. djtodoro added projects: debug-info, LLVM. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. djtodoro added a parent revision: D82546: [Debugify][OriginalMode] Export the

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. Thanks for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

This revision was automatically updated to reflect the committed changes. Closed by commit rG40a3fcb05c83: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:' (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8036

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47 -// The forward declaration should not be in the module scope. -// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file - --

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 266776. djtodoro added a comment. -Tests clean up CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-call.c clang/test/Module

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2057866 , @dblaikie wrote: > Not sure I follow - why was it a problem that there was no DISubprogram at > all? Actually, since the DISubprograms from the retained types don't affect the final DWARF, it's not a proble

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. >> @dblaikie wrote: > > ... At least for the C++ test, this change makes it pass: > > diff --git clang/test/Modules/ModuleDebugInfo.cpp > clang/test/Modules/ModuleDebugInfo.cpp > index 26369c89605..b1ffe27ec22 100644 > --- clang/test/Modules/ModuleDebugInfo.cpp >

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. In D80369#2050022 , @dblaikie wrote: > In D80369#2048932 , @djtodoro wrote: > > > Still have test failing: > > > > Clang :: Modules/DebugInfoTransitiveImport.m > > Clang :: Modules/Modu

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265722. djtodoro retitled this revision from "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "[DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. -Remove the decls only in the case of call-sit

[PATCH] D80369: WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

djtodoro updated this revision to Diff 265481. djtodoro retitled this revision from "[DebugInfo] Remove decl subprograms from 'retainedTypes:'" to "WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'". djtodoro added a comment. Still have test failing: Clang :: Modules/DebugInfoTra

[PATCH] D80369: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

djtodoro created this revision. djtodoro added reviewers: dblaikie, aprantl, vsk. djtodoro added projects: LLVM, debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. After the D70350 , the `retainedTypes:` isn't being used for the pur

[PATCH] D79967: Fix debug info for NoDebug attr

djtodoro added a comment. This seems reasonable, so this change looks good to me! @dblaikie Thanks for pointing out to the potential problems of the usage of the func decl !dbg in the purpose of call sites debug info. It is currently being stored into CU's retainedTypes field. > That's why DIS

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

This revision was automatically updated to reflect the committed changes. Closed by commit rG170ac4be3392: [CSInfo][ISEL] Call site info generation support for Mips (authored by djtodoro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1933985 , @djtodoro wrote: > Oh sorry, I thought it all has been fixed, since all the tests pass. > > We should revert the D75036 until we fix > all the issues. @dstenb do you agree?

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Oh sorry, I thought it all has been fixed, since all the tests pass. We should revert the D75036 until we fix all the issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1934105 , @vsk wrote: > In D73534#1933988 , @djtodoro wrote: > > > In D73534#1933985 , @djtodoro > > wrote: > > > > > Oh sorry, I thought

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Re-enabled with the d9b962100942 . If we face a failure again, since this enables the whole feature, I recommend reverting smaller pieces of the feature that was causing the problem, rather than reve

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Since we landed the fix for the issue related to the D75036 , I'll reland this again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ c

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Why reverting this one? Is it a different assertion? The D75036 was the problem with the previous issue reported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1916309 , @djtodoro wrote: > In D73534#1916291 , @djtodoro wrote: > > > In D73534#1915048 , @mstorsjo > > wrote: > > > > > This broke com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1915048 , @mstorsjo wrote: > This broke compiling for mingw, repro.c: > > a(short); > b() { a(1); } > > > `clang -target x86_64-w64-mingw32 -c repro.c -g -O2`, which gives `Assertion > '!MI.isMoveImmediate() && "Une

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1916291 , @djtodoro wrote: > In D73534#1915048 , @mstorsjo wrote: > > > This broke compiling for mingw, repro.c: > > > > a(short); > > b() { a(1); } > > > > > > `clang -target

[PATCH] D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc15c68abdc6f: [CallSiteInfo] Enable the call site info only for -g + optimizations (authored by djtodoro). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. @ostannard Thanks for reporting that! Please share the case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Nice! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted again with rG2f215cf36adc . The investigation is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1883022 , @nickdesaulniers wrote: > In D73534#1882136 , @djtodoro wrote: > > > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > > reduced the test >

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. In D73534#1882118 , @dstenb wrote: > In D73534#1881353 , @nickdesaulniers > wrote: > > > As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on > > this change. I see

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245345. djtodoro added a comment. - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've reduced the test `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. I’ve already reverted the patch, but I’ll reland it again tomorrow. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Thanks for reporting that, are you sure this was the cause of the failure? I'll revert this while investigate, but it does not seem to me this is related to this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro updated this revision to Diff 245123. djtodoro added a comment. -Addressing the latest comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Option

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Option

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Reverted due to http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/21373/steps/build-stage3-compiler/logs/stdio. I will reland this as soon as I fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6ff07f8a39: [DebugInfo] Enable the debug entry values feature by default (authored by djtodoro). Herald added subscribers: lldb-commits, cfe-commits, jrtc27. Herald added projects: clang, LLDB. Changed

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added a comment. @awpandey Thanks for doing this, but could you please explain the motivation of implementing this? Can we use is (somehow) to generate more variables with the `DW_AT_const_value`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.o

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:61 HANDLE_DI_FLAG((1 << 29), AllCallsDescribed) +HANDLE_DI_FLAG((1 << 30), ConstExpr) We are almost out of space here... I wouldn't add any additional flag here before we do n

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added a comment. I agree, we must pay attention and address the bitcode compatibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.org/D73261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

djtodoro added a comment. > Is it necessary to use DIFlags? I am willing to do that but generally, it is > not welcomed because we have a limited number of DIFlags and most of them are > currently in use. Are there any flags within `DIFlags` that could be applied only to functions? If so, we s

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

djtodoro added a comment. I guess this should be closed? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1f95a6e077: Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag" (authored by djtodoro). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Git

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro added a comment. @vsk I have created the bug (llvm.org/pr44059), do you think this is OK? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro updated this revision to Diff 230054. djtodoro added a comment. -Update the lldb test for the entry values feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInf

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro added a comment. I will do that way. Yes, only the entry values test fails, so we should skip only that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 ___ cfe-commits mailing list cfe-

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro updated this revision to Diff 229495. djtodoro added a comment. -Add the workaround in the LLDB test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68206/new/ https://reviews.llvm.org/D68206 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h clang/te

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

djtodoro reopened this revision. djtodoro added a comment. This revision is now accepted and ready to land. After landing this, I see one LLDB test depends on this. I made a workaround to avoid testing it at the moment. I will remove the workaround when landing the D68209

[PATCH] D68206: [clang] Remove the DIFlagArgumentNotModified debug info flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1643734741d2: [clang] Remove the DIFlagArgumentNotModified debug info flag (authored by djtodoro). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

djtodoro added a comment. I think that it sounds reasonable to avoid declaration subprograms for functions with reserved names, so that part looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added a comment. @awpandey Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

djtodoro added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:803 + if (Tag == dwarf::DW_TAG_typedef && DD->getDwarfVersion() >= 5) { +uint32_t AlignInBytes = DTy->getAlignInBytes(); Please add a comment here. Com

[PATCH] D69743: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. @vsk Thanks for this! (lgtm) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69743/new/ https://reviews.llvm.org/D69743 ___ cfe-commit

  1   2   >