[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

domada added a comment. Hi, thank you for your contribution. Could you fix assertion failure which was reported by Clang CI ( https://buildkite.com/llvm-project/premerge-checks/builds/166519#01898852-f9c9-4dd2-9933-b32be792c976 ) ? `Assertion failed: OpenMPRuntime != nullptr, file C:\ws\w9\llvm

[PATCH] D156423: [OMPIRBuilder] Fix module finalization

domada created this revision. domada added reviewers: jsjodin, skatrak, agozillon, kiranchandramohan, kiranktp, NimishMishra, TIFitis, raghavendhra, dpalermo, jdoerfert. domada added a project: OpenMP. Herald added subscribers: gysit, Dinistro, bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada abandoned this revision. domada added a comment. Herald added subscribers: gysit, Dinistro. Patch not needed. Preprocessor change: https://reviews.llvm.org/D153910 enables passing information about original source file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151445/new/ h

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada updated this revision to Diff 532588. domada edited the summary of this revision. domada added a comment. Patch rebased. Detailed discussion about the need of introduction of the new flag can be found on LLVM discourse

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada added a comment. In D151445#4372892 , @clementval wrote: > You should be able to get this information from the source location in MLIR. Hi, thank you for your quick feedback. You are right, the source location is provided in MLIR. Unfortunately,

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada created this revision. domada added reviewers: awarzynski, kiranchandramohan, jsjodin, kiranktp, agozillon, skatrak, TIFitis, RogerV-AMD, NimishMishra, raghavendhra, dpalermo. domada added a project: Flang. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdas

[PATCH] D147321: [RFC][Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063 + } +} + jdoerfert wrote: > jdoerfert wrote: > > Style `F` > Why does this belong here? We should do it like clang, one function at a > time, or in a generic place. This is

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGd93bdd8bd52a: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate… (authored by domada). Changed prior to commit: https://reviews.llvm.org/D150354?vs=522999&id=523732#toc Repository:

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4348785 , @kiranchandramohan wrote: > In D150354#4342146 , @domada wrote: > >> In D150354#4337148 , @awarzynski >> wrote: >> >>> All i

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522999. domada added a comment. Change the default version of OpenMP version flag to 1.1 for flang. Modify the flag description text. No changes for Clang code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D1503

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4337148 , @awarzynski wrote: > All in all LGTM, but I'm not sure whether Flang should be defaulting to > OpenMP 5.0. AFAIK, that's not supported yet. If you wish I can set to OpenMP 4.5. But then we need to have two s

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522157. domada added a comment. Patch rebased because I applied remarks for parent revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 521282. domada added a comment. Patch rebased + clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/in

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 521251. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/include/flang/Fro

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada created this revision. domada added reviewers: kiranchandramohan, kiranktp, dpalermo, NimishMishra, skatrak, agozillon, raghavendhra. domada added projects: Flang, OpenMP, MLIR. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota

[PATCH] D148525: [OpenMP][AMDGPU] Refactor setting uniform work group size attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGf90056767828: [OpenMP][AMDGPU] Refactor setting uniform work group size attribute (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148525/

[PATCH] D147321: [Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada updated this revision to Diff 515259. domada added a comment. Herald added a subscriber: bviyer. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147321/new/ https://reviews.llvm.org/D147321 Files: clang/lib/CodeGen/CodeGenFunction.cpp llvm/include/llvm/Frontend/O

[PATCH] D148525: [OpenMP][AMDGPU] Refactor setting uniform work group size attribute

domada created this revision. domada added reviewers: jsjodin, ronlieb, dpalermo, JonChesterfield, agozillon, gregrodgers, skatrak, raghavendhra, RogerV-AMD, saiislam. domada added projects: OpenMP, AMDGPU. Herald added subscribers: sunshaoce, kosarev, guansong, hiraditya, tpr, dstuttard, yaxunl,

[PATCH] D147321: [Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

domada created this revision. domada added reviewers: dpalermo, skatrak, TIFitis, RogerV-AMD, kiranchandramohan, agozillon, kiranktp, NimishMishra. domada added projects: Flang, OpenMP. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr,

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGe43247dd329c: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver (authored by domada). Changed prior to commit: https://reviews.llvm.org/D145579?vs=508977&id=509233#toc Repository: rG LLVM

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added a comment. In D145579#4226542 , @tschuett wrote: > I wanted to ask whether you want to put an AMDGPU.cpp and AMD.cpp file in the > flang/lib/Frontend directory. @tschuett No, I don't plan to modify f

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked 2 inline comments as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:149 +err.print(errorMsg.data(), llvm::errs()); +unsigned diagID = ci.getDiagnostics().getCustomDiagID( +clang::DiagnosticsEngine::Error, "Unsu

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508977. domada added a comment. Patch rebased and added new test for checking incorrect wavefront sizes AMDGPU target features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targ

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added a comment. In D145579#4224157 , @tschuett wrote: > Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From > the conversation, there seems to be more target specific behaviours. @tschuett No. I don't plan to further ref

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508660. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/Tool

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend. + // That's why we need to extract impli

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508618. domada retitled this revision from "[Flang][AMDGPU] Add support for AMDGPU to Flang driver" to "[Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Rebase & applied review

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend.

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:93 +std::string CodeGenAction::getAllTargetFeatures() { + std::string allFeaturesStr; awarzynski wrote: > This method could be simplified

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 507333. domada retitled this revision from "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Applied remarks.

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada added a comment. D146612 presents the lowering from MLIR attributes to LLVM IR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits mailing list

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 507269. domada retitled this revision from "[WIP][Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect". domada added a comment. Patch rebased CHANGES SINCE LAST ACTION

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada updated this revision to Diff 503672. domada added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/T

[PATCH] D145579: [Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect

domada created this revision. domada added reviewers: jsjodin, agozillon, skatrak, TIFitis, kiranktp, dpalermo, kiranchandramohan, NimishMishra, awarzynski. domada added projects: Flang, OpenMP, MLIR, AMDGPU. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, kosarev, sdasgup3

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaca3c150733: Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://revie

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. In D141910#4112164 , @tschuett wrote: > For AArch64 the default alignment is 0? I would have expected 128. The refactored function `TargetInfo::getSimdDefaultAlign` is used only for calculation of default alignment for `#pragma o

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada added a comment. @akyrtzi Thank you for your feedback. Can I land the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495627. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/ASTContext.cpp clang/lib/AST/CMakeLists.txt

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495609. domada added a reviewer: akyrtzi. domada added a comment. Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue reported by @akyrtzi . I modified CMakeLists.txt so that it requires generation of missing `Attributes.inc`. @akyrtzi P

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo CH

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada created this revision. domada added reviewers: dpalermo, skatrak, kiranktp, RogerV-AMD, NimishMishra, jsjodin. Herald added subscribers: pmatos, asb, guansong, kbarton, hiraditya, jgravelle-google, sbc100, yaxunl, nemanjai, dschuff. Herald added a project: All. domada requested review of t

[PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada). Herald added projects: clang, LLDB. Heral

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. domada marked an inline comment as done. Closed by commit rGccd314d3209a: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder (authored by domada). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked 2 inline comments as done. domada added inline comments. Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69 +// CHECK: omp_loop.preheader: +// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align" +// CHECK-NEXT:br label [[OMP_LOOP_HEADER:%.*]]

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 468134. domada added a comment. 1. Changed DenseMap to MapVector. MapVector provides that the iteration order is the same as insertion order CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/l

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1871 + } +} +TEST_F(OpenMPIRBuilderTest, ApplySimdlen) { jdoerfert wrote: > This doesn't actually test that 2 assumes with alignmen

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 466774. domada marked an inline comment as done. domada added a comment. 1. Update description of AlignedVars argument CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2640 if (UseOMPIRBuilder) { +llvm::DenseMap AlignedVars; // Emit the associated statement and get its loop representation. ---

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 466766. domada edited the summary of this revision. domada added a comment. 1. Modified generation of align assumptions. OMPIRBuilder generates now only assumptions calls. The arguments of the assumption calls are generated by Clang. 2. Added integration test

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + jdoerfert wrote: > domada wrote: > > jdoerfert wrote: > > > domada wrote: > > > > jdoerfert wrote: > > > > > This doesn't work. Use th

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 465332. domada added a comment. Patch rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Front

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

This revision was automatically updated to reflect the committed changes. Closed by commit rG6842d3501266: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for… (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada updated this revision to Diff 464952. domada added a comment. Remove custom enum for mapping `order(concurrent)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134046/new/ https://reviews.llvm.org/D134046 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/irbuilder_s

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 464924. domada added a comment. Add assert to ensure that alignment value is always specified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp llvm/include/llvm

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + jdoerfert wrote: > domada wrote: > > jdoerfert wrote: > > > This doesn't work. Use the data layout for any default values please. > >

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada updated this revision to Diff 464648. domada retitled this revision from "[OpenMP] Add support for order(concurrent) to OMPIRBuilder for SIMD directive" to "[OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive". domada added a comment. Herald added a

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 464640. domada marked an inline comment as done. domada retitled this revision from "[OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder" to "[OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder". domada added a comme

[PATCH] D134046: [OpenMP] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada created this revision. domada added reviewers: kiranchandramohan, kiranktp. domada added a project: OpenMP. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aart

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada marked an inline comment as done. domada added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:629 + llvm::ArrayRef AlignedVars, + llvm::Value *Alignment, Value *IfCond, ConstantInt *Simdlen, C

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 459697. domada added a comment. Applied review remarks. Scope of changes: 1. replaced ArrayRef AlignedVars, Value * Alignment arguments with DenseMap. It allows to generate different alignment assumption for different variables. OpenMP allows to specify mult

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada created this revision. domada added a reviewer: kiranchandramohan. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

domada added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2598 for (OMPClause *C : S.clauses()) { // Currently only simdlen clause is supported +if (!(isa(C) || isa(C))) Could you update this comment? Comment at:

[PATCH] D129368: [mlir][OpenMP] Lower simd if clause to LLVM IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. domada marked an inline comment as done. Closed by commit rGd90b7bf2c53d: Add support for lowering simd if clause to LLVM IR (authored by domada). Herald added a projec

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

domada added inline comments. Comment at: clang/test/OpenMP/irbuilder_simd.cpp:15 P pp; -#pragma omp simd +#pragma omp simd simdlen(3) for (int i = 3; i < 32; i += 5) { Could you add separate test case instead of modifying existing test case? Repository: