[PATCH] D8484: Allow -gsplit-dwarf for all ELF targets, not just Linux

emaste abandoned this revision. emaste added a comment. Herald added a project: All. Allowed for all ELF OSes as of commit ee957e045f526ce45d24b0f081f277262c3da43d Author: Fangrui Song Date: Thu Mar 28 08:24:00 2019 + [Driver] Allow -gsplit-dwarf on ELF OSes other than Linux

[PATCH] D158920: Delete CloudABI support

emaste added a comment. In D158920#4620361 , @brad wrote: > Looking for any feedback from the FreeBSD guys. Sorry for no reply earlier, I was away for some of the summer and missed this originally. While CloudABI was a very interesting FreeBSD-related p

[PATCH] D135171: FreeBSD: enable __float128 on x86 and powerpc64le

emaste added a comment. Looks like this still needs someone to push it -- @brooks if you rebase and send to GitHub I cna pick it up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

emaste added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3090 if (!EffectiveTriple.isOSLinux()) return; Why is this limited to `isOSLinux()` only? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96007/new/ https://reviews

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

emaste added a comment. > The time_t value may be negative True, but we do not need to allow a negative `SOURCE_DATE_EPOCH` though. The spec implies that it must be nonnegative, although doesn't say so explicitly. https://reproducible-builds.org/specs/source-date-epoch/ Repository: rG LLVM

[PATCH] D135171: FreeBSD: enable __float128 on x86

emaste accepted this revision. emaste added a comment. OK. I think the switch will become unwieldy if additional arch-dependent things are added but could be dealt with then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://review

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Herald added a project: All. The original author appears to have given up on it. Someone will need to rebase and work on pushing it forward CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rGb41bb6c1b715: [Driver] Default to contemporary FreeBSD profiling behaviour (authored by emaste). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

emaste added a subscriber: myfreeweb. emaste added a comment. Similar idea to D6 (libc++ default if major not specified) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114396/new/ https://reviews.llvm.org/D114396 ___

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

emaste created this revision. emaste added a reviewer: dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. FreeBSD provided special _p.a libraries for use with -pg prior to FreeBSD 14. They are no longer used or provided. If the target does not spe

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dec2aa3ad08: [Driver] Default to libc++ on FreeBSD (authored by jbeich, committed by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added inline comments. Comment at: clang/test/Driver/freebsd.cpp:13-14 +// RUN: | FileCheck --check-prefix=CHECK-PG-DEFAULT %s // RUN: %clangxx %s -### -pg -o %t.o -target amd64-unknown-freebsd14.0 -stdlib=platform 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PG-

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste updated this revision to Diff 388931. emaste added a comment. rebase tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/test/Driver/freebsd.cpp Index: clang/test/Driver/freebsd

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

emaste added a comment. In D111863#3100654 , @lhames wrote: > @joerg @dim @emaste Any further comments on this? I have no objection. 2016 (when I patched FreeBSD's in-tree libunwind) is long enough ago that I don't recall any of the context but indeed

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6609892a2dcd: [clang] allow -fstack-clash-protection on FreeBSD (authored by emaste). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

emaste added a comment. Superseded by e67cbac81211d40332a79d98c9d5953624cc1202 (D68720 ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/ https://revi

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

emaste added a comment. We make this change in FreeBSD's in-tree Clang about 9 months ago (https://reviews.freebsd.org/D27366) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108571/new/ https://reviews.llvm.org/D108571 ___ cfe-commits mailing

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

emaste created this revision. emaste added reviewers: serge-sans-paille, craig.topper, dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. `-fstack-clash-protection` was added in Clang commit e67cbac81211

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG699d47472c3f: [Driver] do not link _p libs for -pg on FreeBSD 14 and later (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste added a comment. `-pg` is still supported (see the `OPT_pg` at line 253), gprof just won't be able to "see into" libc, libm, etc. For example a trivial test case calling snprintf and strcmp in a loop, on FreeBSD 11 with _p libs: % cumulative self self total

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste created this revision. emaste added a reviewer: dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In FreeBSD 14 we plan to deprecate the _p.a special profiling libraries -

[PATCH] D97752: Fix -gz=zlib options for linker for FreeBSD too

This revision was automatically updated to reflect the committed changes. Closed by commit rG462cf39a5c18: [Driver] Fix -gz=zlib options for linker also on FreeBSD (authored by emaste). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

[PATCH] D87321: Fix -gz=zlib options for linker

emaste added a comment. I just ran into this issue on FreeBSD, bug report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253942 clang/lib/Driver/ToolChains/FreeBSD.cpp needs updating for this change also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D89490: Introduce __attribute__((darwin_abi))

emaste added a comment. > For now, only Linux/ARM64 is supported/tested. Is there any reason this is Linux-specific (as far as support; I understand if it's not easy for you to test on non-Linux arm64). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. > I think it's ok to only warn on Windows. IMO that's sensible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing li

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. > How do things go wrong on Darwin? I was under the impression that this was > implemented in LLVM as strictly inline code, no runtime support required. That is my impression as well (although it seems that an earlier version might have emitted calls to a stack probe rou

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 _

[PATCH] D68720: Support -fstack-clash-protection for x86

emaste added inline comments. Herald added subscribers: dexonsmith, pengfei. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) +return; + Is there anything OS-dependent here? I plan to add `EffectiveTriple.isO

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Herald added a subscriber: arichardson. running `clang -target x86_64-unknown-freebsd13.0 -split-dwarf foo.c` indeed produces a foo.dwo and foo.o w/o invoking objcopy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 _

[PATCH] D89859: Remove .svn from exclude list as we moved to git

emaste added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

emaste added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: Bdragon28 wrote: > B

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

emaste added a comment. It looks like this conflicts with OpenSSL's compiler version check - https://svnweb.freebsd.org/changeset/base/364822 - https://lists.freebsd.org/pipermail/svn-src-all/2020-August/201804.html We've fixed it in FreeBSD and the change "should" happen upstream, but somethin

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

emaste added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: List was previously

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Fine with me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83645/new/ https://reviews.llvm.org/D83645 ___

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Looks ok to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 _

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added a comment. In D6#1981271 , @jbeich wrote: > - Limit the scope to `-stdlib` > > In D6#1972543 , @dim wrote: > > > the lowest supported version, which is currently 10 > > > Where is this defined?

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

emaste added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:69 + --version - Display the version of this program + -D- Use zero for timestamps and uids/gids (default) + -U- Use actual timestamps and uids/gids ---

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

emaste added a comment. Should have a test added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D70157: Align branches within 32-Byte boundary

emaste added a comment. > I think the default policy discussion might be better had on llvm-dev than a > Phab review. Ok, I agree with that, and also think it's useful to get this patch committed independent of a change to the defaults, which can be handled in a subsequent review. CHANGES SI

[PATCH] D70110: [Driver][FreeBSD] Enable unwind tables on !amd64

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb1761465a0d: clang: enable unwind tables on FreeBSD !amd64 (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70110/new/ https://reviews.l

[PATCH] D70157: Align branches within 32-Byte boundary

emaste added a comment. > Shall we default to -mbranches-within-32B-boundaries if the specified -march= > or -mtune= may be affected by the erratum? I think we should enable it based on `-mtune` specifying an affected CPU (and implicitly based on `-march` if `-mtune` is not specified). CHANGE

[PATCH] D60748: Fix i386 struct and union parameter alignment

emaste added a comment. In D60748#1499756 , @dim wrote: > Please also exclude FreeBSD from these changes, since we care a lot about > backwards compatibility, and specifically about alignment requirements. (We > have run into many issues in our ports co

[PATCH] D46791: Make -gsplit-dwarf generally available

emaste added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46791/new/ https://reviews.llvm.org/D46791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57795: [RISCV] Add FreeBSD targets

emaste added inline comments. Comment at: lib/Basic/Targets.cpp:379 return new LinuxTargetInfo(Triple, Opts); -return new RISCV32TargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); My usual peda

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

emaste added a subscriber: arichardson. emaste added a comment. Herald added a project: clang. In D50294#1246980 , @MaskRay wrote: > In D50294#1245454 , @emaste wrote: > > > I'm using this change: > > https://githu

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

emaste added a comment. > There is a list of 140-150 unsafe (LLD_UNSAFE) packages with LLD. Some of these are tagged with a PR or comment explaining why they are LLD_UNSAFE, but we haven't done it consistently. Some of these 140-150 were probably added in the early days of bringing lld into Fre

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

emaste added a comment. I think the arch-change (switching from a whitelist to a MIPS blacklist) is reasonable. What is the motivation for dropping `DT_HASH`, just binary size reduction? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.l

[PATCH] D52703: Allow ifunc resolvers to accept arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rC344100: clang: Allow ifunc resolvers to accept arguments (authored by emaste, committed by ). Repository: rC Clang https://reviews.llvm.org/D52703 Files: include/clang/Basic/AttrDocs.td include/cl

[PATCH] D52696: Update ifunc attribute support documentation

emaste added a comment. Maybe "available for some architectures in at least..."? Or maybe we shouldn't bother trying to list versions, and mention it is dependent on CPU arch, linker, and rtld? Repository: rL LLVM https://reviews.llvm.org/D52696 __

[PATCH] D52703: Allow ifunc resolvers to accept arguments

emaste created this revision. emaste added a reviewer: DmitryPolukhin. Herald added a reviewer: javed.absar. Herald added subscribers: kristof.beyls, krytarowski. When ifunc support was added to Clang (in https://reviews.llvm.org/rC265917) it did not allow resolvers to take function arguments. Th

[PATCH] D52696: Update ifunc attribute support documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL343408: Update ifunc attribute support documentation (authored by emaste, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52696?vs=167626&id=1

[PATCH] D52696: Update ifunc attribute support documentation

emaste created this revision. emaste added a reviewer: DmitryPolukhin. Herald added a subscriber: krytarowski. We documented GNU binutils and glibc versions required for ifunc support, but our own lld linker and FreeBSD's rtld also support ifuncs. https://reviews.llvm.org/D52696 Files: inclu

[PATCH] D50294: [Driver] Use -gdwarf-3 by default for FreeBSD

emaste added a comment. I'm using this change: https://github.com/emaste/freebsd/commit/1c3deab6d518feb1a7e88de5b342a139e4022a21 In FreeBSD 12 and later we use Clang, lld, and ELF Tool Chain. (We still have gas and objdump from the outdated binutils 2.17.50.) Repository: rC Clang https://r

[PATCH] D42645: New simple Checker for mmap calls

emaste added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until th

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

emaste accepted this revision. emaste added a comment. In https://reviews.llvm.org/D43378#1010574, @devnexen wrote: > As I see only x86_64 arch implements everything (e.g. custom event), making > things easier maybe. arm family might be enabled, power pc might need to > rewrite as x86_64 arch s

[PATCH] D42645: New simple Checker for mmap calls

emaste added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until th

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

emaste added a comment. LGTM with one small note. What will it take for us to enable this on the rest of the platforms Clang/FreeBSD supports? Comment at: test/Driver/XRay/lit.local.cfg:7-8 supported_targets = [ 'x86_64', 'x86_64h', 'arm', 'aarch64', 'arm64', 'powerpc64

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

emaste added a comment. Please upload reviews with context (e.g. `git diff -U9`, `git show -U9`, or `svn diff -x -U99`). See https://llvm.org/docs/Phabricator.html for more info. Comment at: lib/Driver/XRayArgs.cpp:60 D.Diag(diag::err_drv_clang_unsupported)

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on Linux

emaste added a comment. The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will also use llvm-objcopy. Repository: rC Clang https://reviews.llvm.org/D41930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Ping? https://reviews.llvm.org/D23934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38900: libunwind: document tested FreeBSD configs and sort OS list

This revision was automatically updated to reflect the committed changes. Closed by commit rL315814: libunwind: document tested FreeBSD configs and sort OS list (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D38900?vs=118958&id=119031#toc Repository: rL LLVM https:/

[PATCH] D38900: libunwind: document tested FreeBSD configs and sort OS list

emaste added a subscriber: bsdjhb. emaste added a comment. In https://reviews.llvm.org/D38900#897304, @krytarowski wrote: > @joerg might have insight on ppc, sparc64, arm on NetBSD. And @bsdjhb for other architectures on FreeBSD. But I wanted to at least list x86_64 and ARM64 for FreeBSD, wher

[PATCH] D38900: libunwind: document tested FreeBSD configs and sort OS list

emaste created this revision. Herald added subscribers: kristof.beyls, krytarowski, aemerson. libunwind is known to work on FreeBSD/amd64 and FreeBSD/arm64, and is the default unwinder on both of those architectures. While here sort the OS list. https://reviews.llvm.org/D38900 Files: docs/i

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. > My concern is that the stock gcc distributions for FreeBSD, NetBSD from your > sources doesn't define __mips_abicalls, I think we should consider that a bug in GCC that we'll rectify. If `__mips_abicalls` is used in Linux GCC then we can expect 3rd party sources to ch

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. In https://reviews.llvm.org/D29032#654854, @emaste wrote: > As mentioned in https://reviews.llvm.org/D29032 Err, that should be https://reviews.llvm.org/D29024 https://reviews.llvm.org/D29032 ___ cfe-commits mailing list c

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. As mentioned in https://reviews.llvm.org/D29032 I agree with @joerg - `__mips_abicalls` should always be defined if this is what GCC does. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste abandoned this revision. emaste added a comment. Abandon in favour of https://reviews.llvm.org/D23934 https://reviews.llvm.org/D20791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Please also accept `SOURCE_DATE_EPOCH` set in the environment -- see https://reproducible-builds.org/specs/source-date-epoch/ Also although I'm generally leery of options auto-detecting the argument format, I think we should be able to pass an epoch timestamp to -ffixed