emaste added inline comments. Herald added subscribers: dexonsmith, pengfei.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) + return; + ---------------- Is there anything OS-dependent here? I plan to add `EffectiveTriple.isOSFreeBSD()` to FreeBSD-s in-tree Clang https://reviews.freebsd.org/D27366 and intend to upstream the change (with a test), but should we just remove the OS test completely? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits