[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. It's worth noting that accessors in the base APIs don't follow this rule. Should we refactor them as well? In this patch? Examples: class Arena { public: const SourceManager &sourceManager() const { return SourceMgr; }

[PATCH] D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86679 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3d4743277b: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 288010. eduucaldas added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287947. eduucaldas added a comment. answer code-review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas updated this revision to Diff 287889. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86600/new/ https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[PATCH] D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86600 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b75f65e6ba4: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86591 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86544: [SyntaxTree] Add support for call expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2de2ca348dfa: [SyntaxTree] Add support for `CallExpression` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070 +Builder.markChildToken( +std::next(Builder.findToken(S->getCallee()->getEndLoc())), +syntax::NodeRole::OpenParen); gribozavr2 wrote: > Could you add an

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287842. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer code review, squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 F

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:506 | `-'~' -|-'decltype' +|-'decltype' OpenParen |-'(' This is wrong but it's just because decltype is all wrong =

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287694. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Sy

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Add support for all C++ call expressions, including those coming from `operator()`. A call expression's arguments are inside their own node - `Cal

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc655d8081570: [SyntaxTree] Extend the syntax tree dump to also cover `NodeRole` (authored by eduucaldas). Changed prior to commit: https://reviews

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287563. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syntax/B

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287562. eduucaldas added a comment. reorganize and nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/li

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG61273f298f2c: [SyntaxTree] Split `MemberPointer` tests with annotations (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86467/new/ h

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f426c65b06f: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGb493e4cb3e37: [SyntaxTree] Split ConstVolatileQualifiers tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86469/new/ https://re

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287431. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 287430. eduucaldas marked an inline comment as done. eduucaldas added a comment. Update tests to dump role Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: c

[PATCH] D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86470 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D86469: [SyntaxTree] Split ConstVolatileQualifiers tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86469 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/un

[PATCH] D86467: [SyntaxTree] Split `MemberPointer` tests with annotations

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86467 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4baa163c7423: [SyntaxTree] Split `ParametersAndQualifiers` tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90f85dfc14bc: [SyntaxTree] Group tests related to `using` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86443?vs=28

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed83095254a3: [SyntaxTree] Use annotations to reduce noise on member function tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo

[PATCH] D86437: [SyntaxTree] Split array declarator tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8dd506e666: [SyntaxTree] Split array declarator tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa722d6a197c7: [SyntaxTree] Split ExplicitTemplateInstantiation test (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4093d663f83: [SyntaxTree] Split FreeStandingClass tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas updated this revision to Diff 287378. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Template -> ClassTemplate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86441/new/ https://reviews.llvm.org/D86441 Files: c

[PATCH] D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86459 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86443: [SyntaxTree] Group tests related to `using`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86443 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86441 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86440: [SyntaxTree] Split FreeStandingClass tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86440 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86439: [SyntaxTree] Use annotations to reduce noise on member function tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86439 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86437: [SyntaxTree] Split array declarator tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86437 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG1beb11c61ae4: [SyntaxTree] Use annotations in Statement tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86345/new/ https://rev

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. Sorry for doing this after asking for review. I think it might be interesting landing this patch before : https://reviews.llvm.org/D85330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86345 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158 if (!Marks.empty()) OS << Marks << ": "; gribozavr2 wrote: > Maybe the marks should be moved after the primary identifier of the node, > WDYT? That would be more consis

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 286983. eduucaldas added a comment. Adapt Statement tests to new testing infrastructure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files: clang/include/clang/

[PATCH] D86298: [SyntaxTree] Add support for `this`

This revision was automatically updated to reflect the committed changes. Closed by commit rG85c15f17cc68: [SyntaxTree] Add support for `this` (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86298/new/ https://reviews.llvm.or

[PATCH] D86298: [SyntaxTree] Add support for `this`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86298 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e983e24043: [SyntaxTree] Split tests related to Namespace (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

eduucaldas updated this revision to Diff 286823. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86139/new/ https://reviews.llvm.org/D86139 Files: clang/unitt

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

This revision was automatically updated to reflect the committed changes. Closed by commit rGba32915db2ce: [SyntaxTree] Add support for `MemberExpression` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86227?vs=286811&id=286820#toc Repository: rG LLVM Github Mon

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286811. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Unify logic for generating `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:900 + +auto *unqualifiedId = new (allocator()) syntax::UnqualifiedId; +Builder.foldNode(Builder.getRange(S->getMemberLoc(), S->getEndLoc()), -

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286799. eduucaldas marked 10 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/i

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286762. eduucaldas added a comment. Implicit `MemberExpr` generates `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tool

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// expression . template_opt id-expression +/// id-expression +/// e.g. `x.a`, `xp->a` or even just `a` when we have an implicit `this->`.

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas updated this revision to Diff 286593. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syn

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86139 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang/uni

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8c92b54d74c: [SyntaxTree] Use Annotations based tests for expressions (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286259. eduucaldas added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests/T

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.cpp:199 + auto AnnotatedRanges = AnnotatedCode.ranges(); + assert(AnnotatedRanges.size() == TreeDumps.size()); + for (auto i = 0ul; i < AnnotatedRanges.size(); i++) { edu

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286258. eduucaldas added a comment. Fail on non-matching number of tree dumps and annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittest

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286251. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests/Too

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:477 struct X { friend X operator+(const X&, const X&); }; A test for this part was created below Comment at: clang/unittests/Tooling/Syntax/Tree

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 286248. eduucaldas marked 7 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/un

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285632. eduucaldas added a comment. Add annotations to the last missing tests in expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittest

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285629. eduucaldas added a comment. Move added Declaration tests to an appropriate place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Too

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas updated this revision to Diff 285613. eduucaldas added a comment. Previous diff had only the last commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85962/new/ https://reviews.llvm.org/D85962 Files: clang/unittests/Tooling/Syntax/Bu

[PATCH] D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. In this process we also create some other tests, in order to not lose coverage when focusing on the annotated code. Repository: rG LLVM Github

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e4a20fd7062: [SyntaxTree] Split `TreeTestBase` into header and source (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285566. eduucaldas added a comment. remove static inside anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:15-17 +using namespace clang; +using namespace clang::syntax; + Following the [[ https://llvm.org/docs/CodingStandards.html#us

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285421. eduucaldas added a comment. Remove unused `SyntaxTreeTest::addFile` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/B

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285416. eduucaldas added a comment. Fix the diff base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp cla

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285413. eduucaldas added a comment. Switch to using directive on source files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas updated this revision to Diff 285401. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85913/new/ https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests/Too

[PATCH] D85913: [SyntaxTree] Split `TreeTestBase` into header and source

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85913 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/un

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c2e708f0dc5: [SyntaxTree] Clean `#includes` in `TreeTestBase.h` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D8589

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTestBase.h:14 #include "clang/AST/ASTConsumer.h" -#include "clang/AST/Decl.h" -#include "clang/AST/Stmt.h" #include "clang/Basic/LLVM.h" #include "clang/Fr

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas added a comment. We can further split `BuildTreeTest.cpp` for instance in `BuildStatementTest.cpp` and `BuildDeclTest.cpp`, I can't see many arguments towards that though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85897/new/ https:

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas updated this revision to Diff 285342. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85898/new/ https://reviews.llvm.org/D85898 Files: clang/unittests/Tooling/Syntax/MutationsTest.cpp clang/unittests/Too

[PATCH] D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85898 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp clang/unittests

[PATCH] D85897: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We extract the test infrastructure into `TreeTestBase.h` and split the tests into `MutationsTest.cpp` and `BuildTreeTest.cpp` Repository:

[PATCH] D85896: [SyntaxTree] Split `TreeTest.cpp`

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. We extract the test infrastructure into `TreeTestBase.h` and split the tests into `MutationsTest.cpp` and `BuildTreeTest.cpp` Repository:

[PATCH] D85819: [SyntaxTree] Split tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1211fd1ec03: [SyntaxTree] Split tests for expressions (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D85819?vs=28527

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. We'll split this file in a future change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1546-1548 +unsigned operator "" _r(const char*); +template +unsigned operator "" _t(); eduucaldas wrote: > Same setup for `FloatUserDefinedLiteral`. I think it is justified

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2805 -TEST_P(SyntaxTreeTest, UserDefinedBinaryOperator) { +TEST_P(SyntaxTreeTest, UserDefinedOperator_Assignment) { if (!GetParam().isCXX()) { gribozavr2 wrote: > UserD

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285273. eduucaldas marked 11 inline comments as done. eduucaldas added a comment. Answer review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: cla

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285265. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/AST/NestedNam

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas added a comment. Unit tests will be provided once we decide that this is the way to go ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 ___ cfe-commi

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285129. eduucaldas added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpecifier.cpp Index: clang/lib/

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas updated this revision to Diff 285122. eduucaldas added a comment. Don't assume the code is completely correct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85842/new/ https://reviews.llvm.org/D85842 Files: clang/lib/AST/NestedNameSpec

[PATCH] D85842: Fix `NestedNameSpecifierLoc::getLocalSourceRange()`

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. >From the documentation comment above >`NestedNameSpecifierLoc::getLocalSourceRange()` /// Retrieve the source range covering just the last par

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1005 + +TEST_P(SyntaxTreeTest, QualifiedIdWithNamespace) { + if (!GetParam().isCXX()) { Here I didn't merely split the tests, I also changed them a bit. PTAL. ==

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285071. eduucaldas added a comment. Rename tests following `TestSuite_TestCase` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Synt

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285070. eduucaldas added a comment. - [SyntaxTree] Split tests for `QualifiedId` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85819/new/ https://reviews.llvm.org/D85819 Files: clang/unittests/Tooling/Syn

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas updated this revision to Diff 285035. eduucaldas added a comment. Split tests for `UserDefinedLiteral` Split tests for `NumericUserDefinedLiteral` Split tests for `NestedBinaryOperator` Split tests for `UserDefinedBinaryOperator` Split tests for `UserDefinedPrefixOperator` Repository:

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas added a comment. Before we had an UnqualifiedId test that tested for everything in the grammar . Now we just split this test and test the alternatives separately. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:6

[PATCH] D85819: [SyntaxTree] Split tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. We do that because: - Big tests generated big tree dumps that could hardly serve as documentation. - In most cases the tests didn't share setup, t

[PATCH] D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`

This revision was automatically updated to reflect the committed changes. Closed by commit rGac37afa65027: [SyntaxTree] Unbox operators into tokens for nodes generated from… (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8575

<    1   2   3   4   5   >