Re: [PATCH] D16183: Added CheckName field to YAML report

2016-04-12 Thread Ilia Gromov via cfe-commits
Elijah_Th added a comment. alexfh, OK. I'll take a look at apply-replacements and fix if needed, in the beginning of the next week! http://reviews.llvm.org/D16183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-02-09 Thread Ilia Gromov via cfe-commits
Elijah_Th added a comment. YAML report looks like this now: --- MainSourceFile: '' Diagnostics: CheckName: misc-macro-parentheses Replacements: - FilePath:/media/SSD_/code/zdoom/main_1.cpp Offset: 1354 Length: 0 ReplacementText: '('

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-02-09 Thread Ilia Gromov via cfe-commits
Elijah_Th updated this revision to Diff 47302. Elijah_Th added a comment. Fixed YAML format (was not correct in the last patch). Grouped replacements in YAML by Diagnostics. It will help to apply replacements for one fix at once. http://reviews.llvm.org/D16183 Files: /media/SSD_/code/LLVM-c

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-02-04 Thread Ilia Gromov via cfe-commits
Elijah_Th updated this revision to Diff 46883. Elijah_Th added a comment. Now the class that is serialized is Diagnostics. I've moved ClangTidyError and ClangTidyMessage to the upper level, and renamed to Diagnostics and DiagnosticsMessage. Now any tool can use this classes, they contain more in

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-01-18 Thread Ilia Gromov via cfe-commits
Elijah_Th marked 2 inline comments as done. Elijah_Th added a comment. What kind of wrapper should it be? I was thinking of this kind: class ExtendedReplacement : public Replacement { public: ExtendedReplacement(StringRef CheckName, Replacement &R); StringRef getCheckName() const {

Re: [PATCH] D16183: Added CheckName field to YAML report

2016-01-14 Thread Ilia Gromov via cfe-commits
Elijah_Th updated this revision to Diff 44876. Elijah_Th added a comment. - small format changes - removed unnecessary StringRef http://reviews.llvm.org/D16183 Files: tools/clang/include/clang/Tooling/Core/Replacement.h tools/clang/include/clang/Tooling/ReplacementsYaml.h tools/clang/lib/

[PATCH] D16183: Added CheckName field to YAML report

2016-01-14 Thread Ilia Gromov via cfe-commits
Elijah_Th created this revision. Elijah_Th added reviewers: klimek, alexfh, djasper, cfe-commits. Herald added a subscriber: klimek. See details in https://llvm.org/bugs/show_bug.cgi?id=26132 http://reviews.llvm.org/D16183 Files: tools/clang/include/clang/Tooling/Core/Replacement.h tools/cla