[clang] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

@@ -1654,12 +1654,12 @@ void OperationFormat::genElementParser(FormatElement *element, MethodBody &body, dir->shouldBeQualified() ? qualifiedTypeParserCode : typeParserCode; TypeSwitch(dir->getArg()) .Case([&](auto operand) { -body << form

[clang] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/105745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

https://github.com/jpienaar approved this pull request. Nice! https://github.com/llvm/llvm-project/pull/105745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][clang] Move RewriterBuffer to ADT. (PR #99770)

https://github.com/jpienaar closed https://github.com/llvm/llvm-project/pull/99770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][clang] Move RewriterBuffer to ADT. (PR #99770)

https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/99770 >From ee91900dd42321ce1344a70df5f1baddf36bde9f Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sat, 20 Jul 2024 16:25:14 + Subject: [PATCH] [llvm][clang] Move RewriterBuffer to ADT. These classes are n

[clang] [llvm] [llvm][clang] Move RewriterBuffer to ADT. (PR #99770)

https://github.com/jpienaar created https://github.com/llvm/llvm-project/pull/99770 These classes are not specific to clang and useful for other rewriter tools (flagged in previous review). >From 451a4c61066c4a433bc100ebc511dc6447f83ab0 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sat

[clang-tools-extra] [clang] [flang] [llvm] [compiler-rt] [mlir] [mlir][tosa] Add dialect version. (PR #79514)

jpienaar wrote: > > To be able to flag incompatible bytecode files rather than have it fail > > later in mysterious ways. E.g., allows for a more strict failure. > > That would require some sort of principles and policy around the changes that > affect the serialization of this and the mainten

[mlir] [libcxx] [flang] [libc] [clang] [lldb] [llvm] [mlir] Skip invalid test on big endian platform (s390x) (PR #80246)

https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/80246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [flang] [compiler-rt] [clang-tools-extra] [mlir] [clang] [mlir][tosa] Add dialect version. (PR #79514)

jpienaar wrote: > This lack some information to me: > > * What is the purpose of this? To be able to flag incompatible bytecode files rather than have it fail later in mysterious ways. E.g., allows for a more strict failure. > * What kind of compatibility is this supposed to provide? None to

[mlir] [llvm] [clang] [compiler-rt] [flang] [clang-tools-extra] [mlir][tosa] Add dialect version. (PR #79514)

https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/79514 >From 06386cb0d21bb8e210e5ee3eef26df39680fc1d1 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sat, 21 Oct 2023 17:06:33 -0700 Subject: [PATCH] [mlir][tosa] Add dialect version. This adds a singular number

[clang] [clang-tools-extra] [llvm] [libc] [flang] [mlir] [compiler-rt] [libcxx] [mlir][spirv] Implement gpu::TargetAttrInterface (PR #69949)

@@ -15,6 +15,7 @@ #include "Utils.h" #include "mlir/Dialect/GPU/IR/GPUDialect.h" +#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h" jpienaar wrote: This feels off: you have GPU dialect transforms depending on SPIRV attributes/dialect (esp in header). Why is

[clang-tools-extra] [mlir] Add config for PDL (PR #69927)

jpienaar wrote: > Can you expand on the motivation? Why is it a problem that PDL is always > included? Your description isn’t very explicit on the impact. Done. Its not PDL specific, I think it is a problem if any dialect is always included even if not used :) The others just have a simple met

[clang] [mlir] Add config for PDL (PR #69927)

jpienaar wrote: > Can you expand on the motivation? Why is it a problem that PDL is always > included? Your description isn’t very explicit on the impact. Done. Its not PDL specific, I think it is a problem if any dialect is always included even if not used :) The others just have a simple met

[clang-tools-extra] [mlir] Add config for PDL (PR #69927)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/69927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] Add config for PDL (PR #69927)

https://github.com/jpienaar edited https://github.com/llvm/llvm-project/pull/69927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] Add config for PDL (PR #69927)

https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/69927 >From eea36708d838411d70eb99265c3a2f3aabb91460 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sun, 22 Oct 2023 09:33:40 -0700 Subject: [PATCH] [mlir] Add config for PDL Make it so that PDL can be optional

[clang] [mlir] Add config for PDL (PR #69927)

https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/69927 >From eea36708d838411d70eb99265c3a2f3aabb91460 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sun, 22 Oct 2023 09:33:40 -0700 Subject: [PATCH] [mlir] Add config for PDL Make it so that PDL can be optional

[clang-tools-extra] a9f9f3d - Correct typos (NFC)

Author: Sprite Date: 2022-12-16T10:51:26-08:00 New Revision: a9f9f3dff474b7bdb19129eaf625d3ef0084a975 URL: https://github.com/llvm/llvm-project/commit/a9f9f3dff474b7bdb19129eaf625d3ef0084a975 DIFF: https://github.com/llvm/llvm-project/commit/a9f9f3dff474b7bdb19129eaf625d3ef0084a975.diff LOG: C

[clang] 270d580 - [analyzer] Avoid unused variable warning in opt build

Author: Jacques Pienaar Date: 2020-06-12T09:48:49-07:00 New Revision: 270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa URL: https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa DIFF: https://github.com/llvm/llvm-project/commit/270d580a0e9ff2f2e1b6240fccedee7c25dc3bfa.dif

Re: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

How did you come to this conclusion? https://buildkite.com/mlir/mlir-core/builds/2790#9ecce42d-5a20-4e52-8621-c7c0dcee7aa7 is a clean build at e8e078c8bf7987b95298062a644bac9eed26f988 that is just before 1b978ddba05cb15e22b4e75adb5e7362ad861987 (if I look at commits on github) and at fb44b9db95a333

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar accepted this revision. jpienaar added a reviewer: jpienaar. jpienaar added a comment. This revision is now accepted and ready to land. Looks good to me, do you need help submitting? Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1032 @@ +1031,3 @@ + if (!CS) { +

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Cool. I didn't know the review system allows having the patch updated like this :) It still reports me as the author and you as a subscriber. I don't think that matters. Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1033 @@ +1032,3 @@ +

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

@Valentin: It would be great if you could give it a go. I tried resurrecting it earlier today but noticed getDataLayout() had been removed and then I got tied up with other pending work. On Mon, Sep 19, 2016 at 5:11 PM, Valentin Churavy wrote: > vchuravy added a comment. > > @jpienaar are you pl

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Oh, sorry, I didn't see your response before I clicked abandoned. It has been a while, so this patch is pretty stale. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

25, 2016 at 6:46 PM, Kostya Serebryany wrote: > >> +rnk >> >> On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: jpienaar >>> Date: Mon Apr 25 19:09:29 2016 >>> N

r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

Author: jpienaar Date: Mon Apr 25 19:09:29 2016 New Revision: 267496 URL: http://llvm.org/viewvc/llvm-project?rev=267496&view=rev Log: [lanai] Update handling of structs in arguments to be passed in registers. Previously aggregate types were passed byval, change the ABI to pass these in register

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

This revision was automatically updated to reflect the committed changes. jpienaar marked an inline comment as done. Closed by commit rL264655: [lanai] Add Lanai backend to clang driver. (authored by jpienaar). Changed prior to commit: http://reviews.llvm.org/D17002?vs=51806&id=51838#toc Repos

r264655 - [lanai] Add Lanai backend to clang driver.

Author: jpienaar Date: Mon Mar 28 16:02:54 2016 New Revision: 264655 URL: http://llvm.org/viewvc/llvm-project?rev=264655&view=rev Log: [lanai] Add Lanai backend to clang driver. Changes to clang to add Lanai backend. Adds a new target, ABI and toolchain. General Lanai backend discussion on llvm-

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar added a comment. Updated, thanks Comment at: lib/CodeGen/TargetInfo.cpp:6622-6626 @@ +6621,7 @@ + + if (const BuiltinType *BT = T->getAs()) { +BuiltinType::Kind K = BT->getKind(); +if (K == BuiltinType::Float || K == BuiltinType::Double) + return Float; +

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 51806. jpienaar marked 6 inline comments as done. jpienaar added a comment. Removed unnecessary floating point classification (only integer is supported) and performed suggested cleanups. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar added a comment. Friendly ping. http://reviews.llvm.org/D17002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 49969. jpienaar added a comment. Updated to use resetDataLayout. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 49688. jpienaar added a comment. Removed unused variables in LanaiTargetInfo. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/T

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar added reviewers: eliben, jyknight, chandlerc. jpienaar updated this revision to Diff 49119. jpienaar added a comment. Updated preprocessor test init.c to use -match-full-lines. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Drive

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar added inline comments. Comment at: test/CodeGen/lanai-arguments.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple wasm32-unknown-unknown %s -emit-llvm -o - \ +// RUN: | FileCheck %s -check-prefix=LANAI eliben wrote: > why wasm triple? Fixed, thanks. http://r

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated the summary for this revision. jpienaar updated this revision to Diff 48119. jpienaar marked an inline comment as done. jpienaar added a comment. Herald added a subscriber: joker.eph. Move mregparm check to Tools.cpp and correct triple used in test. http://reviews.llvm.org/D1700

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar marked 3 inline comments as done. jpienaar added a comment. Updated thanks. Comment at: lib/CodeGen/TargetInfo.cpp:6498 @@ +6497,3 @@ + + Class classify(QualType Ty) const; + We only had one DefaultNumRegisterParameters that we supported (DefaultNumRe

Re: [PATCH] D17002: [lanai] Add Lanai backend to clang driver

jpienaar updated this revision to Diff 47408. jpienaar added a comment. Added clang-level tests. http://reviews.llvm.org/D17002 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test/CodeGe

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

jpienaar added a comment. @jlebar: We defer it to your and Richard's approval. Thanks http://reviews.llvm.org/D15305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land. Looks good, thanks Comment at: test/CodeGenCUDA/device-vtable.cu:37 @@ +36,3 @@ + virtual void h_method(); + __device__ virtual void d_method(); +}; Doe

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

jpienaar added a comment. Looks good to me. Comment at: lib/AST/RecordLayoutBuilder.cpp:2003 @@ +2002,3 @@ +return nullptr; + if (!Context.getLangOpts().CUDAIsDevice && !MD->hasAttr() && + MD->hasAttr()) Add a comment to explain asymmetry.

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

jpienaar added a comment. Nice, so this will allow parsing/AST construction with builtins from 2 architectures but will fail to compile if a builtin for the host/device is called from device/host. You mention this is not generally possible. Can you give some examples? Comment