[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed an updated version of this that checks for invalid decls when deciding if a decl has been hidden. This stops the assertion failure happening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. I've committed a test for the behaviour when we have invalid decls in https://reviews.llvm.org/rG6244e3840694. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added a comment. The first version of this that I committed caused a failure in clang/test/Modules/stress1.cpp so I reverted it. I've now committed a new version that handles the removal of existing decl when isPreferredLookupResult is true in a slightly different way, which should

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfca88341794: [Sema] Fix handling of functions that hide classes (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 542893. john.brawn edited the summary of this revision. john.brawn added a comment. Restructured to check for hidden tags in the main loop. Also add a bunch of extra tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + rjmccall wrote: > dexonsmith wrote: > > john.brawn wrote: > > > rjmccall wrote: > > > > john.brawn wrote: > > > > > rjmccall wrote: > > > > > > This is

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 539142. john.brawn added a comment. Use BitVector, change how Decls are deleted, adjust test to avoid potentially-conflicting using-declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files:

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + rjmccall wrote: > john.brawn wrote: > > rjmccall wrote: > > > This is going to fire on every single ordinary lookup that finds multiple > > >

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:507 + // C++ [basic.scope.hiding]p2: + // A class name or enumeration name can be hidden by the name of shafik wrote: > This section does not exist anymore, it was replaced in >

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 537731. john.brawn added a comment. Same patch as previous, but with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:542 +N = Decls.size(); + } + rjmccall wrote: > This is going to fire on every single ordinary lookup that finds multiple > declarations, right? I haven't fully internalized the

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn updated this revision to Diff 537721. john.brawn added a comment. Avoid doing work when we don't have both decls that can hide and decls that can be hidden. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154503/new/ https://reviews.llvm.org/D154503 Files:

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn added inline comments. Comment at: clang/unittests/AST/UnresolvedSetTest.cpp:11 +}; +} // namespace clang + jroelofs wrote: > jroelofs wrote: > > This ODR violation broke the build for me because it's picking up the > > definition from Decl.h instead

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn added a comment. Unfortunately my fix then broke builds using MSVC. Hopefully fixed for real in https://reviews.llvm.org/rG25784cd6a962. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154502/new/ https://reviews.llvm.org/D154502

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn added a comment. The test I added here caused failures in buildbots that build with -Wall -Werror, fixed in https://reviews.llvm.org/rG258322105892. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154502/new/

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ade8b7ed997: [AST] Fix bug in UnresolvedSet::erase of last element (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154503: [Sema] Fix handling of functions that hide classes

john.brawn created this revision. john.brawn added reviewers: dexonsmith, rsmith, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a function is declared in the same scope as a class

[PATCH] D154502: [AST] Fix bug in UnresolvedSet::erase of last element

john.brawn created this revision. john.brawn added reviewers: dexonsmith, rsmith, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. UnresolvedSet::erase works by popping the last element then

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG844e9534c6d9: [Lex] Only warn on defining or undefining language-defined builtins (authored by john.brawn). Changed prior to commit:

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527432. john.brawn added a comment. Put x86 tests in undef-x86.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527164. john.brawn added a comment. Move some of the testing to init-x86.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/init-x86.c

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:163-172 + // C defines macros starting with __STDC, and C++ defines macros starting with + // __STDCPP + if (MacroName.startswith("__STDC")) +return

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527024. john.brawn added a comment. Add more testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c Index:

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, nathanchance, mstorsjo. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D144654 made it

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. gcc has the same warning so I wasn't expecting this cause to change problems, but looking more closely at gcc's behaviour it looks like it only warns for some builtin macros and not others (though glancing over the gcc source code it's not clear which macros and for

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D150966 should fix the failure that was seen in buildbots, so I've now re-committed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654

[PATCH] D150966: [clang] Don't define predefined macros multiple times

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78bf8a0a2212: [clang] Dont define predefined macros multiple times (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 525165. john.brawn added a comment. Use -Eonly in test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); }

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); -

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 524686. john.brawn added a comment. Add VE test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); }

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356779 , @barannikov88 wrote: > Check that the predefined macros don't contain anything that causes a > warning > > What is 'anything', exactly? Does it include duplicate predefined macros, or > it tests

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356403 , @barannikov88 wrote: > Is it possible/worth to add an assertion to Builder.defineMacro to enforce > this one definition rule? It just appends a string to a raw_ostream, so it's not possible to check

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523803. john.brawn marked 2 inline comments as done. john.brawn added a comment. Send test output to /dev/null CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files:

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 523785. john.brawn added a comment. Remove redundant braces, explain more in test comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, thakis, arichardson, pratlucas. Herald added subscribers: luke, abrachet, frasercrmck, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. This patch caused a failure in AArch64 buildbots due to AArch64TargetInfo::getTargetDefines redefining _LP64 and __LP64__. Fixed in https://reviews.llvm.org/rGe55d52cd34fb7a6a6617639d147b9d0abaceeeab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e3f587fd1f: [Lex] Warn when defining or undefining any builtin macro (authored by john.brawn). Changed prior to commit:

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.cpp:15 -#undef __cplusplus +#undef __cplusplus // expected-warning {{undefining builtin macro}} #define __cplusplus aaron.ballman wrote: > Why do we diagnose the undef but

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 522683. john.brawn added a comment. Adjusted in order to make clang-format happy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPDirectives.cpp

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 522215. john.brawn edited the summary of this revision. john.brawn added a comment. I've gone with handling the _GNU_SOURCE problem in the clang-tidy tests by re-using the list of feature test macros in shouldWarnOnMacroDef, and not warning if there's a

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn planned changes to this revision. john.brawn added a comment. The clang-tidy failures in pre-merge are because - clang-tidy tests use the compile database from building llvm (though you have to manually copy it otherwise the tests silently pass without actually running the test,

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 521263. john.brawn added a comment. Rebasing now that the patches this depends on have been committed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. I accidentally pushed the old version of this patch in rG524ed4b1ba51 , I've pushed a change to match what was reviewed here in rG78086af43ade

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524ed4b1ba51: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit:

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 511153. john.brawn edited the summary of this revision. john.brawn added a comment. New version that checks for special filenames in ResolveImportedPath. I spent a while trying to come up with a test using just clang where not doing this fails, but

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are: - I'm doing this on an M1 macbook with host triple

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. In D144651#4210787 , @fdeazeve wrote: > According to git-bisect, this patch is causing the LLDB bots to crash. > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console > > (They were failing for other reasons

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was automatically updated to reflect the committed changes. Closed by commit rG72073fc95cd4: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D144651?vs=502977=506642#toc Repository: rG

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with one minor nitpick. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + It would make

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && +!(getLangOpts().ObjC && isObjCProtectedMacro(II))) + Diag(MacroNameTok,

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D145691 should fix the libc++ CI failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 ___ cfe-commits mailing list

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 503305. john.brawn added a comment. Add command line test and release note, and run clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

This revision was automatically updated to reflect the committed changes. Closed by commit rG128f7dac82ea: [Lex] Use line markers in preprocessed assembly predefines file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D145397?vs=502680=503058#toc Repository: rG

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502977. john.brawn added a comment. Ran clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. In D144654#4156430 , @aaron.ballman wrote: > This seems to cause precommit CI failures that should be addressed, and it > should also have a release note about the fix. Failures in CI should be fixed by D145397

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502683. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Herald added a project: clang-tools-extra. Fixed a couple of things causing failures in clangd tests (path

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU line marker directives are not

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn created this revision. john.brawn added reviewers: rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we warn when MI->isBuiltinMacro, but this is

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn created this revision. john.brawn added reviewers: mstorsjo, jansvoboda11, DHowett-MSFT, sammccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix two problems happening during

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b8900f7f91d: [clang][CodeGen] Add default attributes to __clang_call_terminate (authored by john.brawn). Changed prior to commit:

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

john.brawn created this revision. john.brawn added reviewers: rsmith, rjmccall, lebedev.ri, miyuki. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When generating __clang_call_terminate use

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3264ab2021: [FPEnv] Enable strict fp for AArch64 in clang (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138143/new/

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

john.brawn added inline comments. Comment at: clang/docs/ReleaseNotes.rst:760 +- Strict floating point has been enabled for AArch64, which means that + ``-ftrapping-math``, ``-frounding-math``, ``-ffp-model=strict``, and + ``-ffp-exception-behaviour=`` are now accepted.

[PATCH] D137980: [ARM] Pretend atomics are always lock-free for small widths.

john.brawn added a comment. Looking at GCC it looks like there (for cortex-m0 at least) the behaviour is that loads and stores are generated inline, but more complex operations go to the atomic library calls (not the sync library calls). e.g. for int x, y; int fn() { return

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

john.brawn created this revision. john.brawn added reviewers: t.p.northover, fhahn, umesh.kalappa0. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES)

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D129231

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn added a comment. Looking at the descriptions of maths functions in C99 (and I expect C11 will be the same) it looks like there are three kinds: - Those that can report error by errno and floating-point exeption, and may also raise the inexact exception - Those that don't set errno,

[PATCH] D125775: [ARM] Don't Enable AES Pass for Generic Cores

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125775/new/ https://reviews.llvm.org/D125775

[PATCH] D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork

john.brawn created this revision. john.brawn added reviewers: ldionne, Mordante, michaelplatings. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Currently

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1466c34669: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL (authored by john.brawn). Repository: rG LLVM Github Monorepo

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118259: [AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL

john.brawn updated this revision to Diff 422285. john.brawn retitled this revision from "[AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL" to "[AArch64] Adjust aarch64 constrained intrinsics tests and un-XFAIL". john.brawn edited the summary of this revision. john.brawn

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1386 + + IsStrictFPEnabled = true; } dmgreen wrote: > What are the ramifications of setting this to true? The behaviour with IsStrictFPEnabled = false is that strict

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 422257. john.brawn added a comment. Removed clang test changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 419494. john.brawn added a comment. Adjusted formatting slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. llvm/test/CodeGen/AArch64/fp-intrinsics-vector.ll is testing the asm generation, so it probably is fine to remove that here so I will. This test is specifically testing arm_neon.h intrinsics though, so wouldn't make sense unifying with other architectures.

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 416141. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. Herald added a project: All. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118259/new/ https://reviews.llvm.org/D118259 ___ cfe-commits mailing list

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn added a comment. In D118259#3275297 , @fhahn wrote: > Does this clang test actually need to check the generated assembly? Shouldn't > it be enough to check that the correct intrinsics are generated? I could remove the CHECK-ASM checks, but

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e17c9613f36: [AArch64] Add some missing strict FP vector lowering (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbca998ed3c9a: [AArch64] Generate fcmps when appropriate for neon intrinsics (authored by john.brawn). Repository: rG LLVM Github Monorepo

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 405213. john.brawn added a comment. Update based on review comments and adjust formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117795/new/ https://reviews.llvm.org/D117795 Files: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn planned changes to this revision. john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1484 + // of the vector comparison instructions. + setOperationAction(ISD::STRICT_FSETCCS, VT, Expand); + // FIXME: We could potentially make use of the vector comparison

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

john.brawn added inline comments. Comment at: llvm/test/CodeGen/ARM/2013-05-05-IfConvertBug.ll:1-4 ; RUN: llc < %s -mtriple=thumbv7-apple-ios -mcpu=cortex-a8 | FileCheck %s ; RUN: llc < %s -mtriple=thumbv8 | FileCheck -check-prefix=CHECK-V8 %s -; RUN: llc < %s -mtriple=thumbv7

[PATCH] D117795: [AArch64] Add some missing strict FP vector lowering

john.brawn updated this revision to Diff 403614. john.brawn retitled this revision from "[AArch64] Fixes for strict FP vector instructions" to "[AArch64] Add some missing strict FP vector lowering". john.brawn edited the summary of this revision. john.brawn added a comment. The other parts of

[PATCH] D118259: [AArch64] Adjust aarch64-neon-intrinsics-constrained test and un-XFAIL

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. This test no longer fails during isel, but does need the expected

[PATCH] D118257: [AArch64] Generate fcmps when appropriate for neon intrinsics

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. john.brawn requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D117795: [AArch64] Fixes for strict FP vector instructions

john.brawn created this revision. john.brawn added reviewers: kpn, cameron.mcinally, dmgreen, t.p.northover. Herald added subscribers: hiraditya, kristof.beyls. john.brawn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Fix several

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. In D110065#3087330 , @labrinea wrote: > Added v8.1a_ops on AppleA10. However, the target parser lists it as v8.0a, > which seems odd. Out of the scope of this patch anyway. Looking at the definition of A10 in target parser

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. I have one small comment, but otherwise LGTM. Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:1558 + + if (Reg && !isValidSysReg(Reg, Read,

  1   2   >