https://github.com/kkwli closed https://github.com/llvm/llvm-project/pull/113215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kkwli updated
https://github.com/llvm/llvm-project/pull/113215
>From 3c57a70bf075d17bf9001bd6ec505170179ace9b Mon Sep 17 00:00:00 2001
From: Kelvin Li
Date: Fri, 18 Oct 2024 23:25:27 -0400
Subject: [PATCH 1/3] [flang] Support -mabi=vec-extabi and -mabi=vec-default on
AIX
--
@@ -203,6 +203,33 @@ void Flang::AddAArch64TargetArgs(const ArgList &Args,
}
}
+void Flang::AddPPCTargetArgs(const ArgList &Args,
+ ArgStringList &CmdArgs) const {
+ const Driver &D = getToolChain().getDriver();
+ bool VecExtabi = false;
+
+ if
@@ -0,0 +1,15 @@
+! RUN: not %flang -### -c --target=powerpc64le-unknown-linux -mabi=vec-extabi
%s 2>&1 | FileCheck --check-prefix=INVALID1 %s
+! RUN: not %flang -### -c --target=x86_64-unknown-linux -mabi=vec-extabi %s
2>&1 | FileCheck --check-prefix=INVALID2 %s
+! RUN: not %fl
@@ -0,0 +1,116 @@
+
+
+# Fortran Extensions supported by Flang
+
+```{contents}
+---
+local:
+---
+```
+
+For better compatibility with GNU Fortran and Sun Fortran,
+this compiler supports an option (`-funsigned`) that enables
+the `UNSIGNED` data type, constants, intrinsic functi
@@ -203,6 +203,30 @@ void Flang::AddAArch64TargetArgs(const ArgList &Args,
}
}
+void Flang::AddPPCTargetArgs(const ArgList &Args,
+ ArgStringList &CmdArgs) const {
+ bool VecExtabi = false;
+ for (const Arg *A : Args.filtered(options::OPT_mabi_E
https://github.com/kkwli updated
https://github.com/llvm/llvm-project/pull/113215
>From 3c57a70bf075d17bf9001bd6ec505170179ace9b Mon Sep 17 00:00:00 2001
From: Kelvin Li
Date: Fri, 18 Oct 2024 23:25:27 -0400
Subject: [PATCH 1/2] [flang] Support -mabi=vec-extabi and -mabi=vec-default on
AIX
--
https://github.com/kkwli created
https://github.com/llvm/llvm-project/pull/113215
This option is to enable the AIX extended and default vector ABIs.
>From 3c57a70bf075d17bf9001bd6ec505170179ace9b Mon Sep 17 00:00:00 2001
From: Kelvin Li
Date: Fri, 18 Oct 2024 23:25:27 -0400
Subject: [PATCH] [f
kkwli wrote:
The linker-flags test fails on AIX too.
https://github.com/llvm/llvm-project/pull/99058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kkwli approved this pull request.
LG. Thanks.
https://github.com/llvm/llvm-project/pull/96799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli wrote:
This change will also break backward compatibility that the old object file
that contain `main` can no longer use the new compiler to link with other
objects. I think we can put a warning in the release note or something like
that to warn users.
https://github.com/llvm/llvm-proje
@@ -24,6 +24,7 @@ add_flang_library(FIRBuilder
Runtime/Inquiry.cpp
Runtime/Intrinsics.cpp
Runtime/Numeric.cpp
+ Runtime/Main.cpp
kkwli wrote:
I think this list is in alphabetical order?
https://github.com/llvm/llvm-project/pull/89938
__
https://github.com/kkwli approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/89938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kkwli edited https://github.com/llvm/llvm-project/pull/89938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli wrote:
@kparzysz Is it supposed to also print the predefined macros? Or only the
user-defined macros?
https://github.com/llvm/llvm-project/pull/87627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/kkwli approved this pull request.
LG. Thanks
https://github.com/llvm/llvm-project/pull/79016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli wrote:
> > How would `flang-new -fno-fortran-main t.f -lFortran_main` work?
>
> This works because I only remove `-lFortran_main` when it is going to be
> added implicitly. `-fno-fortran-main` ensures that we never reach this
> branch. I've added a test to verify this.
I don't know what
kkwli wrote:
> My plan is the following:
>
> * Try to fix isysroot.f90 test by making DEFAULT_SYSROOT a LIT "feature".
>
> * Keep using -isysroot on Flang's tests, on Darwin, as it seems to be the
> recommended way to select an SDK.
>
> * Add support for -sysroot.
>
>
> Does it
kkwli wrote:
> > How would `flang-new -fno-fortran-main t.f -lFortran_main` work?
>
> Good question. This won't work with this patch but currently should work.
> I'll have to fix this.
>
> Do you agree that `flang-new -lFortran_main` is something we want to make
> work?
In my opinion, we sho
kkwli wrote:
How would `flang-new -fno-fortran-main t.f -lFortran_main` work?
https://github.com/llvm/llvm-project/pull/78152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli wrote:
If the compiler is built with `DEFAULT_SYSROOT`, the `-isysroot` option is
ignored. Is that the expected behavior? My local MacOS build (with
`-DDEFAULT_SYSROOT="$(xcrun --show-sdk-path)"`) has `isysroot.f90` failed.
https://github.com/llvm/llvm-project/pull/77365
https://github.com/kkwli approved this pull request.
LG. Thanks
https://github.com/llvm/llvm-project/pull/73903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7,7 +7,7 @@
!
! This test is for x86_64, where exponent-letter 'q' is for
! 10-byte extended precision
-! UNSUPPORTED: system-windows
+! UNSUPPORTED: system-windows, system-aix
kkwli wrote:
Ok
https://github.com/llvm/llvm-project/pull/73903
__
@@ -7,7 +7,7 @@
!
! This test is for x86_64, where exponent-letter 'q' is for
! 10-byte extended precision
-! UNSUPPORTED: system-windows
+! UNSUPPORTED: system-windows, system-aix
kkwli wrote:
Why not `target=powerpc{{.*}}` as PPC is non-x86_64 regardless of
Author: Kelvin Li
Date: 2023-08-04T17:11:30-04:00
New Revision: 00769d69fbaa39ecdcbbaf826a35ad999bdc951e
URL:
https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e
DIFF:
https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e.diff
LOG
Author: Kelvin Li
Date: 2022-02-04T22:15:14-05:00
New Revision: 8ea4aed50a9f84d9617219ccc936c005c5f31c24
URL:
https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24
DIFF:
https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24.diff
LOG
Author: Kelvin Li
Date: 2020-02-03T18:30:36-05:00
New Revision: ac430336318a1abe6e4726e8df49ee0e6b779691
URL:
https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691
DIFF:
https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691.diff
LOG
Author: Kelvin Li
Date: 2020-01-03T11:55:37-05:00
New Revision: 427ffa2cdbbc7337d903ba71823a7830fa92568d
URL:
https://github.com/llvm/llvm-project/commit/427ffa2cdbbc7337d903ba71823a7830fa92568d
DIFF:
https://github.com/llvm/llvm-project/commit/427ffa2cdbbc7337d903ba71823a7830fa92568d.diff
LOG
Author: Kelvin Li
Date: 2019-11-22T15:32:40-05:00
New Revision: 0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384
URL:
https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384
DIFF:
https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384.diff
LOG
Author: Kelvin Li
Date: 2019-11-06T22:03:09-05:00
New Revision: 9f10cc2d124c275f2e7a6764e168f6b75527e78f
URL:
https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f
DIFF:
https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f.diff
LOG
Author: kli
Date: Tue Feb 5 08:43:00 2019
New Revision: 353186
URL: http://llvm.org/viewvc/llvm-project?rev=353186&view=rev
Log:
[OPENMP] issue error messages for multiple teams contructs in a target construct
The fix is to issue error messages if there are more than one
teams construct inside
Author: kli
Date: Fri Jan 18 11:57:37 2019
New Revision: 351580
URL: http://llvm.org/viewvc/llvm-project?rev=351580&view=rev
Log:
[OPENMP][DOCS] Release notes/OpenMP support updates, NFC.
Differential Revision: https://reviews.llvm.org/D56733
Modified:
cfe/trunk/docs/OpenMPSupport.rst
cf
Author: kli
Date: Tue Dec 18 14:18:41 2018
New Revision: 349551
URL: http://llvm.org/viewvc/llvm-project?rev=349551&view=rev
Log:
[OPENMP] parsing and sema support for 'close' map-type-modifier
A map clause with the close map-type-modifier is a hint to
prefer that the variables are mapped using
Author: kli
Date: Tue Nov 27 16:51:08 2018
New Revision: 347723
URL: http://llvm.org/viewvc/llvm-project?rev=347723&view=rev
Log:
[OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp (NFC)
The flag ColonExpected is not changed after being initialized to
false at declaration.
Patch by
Author: kli
Date: Wed Nov 21 12:15:57 2018
New Revision: 347411
URL: http://llvm.org/viewvc/llvm-project?rev=347411&view=rev
Log:
[OPENMP] Refactor code for parsing omp declare target directive and its clauses
(NFC)
This patch refactor the code for parsing omp declare target directive and
it
Author: kli
Date: Wed Nov 21 11:38:53 2018
New Revision: 347408
URL: http://llvm.org/viewvc/llvm-project?rev=347408&view=rev
Log:
[OPENMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC)
Whether the map type modifier is specified or not, the flag
MapTypeModifierSpecif
Author: kli
Date: Wed Nov 21 11:10:48 2018
New Revision: 347405
URL: http://llvm.org/viewvc/llvm-project?rev=347405&view=rev
Log:
[OPENMP] Support relational-op != (not-equal) as one of the canonical
forms of random access iterator
In OpenMP 4.5, only 4 relational operators are supported: <,
Author: kli
Date: Tue Sep 25 21:28:39 2018
New Revision: 343063
URL: http://llvm.org/viewvc/llvm-project?rev=343063&view=rev
Log:
[OPENMP] Add support for OMP5 requires directive + unified_address clause
Add support for OMP5.0 requires directive and unified_address clause.
Patches to follow will
Author: kli
Date: Sat Sep 15 06:54:15 2018
New Revision: 342322
URL: http://llvm.org/viewvc/llvm-project?rev=342322&view=rev
Log:
[OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer (NFC)
Move declarations for OMPClauseReader, OMPClauseWriter to ASTReader.h
and ASTWriter.h and move
Author: kli
Date: Sun Sep 9 19:07:09 2018
New Revision: 341766
URL: http://llvm.org/viewvc/llvm-project?rev=341766&view=rev
Log:
[OpenMP] Add support for nested 'declare target' directives
Add the capability to nest multiple declare target directives
- including header files within a declare ta
Author: kli
Date: Tue Dec 12 12:08:12 2017
New Revision: 320521
URL: http://llvm.org/viewvc/llvm-project?rev=320521&view=rev
Log:
[OpenMP] Diagnose function name on the link clause
This patch is to add diagnose when a function name is
specified on the link clause. According to the OpenMP
spec, o
Author: kli
Date: Tue Dec 12 10:33:39 2017
New Revision: 320506
URL: http://llvm.org/viewvc/llvm-project?rev=320506&view=rev
Log:
Add --cuda-path to mock a CUDA Toolkit installation to avoid
unexpected error messages for incompatibility between the
default SM level and the support in the installed
Author: kli
Date: Thu Nov 30 10:52:06 2017
New Revision: 319458
URL: http://llvm.org/viewvc/llvm-project?rev=319458&view=rev
Log:
[OpenMP] Diagnose undeclared variables on declare target clause
Clang asserts on undeclared variables on the to or link clause in the declare
target directive. The pat
Author: kli
Date: Tue Jan 10 12:57:07 2017
New Revision: 291583
URL: http://llvm.org/viewvc/llvm-project?rev=291583&view=rev
Log:
[OpenMP] Remove outdated comments. NFC.
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.def
Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def
URL:
http
Author: kli
Date: Mon Jan 9 23:15:35 2017
New Revision: 291540
URL: http://llvm.org/viewvc/llvm-project?rev=291540&view=rev
Log:
[OpenMP] Support the 'is_device_ptr' clause with 'target parallel for' pragma
This patch is to add support of the 'is_device_ptr' clause with the 'target
parallel for
Author: kli
Date: Mon Jan 9 22:26:44 2017
New Revision: 291537
URL: http://llvm.org/viewvc/llvm-project?rev=291537&view=rev
Log:
[OpenMP] Support the 'is_device_ptr' clause with 'target parallel for simd'
pragma
This patch is to add support of the 'is_device_ptr' clause with the 'target
parall
Author: kli
Date: Fri Jan 6 12:49:49 2017
New Revision: 291260
URL: http://llvm.org/viewvc/llvm-project?rev=291260&view=rev
Log:
[OpenMP] fix typo - the standalone 'distribute' pragma should be 'teams
distribute' pragma
Modified:
cfe/trunk/test/OpenMP/teams_distribute_collapse_messages.cpp
Author: kli
Date: Mon Jan 2 10:42:11 2017
New Revision: 290813
URL: http://llvm.org/viewvc/llvm-project?rev=290813&view=rev
Log:
[OpenMP] Add test cases for the proc_bind and schedule clauses with 'teams
distribute parallel for' pragma.
https://reviews.llvm.org/D28205
Added:
cfe/trunk/test
Author: kli
Date: Sat Dec 31 17:36:47 2016
New Revision: 290795
URL: http://llvm.org/viewvc/llvm-project?rev=290795&view=rev
Log:
Fix typo in test case. NFC
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_collapse_messages.cpp
Modified:
cfe/trunk/test/OpenMP/teams_distr
Author: kli
Date: Wed Dec 28 11:57:07 2016
New Revision: 290673
URL: http://llvm.org/viewvc/llvm-project?rev=290673&view=rev
Log:
Fix format. NFC
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: kli
Date: Fri Dec 16 14:50:46 2016
New Revision: 289989
URL: http://llvm.org/viewvc/llvm-project?rev=289989&view=rev
Log:
[OpenMP] support the 'is_device_ptr' clause with 'target parallel' pragma
This patch is to add support of the 'is_device_ptr' clause in the 'target
parallel' pragma.
Author: kli
Date: Thu Dec 15 18:15:54 2016
New Revision: 289897
URL: http://llvm.org/viewvc/llvm-project?rev=289897&view=rev
Log:
Fix typo in error messages. NFC.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp
Modified:
cfe/trunk/test/OpenMP/teams_distr
Author: kli
Date: Thu Dec 15 11:55:32 2016
New Revision: 289836
URL: http://llvm.org/viewvc/llvm-project?rev=289836&view=rev
Log:
Fix typo in comment. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: kli
Date: Wed Dec 14 09:39:58 2016
New Revision: 289657
URL: http://llvm.org/viewvc/llvm-project?rev=289657&view=rev
Log:
Fix assert message. NFC.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
Author: kli
Date: Tue Dec 6 17:18:06 2016
New Revision: 288862
URL: http://llvm.org/viewvc/llvm-project?rev=288862&view=rev
Log:
[OpenMP] Fix typo in the run command in the test case. NFC.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_ast_print.cpp
Modified: cfe/trunk/t
Author: kli
Date: Tue Dec 6 12:50:20 2016
New Revision: 288838
URL: http://llvm.org/viewvc/llvm-project?rev=288838&view=rev
Log:
[OpenMP] Fix typo in the test case. NFC.
Modified:
cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_if_messages.cpp
Modified:
cfe/trunk/test/OpenMP/teams
The failure cannot be reproduced. I re-apply r279045. Committed revision
285066.
Thanks,
Kelvin
On Thu, Aug 18, 2016 at 5:46 AM, Diana Picus wrote:
> Hi,
>
> I had to revert this (r279045) because it breaks some of our buildbots
> (e.g.
> clang-cmake-aarch64-quick, clang-x86_64-linux-selfhost
kkwli0 added a comment.
Should we issue a warning message in this case?
https://reviews.llvm.org/D24615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 added a comment.
Thanks. I will update it when I commit the patch.
https://reviews.llvm.org/D23189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Mon Jul 25 23:32:50 2016
New Revision: 276726
URL: http://llvm.org/viewvc/llvm-project?rev=276726&view=rev
Log:
[OpenMP] diagnose orphaned teams construct
The OpenMP spec mandates that 'a teams construct must be contained within a
target construct'. Currently, this scenario is
kkwli0 added a comment.
Will add the braces. Thanks.
https://reviews.llvm.org/D22785
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel.
kkwli0 added a subscriber: cfe-commits.
The spec mandates that 'a teams construct must be contained within a target
construct'. Currently, this scenario is not diagnosed. This patch is
Author: kli
Date: Wed Jul 20 15:45:29 2016
New Revision: 276177
URL: http://llvm.org/viewvc/llvm-project?rev=276177&view=rev
Log:
[OpenMP] Allow negative lower bound in array sections based on pointers
OpenMP 4.5 removed the restriction that array section lower bound must be non
negative.
This c
Author: kli
Date: Wed Jul 20 14:41:17 2016
New Revision: 276167
URL: http://llvm.org/viewvc/llvm-project?rev=276167&view=rev
Log:
[OpenMP] Ignore parens in atomic capture
Clang misdiagnoses atomic captures cases that contains parens.
i.e.
int v, int *p;
#pragma omp atomic capture
{ v = (*p); (
Author: kli
Date: Mon Jul 18 17:49:16 2016
New Revision: 275926
URL: http://llvm.org/viewvc/llvm-project?rev=275926&view=rev
Log:
[OpenMP] Fix incorrect diagnostics in map clause
Having the following code pattern will result in incorrect diagnostic
int main() {
int arr[10];
#pragma omp target
Author: kli
Date: Mon Jul 18 11:09:53 2016
New Revision: 275805
URL: http://llvm.org/viewvc/llvm-project?rev=275805&view=rev
Log:
[OpenMP] update test cases for -std=c++11 compile
target_parallel_for_simd_collapse_messages.cpp and
target_parallel_for_simd_ordered_messages.cpp give different diag
kkwli0 added a subscriber: cfe-commits.
kkwli0 added a comment.
Add cfe-commits
https://reviews.llvm.org/D22417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 added a comment.
I update the test cases in https://reviews.llvm.org/D22417.
Repository:
rL LLVM
https://reviews.llvm.org/D22096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
I will take a look and put up a patch for it.
Kelvin
On Fri, Jul 15, 2016 at 2:46 AM, Alexey Bataev wrote:
> Kelvin,
> Please look at these messages and fix the tests. Or tell me and I will
> fix them
>
> Best regards,
> Alexey Bataev
> =
> Software Engineer
> Intel Compiler Team
>
Author: kli
Date: Thu Jul 14 23:39:07 2016
New Revision: 275529
URL: http://llvm.org/viewvc/llvm-project?rev=275529&view=rev
Log:
[OpenMP] add check for both simdlen and safelen clauses specified
This patch adds the check for specifying both simdlen and safelen clauses on
the 'distribute simd' o
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel.
kkwli0 added a subscriber: cfe-commits.
This patch adds the check for specifying both simdlen and safelen clauses on
the 'distribute simd' or 'distribute parallel for simd' constructs.
Author: kli
Date: Wed Jul 13 16:51:49 2016
New Revision: 275323
URL: http://llvm.org/viewvc/llvm-project?rev=275323&view=rev
Log:
[OpenMP] remove duplicate code in ActOnOpenMPRegionStart
This patch is to remove duplicate code in ActOnOpenMPRegionStart. (NFC)
Differential Revision: http://reviews
Author: kli
Date: Wed Jul 13 15:40:32 2016
New Revision: 275315
URL: http://llvm.org/viewvc/llvm-project?rev=275315&view=rev
Log:
[OpenMP] add more tests for 'distribute parallel for simd' pragma
This patch is to add two additional tests for testing 'distribute parallel for
simd' pragma with dis
Author: kli
Date: Wed Jul 13 14:16:56 2016
New Revision: 275306
URL: http://llvm.org/viewvc/llvm-project?rev=275306&view=rev
Log:
[OpenMP] add more tests for 'distribute simd' pragma
This patch is to add two additional tests for testing 'distribute simd' pragma
with disallowed clauses and loops.
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, hfinkel, arpith-jacob.
kkwli0 added a subscriber: cfe-commits.
This patch is to add two additional tests for testing 'distribute simd' pragma
with disallowed clauses and loops.
http://reviews.llvm.org/D22176
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel.
kkwli0 added a subscriber: cfe-commits.
This patch is to add two additional tests for testing 'distribute parallel for
simd' pragma with disallowed clauses and loops.
http://reviews.llv
Author: kli
Date: Tue Jul 5 16:38:53 2016
New Revision: 274577
URL: http://llvm.org/viewvc/llvm-project?rev=274577&view=rev
Log:
[OpenMP] remove outdated comment (NFC)
Modified:
cfe/trunk/lib/Basic/OpenMPKinds.cpp
Modified: cfe/trunk/lib/Basic/OpenMPKinds.cpp
URL:
http://llvm.org/viewvc/ll
Author: kli
Date: Fri Jul 1 09:30:25 2016
New Revision: 274352
URL: http://llvm.org/viewvc/llvm-project?rev=274352&view=rev
Log:
[OpenMP] Issue warning if a simd construct nested inside another simd
construct
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Se
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
sfantao wrote:
> A
kkwli0 closed this revision.
kkwli0 added a comment.
At revision: 273908
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Mon Jun 27 14:15:43 2016
New Revision: 273908
URL: http://llvm.org/viewvc/llvm-project?rev=273908&view=rev
Log:
[OpenMP] Diagnose missing cases of statements between target and teams
directives
Clang fails to diagnose cases such as
#pragma omp target
while(0) {
#pragma om
kkwli0 added a comment.
The changes look fine to me. Thanks.
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Tue Jun 21 22:10:32 2016
New Revision: 273369
URL: http://llvm.org/viewvc/llvm-project?rev=273369&view=rev
Log:
[OpenMP] Add the depend clause to target update construct (sema and parsing)
Differential Revision: http://reviews.llvm.org/D21532
Added:
cfe/trunk/test/OpenMP/t
Author: kli
Date: Mon Jun 20 14:16:34 2016
New Revision: 273190
URL: http://llvm.org/viewvc/llvm-project?rev=273190&view=rev
Log:
[OpenMP] Add the nowait clause to target update construct.
Differential Revision: http://reviews.llvm.org/D21477
Added:
cfe/trunk/test/OpenMP/target_update_nowait
kkwli0 added a comment.
Patch for the to and from clauses is in http://reviews.llvm.org/D18488.
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 added a comment.
Thanks for the review.
As request, I will split this patch into two:
1. to and from clause (without test cases)
2. target update directive (with test cases)
I will use this review for the target update directive.
http://reviews.llvm.org/D15944
__
kkwli0 updated this revision to Diff 50774.
kkwli0 marked 5 inline comments as done.
kkwli0 added a comment.
Addressed the comments from the last review: added assert calls and outline the
common code in ActOnOpenMPToClause, ActOnOpenMPFromClause and
ActOnOpenMPMapClause to a static function.
kkwli0 updated this revision to Diff 50024.
kkwli0 marked 2 inline comments as done.
kkwli0 added a comment.
I rebase the patch to the latest trunk and make use of the infrastructure form
parsing and sema.
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/Open
kkwli0 marked 3 inline comments as done.
Comment at: include/clang/AST/OpenMPClause.h:3196
@@ -3195,1 +3195,3 @@
+/// \brief This represents clause 'from' in the '#pragma omp ...'
+/// directives.
ABataev wrote:
> New clauses must be added in separate patches af
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, rsmith, fraggamuffin, sfantao, hfinkel,
carlo.bertolli.
kkwli0 added a subscriber: cfe-commits.
This patch is to add parsing and sema support for target update directive. It
also includes the to and from clause as it is required to
kkwli0 added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:708
@@ -707,3 +707,3 @@
public:
- /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size
- /// expression \a ChunkSize.
+ /// \brief Build 'dist_schedule' clause with schedule kind
kkwli0 closed this revision.
kkwli0 added a comment.
Committed revision 254207.
http://reviews.llvm.org/D15029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kli
Date: Fri Nov 27 12:47:36 2015
New Revision: 254207
URL: http://llvm.org/viewvc/llvm-project?rev=254207&view=rev
Log:
[OpenMP] Parsing and sema support for thread_limit clause.
http://reviews.llvm.org/D15029
Added:
cfe/trunk/test/OpenMP/teams_thread_limit_messages.cpp
Modified:
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242
@@ -5216,2 +5219,25 @@
+static bool IsNonNegativeIntegerValue(Expr *&ValExpr, Sema &SemaRef,
+ OpenMPClauseKind CKind) {
+ if (!ValExpr->isTypeDependent() && !ValExp
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, hfinkel, sfantao, fraggamuffin, rsmith.
kkwli0 added a subscriber: cfe-commits.
This patch is to add parsing and sema support for thread_limit clause.
http://reviews.llvm.org/D15029
Files:
include/clang/AST/OpenMPClause.h
include
Author: kli
Date: Tue Nov 24 14:50:12 2015
New Revision: 254019
URL: http://llvm.org/viewvc/llvm-project?rev=254019&view=rev
Log:
[OpenMP] Parsing and sema support for num_teams clause
http://reviews.llvm.org/D14802
Added:
cfe/trunk/test/OpenMP/teams_num_teams_messages.cpp
Modified:
cfe/
kkwli0 closed this revision.
kkwli0 added a comment.
Committed revision 253849.
Committed revision 253850.
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: kli
Date: Sun Nov 22 23:36:37 2015
New Revision: 253850
URL: http://llvm.org/viewvc/llvm-project?rev=253850&view=rev
Log:
[OpenMP] Parsing and sema support for map clause - add test case
http://reviews.llvm.org/D14134
Added:
cfe/trunk/test/OpenMP/target_map_messages.cpp
Added: cfe
Author: kli
Date: Sun Nov 22 23:32:03 2015
New Revision: 253849
URL: http://llvm.org/viewvc/llvm-project?rev=253849&view=rev
Log:
[OpenMP] Parsing and sema support for map clause
http://reviews.llvm.org/D14134
Modified:
cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h
cfe/trunk/inc
kkwli0 updated this revision to Diff 40537.
kkwli0 added a comment.
Updated patch with the 2nd review comments addressed.
http://reviews.llvm.org/D14134
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/cl
1 - 100 of 108 matches
Mail list logo
