https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/154455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/153641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
lgtm with or without a test for this specific timing issue.
https://github.com/llvm/llvm-project/pull/151774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/147630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
This looks good to me, but I'd also like @yronglin to take a look since it
interacts with their patch.
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@l
https://github.com/Bigcheese approved this pull request.
Looks good to me, but I'd also like @akyrtzi to take a look if they have time.
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
Bigcheese wrote:
> I have a question, when the input does not meet the restrictions of P1857R3,
> do we need to fallback to the old parsing method to perform error recovery?
Hmm, that would probably be the most useful. There's not any ambiguity about
what the user meant by:
```
import
a;
```
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/149059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1122,16 +1122,17 @@ ort \
)";
ASSERT_FALSE(
minimizeSourceToDependencyDirectives(Source, Out, Tokens, Directives));
- EXPECT_STREQ("#include \"textual-header.h\"\nexport module m;"
+ EXPECT_STREQ("module;#include \"textual-header.h\"\nexport module m;"
---
https://github.com/Bigcheese approved this pull request.
lgtm.
https://github.com/llvm/llvm-project/pull/148674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese commented:
This really needs to start with an RFC on https://discourse.llvm.org/ first
that covers what you want to do. See
https://llvm.org/docs/DeveloperPolicy.html#discuss-the-change-gather-consensus,
and you can see examples of other RFCs on discourse for how t
Bigcheese wrote:
I'll try to review it this week.
https://github.com/llvm/llvm-project/pull/107168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
With the last bit this looks fine to me, but you should wait for Chuanqi and
see if the naming should be changed.
https://github.com/llvm/llvm-project/pull/145220
___
cfe-commits mailing list
cf
@@ -0,0 +1,171 @@
+// The driver never checks to implicitly enable the explicit module build
+// support unless at least two input files are provided.
+// To trigger the C++20 module usage check, we always pass a second dummy file
+// as input.
+// TODO: Remove -fmodules everywhe
https://github.com/Bigcheese edited
https://github.com/llvm/llvm-project/pull/145220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4403,6 +4411,174 @@ void Driver::handleArguments(Compilation &C,
DerivedArgList &Args,
}
}
+static void skipWhitespace(const char *&Ptr) {
+ while (isWhitespace(*Ptr))
+++Ptr;
+}
+
+// Returns the length of EOL, either 0 (no end-of-line), 1 (\n) or 2 (\r\n).
+stati
@@ -577,6 +577,19 @@ def err_drv_reduced_module_output_overrided : Warning<
"please consider use '-fmodule-output=' to specify the output file for
reduced BMI explicitly">,
InGroup>;
+def remark_fmodules_driver_enabled : Remark<
+ "support for explicit module builds enab
@@ -0,0 +1,171 @@
+// The driver never checks to implicitly enable the explicit module build
+// support unless at least two input files are provided.
+// To trigger the C++20 module usage check, we always pass a second dummy file
+// as input.
+// TODO: Remove -fmodules everywhe
@@ -4414,6 +4590,34 @@ void Driver::BuildActions(Compilation &C, DerivedArgList
&Args,
handleArguments(C, Args, Inputs, Actions);
+ if (Args.hasFlag(options::OPT_fmodules_driver,
+ options::OPT_fno_modules_driver, false)) {
+Diags.Report(diag::remark
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/146645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese edited
https://github.com/llvm/llvm-project/pull/146645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -880,6 +880,37 @@ TEST(MinimizeSourceToDependencyDirectivesTest,
EXPECT_EQ(pp_eof, Directives[22].Kind);
}
+TEST(MinimizeSourceToDependencyDirectivesTest,
+ TestFixedBugThatReportUnterminatedDirectiveFalsely) {
+ SmallVector Out;
+ SmallVector Tokens;
+ SmallVector
@@ -393,7 +393,7 @@ static bool isQuoteCppDigitSeparator(const char *const
Start,
}
void Scanner::skipLine(const char *&First, const char *const End) {
Bigcheese wrote:
The rule we follow here is that it's ok to miss dependencies as long as the
original inp
https://github.com/Bigcheese approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/146766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
> > This PR is part of a series aimed at implementing native support for
> > explicit module builds from the Clang driver.
>
> This is confusing. Since explicit modules is an unrelated term with C++20
> modules.
All C++20 named modules builds are done explicitly at the moment
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/145857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
Yes, I'll be able to review it sometime this week.
https://github.com/llvm/llvm-project/pull/144233
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
> LGTM. I think I would slightly prefer for
> `DependencyScanningWorkerFilesystem` to accept the entire service instead of
> its members (for the same reasons we do that in the worker, action, etc.)
I changed this, although now the tests need a service. I don't think that's a
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/144000
>From d07ccf298fd3755036ec90e4cd7f1d1408c4506e Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Thu, 12 Jun 2025 17:13:52 -0700
Subject: [PATCH] [clang][scan-deps] Add option to disable caching stat
failu
@@ -1081,7 +1084,8 @@ int clang_scan_deps_main(int argc, char **argv, const
llvm::ToolContext &) {
};
DependencyScanningService Service(ScanMode, Format, OptimizeArgs,
-EagerLoadModules, /*TraceVFS=*/Verbose);
+
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/143950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/144000
While the source code isn't supposed to change during a build, in some
environments it does. This adds an option that disables caching of stat
failures, meaning that source files can be added to the build dur
Bigcheese wrote:
> @Bigcheese I have a question about `A module directive may only appear as the
> first preprocessing tokens in a file (excluding the global module
> fragment.)`. IIUC, as you said in [#90574
> (comment)](https://github.com/llvm/llvm-project/pull/90574#discussion_r1591569547),
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/142452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
lgtm. I agree this makes the lifetime clearer.
https://github.com/llvm/llvm-project/pull/139584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/Bigcheese approved this pull request.
lgtm, looks like it keeps the existing semantics.
https://github.com/llvm/llvm-project/pull/138983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/Bigcheese approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/139091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
lgtm with Chuanqi's release notes request.
Separately, I'd also like to see the rtti and exceptions stuff be marked
compatible, although with some testing first of what happens when people do
create AST differences with the macros. It's
@@ -398,11 +398,11 @@ BENIGN_LANGOPT(HalfNoSemanticInterposition, 1, 0,
"Like -fno-semantic-interposition but don't use local aliases")
ENUM_LANGOPT(StackProtector, StackProtectorMode, 2, SSPOff,
"stack protector mode")
-ENUM_LANGOPT(TrivialAutoVarIn
https://github.com/Bigcheese approved this pull request.
Just looking at the `missing_textual_header` module alone this is a bit odd,
but that's just the semantics of textual headers. Really textual headers just
exist to control the non-modular include warning, so this is fine.
https://github.
@@ -0,0 +1,77 @@
+// Test that modifications to a common header (imported from both a PCH and a
TU)
+// cause rebuilds of dependent modules imported from the TU on incremental
build.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module mod_common { he
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/132853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -209,20 +209,21 @@ void
ModuleDepCollector::addOutputPaths(CowCompilerInvocation &CI,
void dependencies::resetBenignCodeGenOptions(frontend::ActionKind
ProgramAction,
const LangOptions &LangOpts,
@@ -0,0 +1,127 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Bigcheese wrote:
I believe the Linux test failure was due to a test that should have failed. It
had a case insensitive VFS for the headers, but not for the modulemap. When
looking up `fw.framework/Modules/module.modulemap` it should fail because that
path doesn't exist, and isn't made case ins
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132853
>From cea7c581ff90952d112d912da02de688e09112f7 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 29 Jan 2025 12:49:29 -0800
Subject: [PATCH] [clang][modules] Lazily load by name lookups in module maps
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132853
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans
https://github.com/Bigcheese approved this pull request.
Makes sense. Every non-test creation of `CompilerInstance` has an associated
invocation.
https://github.com/llvm/llvm-project/pull/137668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Juan Manuel Martinez =?utf-8?q?Caamaño?=
Message-ID:
In-Reply-To:
Bigcheese wrote:
module maps don't get preprocessed, so I don't think it matters what that is
set to. For normal module.modulemap files `Preprocessed` is `false`. I think
it's fine to remove the true and see if anything breaks
https://github.com/Bigcheese approved this pull request.
I think this looks good overall. I'm a little concerned that the single file
and single module names are similar while having quite different semantics, but
single file is never actually exposed to users, so they won't be confused. I
don
https://github.com/Bigcheese approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/137363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -59,19 +60,46 @@ class InProcessModuleCache : public ModuleCache {
InMemoryModuleCache InMemory;
public:
- InProcessModuleCache(ModuleCacheMutexes &Mutexes) : Mutexes(Mutexes) {}
+ InProcessModuleCache(ModuleCacheEntries &Entries) : Entries(Entries) {}
void prepare
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/137087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -322,3 +372,81 @@ void HeaderIncludesJSONCallback::FileSkipped(
IncludedHeaders.push_back(SkippedFile.getName().str());
}
+
+void HeaderIncludesDirectPerFileCallback::EndOfMainFile() {
+ if (Dependencies.empty())
+return;
+
+ // Sort the files so that the output doe
https://github.com/Bigcheese edited
https://github.com/llvm/llvm-project/pull/137087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
lgtm.
https://github.com/llvm/llvm-project/pull/137087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/136046
Reland https://github.com/llvm/llvm-project/pull/133173. This changes the
assembly code to use `.cfi_{start,end}proc` directly in a file scope asm
statement and restricts enabling it to MachO to help ensure t
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132853
>From 93fa13d9efabf72032966306473689dfac221857 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 29 Jan 2025 12:49:29 -0800
Subject: [PATCH] [clang][modules] Lazily load by name lookups in module maps
Bigcheese wrote:
And another fix for `!LLVM_ENABLE_THREADS`:
4f64c80d5a23c244f942193e58ecac666c173308
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
Bigcheese wrote:
I'll have a fix in a sec.
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/133173
>From 52b33e2511a2e775e78471fbb2c66ad072369168 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 26 Mar 2025 14:48:19 -0700
Subject: [PATCH] [llvm][clang] Allocate a new stack instead of spawning a new
@@ -1206,82 +1198,70 @@
createCompilerInstanceForModuleCompileImpl(CompilerInstance &ImportingInstance,
DiagnosticOptions &DiagOpts = Invocation->getDiagnosticOpts();
DiagOpts.VerifyDiagnostics = 0;
- assert(ImportingInstance.getInvocation().getModuleHash() ==
-
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/135473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1206,82 +1198,70 @@
createCompilerInstanceForModuleCompileImpl(CompilerInstance &ImportingInstance,
DiagnosticOptions &DiagOpts = Invocation->getDiagnosticOpts();
DiagOpts.VerifyDiagnostics = 0;
- assert(ImportingInstance.getInvocation().getModuleHash() ==
-
https://github.com/Bigcheese approved this pull request.
I believe that's fine to run, it just may build the index again.
https://github.com/llvm/llvm-project/pull/134887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
Bigcheese wrote:
Can you not just move the `err_module_rebuild_finalized` diagnostic into
`compileModuleImpl`? It has access to everything it needs there.
https://github.com/llvm/llvm-project/pull/134887
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/133173
>From 52b33e2511a2e775e78471fbb2c66ad072369168 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 26 Mar 2025 14:48:19 -0700
Subject: [PATCH] [llvm][clang] Allocate a new stack instead of spawning a new
@@ -2128,9 +2245,16 @@ bool ModuleMap::loadModuleMapFile(FileEntryRef File,
bool IsSystem,
// If the module map file wasn't already entered, do so now.
if (ID.isInvalid()) {
-auto FileCharacter =
-IsSystem ? SrcMgr::C_System_ModuleMap : SrcMgr::C_User_ModuleMa
@@ -0,0 +1,115 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/133173
>From cc251995b3d55b3cd76b0b65753be88c9fb9d627 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 26 Mar 2025 14:48:19 -0700
Subject: [PATCH] [llvm][clang] Allocate a new stack instead of spawning a new
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132853
>From d19d7c6314dbb68abfe7cdceebd8e8f65aedddc5 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 29 Jan 2025 12:49:29 -0800
Subject: [PATCH] [clang][modules] Lazily load by name lookups in module maps
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132853
>From d19d7c6314dbb68abfe7cdceebd8e8f65aedddc5 Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Wed, 29 Jan 2025 12:49:29 -0800
Subject: [PATCH 1/2] [clang][modules] Lazily load by name lookups in module
@@ -52,6 +56,7 @@ else()
check_include_file(mach/mach.h HAVE_MACH_MACH_H)
check_include_file(malloc/malloc.h HAVE_MALLOC_MALLOC_H)
check_include_file(pthread.h HAVE_PTHREAD_H)
+ check_include_file(sys/resource.h HAVE_SYS_RESOURCE_H)
Bigcheese wrote:
I c
Bigcheese wrote:
> This now makes much more sense after the renames from the prep-commit. There
> are still some naming inconsistencies, though. For example
> `ModuleMap::loadModuleMapFile()` both **parses** and loads a module map file,
> but `ModuleMap::findOrLoadModule()` expects the module
Bigcheese wrote:
> If split stacks are negatively impacting profiling, debugging, or other
> compiler development tasks, I have to ask, have we considered optimizing
> clang stack usage?
The issue is we will always have this problem with implicitly built modules.
It's naturally recursive as w
@@ -0,0 +1,115 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/133173
Clang spawns a new thread to avoid running out of stack space. This can make
debugging and performance analysis more difficult as how the threads are
connected is difficult to recover.
This patch introduces
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/132970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese updated
https://github.com/llvm/llvm-project/pull/132970
>From 1dca90893cd12709f7d3952b68b552fe93b19c5d Mon Sep 17 00:00:00 2001
From: Michael Spencer
Date: Tue, 25 Mar 2025 11:14:46 -0700
Subject: [PATCH] [clang] Consistently use "load" to refer to populating
clan
@@ -1801,6 +1801,33 @@ HeaderSearch::loadModuleMapFileImpl(FileEntryRef File,
bool IsSystem,
return LMM_NewlyLoaded;
}
+HeaderSearch::LoadModuleMapResult
+HeaderSearch::parseModuleMapFileImpl(FileEntryRef File, bool IsSystem,
Bigcheese wrote:
https://githu
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/132970
Now that we have ModuleMapFile.cpp which parses module maps, it's confusing
what ModuleMap::parseModuleMapFile actually does. HeaderSearch already called
this loading a module map, so consistently use that te
https://github.com/Bigcheese approved this pull request.
There's no point in having vague ownership here, so this lgtm.
https://github.com/llvm/llvm-project/pull/132780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
Author: Michael Spencer
Date: 2025-03-25T10:58:44-07:00
New Revision: 53fa28940e0a3ef183e04dd8bc8566d64bbfd101
URL:
https://github.com/llvm/llvm-project/commit/53fa28940e0a3ef183e04dd8bc8566d64bbfd101
DIFF:
https://github.com/llvm/llvm-project/commit/53fa28940e0a3ef183e04dd8bc8566d64bbfd101.dif
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/132853
Instead of eagerly populating the `clang::ModuleMap` when looking up a module
by name, this patch changes `HeaderSearch` to only load the modules that are
actually used.
This introduces `ModuleMap::findOrLoa
https://github.com/Bigcheese approved this pull request.
I think this looks good now. Also nice in general to not mess with options
after argument parsing.
https://github.com/llvm/llvm-project/pull/130823
___
cfe-commits mailing list
cfe-commits@lists
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/132063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/131940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
The general issue with changing this to benign is that it ends up being
non-deterministic and buggy for implicitly built modules. I think what we want
here is `COMPATIBLE_LANGOPT`. By default it will still feed into the context
hash, but the compiler won't reject loading such
Bigcheese wrote:
Is the expectation here that people will name implementation units "foo.cpp"
and the corresponding interface unit "foo.cppm"? I guess that's reasonable.
https://github.com/llvm/llvm-project/pull/131591
___
cfe-commits mailing list
cfe
https://github.com/Bigcheese commented:
Overall I think this looks good. I'm not sure I share the same concerns. The
situation this covers is how likely is it that the build system is going to
determine this needs to be rebuilt, and that happens (in most cases) purely
based on the reported dep
@@ -843,7 +864,7 @@ void ModuleDepCollectorPP::addModuleDep(
!MDC.isPrebuiltModule(Import)) {
Bigcheese wrote:
I think that's fine as long as the current patch says that pre built modules
means it's not in sysroot, as I think that's a small addition and
https://github.com/Bigcheese edited
https://github.com/llvm/llvm-project/pull/130634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese approved this pull request.
lgtm.
https://github.com/llvm/llvm-project/pull/130989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Bigcheese edited
https://github.com/llvm/llvm-project/pull/130989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,54 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,54 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,54 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
https://github.com/Bigcheese commented:
I have a few comments on naming, but overall this looks good.
https://github.com/llvm/llvm-project/pull/130989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
1 - 100 of 360 matches
Mail list logo
