[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024bb62ffd07: [Driver] Pass --target2= to linker from baremetal toolchain (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

miyuki created this revision. miyuki added reviewers: peter.smith, phosek, michaelplatings. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. miyuki requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:83 +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), + [](const std::string ) { Please use `llvm::find_if(InFlags, ...)`

[PATCH] D142932: Multilib YAML parsing

miyuki added inline comments. Comment at: clang/lib/Driver/Multilib.cpp:82 + for (const Matcher : Matchers) { +const std::regex Regex(M.Regex); +if (std::find_if(InFlags.begin(), InFlags.end(), Please use the LLVM regular expression engine

[PATCH] D138679: [clang][CodeGen] Add default attributes to __clang_call_terminate

miyuki added a comment. The CI failures look related to this change: https://buildkite.com/llvm-project/premerge-checks/builds/123301#0184aa94-1b82-44a9-9c25-4074e026d266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138679/new/

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

miyuki added a comment. Thanks for fixing the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

miyuki added a comment. Hi Martin, I think this patch caused a regression. Clang used to warn about the following code: struct X { [[deprecated]] struct Y {}; }; $ clang -std=c++17 -Wall test.cpp :2:7: warning: attribute 'deprecated' is ignored, place it after "struct" to

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

miyuki added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:897 +Builder.defineMacro("__ARM_FEATURE_PAUTH", "1"); +Builder.defineMacro("__ARM_FEATURE_BTI", "1"); + } Since we decided to have two separate flags, I think this line should be

[PATCH] D105493: [clang] Change set type used for SourceLocation.

miyuki added inline comments. Comment at: clang/include/clang/Basic/SourceLocation.h:19 #include "llvm/ADT/StringRef.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include Can this `#include` be removed? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105490: Remove unused parameter from parseMSInlineAsm.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. This change is not part of my original D97204 patch (in D97204 , I replaced `void *AsmLoc` with `uint64_t AsmLoc`), so I

[PATCH] D104442: [libclang] Fix error handler in translateSourceLocation.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. This change is pretty obvious. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104442/new/ https://reviews.llvm.org/D104442

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki added a comment. In D97204#2586111 , @rsmith wrote: > Thanks for doing this! > > The 8-9% memory hit is better than I'd feared, but still seems uncomfortably > large. I've left comments on a couple of places where I think we could > substantially

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki updated this revision to Diff 325762. miyuki edited the summary of this revision. miyuki added a comment. Fixed python bindings and formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97204/new/ https://reviews.llvm.org/D97204 Files:

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki added a comment. In D97204#2580490 , @akyrtzi wrote: > Hi @miyuki, > >> A major thing worth noting is that 64-bit source locations will >> require an ABI breakage in libclang. This patch changes the bit width >> in libclang unconditionally, rather

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki created this revision. miyuki added a reviewer: rsmith. Herald added subscribers: dexonsmith, lebedev.ri, martong, arphaman, kbarton, hiraditya, mgorny, nemanjai. Herald added a reviewer: lebedev.ri. miyuki requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG30d9ca1bd9de: [clang][AST] Encapsulate DeclarationNameLoc, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

miyuki added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://reviews.llvm.org/D94596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki updated this revision to Diff 317627. miyuki edited the summary of this revision. miyuki added a comment. Added `static_assert`s that check that `SourceRange` and `SourceLocation` are trivially destructible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki added a comment. I will wait until the end of this week to see if anyone has objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ https://reviews.llvm.org/D94599 ___ cfe-commits

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG176f5e95e1af: [clang-tidy] Use DenseSetSourceLocation in UpgradeDurationConversionsCheck… (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. > This revision was landed with ongoing or failed builds. The only failures were clang-format warnings, they looked bogus to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 316414. miyuki added a comment. Refactored `SLocEntry` in a similar way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files:

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, EricWF. Herald added a subscriber: xazax.hun. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces `unordered_set` (which used to store

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The class `SymbolOccurrences` can store either a single `SourceRange` in-place or multiple

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki abandoned this revision. miyuki added a comment. Abandoning in favor of D94237 and D94596 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, rsmith, faisalv. Herald added a subscriber: arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change makes `DeclarationNameLoc` a proper class

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. In D94237#2493844 , @dblaikie wrote: > Do you need to run the destructor before placement new in these situations? No, because there is no active union member in any of those situations. And if even if there was an active member,

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e08f0073e3: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki updated this revision to Diff 315759. miyuki added a comment. Fixed a typo in the word "implicit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files:

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:660 + /// Location of the left and right angle brackets. + alignas(ObjCTypeParamDecl *) SourceRange Brackets; /// The number of parameters in the list, which are tail-allocated.

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki updated this revision to Diff 315601. miyuki edited the summary of this revision. miyuki added a comment. Removed alignas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files:

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f76788b0930: [clang][Sema] Compare SourceLocations directly [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94231/new/

[PATCH] D94237: [clang] Use SourceLocations in unions

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. Herald added a subscriber: jfb. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there are many instances where `SourceLocation` objects

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki updated this revision to Diff 315113. miyuki added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ordered comparison operators are defined for the SourceLocation class, so SourceLocation objects

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch utilizes the `alignas` specifier and removes the workaround which used a union object for the same

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

miyuki added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:47 +if (!pass) + std::cout << "ExpectedFlags = 0x" << std::hex << ExpectedFlags +<< " do not equal ExtKind = 0x" << std::hex << ExtKind I suggest using LLVM

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG443ab4d2e012: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } dexonsmith wrote: > I'm surprised you need this `static_cast`, can you explain why it was > necessary? `Loc` is an

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300214. miyuki added a comment. Fixed linter errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300049. miyuki added a comment. Reverted accidentally removed chunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300044. miyuki retitled this revision from "[Basic] Integrate SourceLocation and SourceRange with FoldingSet, NFCI" to "[clang][Basic] Integrate SourceLocation with FoldingSet, NFCI". miyuki edited the summary of this revision. miyuki added a comment.

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki added a comment. In D69903#2340020 , @dexonsmith wrote: > An alternative would be to update the unions to an `AlignedCharArrayUnion` > and use `SourceLocation` directly. WDYT? So, say, in `DeclarationNameLoc`, I would add `AlignedCharArrayUnion`

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG781941183700: [clang] Use SourceLocation as key in hash maps, NFCI (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D69840?vs=299126=299366#toc Repository: rG LLVM Github

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG234c47ae2a8e: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. The build failure is unrelated (see D89463 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 ___

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki updated this revision to Diff 299340. miyuki edited the summary of this revision. miyuki added a comment. Added an example of usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89719/new/ https://reviews.llvm.org/D89719 Files:

[PATCH] D69840: [clang] Use SourceLocation as key in hash maps, NFCI

miyuki updated this revision to Diff 299126. miyuki edited the summary of this revision. miyuki added a comment. Split out the refactoring part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files:

[PATCH] D89719: [clang][Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. This change creates a `DenseMapInfo` trait specialization for the SourceLocation class. The empty key, the tombstone

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c16039b3f1: [clang] Use SourceLocation as key in std::map, NFCI (authored by miyuki). Changed prior to commit:

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in `SourceLocation` into https://reviews.llvm.org/D89705. > A general comment is that there are a couple of functional changes in this > patch,

[PATCH] D89705: [clang] Use SourceLocation as key in std::map, NFCI

miyuki created this revision. miyuki added a reviewer: dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. SourceLocation implements `operator<`, so `SourceLocation`-s can be used as keys in `std::map` directly, there is no

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88164: [clang][Sema] Use enumerator instead of hard-coded constant

miyuki created this revision. miyuki added reviewers: compnerd, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki requested review of this revision. Sema::DiagnoseSwiftName uses the constant 12 instead of the corresponding enumerator

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae1396c7d4d8: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288373. miyuki added a comment. Small refactoring of bitcode updater tests (use `some-name.ll.bc` names for bitcode files in order to be able to refer to them as `%s.bc` from `some-name.ll`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:473 def int_aarch64_neon_bfdot : AdvSIMD_Dot_Intrinsic; - def int_aarch64_neon_bfmmla : AdvSIMD_MatMul_Intrinsic; - def int_aarch64_neon_bfmlalb : AdvSIMD_FML_Intrinsic; - def

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 288068. miyuki edited the summary of this revision. miyuki set the repository for this revision to rG LLVM Github Monorepo. miyuki added a comment. Herald added a subscriber: wenlei. 1. Also update bfdot 2. Add auto-upgrade for old intrinsics Repository:

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki abandoned this revision. miyuki added a comment. Abandoning in favour of: commit a64883431369f28f3fac311c496a4dfad480058f Author: Richard Smith Date: Wed Jul 29 16:49:05 2020 -0700 PR46729: Reject explicit and

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki updated this revision to Diff 286761. miyuki added a comment. Keep the second vbfmlaltq_laneq_f32 test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/ https://reviews.llvm.org/D86146 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki added a comment. In D86146#2226702 , @dmgreen wrote: > Do we need to upgrade the old bfmmla to the new signatures? What is the old bfmmla? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86146/new/

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

miyuki created this revision. miyuki added reviewers: dmgreen, simon_tatham, ostannard. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki requested review of this revision. This patch adjusts the following

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

miyuki added a comment. For intrinsics that are plain functions (not macros) you could just check the signatures using assignments to function pointers, e.g.: #include uint16_t (*fp1)(int32_t) = _s32; $ clang -target=aarch64-arm-none-eabi -march=armv8-a+simd -c neon.c -fsyntax-only

[PATCH] D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. The mangling agrees with https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-builtin LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

miyuki added a comment. I have reproduced the type 1 failure and I confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

miyuki added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:72 +ThunderX3T110, +CortexX1, +CortexA78 I think the new CPUs should be grouped with other Cortex-A CPUs. Comment at:

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f353a2e5a98: [BFloat] Add convert/copy instrinsic support (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D80928?vs=272406=272731#toc Repository: rG LLVM Github Monorepo

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c579540ff69: [ARM] BFloat MatMul IntrinsicsCodeGen (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/

[PATCH] D81740: [ARM] BFloat MatMul Intrinsics

miyuki updated this revision to Diff 272668. miyuki retitled this revision from "[AArch32]: BFloat MatMul Intrinsics" to "[ARM] BFloat MatMul Intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Herald added a subscriber: danielkiss. Addressed the review comments

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a4feb1d53df: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki marked 5 inline comments as done. miyuki added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" || LukeGeeson wrote:

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki updated this revision to Diff 272406. miyuki added a comment. 1. Rebased and fixed failures 2. Added a test for AArch64 codegen of lane copying intrinsics 3. Addressed reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

miyuki created this revision. miyuki added reviewers: stuij, labrinea, dmgreen, simon_tatham. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. miyuki added a child revision: D80928: [BFloat] Add convert/copy instrinsic support. Currently, in order

[PATCH] D81740: [AArch32]: BFloat MatMul Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple armv8-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -mfloat-abi hard \ Would it be sufficient to

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268528. miyuki added a comment. Fixed the "RUN:" line in the A32 test, implemented vduph_lane for A32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 ___ cfe-commits mailing list

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:4675 + SDValue Ops[] = { Src, Pred, Reg0 }; + CurDAG->SelectNodeTo(N, ARM::BF16_VCVT, MVT::v4i16, Ops); + return; Why does it return `MVT::v4i16`, not `MVT::v4bf16`?

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple aarch64-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -emit-llvm -o - %s | FileCheck %s Is it

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268162. miyuki retitled this revision from "[clang][BFloat] add create/set/get/dup intrinsics" to "[clang][BFloat] Add create/set/get/dup intrinsics". miyuki edited the summary of this revision. miyuki added a comment. Addressed reviewers' comments. CHANGES

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

miyuki added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1860 + + def VGET_HIGH_BF : NoTestOpInst<"vget_high", ".Q", "b", OP_HI>; + def VGET_LOW_BF : NoTestOpInst<"vget_low", ".Q", "b", OP_LO>; dmgreen wrote: > Do you know what InstName

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: miyuki wrote: > This chunk does not belong to the patch

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: This chunk does not belong to the patch

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/aarch64-bf16-dotprod-intrinsics.c:8 +// CHECK-LABEL: test_vbfdot_f32 +// CHECK: %0 = bitcast <4 x bfloat> %a to <8 x i8> +// CHECK: %1 = bitcast <4 x bfloat> %b to <8 x i8> Why not `CHECK-NEXT`?

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7ab9e7c9b30: [ARM] Release notes for the Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78481/new/

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

miyuki created this revision. miyuki added reviewers: kristof.beyls, simon_tatham. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. This change mentions CDE assembly in the LLVM release notes and CDE intrinsics in both Clang and LLVM release notes. Repository:

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but please wait a couple more days before committing to see if anyone wants to chime in (I guess one week since the upload date should be enough). CHANGES SINCE LAST ACTION

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck %s Can you try -sroa after

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd722ef63f18: [ARM,CDE] Improve CDE intrinsics testing (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76927/new/

[PATCH] D76927: [ARM,CDE] Improve CDE intrinsics testing

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch: - adds tests for vreinterpret intinsics in big-endian mode - adds C++ runs to the CDE+MVE header

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4da94e5b5f: [ARM,CDE] Implement predicated Q-register CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76610/new/

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76714/new/ https://reviews.llvm.org/D76714

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, ostannard, dmgreen. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. This patch implements the following CDE intrinsics: T __arm_vcx1q_m(int coproc, T

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a85e3585ec5: [ARM,CDE] Implement GPR CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ae3eff8baac: [ARM,CDE] Implement CDE vreinterpret intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG969034b86037: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D76299?vs=251039=251635#toc Repository: rG LLVM

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd22e66171251: [ARM,CDE] Implement CDE S and D-register intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/

[PATCH] D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76359/new/ https://reviews.llvm.org/D76359

  1   2   3   >