https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/145857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
I also checked the other tests in `test/ClangScanDeps`. This is currently the
only test where Windows is disabled only because of the path seperator
difference.
https://github.com/llvm/llvm-project/pull/145857
___
cfe-commits maili
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145857
The test `test/ClangScanDeps/P1689.cppm` was previously not supported on
Windows due to the differences in path separators between Windows and Linux.
This normalizes the paths, allowing this test to run on
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1295,13 +1305,18 @@ FormatToken *FormatTokenLexer::getNextToken() {
case '/':
// The text was entirely whitespace when this loop was entered. Thus
// this has to be an escape sequence.
-assert(Text.substr(i, 2) == "\\\r" || Text.substr(i, 2) ==
@@ -1295,13 +1305,18 @@ FormatToken *FormatTokenLexer::getNextToken() {
case '/':
// The text was entirely whitespace when this loop was entered. Thus
// this has to be an escape sequence.
-assert(Text.substr(i, 2) == "\\\r" || Text.substr(i, 2) ==
@@ -25768,6 +25768,29 @@ TEST_F(FormatTest, OperatorPassedAsAFunctionPtr) {
verifyFormat("foo(operator, , -42);", Style);
}
+TEST_F(FormatTest, LineSpliceWithTrailingWhitespace) {
+ // Test that each sequence of a backslash (\) immediately followed by zero or
+ // more hor
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,347 @@
+// This checks that clang-scan-deps properly outputs named module dependencies
+// when using the the scanning output format 'experimental-full'.
+//
+// See commit 72304.
+// UNSUPPORTED: target={{.*}}-aix{{.*}}
+//
+// The slash direction in linux and windows
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145221
>From 981742eea871868d58293e9a2b58fb3ef2569e7c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sat, 21 Jun 2025 18:54:38 +0200
Subject: [PATCH 1/7] [clang][clang-scan-deps] Add named modules to format
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/4] [clang-format] Handle Trailing Whitespace After Line
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,14 @@
+// RUN: grep -Ev "// *[A-Z-]+:" %s \
naveen-seth wrote:
Sorry, I misunderstood that! Implemented as unit tests now.
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-co
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/3] [clang-format] Handle Trailing Whitespace After Line
@@ -0,0 +1,14 @@
+// RUN: grep -Ev "// *[A-Z-]+:" %s \
naveen-seth wrote:
Fixed.
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/2] [clang-format] Handle Trailing Whitespace After Line
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145243
…223R2)
Fixes #145226.
Implement
[P2223R2](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2223r2.pdf)
in clang-format to correctly handle cases where a backslash '\\' is followed by
trailing w
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From cc92d075db7e9b0cd4c8187e9dc8e20bf4151fdc Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH] [clang][modules-driver] Add scanner to detect C++20 modu
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145220
This PR is part of a series aimed at implementing native support for explicit
module builds from the Clang driver.
This introduces a new scanner that detects C++20 module usage in source files
without using
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145221
This adds standard C++ named modules to the scanning output format
'experimental-full'.
This is motivated by an effort to provide native support for explicit module
builds from the Clang driver.
The driver
naveen-seth wrote:
Hi @hyp, @Bigcheese, would you be available to review this?
https://github.com/llvm/llvm-project/pull/143950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/143950
P2223R2 allows the line-continuation slash `\` to be followed by additional
whitespace. The Clang lexer already follows this behavior, also for versions
prior to C++23. The dependency directive scanner howe
naveen-seth wrote:
Thanks for the review.
In case the changes get approved, please also merge it on my behalf since I
don't have commit access yet. Thank you!
https://github.com/llvm/llvm-project/pull/141695
___
cfe-commits mailing list
cfe-commits@l
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/141695
>From 8556e25c43fff5525501113f38dc0f3b48203f5c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Wed, 28 May 2025 02:26:54 +0200
Subject: [PATCH 1/4] [C2y] Correctly handle FP-suffixes on prefixed octal
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/141695
>From 8556e25c43fff5525501113f38dc0f3b48203f5c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Wed, 28 May 2025 02:26:54 +0200
Subject: [PATCH 1/3] [C2y] Correctly handle FP-suffixes on prefixed octal
naveen-seth wrote:
Ping
https://github.com/llvm/llvm-project/pull/141695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Hi @Bigcheese, can I tag you for review?
https://github.com/llvm/llvm-project/pull/142455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/142455
This simply moves code for diagnosing misuse of arguments `/Fo`, `/Fa`, and
`/o` from `Driver::BuildActions` into `Driver::handleArguments`, following the
intention of 740f69b.
This change better aligns wi
@@ -1432,14 +1432,26 @@ void
NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) {
Diags.Report(TokLoc, DiagId);
++s;
DigitsBegin = s;
-SawOctalPrefix = true;
+radix = 8;
naveen-seth wrote:
I don't think the octal digi
naveen-seth wrote:
Yes, please.
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Thank you for reviewing!
(And apologies for the formatting and coding-standard issues on my end!)
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/8] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/6] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/3] [clang] Enforce 1-based indexing for command line source
@@ -0,0 +1,6 @@
+// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:0:1 %s -o -
+// RUN: not %clang_cc1 -fsyntax-only -code-completion-at=%s:1:0 %s -o -
+
+// Related to #139375
+// Clang uses 1-based indexing for source locations given from the
command-line.
+// Verify
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/2] [clang] Enforce 1-based indexing for command line source
naveen-seth wrote:
> Thanks for working on that. I think it might better to do that check where
> `ParsedSourceLocation::FromString` is called, so that we can have a proper
> front-end diagnostics for it (search for `err_fe_invalid_code_complete_file`
> and `OPT_code_completion_at`)
Thank you
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/139457
Fixes #139375
Clang expects command line source locations to be provided using 1-based
indexing.
Currently, Clang does not reject zero as invalid argument for column or line
number, which can cause Clang t
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/137711
Fixes #132692.
`clang -cc1` crashes when generating a module interface with
`emit-module-interface` or `emit-reduced-module-interface` using an input file
which is already a precompiled module (`.pcm`) fil
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 957a45312767a40b513bfd4f545c23fda9c4866f Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Tue, 8 Apr 2025 00:56:14 +
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#13
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From a23ba4d51332180ff5d1b5bc9de2d0c6c04cbf66 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/133462
When using -fmodule-file== with incorrect inputs, the
compiler crashes in two scenarios:
1. A module is mapped to the right BMI file but one of its transitively
exported module dependencies is also mapped
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Hi, sorry! I left a comment earlier but noticed that a large part of the
explanation was incorrect and deleted it. Here is the fixed comment:
At first I thought that the issue can be fixed by just checking for duplicates
while parsing the command-line arguments, but that doe
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 74ace4fd3c71ff59f2d89680c0f1382d0f9933f4 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH 1/2] [clang][modules] Guard against bad -fmodule-file mappings
naveen-seth wrote:
Hi @ChuanqiXu9, @mpark, @shafik,
For context, here is how this PR would change clang's behavior when replicating
the original crash in #132059:
The original crash, where the module `hello` wasn’t mapped to any BMI file,
would now display the following:
```bash
clang++ -fmo
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 74ace4fd3c71ff59f2d89680c0f1382d0f9933f4 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From 804617c3083935d10f98b10e86f965e7508eb587 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/133462
>From cfbc14d381b5daed70ca812daac9ceed0039b5f6 Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Fri, 28 Mar 2025 06:59:06 +0100
Subject: [PATCH] [clang][modules] Guard against bad -fmodule-file mappings
(#1
https://github.com/naveen-seth reopened
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/133462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
64 matches
Mail list logo
