https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/155523
The OutputPaths field of FullDependencyConsumer is not used, and the resulting
TranslationUnitDeps has no corresponding field. This change removes the unused
member.
It was added in commit f978ea4, and thi
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/155450
>From eca24f1b8504d522fc2ebcd00fd80b78045a5cc8 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Mon, 25 Aug 2025 02:36:42 +0200
Subject: [PATCH] [clang][modules-driver] Move logic to enable -fmodules-d
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/155450
This patch is part of a series to support driver-managed module builds for C++
named modules and Clang modules.
Commit 9403c2d introduced the entry point for the driver-managed module build
logic and assum
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/155450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth converted_to_draft
https://github.com/llvm/llvm-project/pull/152770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/152770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From 3ddbf65c4738c3c4e78607d5083838b020ccbcf4 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From 4ebde1600f9071e7dd15242891f9dbba2cad1bf7 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From dd73559867c5273fc0eb4a6498bb81e5b226c4b6 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From f9dad8d99616e0799c318dda1a8e50351021f169 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From 82ccdec367d18320ca5448a4b36e928889e17936 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth ready_for_review
https://github.com/llvm/llvm-project/pull/152770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From 905e78df28462b647bfdb7cf3231198c90bf3097 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 22 Aug 2025 04:58:18 +0200
Subject: [PATCH] [clang][modules-driver] Add dependency scan and dependen
https://github.com/naveen-seth approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/153863
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -188,13 +192,23 @@ class FullDependencyConsumer : public DependencyConsumer {
ContextHash = std::move(Hash);
}
+ void handleProvidedAndRequiredStdCXXModules(
+ std::optional Provided,
+ std::vector Requires) override {
+ModuleName = Provided ? Provided-
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/153497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/153497
This patch is part of a series to support driver managed module builds for C++
named modules and Clang modules.
This introduces a scanner that detects C++ named module usage early in the
driver with only ne
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/152770
This patch is part of a series to support driver-managed module builds.
It adds support for the discovery of module dependencies and for dependency
graph generation from within the driver.
The dependency s
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/152770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/152770
>From 89de9916577a76868aa74bad03a8de9fd6339623 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Mon, 21 Jul 2025 22:34:14 +0200
Subject: [PATCH 1/3] Reland Reland [clang][modules-driver] Add scanner to
https://github.com/naveen-seth converted_to_draft
https://github.com/llvm/llvm-project/pull/152770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/149900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/147630
>From 6b440de2ed76a6095c4b68ba1301dfbd19f9a285 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/5] Reland [clang][modules-driver] Add scanner to detect
naveen-seth wrote:
This now also leverages the `Scanner` in `DependencyDirectivesScanner.cpp` to
reuse its logic for properly lexing module related directives. For this to
happen, I had to first land two fixes with #148674 and #148685.
https://github.com/llvm/llvm-project/pull/147630
_
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/147630
>From 6b440de2ed76a6095c4b68ba1301dfbd19f9a285 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/4] Reland [clang][modules-driver] Add scanner to detect
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/147630
>From 6b440de2ed76a6095c4b68ba1301dfbd19f9a285 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/3] Reland [clang][modules-driver] Add scanner to detect
naveen-seth wrote:
Thank you for reviewing!
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/148685
>From 7a759271c54b78eb940bf12274bcc535a3df22e3 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Mon, 14 Jul 2025 19:17:10 +0200
Subject: [PATCH 1/3] [clang][deps] Recognize 'module;' in dependency dire
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/148674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth commented:
Hi, I've requested the reviewers of
[#147156](https://github.com/llvm/llvm-project/pull/147156) for this since I
don't understand this topic all too well.
https://github.com/llvm/llvm-project/pull/148640
___
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/148685
>From 7a759271c54b78eb940bf12274bcc535a3df22e3 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Mon, 14 Jul 2025 19:17:10 +0200
Subject: [PATCH 1/2] [clang][deps] Recognize 'module;' in dependency dire
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/148685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/148685
With this change, the dependency directive scanner now properly identifies
"module;" as a directive, as per P1857R3.
Previously, the global module fragment was not recognized by the scanner.
>From 7a759271c
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/148674
>From bb1c20a40fa8635b8987733708979729d54aa02e Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Mon, 14 Jul 2025 18:44:01 +0200
Subject: [PATCH 1/2] [clang][deps] Fix dependency scanner misidentifying
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/148674
The dependency directive scanner was incorrectly classifying namespaces such as
`import::inner xi` as directives. According to
[P1857R3](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p1857r3.html
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/147630
>From 6b440de2ed76a6095c4b68ba1301dfbd19f9a285 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/2] Reland [clang][modules-driver] Add scanner to detect
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/147630
This patch is part of a series to natively support C++20 module usage from the
Clang driver (without requiring an external build system). This introduces a
new scanner that detects C++20 module usage in sou
https://github.com/naveen-seth approved this pull request.
https://github.com/llvm/llvm-project/pull/147286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/145220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Done. For the regression test, I've updated it to use `--allow-empty` instead
of forcing output using `clang -v` (+formatting & removed duplicate flags).
Thank you for the reviews.
https://github.com/llvm/llvm-project/pull/145220
_
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/7] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/5] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/4] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/3] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From 2574e28fd8dd33d4042f169576d9927ae0649ff5 Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/3] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/146645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/146645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/146645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -393,7 +393,7 @@ static bool isQuoteCppDigitSeparator(const char *const
Start,
}
void Scanner::skipLine(const char *&First, const char *const End) {
naveen-seth wrote:
My bad! The bug was introduced because I initialized `char LastNonWhitespace =
' ';` o
https://github.com/naveen-seth commented:
I realized that I probably should have also removed the following code in
#143950:
https://github.com/llvm/llvm-project/blob/2b03efc7fba813bb0c52b7016867f200a91c2d34/clang/lib/Lex/DependencyDirectivesScanner.cpp#L445-L451
The logic added in #143950 als
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From cc92d075db7e9b0cd4c8187e9dc8e20bf4151fdc Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH 1/2] [clang][modules-driver] Add scanner to detect C++20
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/145857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
I also checked the other tests in `test/ClangScanDeps`. This is currently the
only test where Windows is disabled only because of the path seperator
difference.
https://github.com/llvm/llvm-project/pull/145857
___
cfe-commits maili
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145857
The test `test/ClangScanDeps/P1689.cppm` was previously not supported on
Windows due to the differences in path separators between Windows and Linux.
This normalizes the paths, allowing this test to run on
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1295,13 +1305,18 @@ FormatToken *FormatTokenLexer::getNextToken() {
case '/':
// The text was entirely whitespace when this loop was entered. Thus
// this has to be an escape sequence.
-assert(Text.substr(i, 2) == "\\\r" || Text.substr(i, 2) ==
@@ -1295,13 +1305,18 @@ FormatToken *FormatTokenLexer::getNextToken() {
case '/':
// The text was entirely whitespace when this loop was entered. Thus
// this has to be an escape sequence.
-assert(Text.substr(i, 2) == "\\\r" || Text.substr(i, 2) ==
@@ -25768,6 +25768,29 @@ TEST_F(FormatTest, OperatorPassedAsAFunctionPtr) {
verifyFormat("foo(operator, , -42);", Style);
}
+TEST_F(FormatTest, LineSpliceWithTrailingWhitespace) {
+ // Test that each sequence of a backslash (\) immediately followed by zero or
+ // more hor
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,347 @@
+// This checks that clang-scan-deps properly outputs named module dependencies
+// when using the the scanning output format 'experimental-full'.
+//
+// See commit 72304.
+// UNSUPPORTED: target={{.*}}-aix{{.*}}
+//
+// The slash direction in linux and windows
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145221
>From 981742eea871868d58293e9a2b58fb3ef2569e7c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sat, 21 Jun 2025 18:54:38 +0200
Subject: [PATCH 1/7] [clang][clang-scan-deps] Add named modules to format
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/4] [clang-format] Handle Trailing Whitespace After Line
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,14 @@
+// RUN: grep -Ev "// *[A-Z-]+:" %s \
naveen-seth wrote:
Sorry, I misunderstood that! Implemented as unit tests now.
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-co
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/3] [clang-format] Handle Trailing Whitespace After Line
@@ -0,0 +1,14 @@
+// RUN: grep -Ev "// *[A-Z-]+:" %s \
naveen-seth wrote:
Fixed.
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145243
>From 8cee6b33c54aca0ea69b3ad291287464523a3d7a Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Sun, 22 Jun 2025 18:06:07 +0200
Subject: [PATCH 1/2] [clang-format] Handle Trailing Whitespace After Line
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/145243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145243
…223R2)
Fixes #145226.
Implement
[P2223R2](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2223r2.pdf)
in clang-format to correctly handle cases where a backslash '\\' is followed by
trailing w
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/145220
>From cc92d075db7e9b0cd4c8187e9dc8e20bf4151fdc Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Fri, 13 Jun 2025 09:19:21 +0200
Subject: [PATCH] [clang][modules-driver] Add scanner to detect C++20 modu
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145220
This PR is part of a series aimed at implementing native support for explicit
module builds from the Clang driver.
This introduces a new scanner that detects C++20 module usage in source files
without using
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/145221
This adds standard C++ named modules to the scanning output format
'experimental-full'.
This is motivated by an effort to provide native support for explicit module
builds from the Clang driver.
The driver
naveen-seth wrote:
Hi @hyp, @Bigcheese, would you be available to review this?
https://github.com/llvm/llvm-project/pull/143950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/143950
P2223R2 allows the line-continuation slash `\` to be followed by additional
whitespace. The Clang lexer already follows this behavior, also for versions
prior to C++23. The dependency directive scanner howe
naveen-seth wrote:
Thanks for the review.
In case the changes get approved, please also merge it on my behalf since I
don't have commit access yet. Thank you!
https://github.com/llvm/llvm-project/pull/141695
___
cfe-commits mailing list
cfe-commits@l
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/141695
>From 8556e25c43fff5525501113f38dc0f3b48203f5c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Wed, 28 May 2025 02:26:54 +0200
Subject: [PATCH 1/4] [C2y] Correctly handle FP-suffixes on prefixed octal
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/141695
>From 8556e25c43fff5525501113f38dc0f3b48203f5c Mon Sep 17 00:00:00 2001
From: Naveen Seth Hanig
Date: Wed, 28 May 2025 02:26:54 +0200
Subject: [PATCH 1/3] [C2y] Correctly handle FP-suffixes on prefixed octal
naveen-seth wrote:
Ping
https://github.com/llvm/llvm-project/pull/141695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Hi @Bigcheese, can I tag you for review?
https://github.com/llvm/llvm-project/pull/142455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/naveen-seth created
https://github.com/llvm/llvm-project/pull/142455
This simply moves code for diagnosing misuse of arguments `/Fo`, `/Fa`, and
`/o` from `Driver::BuildActions` into `Driver::handleArguments`, following the
intention of 740f69b.
This change better aligns wi
@@ -1432,14 +1432,26 @@ void
NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) {
Diags.Report(TokLoc, DiagId);
++s;
DigitsBegin = s;
-SawOctalPrefix = true;
+radix = 8;
naveen-seth wrote:
I don't think the octal digi
naveen-seth wrote:
Yes, please.
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
naveen-seth wrote:
Thank you for reviewing!
(And apologies for the formatting and coding-standard issues on my end!)
https://github.com/llvm/llvm-project/pull/139457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/8] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/7] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/6] [clang] Enforce 1-based indexing for command line source
https://github.com/naveen-seth updated
https://github.com/llvm/llvm-project/pull/139457
>From 5f246435b9784113ada3f82328433487391f40ab Mon Sep 17 00:00:00 2001
From: naveen-seth
Date: Sun, 11 May 2025 14:24:00 +
Subject: [PATCH 1/3] [clang] Enforce 1-based indexing for command line source
1 - 100 of 121 matches
Mail list logo
