nicovank wrote:
You're right -- it's already being run, but only on the changed lines, not the
entire file. Either way, it should cover future diffs minus rare weird edge
cases.
https://github.com/llvm/llvm-project/pull/143324
___
cfe-commits mailing
https://github.com/nicovank approved this pull request.
LGTM! Can confirm that all `.cpp` and `.h` files in
`clang-tools-extra/clang-tidy` pass under `clang-format` head. Maybe this can
be added to some formatter CI? I'm not familiar with the CI setup.
https://github.com/llvm/llvm-project/pull
@@ -39,23 +38,6 @@ class UseTrailingReturnTypeCheck : public ClangTidyCheck {
private:
Preprocessor *PP = nullptr;
nicovank wrote:
Is this field still needed now?
https://github.com/llvm/llvm-project/pull/140759
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/140759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -28,7 +27,7 @@ struct ClassifiedToken {
class UseTrailingReturnTypeCheck : public ClangTidyCheck {
public:
UseTrailingReturnTypeCheck(StringRef Name, ClangTidyContext *Context)
- : ClangTidyCheck(Name, Context) {}
+ : ClangTidyCheck(Name, Context) {};
---
https://github.com/nicovank approved this pull request.
LGTM!
AFAICT in this case this won't make an immediate performance difference since
fields in this struct are primitives, but may in the future if the struct
changes. This probably won't trigger
[performance-move-const-arg](https://clang
nicovank wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/139307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/139307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank approved this pull request.
https://github.com/llvm/llvm-project/pull/139307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nicovank wrote:
> But it might not be a `UnaryOperator`, no?
`unaryOperator(...).bind("op")` implies `op` will always be a `UnaryOperator`.
https://github.com/llvm/llvm-project/pull/138283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/nicovank requested changes to this pull request.
This is not needed IMO. This is a simple matcher, `op` is expected to always be
bound.
One might say that it can't hurt to add extra checks, but I don't think that's
good justification for adding more code / bloat, even if in
https://github.com/nicovank approved this pull request.
https://github.com/llvm/llvm-project/pull/138305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/135824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/135826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/135826
`check_clang_tidy` now matches full lines only, so `{{^}}` clauses are no
longer necessary.
I am splitting those changes over multiple PRs to make review easier. Numbering
them but the actual order doesn't m
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/133756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Apr 2025 13:51:59 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-wh
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 3f332176331ff0da2413eae0db9e7f9ce816bbd1 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 7 Apr 2025 13:51:59 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-wh
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/133756
See Discourse post here:
https://discourse.llvm.org/t/rfc-using-match-full-lines-in-clang-tidy-tests/85553
I've added `--match-partial-fixes` to all tests that were failing, unless I
noticed the fix was quick
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 13:33:10 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
nicovank wrote:
Line 520: th
@@ -535,7 +535,7 @@ struct FragmentCompiler {
}
if (Filters->empty())
return std::nullopt;
-auto Filter = [Filters](llvm::StringRef Path) {
+auto Filter = [Filters = std::move(Filters)](llvm::StringRef Path) {
for (auto &Regex : *Filters)
--
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 15:16:32 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 4df359ed712486c9fc94f1296474cdb06715 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 15:16:32 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
@@ -245,15 +246,15 @@ def check_no_diagnosis(self, clang_tidy_output: str) ->
None:
def check_fixes(self) -> None:
if self.has_check_fixes:
-try_run(
-[
-"FileCheck",
-"-input-file=" + self.temp_f
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133756
>From 79484e3802c16ca2f5d3e8c46b2f8895ce580795 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Mon, 31 Mar 2025 13:33:10 -0400
Subject: [PATCH] [clang-tidy] Use --match-full-lines instead of
--strict-w
@@ -172,7 +172,7 @@ void test(std::string s, std::string_view sv, sub_string
ss, sub_sub_string sss,
0 != s.compare(0, sv.length(), sv);
// CHECK-MESSAGES: :[[@LINE-1]]:{{[0-9]+}}: warning: use starts_with
- // CHECK-FIXES: s.starts_with(sv);
+ // CHECK-FIXES: !s.starts
nicovank wrote:
The main changes are here.
https://github.com/llvm/llvm-project/pull/133756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/133140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:28:56 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:35:05 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
@@ -71,12 +72,13 @@ def try_run(args, raise_error=True):
# This class represents the appearance of a message prefix in a file.
class MessagePrefix:
-def __init__(self, label):
+
nicovank wrote:
Note that this space is "on purpose", the formatter wants it
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 6d0068c97341a93ee116878599c13e429082b0a8 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:35:05 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/133140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/133140
>From 48bb3c79069c9bad5ee01865058a155368586b2e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Thu, 27 Mar 2025 13:28:56 -0400
Subject: [PATCH] [NFC][clang-tidy] Add type annotations to check_clang_tidy
@@ -48,15 +48,16 @@
import re
import subprocess
import sys
+from typing import List, Tuple
nicovank wrote:
`list` and `tuple` are Python 3.9: https://peps.python.org/pep-0585/
LLVM minimum Python version is 3.8 for now:
https://github.com/llvm/llvm-project/bl
@@ -71,12 +72,12 @@ def try_run(args, raise_error=True):
# This class represents the appearance of a message prefix in a file.
class MessagePrefix:
-def __init__(self, label):
+def __init__(self, label: str):
nicovank wrote:
Good catch, thank you, I a
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/133140
I'm looking to make some changes in this file, start by typing it.
```
> python3 -m mypy --strict clang-tools-extra/test/clang-tidy/check_clang_tidy.py
Success: no issues found in 1 source file
```
>From ba5
nicovank wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank approved this pull request.
I saw you have a pending commit access request -- I'll just let you merge this
when you are able to.
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@list
https://github.com/nicovank approved this pull request.
LGTM, thanks!!
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -128,7 +128,12 @@ Changes in existing checks
` check by providing additional
examples and fixing some macro related false positives.
-- Improved :doc:`performance/unnecessary-value-param
+- Improved :doc:`modernize-use-starts-ends-with
+ ` check by adding more
+ match
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/129564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,788 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Vicente Mataix =?utf-8?q?Ferrándiz?= ,
Vicente Mataix =?utf-8?q?Ferrándiz?= ,
Vicente Mataix =?utf-8?q?Ferrándiz?=
Message-ID:
In-Reply-To:
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+pars
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/122957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/122957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/122957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -31,6 +31,6 @@ Options
A semicolon-separated list of names of types allowed to be copied in each
iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches
every type with suffix `Ref`, `ref`, `Reference` and `reference`. The
default
-
@@ -31,6 +31,6 @@ Options
A semicolon-separated list of names of types allowed to be copied in each
iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches
every type with suffix `Ref`, `ref`, `Reference` and `reference`. The
default
-
@@ -31,6 +31,6 @@ Options
A semicolon-separated list of names of types allowed to be copied in each
iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches
every type with suffix `Ref`, `ref`, `Reference` and `reference`. The
default
-
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/nicovank commented:
Some comments.
Regarding usage of `std::string`: Right now the library takes a `StringRef`
through `Template` and `Parser`, and then keeps (2-4?) copies of chunks of the
input in `Token` (`RawBody` and `TokenBody`) then `ASTNode` (`RawBody` and
`Body`).
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
nicovank wrote:
I might have missed it but test re-using `Template` and rendering twice?
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/105893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,785 @@
+//===-- Mustache.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,114 @@
+//===--- Mustache.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/nicovank approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/120963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nicovank wrote:
Sync with
[ClangTidyMain.cpp](https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp#L57-L58)?
https://github.com/llvm/llvm-project/blob/d36836de0183b9b1939cc679d153e3b313e55c76/clang-tools-extra/cla
@@ -9,7 +9,7 @@ See also:
.. toctree::
:maxdepth: 1
- The list of clang-tidy checks
+ The List of Clang-Tidy Checks
nicovank wrote:
Maybe?
```suggestion
List of Clang-Tidy Checks
```
https://github.com/llvm/llvm-project/pull/119938
https://github.com/nicovank approved this pull request.
Ctrl+F -ing for lowercase `clang-tidy` reveals a couple more places where it
should maybe be updated: lines 331, 350 and 352 (`` :program:`clang-tidy` ``?).
It's very minor anyway.
https://github.com/llvm/llvm-project/pull/119938
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/119938
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,6 +10,7 @@ See also:
:maxdepth: 1
The list of clang-tidy checks
+ The list of clang-tidy global options
Clang-tidy IDE/Editor Integrations
Getting Involved
External Clang-Tidy Examples
nicovank wrote:
Just a drive-by comment, n
nicovank wrote:
I see, thanks for looking into it! To be honest I think `file_name_re` could be
removed, `--source-filter` already takes in a regex and filters files based on
it, which is more clear. The `files` arguments could just be taken as-is as a
list of file paths (or maybe optionally d
nicovank wrote:
Is there a reason to bring it back? Is it causing issues?
IIRC this was on purpose because from `os.path.abspath`:
> On most platforms, this is equivalent to calling the function
> [normpath()](https://docs.python.org/3/library/os.path.html#os.path.normpath)
> as follows: normpa
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/117837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank created
https://github.com/llvm/llvm-project/pull/117837
In C++20, `operator!=` can be rewritten by negating `operator==`. This is the
case for `std::string`, where `operator!=` is not provided hence relying on
this rewriting.
Cover this case by matching `binaryOp
nicovank wrote:
Incorporated in #116033.
https://github.com/llvm/llvm-project/pull/116132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank closed
https://github.com/llvm/llvm-project/pull/116132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nicovank edited
https://github.com/llvm/llvm-project/pull/116033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -183,38 +210,43 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
https://github.com/nicovank approved this pull request.
LGTM minus 1 nit. Thanks!
https://github.com/llvm/llvm-project/pull/116033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -183,40 +210,47 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
@@ -183,40 +210,47 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
@@ -183,40 +210,45 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
@@ -183,40 +210,45 @@ void UseStartsEndsWithCheck::check(const
MatchFinder::MatchResult &Result) {
const auto *EndsWithFunction =
Result.Nodes.getNodeAs("ends_with_fun");
assert(bool(StartsWithFunction) != bool(EndsWithFunction));
+
const CXXMethodDecl *Replacemen
1 - 100 of 461 matches
Mail list logo
