[PATCH] D151730: [RISCV] Support target attribute for function

2023-11-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 558134. BeMg added a comment. 1. reuse the find result 2. replace for loop with llvm::copy_if 3. use explicit std::vector declaration instead of auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https

[PATCH] D151730: [RISCV] Support target attribute for function

2023-11-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D151730: [RISCV] Support target attribute for function

2023-11-03 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:370 + std::vector &Features) { + Features.push_back("__RISCV_TargetAttrNeedOverride"); + auto RII = llvm::RISCVISAInfo::parseArchString( craig.topper wrote

[PATCH] D151730: [RISCV] Support target attribute for function

2023-11-02 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 557995. BeMg added a comment. 1. remain else if by removing continue 2. Keep NonISAExtFeature after override 3. Update testcase with -target-feature +save-restore 4. Improve resolveTargetOverride function Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D151730: [RISCV] Support target attribute for function

2023-11-02 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:434 +if (MarchFromCPU != "") { + Ret.Features.clear(); + handleFullArchString(MarchFromCPU, Ret.Features); craig.topper wrote: > Why does this clear Ret.Features,

[PATCH] D151730: [RISCV] Support target attribute for function

2023-10-31 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 557943. BeMg added a comment. Herald added a reviewer: aaron.ballman. Align with spec 1. duplicate target attribute will cause compilation fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://re

[PATCH] D151730: [RISCV] Support target attribute for function

2023-10-05 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D151730: [RISCV] Support target attribute for function

2023-09-12 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 556544. BeMg added a comment. Update to lastest spec 1. When it exist the duplicate target attribute, select the lastest one. 2. arch's features will override cpu's features. TargetFeature will override commandline feature. 3. enhence the testcase Repository:

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

2023-09-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. Thanks for the review. I'm working on RISC-V FMV support, and we found the large set of extension features is hard to maintain the priority that doesn't collision at all. Lack the appropriate priority, it will generate the random mangling name. The predictable mangling na

[PATCH] D159174: [clang] Use stable_sort in AppendTargetMangling

2023-08-30 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added a subscriber: mgrang. Herald added a project: All. BeMg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For the target features in the same priority, make sure it is not a random mangling name. Re

[PATCH] D155935: [RISCV] Enable multiversion function

2023-08-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 552721. BeMg added a comment. Herald added a subscriber: sunshaoce. Rebase and update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155935/new/ https://reviews.llvm.org/D155935 Files: clang/include/cla

[PATCH] D158624: [RISCV] Implement multiVersionSortPriority

2023-08-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, nio

[PATCH] D151730: [RISCV] Support target attribute for function

2023-08-22 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 552265. BeMg added a comment. Also remove the `-` operator from target attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.c

[PATCH] D151730: [RISCV] Support target attribute for function

2023-08-21 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 552200. BeMg added a comment. Herald added a subscriber: sunshaoce. Remove some condition because RFC doesn't support it. (Must include prefix arch|cpu|tune) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/ne

[PATCH] D152423: [RISCV] Add function that check extension name with version

2023-08-20 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b60e1e821b4: [RISCV] Add function that check extension name with version (authored by BeMg). Herald added a subscriber: sunshaoce. Repository: rG

[PATCH] D152423: [RISCV] Add function that check extension name with version

2023-08-15 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 550238. BeMg added a comment. revert last patch because it's wrong one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D152423 Files: llvm/include/llvm/Support/RISCVISAInfo.h

[PATCH] D151730: [RISCV] Support target attribute for function

2023-08-15 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 550237. BeMg added a comment. rebase and update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Tar

[PATCH] D152423: [RISCV] Add function that check extension name with version

2023-08-14 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 549892. BeMg added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. rebase and update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D1

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-08-04 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df05cd01c17: [RISCV] Support overloaded version ntlh intrinsic function (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-08-03 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 546753. BeMg added a comment. Add new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/riscv_ntlh.h cl

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-08-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 546324. BeMg added a comment. Use semacheck and CGBuiltin to support overload version functionY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/CodeGe

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-07-27 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 544645. BeMg added a comment. Add prefix __riscv_ for all marco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 Files: clang/lib/Headers/riscv_ntlh.h clang/test/Code

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

2023-07-25 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D155935: [RISCV] Enable multiversion function

2023-07-21 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D155674: [RISCV] Update zihintntl to 1p0

2023-07-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg abandoned this revision. BeMg added a comment. duplicate with https://reviews.llvm.org/D151547 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155674/new/ https://reviews.llvm.org/D155674 ___ cfe-comm

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

2023-07-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

2023-07-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: llvm/unittests/Support/RISCVISAInfoTest.cpp:376 EXPECT_EQ(Exts.count("zihintntl"), 1U); - auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihintntl0p2", true); + auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihint

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

2023-07-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:151 // RUN: -o - | FileCheck --check-prefix=CHECK-ZIHINTNTL-EXT %s // CHECK-ZIHINTNTL-EXT: __riscv_zihintntl 2000{{$}} The CHECK-ZIHINTNTL-EXT also need update. Reposito

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

2023-07-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: llvm/docs/RISCVUsage.rst:214 +``zihintntl`` LLVM implements the `0.2 draft specification `__. zihintntl could add into `table:: Ratified E

[PATCH] D155674: [RISCV] Update zihintntl to 1p0

2023-07-18 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, nio

[PATCH] D151730: [RISCV] Support target attribute for function

2023-07-13 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 539907. BeMg added a comment. Move riscv-func-attr-target.ll into D155155 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: cla

[PATCH] D151730: [RISCV] Support target attribute for function

2023-07-13 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 539901. BeMg added a comment. Update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.

[PATCH] D151730: [RISCV] Support target attribute for function

2023-07-12 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 539856. BeMg added a comment. separate the change to RISCVAsmPrinter.cpp into another patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targ

[PATCH] D151730: [RISCV] Support target attribute for function

2023-07-12 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 539428. BeMg added a comment. 1. simplify riscv-func-attr-target.ll 2. handle corner case in parseTargetAttr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: cla

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-29 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 535653. BeMg added a comment. Use getTargetFeatureForExtension instead of isSupportExtension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Tar

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-28 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:385 + StringRef ExtName = Ext.substr(1); + if (llvm::RISCVISAInfo::isSupportedExtensionWithVersion(ExtName) || + llvm::RISCVISAInfo::isSupportedExtension(ExtName)) ---

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-27 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 535191. BeMg marked 8 inline comments as done. BeMg added a comment. Add const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-25 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 534428. BeMg added a comment. 1. Attrstring -> AttrString 2. using StringRef instead of string 3. Append unsupported target feature Let follow-up procedure raise diagnostic code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-09 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 529906. BeMg added a comment. 1. Update testcase 2. Remove supportsMultiVersioning for RISCV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Tar

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-07 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 529510. BeMg added a comment. Use isSupportedExtensionWithVersion to implement parseTargetAttr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/cla

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-05 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 528390. BeMg added a comment. 1. Update testcase 2. Support - 3. Verfy extension version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Bas

[PATCH] D151730: [RISCV] Support target attribute for function

2023-06-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 527748. BeMg added a comment. 1. Update RTS's function name 2. Add backend testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Basic/Ta

[PATCH] D151730: [WIP][RISCV] Support target attribute for function

2023-05-31 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 526988. BeMg added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D151730: [RISCV] Support target attribute for function

2023-05-30 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D149126: [RISCV][NFC] skip non-RISCV target test riscv32-zihintntl.c

2023-04-24 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc72e8fe6758: [RISCV][NFC] skip non-RISCV target test riscv32-zihintntl.c (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D149126: [RISCV][NFC] skip non-RISCV target test riscv32-zihintntl.c

2023-04-24 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

2023-04-17 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; craig.topper wrot

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

2023-04-11 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. test_nontemporal_load_v16i8 test_nontemporal_load_v8i16 These two test cases in nontemporal.ll are affected by `areTwoSDNodeTargetMMOFlagsMergeable`. Does we need extra testcases for `areTwoSDNodeTargetMMOFlagsMergeable`? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

2023-03-29 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 509244. BeMg edited the summary of this revision. BeMg added a comment. Herald added a subscriber: jobnoorman. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143364/new/ https://reviews.llvm.org/D143364 Fil

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-21 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5370255ff18a: [RISCV] Merge Masked and unMasked RVV manual codegen (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-21 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484498. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484459. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484437. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484436. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484251. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d4c6506100b: [RISCV] Refactor RVV Policy by structure (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-20 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 484180. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.org/D139995 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h clang/lib/Sema/SemaRIS

[PATCH] D140361: [WIP][RISCV] Merge Masked and unMasked manual codegen

2022-12-19 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabu

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-16 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 483707. BeMg added a comment. 1. Use Undisturbed, Agnostic and Omit to represent Tail and Mask 2. Replace getDefaultPolicyBits != 0 with !RVVI->isTUPolicy() && !RVVI->isTUMUPolicy() 3. Use llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-15 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 483414. BeMg added a comment. 1. Remove this-> 2. Remove Policy() in struct declarationx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.org/D139995 Files: clang/include/clang/Sup

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-14 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:105 + : TU(_TU), TA(_TA), MU(_MU), MA(_MA) {} + Policy(bool _TU, bool _TA, bool _MU, bool _MA, bool _IntrinsicWithoutMU) + : TU(_TU), TA(_TA), MU(_MU), MA(_MA),

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-14 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:140 +// Just for maintain the old order for quick test. +return std::tie(this->MU, this->MA, this->TA, this->TU) < + std::tie(Other.MU, Other.MA, Other.TA, Other.TU);

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-14 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 483068. BeMg added a comment. 1. Update policy constructor 2. use emplace_back 3. Fix miss WithoutIntrinsicMU in policy equal check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139995/new/ https://reviews.llvm.or

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

2022-12-13 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabu

[PATCH] D136571: [RISCV] add svinval extension

2022-10-26 Thread Piyou Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d7940fd7761: [RISCV] add svinval extension (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571

[PATCH] D136571: [RISCV] add svinval extension

2022-10-25 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470722. BeMg marked 2 inline comments as done. BeMg added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target

[PATCH] D136571: [RISCV] add svinval extension

2022-10-25 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470559. BeMg added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/

[PATCH] D136571: [RISCV] add svinval extension

2022-10-25 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470428. BeMg added a comment. Update RISCVUsage.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs

[PATCH] D136570: [RISCV] Add Svnapot extension

2022-10-24 Thread Piyou Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf8b8426861a7: [RISCV] Add Svnapot extension (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570

[PATCH] D136571: [RISCV] add svinval extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470046. BeMg added a comment. Reorder the def then use the same let Predicates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preprocessor/riscv-tar

[PATCH] D136571: [RISCV] add svinval extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470041. BeMg added a comment. Use Requires<[HasStdSvinval]> instead of using let Predicates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136571/new/ https://reviews.llvm.org/D136571 Files: clang/test/Preproces

[PATCH] D136570: [RISCV] Add Svnapot extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470040. BeMg added a comment. Remove Predicate and AssemblerPredicate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570 Files: clang/test/Preprocessor/riscv-target-featu

[PATCH] D136570: [RISCV] Add Svnapot extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg updated this revision to Diff 470039. BeMg added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Support/RISCVISA

[PATCH] D136571: [RISCV] add svinval extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n

[PATCH] D136570: [RISCV] Add Svnapot extension

2022-10-23 Thread Piyou Chen via Phabricator via cfe-commits
BeMg created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n