[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. > But that's not a problem of this patch, and we will address that later if > needed. Thanks for looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9766fed9c10e: [DeadArgElim] Re-apply: Set unused arguments for internal functions (authored by qcolombet). Repository: rG LLVM Github Monorepo

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a comment. Thanks @thakis ! @fhahn are you okay with the clang tests update as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124699/new/ https://reviews.llvm.org/D124699 ___

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a subscriber: vitalybuka. qcolombet added a comment. Hi @thakis , @dyung , @vitalybuka, Thanks for the heads-up and the revert. Fixed clang tests included in the diff. Cheers, -Quentin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet updated this revision to Diff 426555. qcolombet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - includes fixes to clang tests that were missed in the original commit. If someone knows who we can add from the clang side to double check the tests

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. Hi Nick, From the backend prospective, this looks fine but you'll want someone to look at the front end part before landing that change. Cheers, -Quentin Repository: rG LLVM Github

[PATCH] D69868: Allow "callbr" to return non-void values

qcolombet added a comment. > I've been concerned about the register live-ins too (I'm less concerned about > the successors issue). Is there documentation on the original decision to > disallow physical register live-ins for MBBs before register allocation? We > could then check to see if

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

qcolombet added a comment. Should we emit an error if we request x86_64h with an arch older than haswell? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775 ___ cfe-commits

[PATCH] D42860: [ReleaseNotes] Add note for the new -fexperimental-isel flag.

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet accepted this revision. qcolombet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4699 +else + CmdArgs.push_back("-global-isel=0"); + } aemerson wrote: > qcolombet wrote: > > qcolombet wrote: > > > I think that it would be useful to also set

[PATCH] D42276: [Driver] Add an -fexperimental-isel driver option to enable/disable GlobalISel

qcolombet added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4699 +else + CmdArgs.push_back("-global-isel=0"); + } I think that it would be useful to also set -global-isel-abort=2, so that users can report problem early. What do you