[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-20 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 360261. quinnp added a comment. Rebasing to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Ta

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-20 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 360128. quinnp added a comment. Rebasing patch. Moving macro definitions from a header file to a src file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: cla

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-19 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359783. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359441. quinnp added a comment. Fixing a run line in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359437. quinnp added a comment. Adding a better comment for the handling of the ppc_fsels intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inc

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359426. quinnp marked 8 inline comments as done. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clan

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359398. quinnp added a comment. Adding a `REQUIRES: powerpc-registered-target` to a testcase and removing checks for `entry:` in front end test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ ht

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359338. quinnp added a comment. Removing entry checks from front end test and renaming a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/C

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359327. quinnp added a comment. Removing entry checks from front end test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsP

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359325. quinnp added a comment. Fixing a syntax error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/B

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359310. quinnp added a comment. Adressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106150/new/ https://reviews.llvm.org/D106150 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D106150: [PowerPC] swdiv_nochk Builtins for XL Compat

2021-07-16 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. This

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359118. quinnp added a comment. Removing a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/built

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359116. quinnp added a comment. Adding `REQUIRES: powerpc-registered target` to front end test case`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/li

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359093. quinnp marked an inline comment as done. quinnp added a comment. Adressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105984/new/ https://reviews.llvm.org/D105984 Files: clang/lib/C

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 nemanjai wrote: > Oh, I beli

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359079. quinnp added a comment. Typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ https://reviews.llvm.org/D105834 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builtins-ppc-xlcomp

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

2021-07-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 359077. quinnp added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Removing some FIXME comments and tests that are handled elsewhere with semachecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

2021-07-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358639. quinnp added a comment. Removing another comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

2021-07-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358637. quinnp added a comment. Removing a misleading comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/Co

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

2021-07-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358613. quinnp retitled this revision from "[PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins " to "[PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins". quinnp added a comment. Fixing indentation. Repository: rG LLVM Git

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

2021-07-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358609. quinnp marked 9 inline comments as done. quinnp added a comment. Addressing review comment about indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 F

[PATCH] D105984: [PowerPC] Vec Div Builtins Restore FMF of Builder

2021-07-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes `__builtin_ppc_recipdivf`, `__builtin_ppc_recipdivd`, `__builtin_ppc_rsqrtf`, and `_

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-12 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358049. quinnp added a comment. Addressing review comments. Using an early exit for SemaFeatureCheck and combining the 3 test cases into 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://revi

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

2021-07-12 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. Thi

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-12 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 358004. quinnp added a comment. Adding tests for each of the features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-12 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 357942. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSemaKinds

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-09 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 357644. quinnp added a comment. Parameterizing the ppc builtin arch sema error. This change is made assuming that the SemaFeatureCheck will be used by other builtins in the future. SemaFeatureCheck is commented to avoid an unused function error when building

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-09 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 357604. quinnp added a comment. Feature is now working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-09 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 357516. quinnp added a comment. Adressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-08 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 357297. quinnp added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Work in progress addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/n

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-06 Thread Quinn Pham via Phabricator via cfe-commits
quinnp added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s //

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-06 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 356774. quinnp added a comment. Updating pwr10 features to include previous features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/lib/Basic/Targets/

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

2021-07-06 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] This patch adds features for pwr7, pwr8, and pwr9 that can be used for semacheking builtin func

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

2021-07-06 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 356719. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-02 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 356272. quinnp marked 4 inline comments as done. quinnp added a comment. Fixing a typo and the format of a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files:

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-07-02 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 356264. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inc

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

2021-07-02 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105360

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-25 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 354498. quinnp added a comment. Added non-vsx implementation of builtins and non-vsx backend tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/inclu

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-22 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 353716. quinnp marked 2 inline comments as done. quinnp added a comment. Fixing the 32bit AIX run line in the testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-21 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 353475. quinnp added a comment. Addressing comments and updating tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.d

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-15 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 352240. quinnp added a comment. Changed the target architecture of tests to follow the convention: BE-pwr7 LE-pwr8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Fi

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

2021-06-11 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Moving the definition of the defineXLCompatMacros function from the header file clang/lib/Basic

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

2021-06-09 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103986

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-27 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 348332. quinnp added a comment. Addressing the last comments made by @nemanjai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/Buil

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-25 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 34. quinnp added a comment. This update is motivated by comments made by @nemanjai. All of the builtin names have been changed to follow the convention of __builtin__. To fulfill the original goal of compatibility with the XL compiler, macros have been a

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-21 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 347029. quinnp added a comment. Adding a comment in BuiltinsPPC.def for motivation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 345519. quinnp added a comment. Removed some unused checks in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.de

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 345517. quinnp added a comment. Re-added some changes that were lost in the previous updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/cl

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 345515. quinnp added a comment. Removing redundant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def llvm/inc

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 345512. quinnp added a comment. [PowerPC] Fixing previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-14 Thread Quinn Pham via Phabricator via cfe-commits
quinnp updated this revision to Diff 345510. quinnp added a comment. Fixed some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp Index: llvm

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

2021-05-13 Thread Quinn Pham via Phabricator via cfe-commits
quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Most of the builtins already had intrinsics and only needed to be implem

<    1   2