[PATCH] D103048: [IR] make -stack-alignment= into a module attr

ro added a comment. One test `FAILs` on Solaris/sparcv9: LLVM :: CodeGen/Generic/ForceStackAlign.ll with LLVM ERROR: Function "g" required stack re-alignment, but LLVM couldn't handle it (probably because it has a dynamic alloca). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > ro wrote: > > glaubitz wrote: > > > joerg

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:135 } +// LLVM lacks atomics support on 32-bit SPARC, so forcibly link with +// libatomic as a workaround. glaubitz wrote: > joerg wrote: > > This comment is misleading.

[PATCH] D118021: [Driver] Use libatomic for 32-bit SPARC atomics support

ro created this revision. ro added reviewers: jyknight, venkatra, efriedma, jrtc27. ro added a project: clang. Herald added a subscriber: fedor.sergeev. ro requested review of this revision. Herald added a subscriber: cfe-commits. Even after D86621 , `clang -m32`

[PATCH] D107559: [clang] Fix libclang linking on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rGa382a746275b: [clang] Fix libclang linking on Solaris (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added a comment. Ah, I forgot: I've meanwhile tested the patch on `x86-64-pc-linux-gnu` (Ubuntu 20.04) where `/usr/bin/ld` is from binutils 2.34: `libclang.so` was versioned just the same without and with the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added inline comments. Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platforms

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro added a comment. In D107559#2928851 , @tstellar wrote: > Is there any kind of comment that is supported by all linkers? Seems there isn't. In that case, we could either move the comments to a separate file (`libclang.README`?), strip the comments

[PATCH] D107559: [clang] Fix libclang linking on Solaris

ro created this revision. ro added reviewers: clang, tstellar, MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny, jyknight. ro requested review of this revision. Herald added a subscriber: cfe-commits. Linking `libclang.so` is currently broken on Solaris: ld:

[PATCH] D104505: [HIP] Defer operator overloading errors

ro added a comment. This patch broke the Solaris/sparcv9 and Solaris/amd64 buildbots:

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +//

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > MaskRay wrote: > > ro wrote: > > > MaskRay wrote: > > > > ro wrote: > > > > > MaskRay

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > ro wrote: > > > > MaskRay wrote: > > > > > ro wrote: >

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro updated this revision to Diff 307067. ro added a comment. Herald added a project: LLVM. - Move declarations to new `sanitizer_solaris.h`. - Augment `check_linker_flag` do reject unknown `-z` options that GNU ld noisily accepts. Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > ro wrote: > > > > MaskRay wrote: > > > > > GNU ld

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > ro wrote: > > MaskRay wrote: > > > GNU ld reports a warning instead of an error when an

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 &&

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use +// dlinfo(RTLD_DI_LINKMAP) instead which works on both Solaris 11.3 and

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: atanasyan, fedor.sergeev, kristof.beyls, arichardson, sdardis, jyknight. Herald added a project: clang. ro requested review of this revision. While investigating the failures of `symbolize_pc.cpp` and

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro created this revision. ro added reviewers: vitalybuka, MaskRay. ro added a project: Sanitizers. Herald added subscribers: Sanitizers, pengfei, fedor.sergeev, mgorny, jyknight. Herald added a project: clang. ro requested review of this revision. In the initial Solaris ASan port, `GetTls` was

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393747 , @glaubitz wrote: > > No worries. I'm glad someone is taking care of the Solaris parts and > appreciate fixes from other parties. My pleasure: hopefully our work will also be for the benefit of the other

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393651 , @glaubitz wrote: > > Please feel free to reach out to the corresponding debian-$ARCH mailing list > for such questions. Debian-specific layouts are not > necessarily obvious at first glance to people not very

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393366 , @glaubitz wrote: > In D90524#2393320 , @ro wrote: > >> In D90524#2393312 , @glaubitz wrote: >> >>> Ping. It would be nice to get this

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

ro abandoned this revision. ro added a comment. Herald added a subscriber: pengfei. Superceded by D90524 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85582/new/ https://reviews.llvm.org/D85582

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro resigned from this revision. ro added a comment. In D90524#2393353 , @glaubitz wrote: > In D90524#2393319 , @ro wrote: > >> In D90524#2388214 , @glaubitz wrote: >> >>> I

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2393312 , @glaubitz wrote: > Ping. It would be nice to get this finally merged so that the testsuite noise > finally goes down on the sparc64 Linux worker. Please be a little more patient: one ping a week is considered

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. In D90524#2388214 , @glaubitz wrote: > I think it should be good for merging now. I addressed all remarks. I'm still > convinced that "workaround" is the proper term though. Quite the contrary: the comment you cited // FIXME: This

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

ro added a comment. As I'd mentioned in D90524 , I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise. Another point I'm not certain about is wether the checks for

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

ro added a comment. As it happens, I'd arrived at exactly the same patch when I tried a build on a Debian/sparc64 system in the GCC compile farm (gcc202), submitted as D85582 . A couple of questions/caveats: - I wouldn't call this patch a workaround, as you do

[PATCH] D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: Sanitizers, s.egerton, dexonsmith, jrtc27, simoncook, fedor.sergeev, hiraditya, mgorny, jyknight. Herald added projects: clang, Sanitizers, LLVM. ro requested review of this revision. The SysVr4 SPARC psABI

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

ro added a comment. This patch broke builds with `gcc`, e.g. Builder clang-solaris11-amd64 Build #6724 : [23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED:

[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

ro abandoned this revision. ro added a comment. Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

ro added a comment. As described in D87825 , this patch broke `Debug` builds on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87588/new/

[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

ro created this revision. ro added reviewers: JonasToth, aaron.ballman. ro added a project: clang. Herald added subscribers: usaxena95, kadircet, fedor.sergeev, jyknight. ro requested review of this revision. Herald added a subscriber: ilya-biryukov. D87588 broke

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9cbe5cf30e3: [X86] Fix stack alignment on 32-bit Solaris/x86 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2278436 , @MaskRay wrote: >> This patch avoid the issue by defaulting to -mstackrealign, just like gcc. > > This sentence from the description should be removed. Sure: I usually review and eventually update the description

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2278002 , @joerg wrote: > I'm still curious about the source of the vptr diff, but that's a minor > question, otherwise. LGTM Thanks. I think I've found what's going on here: the memory ranges are ultimately printed by

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2275045 , @efriedma wrote: > Also, it would be nice to have some regression test coverage; add a Solaris > RUN line to llvm/test/CodeGen/X86/stack-align2.ll ? Sure, done in the updated patch. I'd checked that if `FAIL`s

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 292153. ro added a comment. - Rely on `stackAlignment` default for 32-bit Solaris/x86 - Handle Solaris in `llvm/test/CodeGen/X86/stack-align2.ll` Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 291837. ro added a reviewer: vitalybuka. ro added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Allow for whitespace differences in `vptr.cpp`. Tested on `amd64-pc-solaris2.11` with the previous `-mstackrealign` patch and

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a subscriber: vitalybuka. ro added a comment. In D87615#2273427 , @ro wrote: > > Tested on `amd64-pc-solaris2.11`. However, compared to the `-mstackrealign` > version > there's one regression that I still need to investigate: > >

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 291831. ro retitled this revision from "[clang][Driver] Force stack realignment on 32-bit Solaris/x86" to "[X86] Fix stack alignment on 32-bit Solaris/x86". ro added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Set

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro added a comment. That claim of 16-byte alignment on Solaris is half-wrong: it's definitely wrong on Solaris, but seems to be true on Illumos. However, there's currently no way to distinguish the two other than checking `uname -v` at runtime in a native compiler. The configure triples

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro added a comment. In D87615#2271646 , @efriedma wrote: > > X86Subtarget::initSubtargetFeatures claims that that stack is 16-byte aligned > on Solaris; if that's wrong, we should fix it, not force stack realignment. I missed that (my usual issue of

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro added a comment. In D87615#2271268 , @RKSimon wrote: > Would it be possible to add some tests? Probably not reliably: the tests that usually fail bye the hundreds happen to `PASS` once in a while when the stack pointer is 16-byte aligned by accident.

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

ro created this revision. ro added reviewers: MaskRay, rahmanl, efriedma, RKSimon. ro added a project: clang. Herald added a subscriber: fedor.sergeev. ro requested review of this revision. On Solaris/x86, several hundred 32-bit tests `FAIL`, all in the same way: env

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG76e85ae268f8: [clang][Sparc] Default to -mcpu=v9 for Sparc V8 on Solaris (authored by ro). Repository: rG LLVM Github

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Ping? It's been a week and AFAICT there's nothing left for me to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Is there anything left to do to get approval? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro updated this revision to Diff 289658. ro added a comment. Add FIXME for SparcV8 `MaxAtomicInlineWidth`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 Files: clang/lib/Basic/Targets/Sparc.cpp

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > ro wrote: > > > > efriedma wrote: > > > > > ro wrote: > > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > ro wrote: > > > > efriedma wrote: > > > > > This probably

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; ro wrote: > efriedma wrote: > > ro wrote: > > > brad wrote: > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; efriedma wrote: > ro wrote: > > brad wrote: > > > ro wrote: > >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:350 return A->getValue(); +if (T.getArch() == llvm::Triple::sparc && T.isOSSolaris()) + return "v9"; brad wrote: > ro wrote: > > efriedma wrote: > > > Do we want to

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:224 +Builder.defineMacro("__GCC_HAVE_SYNC_COMPARE_AND_SWAP_8"); + } } efriedma wrote: > ro wrote: > > efriedma wrote: > > > This probably should be refactored so the target-independent

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2249240 , @jrtc27 wrote: > Actually, `__sparcv8` is only for V8; if you have 32-bit V9 on Solaris it > defines `__sparcv8plus` _instead_: > > jrtc27@gcc-solaris11:~$ /opt/solarisstudio12.4/bin/cc -E - -xarch=v9 -m32 >

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro updated this revision to Diff 289128. ro added a comment. Define `__sparcv8` only on 32-bit Solaris/SPARC. Update testcase. Remove `XFAIL`s that only apply to `clang`/2-stage builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247791 , @jrtc27 wrote: > GCC on Linux defines `__sparc_v9__` even with `-m32`. I don't know what > Solaris does but please don't break other operating systems just because > Solaris has broken headers that conflate the

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. In D86621#2247786 , @efriedma wrote: > > For compiler-rt, the XFAILs should probably reflect whatever config the bot > is running. (Alternatively, you could use UNSUPPORTED, but that doesn't seem > warranted here.) That's been

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added reviewers: venkatra, efriedma. ro added a comment. Herald added a subscriber: danielkiss. Ping? It's been a week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. While doing 2-stage builds, the 2 `XFAIL`s due to Bug 42493 were required. However, I've since also done a 1-stage build with gcc 10, which shows Unexpectedly Passed Tests (2): UBSan-Standalone-sparc :: TestCases/Float/cast-overflow.cpp UBSan-Standalone-sparc ::

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro created this revision. ro added reviewers: brad, jyknight. ro added a project: clang. Herald added subscribers: Sanitizers, jfb, jrtc27, fedor.sergeev. Herald added a reviewer: jfb. Herald added a project: Sanitizers. ro requested review of this revision. Herald added a subscriber: dexonsmith.

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rGf59bec7acb82: [clang][Driver] Default to /usr/bin/ld on Solaris (authored by ro). Changed prior to commit: https://reviews.llvm.org/D84029?vs=282192=285484#toc Repository: rG LLVM Github Monorepo

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); MaskRay wrote: > phosek wrote: > > Another option would be `unstable`. > I picked `future` because there is an

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. Ping^2? It's been two weeks now and with having to specify `-DCLANG_DEFAULT_LINKER=/usr/bin/ld ` as a workaround, many tests `FAIL` on Solaris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

ro created this revision. ro added reviewers: echristo, MaskRay, phosek. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. ro requested review of this revision. When building current master on `sparc64-unknown-linux-gnu` (Debian 5.7.10), all 32-bit tests failed to

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. Ping? It's been a week... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/ https://reviews.llvm.org/D84029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

ro added a comment. In D85309#2198505 , @MaskRay wrote: > Please find a suitable test file (clang/test/Driver/solaris-*.c) and add some > tests there (for example, solaris-ld.c) > The challenge is that CLANG_ENABLE_GLD is not a default configuration, so

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

This revision was automatically updated to reflect the committed changes. ro marked 3 inline comments as done. Closed by commit rG710949482edb: [clang][Driver] Dont hardcode --as-needed/--no-as-needed on Illumos (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro marked 3 inline comments as done. ro added a comment. In D84412#2193600 , @MaskRay wrote: > #clang does not have many people. You > might need to add people explicitly.. I always found finding reviewers sort of a

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro updated this revision to Diff 283232. ro added a comment. Incorporate review comments: clarify comment and arg name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 Files:

[PATCH] D85309: [WIP][clang][Driver] Support GNU ld on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: fedor.sergeev, mgorny. ro requested review of this revision. This patch is posted just for reference on top of D84029 and D84412

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro added a reviewer: MaskRay. ro added a comment. Ping? It's been two weeks now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 ___ cfe-commits mailing list

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. In D84029#2170105 , @MaskRay wrote: > Can you add a test to `test/Driver/solaris-ld.c`? No, this needs a separate testcase: the `-C` option unconditionally passed to the linker is only understood by the native `ld`. I've added

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro updated this revision to Diff 282192. ro added a comment. Herald added subscribers: llvm-commits, ormris, delcypher. Herald added a project: LLVM. Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

ro created this revision. ro added a reviewer: clang. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. `ninja check-all` currently fails on Illumos: [84/716] Generating default/Asan-i386-inline-Test FAILED:

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro updated this revision to Diff 280108. ro added a reviewer: MaskRay. ro added a comment. Rebased after D83015 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/ https://reviews.llvm.org/D84029 Files:

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

ro added a comment. This patch introduced a couple of failures on the Solaris buildbots (Solaris/sparcv9 and Solaris/x86 ). E.g. FAIL: Clang :: Driver/env.c (12768 of 69452)

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro created this revision. ro added reviewers: clang, rsmith, mehdi_amini, rnk. ro added a project: clang. Herald added a subscriber: fedor.sergeev. `clang` currently requires the native linker on Solaris: - It passes `-C` to `ld` which GNU `ld` doesn't understand. - To use `gld`, one needs to

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367866: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rL367864: Move LangStandard*, InputKind::Language to Basic (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added a comment. I've now submitted the lldb patch to reflect the `LangStandard.h` move. It turns out the part of isl (included in polly) that uses `InputKind::C` isn't even compiled inside the llvm tree. Nonetheless, I've submitted a patch upstream

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 213243. ro marked 2 inline comments as done. ro added a comment. - Restrict enum class Languge to uint8_t to save space. - Filter patch through clang-format-diff.py Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > ro wrote: > > rnk wrote: > > > Is it feasible to make this an `enum class`? I'm worried about namespace > >

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. In D64793#1613063 , @rnk wrote: > lgtm > > If I interpret @jyknight correctly, having failed to dissuade you, he doesn't > feel strongly enough about this to block it, he just wants to reduce legacy > when feasible. Fully

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro updated this revision to Diff 212993. ro added a comment. Account for enum class Language change in D65562 . Tested as before. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/ https://reviews.llvm.org/D64793 Files:

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro marked 2 inline comments as done. ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > Is it feasible to make this an `enum class`? I'm worried about

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 212992. ro marked an inline comment as done. ro added a comment. Change Language to enum class. Tested as before. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/ https://reviews.llvm.org/D65562 Files:

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro updated this revision to Diff 212763. ro marked 2 inline comments as done. ro added a comment. Updated patch to make use of the move to `Basic`. Tested on top of that one on `x86_64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and `x86_64-pc-linux-gnu`.

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro marked 5 inline comments as done. ro added a comment. In D64793#1604877 , @jyknight wrote: > > I fear it is necessary: at least it matches documented behaviour of both > > the Sun/Oracle Studio compilers and gcc. > > I will defer to your opinion here.

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro created this revision. ro added reviewers: rsmith, rnk. Herald added subscribers: fedor.sergeev, Anastasia, mgorny, jyknight. Herald added a reviewer: bollu. Herald added a project: clang. This patch is a prerequisite for using `LangStandard` from `Driver` in https://reviews.llvm.org/D64793.

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL367351: [Driver] Support -fsanitize=function on Solaris/x86 (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro updated this revision to Diff 212393. ro added a comment. Test i386--solaris instead of x86_64--solaris twice. Retested on x86_64-pc-solaris2.11. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 Files:

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. In D64488#1606716 , @krytarowski wrote: > Something is broken between reviews. and my mailbox as I am not receiving any > e-mails so pinging does not make any effect... no LLVM admin replied to my > questions on this to validate

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL367305: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro added a comment. Ping^2? It's been two weeks now. Who can decide if the LangStandards code can be used from lib/Frontend as is or needs to be moved elsewhere (lib/Basic?) for use by driver code? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64793/new/

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro added a comment. Ping^3? Three weeks and counting... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64488/new/ https://reviews.llvm.org/D64488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64793: [Driver] Properly use values-X[ca].o, values-xpg[46].o on Solaris

ro marked an inline comment as done. ro added a comment. In D64793#1597550 , @jyknight wrote: > Is this really necessary? Users don't typically pass -std= to the driver for > linking anyways (what do you even pass if you've compiled both C and C++ >

[PATCH] D64487: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da6eea07cde: [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC (authored by ro). Changed prior to commit: https://reviews.llvm.org/D64487?vs=208946=211316#toc Repository: rG LLVM

<    1   2   3   >