[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. From what I understand the whole idea here is to just ask the external AST source to complete the record before we import them? If yes, then this seems like the right idea to

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

This revision was automatically updated to reflect the committed changes. Closed by commit rGad7211df6f25 (authored by obruns, committed by teemperor). Changed prior to commit: https://reviews.llvm.org/D77468?vs=255059=255256#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

teemperor added a comment. Landed as ad7211df6f257e39da2e5a11b2456b4488f32a1e Btw, usually patches also need a test (especially if they are less trivial than this one). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. We don't usually use alternative operator spelling in Clang, but otherwise this LGTM. I'll land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I seems quite a lot of APIs in Clang are already requiring non-const Modules so I think this is fine to make D75488 possible. Let's ship it CHANGES

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. I am fine with this if we *really* need it for D75488 . So far the only direct place where we do need the module to be non-const was some redundant assignment for Name (I added a comment in D75488 ),

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. Can you link what code is actually requiring this change? I just went over the patch series and it's not obvious to me what exactly this is used for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

teemperor added a comment. This patch broke the Clang build with enabled modules (which is used by the LLDB bot, but every other bot is also dead: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

teemperor added a comment. My only problem is the reimplementation of the default visit methods with (from what I can tell) the same behavior as the default. If you delete all of these then that would also fix Shafik's point that all the custom dispatch code is technically untested in the unit

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37734f643fb: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1878732 , @balazske wrote: > In D74542#1878576 , @teemperor wrote: > > > @balazske Do you see any problems with this patch? > > > I have no opinion against the change. Probably

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

teemperor added a comment. This broke the LLVM_ENABLE_MODULES build because it introduces a cyclic dependency between LLVM_IR and LLVM_intrinsic_gen: FAILED: tools/lld/lib/ReaderWriter/MachO/CMakeFiles/lldMachO.dir/MachONormalizedFileBinaryReader.cpp.o

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. @balazske Do you see any problems with this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor added a comment. In D74542#1874201 , @martong wrote: > Looks good to me! Thanks! > Adding @balazske as another reviewer though. He worked on something related > to this, where we also experienced an assert in `isBeforeInTranslationUnit`.

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

teemperor created this revision. teemperor added reviewers: martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When importing the main FileID the ASTImporter currently gives it no

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

teemperor added a comment. I ran the patch on macOS and Linux through check-lldb and there were no regressions, so this is LGTM. The libc++ failures should go away when you add `libcxx;libcxxabi` to LLVM_ENABLE_PROJECTS (the tests are using libc++). Repository: rG LLVM Github Monorepo

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

This revision was automatically updated to reflect the committed changes. Closed by commit rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73166: [ASTImporter] Properly delete decls from SavedImportPaths

teemperor added a comment. I can land it, seems to pass all LLDB tests too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73166/new/ https://reviews.llvm.org/D73166 ___ cfe-commits mailing list

[PATCH] D69933: [ASTImporter] Limit imports of structs

teemperor added a comment. I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

teemperor added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory { MadCoder wrote: > aprantl wrote: > >

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. Another bug report for this: https://bugs.llvm.org/show_bug.cgi?id=44331 Please close when landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 ___ cfe-commits

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

This revision was automatically updated to reflect the committed changes. Closed by commit rGccfab8e4596e: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233998. teemperor added a comment. - Further reduced test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4558497ff6: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor updated this revision to Diff 233968. teemperor added a comment. - Addressed Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 Files: clang/include/clang/AST/ExternalASTSource.h

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor marked an inline comment as done. teemperor added a comment. In D71397#1782537 , @lhames wrote: > Side note: This https://reviews.llvm.org/D39111 seems related. The patch has > languished as I have been busy with other work, but if it would be

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor updated this revision to Diff 233756. teemperor added a comment. - Removed Objective-C metadata from LLVM test. - Removed quoted attributes. - Update DebugInfoFlags.def to be compatible with D68117 assuming probinson are applied there. CHANGES SINCE

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. I wonder if we have a way to fix this from with LLDB. Having Clang code that is only tested in LLDB is always a bit weird. Otherwise the idea itself LGTM, thanks for working on this (and reducing the test case to that!) Comment at:

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. See D71398 for the LLDB removal of our own RTTI workaround. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 ___

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor added a comment. I didn't add specific ID's to all of the subclasses in clang/clang-tools-extra because we never actually check for these specific classes anywhere from what I can see. But if anyone thinks that would be useful to have then I can update the patch. Repository: rC

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

teemperor created this revision. teemperor added reviewers: aprantl, dblaikie, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently have some very basic LLVM-style RTTI support in the ExternalASTSource class hierarchy based on the `SemaSource` bool( to

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. With DWARF5 it is no longer possible to distinguish normal methods and methods with `__attribute__((objc_direct))` by just

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG164e0fc5c7f7: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232547. teemperor added a comment. - Reverted unintentional change to unreachable error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } martong wrote: > I think, we should keep the "Not implemented yet!"

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232541. teemperor added a comment. - Put code in raw string (Thanks Gabor!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor created this revision. teemperor added a reviewer: martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When Sema encounters a ObjCMethodDecl definition it declares the implicit

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70440/new/ https://reviews.llvm.org/D70440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

teemperor added a comment. FYI, this doesn't compile, see: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/10890 (and probably all other build bots that are starting to break). FAILED: tools/sancov/CMakeFiles/sancov.dir/sancov.cpp.o

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. 6c0a160c2d33e54aecf1538bf7c85d8da92051be renamed the file (thanks Jeremy). In D63607#1726978 , @peterwaller-arm wrote: > In D63607#1726895

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7bde65dcff: [ASTImporter] Add support for BuiltinTemplateDecl (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69566/new/

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

teemperor added a comment. Could we have the `clang/test/Driver/flang/flang.F90` and `clang/test/Driver/flang/flang.f90` files in different directories please? As macOS's FS is case-insensitive, those two files have the same path from macOS perspective which is causing a whole bunch of issues

[PATCH] D69566: [ASTImporter] Add support for BuiltinTemplateDecl

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. Herald added subscribers: cfe-commits, kristina, rnkovacs. Herald added a reviewer: shafik. Herald added a project: clang. That decl kind is currently not implemented. BuiltinTemplateDecl is for decls that are

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

teemperor resigned from this revision. teemperor added a comment. This LGTM modulo rjmccall's comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ cfe-commits mailing list

[PATCH] D67774: [Mangle] Check ExternalASTSource before adding prefix to asm label names

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I wonder what's the motivation for making this a setting in the ExternalASTSource? Opposed to e.g. storing a bit in AsmLabelAttr, which we could squeeze in by maybe stealing a

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

teemperor added a comment. Seems like this patch introduced a cyclic dependency between Basic and AST when building with LLVM_ENABLE_MODULES=On: While building module 'Clang_AST' imported from llvm/lldb/include/lldb/Symbol/ClangUtil.h:14: While building module 'Clang_Basic' imported from

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

This revision was automatically updated to reflect the committed changes. Closed by commit rL368510: [clang] Fixed x86 cpuid NSC signature (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

teemperor accepted this revision. teemperor added a comment. LGTM. Thanks for the patch! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65978/new/ https://reviews.llvm.org/D65978 ___ cfe-commits mailing list

[PATCH] D65978: [clang] Fixed x86 cpuid NSC signature

teemperor added a comment. @Jacotot I assume you don't have commit access to merge yourself? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65978/new/ https://reviews.llvm.org/D65978 ___ cfe-commits mailing list

[PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

teemperor added a comment. The error handling in LLDB seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ cfe-commits mailing list

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks a lot for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61333/new/ https://reviews.llvm.org/D61333

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. On my system clang-format has some complaints, so I think you need to rerun clang-format. Probably caused by the rebasing. I have some minor comments about the TestAST.py (see

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

teemperor added a comment. @martong Sorry for the delay, feel free to ping me in the future about these patches. I'll review them ASAP now that I'm back in office, so these delay's hopefully won't happen again. I tried applying this patch and it seems it needs to be rebased. I would do it

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

teemperor added a comment. I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB. Otherwise the LLDB part of this patch LGTM. Repository: rG LLVM

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor closed this revision. teemperor added a comment. This has been landed as rC359338 but somehow Phabricator didn't close this. Closing this manually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61140/new/ https://reviews.llvm.org/D61140

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor, committed by ). Changed prior to commit:

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor added a comment. I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review! CHANGES SINCE LAST ACTION

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 197149. teemperor added a comment. - Refactored test according to Gábor's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 196955. teemperor retitled this revision from "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior." to "[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.". teemperor edited the summary of this

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. Sorry, that test case actually was a bit too complicated. This seems to work: diff --git a/clang/test/Import/cxx-record-flags/Inputs/F.cpp b/clang/test/Import/cxx-record-flags/Inputs/F.cpp new file mode 100644 index 000..1294c67f68d --- /dev/null +++

[PATCH] D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition

teemperor added a comment. In D61140#1479111 , @aprantl wrote: > Could we test this by doing -dump-ast of From and To and FileCheck-ing the > output? +1 for this. Importing a simple record should test this? E.g. something like this: diff --git

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 192594. teemperor added a comment. Ah, I get it now. Fixed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTImporter.cpp

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:590 + new RedirectingImporter(ToContext, ToFileManager, FromContext, + FromFileManager, MinimalImport, LookupTabl)); +}; a_sidorin

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 192588. teemperor marked an inline comment as done. teemperor added a comment. - Addressed (most of) Aleksei's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files:

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. In D59485#1439628 , @martong wrote: > In D59485#1439570 , @martong wrote: > > > In D59485#1439390 , @teemperor > > wrote: > > > > > > Well, I

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191946. teemperor marked 5 inline comments as done. teemperor added a comment. - Removed unused functions. - Fixed two comments that I missed to update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor added a comment. > Well, I still don't understand how LLDB synthesis the AST. > So you have a C++ module in a .pcm file. This means you could create an AST > from that with ASTReader from it's .clang_ast section, right? In that case > the AST should be complete with all type

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191859. teemperor marked 4 inline comments as done. teemperor added a comment. - Addressed feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191765. teemperor retitled this revision from "[ASTImporter] Allow adding a import strategy to the ASTImporter" to "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior.". teemperor edited the summary of this revision. teemperor

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL356592: Remove the unused return value in ASTImporter::Imported [NFC] (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

teemperor created this revision. teemperor added reviewers: balazske, martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. `ASTImporter::Imported` currently returns a Decl, but that return

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor planned changes to this revision. teemperor added a comment. I think we could also refactor the strategy into a `PreImport` call. That way we don't break all the user-code out there and it seems less intrusive to the ASTImporter code. I'll update the patch. CHANGES SINCE LAST ACTION

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor updated this revision to Diff 191257. teemperor retitled this revision from "[ASTImporter] Allow adding a shim to the ASTImporter" to "[ASTImporter] Allow adding a import strategy to the ASTImporter". teemperor edited the summary of this revision. teemperor added a comment. Thanks for

[PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

teemperor created this revision. teemperor added reviewers: martong, balazske, a.sidorin, shafik. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. We are currently implementing support in LLDB that reconstructs the STL templates from the target program in the

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/D58743 ___ cfe-commits mailing

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think the idea of the patch is right. Not sure tough if having Import take a second parameter is consistent with the other Import functions (and if that even matters).

[PATCH] D57956: [www] Add ASTImporter fuzzer project.

teemperor closed this revision. teemperor added a comment. landed in llvm-svn: 354043 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57956/new/ https://reviews.llvm.org/D57956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

teemperor resigned from this revision. teemperor added a comment. LGTM for the CloneChecker changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/ https://reviews.llvm.org/D57850 ___ cfe-commits mailing

[PATCH] D56936: Fix handling of overriden methods during ASTImport

teemperor accepted this revision. teemperor added a comment. LGTM, thanks! Comment at: unittests/AST/ASTImporterTest.cpp:2271 +struct D:B { void f(){}; }; + )"; + auto BFP = I think this should be formatted in the same way as the snippet above.

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor abandoned this revision. teemperor added a comment. So, the idea of going back to the headers and see if we can potentially remove mm_malloc from the modulemap didn't work out (mostly because a lot of headers include it indirectly). However, when going back to the original issue i

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rC351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351739: [ASTImporter] Add test for importing anonymous namespaces. (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

teemperor updated this revision to Diff 182761. teemperor added a comment. - Added a comment that the using directives are created by Sema. Also sorry for the late update :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51178/new/ https://reviews.llvm.org/D51178 Files:

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor updated this revision to Diff 182718. teemperor added a comment. - Moved code into the VisitFunctionDecl function. I don't mind if we clean up that function in a later commit. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor added a comment. Didn't really upstream any non-trivial ASTImporter patches yet, so please point out any style errors. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56651/new/ https://reviews.llvm.org/D56651

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

teemperor created this revision. teemperor added reviewers: shafik, martong, a_sidorin. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Shafik found out that importing a CXXConstructorDecl will create a translation unit that causes Clang's CodeGen to crash.

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor added a comment. @joerg Yeah, we saw the commit explaining why the original fwd declaration patch was reverted. However, from what I can see, we only have three ways to fix the cyclic dependency between glibc and Clang's internal module: 1. We say that we don't support including

[PATCH] D55475: Misc typos fixes in ./lib folder

This revision was automatically updated to reflect the committed changes. Closed by commit rC348755: Misc typos fixes in ./lib folder (authored by teemperor, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55475/new/ https://reviews.llvm.org/D55475

[PATCH] D55475: Misc typos fixes in ./lib folder

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This looks all good to me and from what see this was requested in a previous review (D44188 ). Do you need someone to commit this or did you receive

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

This revision was automatically updated to reflect the committed changes. Closed by commit rL347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. teemperor added a project: LLDB. Herald added subscribers: cfe-commits, rnkovacs. `MustBuildLookupTable` must always be called on a primary context as we otherwise trigger an assert, but we don't ensure that this

[PATCH] D53639: [autocompletion] Handle the space before pressing tab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D53639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D53639: [autocompletion] Handle the space before pressing tab

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:1514 + // which should end up in a file completion. + bool HasSpace = false; + if (PassedFlags.endswith(","))

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 164885. teemperor marked 3 inline comments as done. teemperor added a comment. - Removed comment about redeclaring free in the test. That's wasn't correctly formulated and is anyway no longer true now that the test case including this file got bigger. -

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 162940. teemperor marked an inline comment as done. teemperor added a comment. - Reverted unintended change to test case that slipped into the latest diff. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor marked 3 inline comments as done. teemperor added inline comments. Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:6 +#include "libc-empty-except.h" + +void f() { bruno wrote: > In a testcase like this but using the actual real headers,

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 162902. teemperor added a comment. - Now using UpdateExceptionSpec. - Added a comment to the SemaExceptionSpec.cpp code why we are permitting this. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp

[PATCH] D51142: [ASTImporter] Add test for PackExpansionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL340627: [ASTImporter] Add test for PackExpansionExpr (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51178: [ASTImporter] Add test for importing anonymous namespaces.

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51178 Files: test/Import/cxx-anon-namespace/Inputs/F.cpp test/Import/cxx-anon-namespace/test.cpp Index:

[PATCH] D51142: [ASTImporter] Add test for PackExpansionExpr

teemperor created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. Repository: rC Clang https://reviews.llvm.org/D51142 Files: test/Import/pack-expansion-expr/Inputs/F.cpp test/Import/pack-expansion-expr/test.cpp Index:

<    1   2   3   4   >