Re: [PATCH] D155580: [trivial-auto-var-init] Do not emit initialization code for empty class

On Tue, Jul 18, 2023 at 10:15:09PM +0900, JF Bastien wrote: > > > On Tue, Jul 18, 2023 at 8:41 PM serge via Phabricator <[1] > revi...@reviews.llvm.org> wrote: > > serge-sans-paille created this revision. > serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman. > Her

Re: [PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

Sure! ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D99409: [clang] Speedup line offset mapping computation

On Wed, Apr 07, 2021 at 12:48:01PM +, Simon Pilgrim via Phabricator wrote: > RKSimon added a comment. > > @serge-sans-paille Please can you look at the clang-ppc buildbot breakages: > http://lab.llvm.org:8011/#/builders/52/builds/6108 I'm on it. __

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look? e

Re: [PATCH] D78192: Support compiler extensions as a normal component

On Fri, Apr 24, 2020 at 10:15:15AM +0100, Russell Gallop wrote: > Hi Serge, > > It looks like this is failing to build on Windows bots (e.g. [1]http:// > lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ > builds/32003). Error below. > > Please could you take a look? S

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 08:08:49PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Unsure if my reply was sent over email so copying it here. > > Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to > fix it. Thanks. Will you be sending out

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

Does adding // REQUIRES: platform-linker to Driver/riscv32-toolchain-extra.c fixes your issue? On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 >

Re: [PATCH] D74704: Support -fuse-ld=lld for riscv

On Wed, Feb 26, 2020 at 06:25:39PM +, Leonard Chan via Phabricator wrote: > leonardchan added a comment. > > Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 > > might've broken our toolchain again: s***t. Can y

Re: [PATCH] D68720: Support -fstack-clash-protection for x86

On Sat, Feb 08, 2020 at 01:26:03PM +, Simon Pilgrim via Phabricator wrote: > RKSimon added a comment. > > @serge-sans-paille Please can you fix the issues with EXPENSIVE_CHECKS > builds: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/2604 yeah, spotted

Re: [PATCH] D68720: Support -fstack-clash-protection for x86

On Fri, Feb 07, 2020 at 07:12:39PM +, Nico Weber via Phabricator wrote: > thakis added a comment. > > This breaks check-clang on mac and win: > http://45.33.8.238/mac/7485/step_7.txt http://45.33.8.238/win/7753/step_7.txt > > Please revert and then investigate asynchronously, unless the fix

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > >  ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > > Why is this running on every test of the pass manager? It should be an > example >

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Mon, Jan 06, 2020 at 03:45:15PM -0800, Eric Christopher wrote: > Hi Serge, Hi Eric, > I have a few questions here about this: > > In general this appears to be a lot more complex than the existing plugin > solutions and requires quite a lot of custom cmake rules that are difficult to > mainta

r372281 - Initialize all fields in ABIArgInfo.

Author: serge_sans_paille Date: Wed Sep 18 17:54:40 2019 New Revision: 372281 URL: http://llvm.org/viewvc/llvm-project?rev=372281&view=rev Log: Initialize all fields in ABIArgInfo. Due to usage of an uninitialized fields, we end up with a Conditional jump or move depends on uninitialised value F

r366194 - [clang-scan-view] Force utf-8 when handling report (python2 only)

Author: serge_sans_paille Date: Tue Jul 16 01:56:47 2019 New Revision: 366194 URL: http://llvm.org/viewvc/llvm-project?rev=366194&view=rev Log: [clang-scan-view] Force utf-8 when handling report (python2 only) Original patch by random human Differential Revision: https://reviews.llvm.org/D64129

Re: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

-fast\llvm.src\tools\clang\tools\extra\test\clang-tidy\empty-database.cpp. > Compile command not found. > > >^ > > > error: command

[clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Added: clang-tools-extr

r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Modified: cfe/trunk/lib

r362584 - Reduce memory consumption of coverage dumps

Author: serge_sans_paille Date: Tue Jun 4 23:35:10 2019 New Revision: 362584 URL: http://llvm.org/viewvc/llvm-project?rev=362584&view=rev Log: Reduce memory consumption of coverage dumps Avoiding an intermediate join operation removes the need for an intermediate buffer that may be quite large,

r360885 - Fix isInSystemMacro in presence of macro and pasted token

Author: serge_sans_paille Date: Thu May 16 05:40:00 2019 New Revision: 360885 URL: http://llvm.org/viewvc/llvm-project?rev=360885&view=rev Log: Fix isInSystemMacro in presence of macro and pasted token When a warning is raised from the expansion of a system macro that involves pasted token, there

r354549 - Revert r354546

Author: serge_sans_paille Date: Wed Feb 20 22:59:21 2019 New Revision: 354549 URL: http://llvm.org/viewvc/llvm-project?rev=354549&view=rev Log: Revert r354546 This triggers an ICE on gcc 7, see http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/17598/steps/build%20stage%201/logs/

r354548 - Fix typo in r354546

Author: serge_sans_paille Date: Wed Feb 20 22:12:41 2019 New Revision: 354548 URL: http://llvm.org/viewvc/llvm-project?rev=354548&view=rev Log: Fix typo in r354546 Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h Modified: cfe/trunk/include/clang/CodeGen/CGFunctionInfo.h URL: http

r354546 - [NFC] Always initialize all members in ABIArgInfo

Author: serge_sans_paille Date: Wed Feb 20 20:55:50 2019 New Revision: 354546 URL: http://llvm.org/viewvc/llvm-project?rev=354546&view=rev Log: [NFC] Always initialize all members in ABIArgInfo Differential Revision: https://reviews.llvm.org/D57523 Modified: cfe/trunk/include/clang/CodeGen/C

r353707 - [tools] Fix python DeprecationWarning: invalid escape sequence

Author: serge_sans_paille Date: Mon Feb 11 07:03:17 2019 New Revision: 353707 URL: http://llvm.org/viewvc/llvm-project?rev=353707&view=rev Log: [tools] Fix python DeprecationWarning: invalid escape sequence The python documentation says "it’s highly recommended that you use raw strings for all b

r352838 - Fix isInSystemMacro to handle pasted macros

Author: serge_sans_paille Date: Thu Jan 31 22:11:44 2019 New Revision: 352838 URL: http://llvm.org/viewvc/llvm-project?rev=352838&view=rev Log: Fix isInSystemMacro to handle pasted macros Token pasted by the preprocessor (through ##) have a Spelling pointing to scratch buffer. As a result they a

r352039 - Fix python3 compability issue in clang binding

Author: serge_sans_paille Date: Thu Jan 24 02:34:44 2019 New Revision: 352039 URL: http://llvm.org/viewvc/llvm-project?rev=352039&view=rev Log: Fix python3 compability issue in clang binding The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 enco

r351706 - Tentative fix for r351701 and gcc 6.2 build on ubuntu

Author: serge_sans_paille Date: Sun Jan 20 15:43:37 2019 New Revision: 351706 URL: http://llvm.org/viewvc/llvm-project?rev=351706&view=rev Log: Tentative fix for r351701 and gcc 6.2 build on ubuntu Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp UR

r351701 - Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...>

Author: serge_sans_paille Date: Sun Jan 20 13:19:56 2019 New Revision: 351701 URL: http://llvm.org/viewvc/llvm-project?rev=351701&view=rev Log: Replace llvm::isPodLike<...> by llvm::is_trivially_copyable<...> As noted in https://bugs.llvm.org/show_bug.cgi?id=36651, the specialization for isPodLi

r350955 - [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

Author: serge_sans_paille Date: Fri Jan 11 11:04:48 2019 New Revision: 350955 URL: http://llvm.org/viewvc/llvm-project?rev=350955&view=rev Log: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py Current clang fail to bootstrap in PGO mode when only python3 is available,

r350467 - [python] Make the collections import future-proof

Author: serge_sans_paille Date: Sat Jan 5 04:07:36 2019 New Revision: 350467 URL: http://llvm.org/viewvc/llvm-project?rev=350467&view=rev Log: [python] Make the collections import future-proof On Python 3.7 the old code raises a warning: DeprecationWarning: Using or importing the ABCs f

r350319 - Portable Python script across Python version

Author: serge_sans_paille Date: Thu Jan 3 06:27:05 2019 New Revision: 350319 URL: http://llvm.org/viewvc/llvm-project?rev=350319&view=rev Log: Portable Python script across Python version Get rid of Python version specific shebang. Differential Revision: https://reviews.llvm.org/D55207 Modifie

r350318 - Portable Python script across Python version

Author: serge_sans_paille Date: Thu Jan 3 06:26:56 2019 New Revision: 350318 URL: http://llvm.org/viewvc/llvm-project?rev=350318&view=rev Log: Portable Python script across Python version StringIO is obsoleted in Python3, replaced by io.BytesIO or io.StringIO depending on the use. Differential

r349627 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 19 05:46:13 2018 New Revision: 349627 URL: http://llvm.org/viewvc/llvm-project?rev=349627&view=rev Log: Portable Python script across Python version urllib2 as been renamed into urllib and the library layout has changed. Workaround that in a consistent mann

r349504 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 08:07:37 2018 New Revision: 349504 URL: http://llvm.org/viewvc/llvm-project?rev=349504&view=rev Log: Portable Python script across Python version Make scripts more future-proof by importing most __future__ stuff. Differential Revision: https://reviews.l

r349503 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 08:07:06 2018 New Revision: 349503 URL: http://llvm.org/viewvc/llvm-project?rev=349503&view=rev Log: Portable Python script across Python version commands.getoutput has been move to subprocess module in Python3 Differential Revision: https://reviews.llv

r349501 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 08:04:21 2018 New Revision: 349501 URL: http://llvm.org/viewvc/llvm-project?rev=349501&view=rev Log: Portable Python script across Python version In Python3, dict.items, dict.keys, dict.values, zip, map and filter no longer return lists, they create gen

r349455 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 00:38:50 2018 New Revision: 349455 URL: http://llvm.org/viewvc/llvm-project?rev=349455&view=rev Log: Portable Python script across Python version In Python2, division between integer yields an integer, while it yields a float in Python3. Use a combinati

r349454 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 00:36:33 2018 New Revision: 349454 URL: http://llvm.org/viewvc/llvm-project?rev=349454&view=rev Log: Portable Python script across Python version Using from __future__ import print_function it is possible to have a compatible behavior of `print(...)` ac

r349449 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 00:25:25 2018 New Revision: 349449 URL: http://llvm.org/viewvc/llvm-project?rev=349449&view=rev Log: Portable Python script across Python version ConfigParser module has been renamed as configparser in Python3 Differential Revision: https://reviews.llvm

r349448 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 00:24:06 2018 New Revision: 349448 URL: http://llvm.org/viewvc/llvm-project?rev=349448&view=rev Log: Portable Python script across Python version Replace `xrange(...)` by either `range(...)` or `list(range(...))` depending on the context. Differential

r349447 - Portable Python script across Python version

Author: serge_sans_paille Date: Tue Dec 18 00:22:47 2018 New Revision: 349447 URL: http://llvm.org/viewvc/llvm-project?rev=349447&view=rev Log: Portable Python script across Python version dict no longer have the `has_key` method in Python3. Instead, one can use the `in` keyword which already wor

r349010 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:45:55 2018 New Revision: 349010 URL: http://llvm.org/viewvc/llvm-project?rev=349010&view=rev Log: Portable Python script across Python version SocketServer has been renamed socketserver in Python3. Differential Revision: https://reviews.llvm.org/D552

r349009 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:44:19 2018 New Revision: 349009 URL: http://llvm.org/viewvc/llvm-project?rev=349009&view=rev Log: Portable Python script across Python version Queue module as been renamed into queue in Python3 Differential Revision: https://reviews.llvm.org/D55202

r349008 - Portable Python script across Python version

Author: serge_sans_paille Date: Wed Dec 12 23:42:30 2018 New Revision: 349008 URL: http://llvm.org/viewvc/llvm-project?rev=349008&view=rev Log: Portable Python script across Python version Use higher-level and more compatible threading module to start a new thread. Differential Revision: https:/

r348184 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:26:51 2018 New Revision: 348184 URL: http://llvm.org/viewvc/llvm-project?rev=348184&view=rev Log: Portable Python script across Python version Workaround naming and hierarchy changes in BaseHTTPServer and SimpleHTTPServer module. Differential Revisi

r348182 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:12:34 2018 New Revision: 348182 URL: http://llvm.org/viewvc/llvm-project?rev=348182&view=rev Log: Portable Python script across Python version Python2 supports both backticks and `repr` to access the __repr__ slot. Python3 only supports `repr`. Diff

r348129 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 04:41:35 2018 New Revision: 348129 URL: http://llvm.org/viewvc/llvm-project?rev=348129&view=rev Log: Portable Python script across Python version Python3 does not support type destructuring in function parameters. Differential Revision: https://reviews.

r348127 - Portable Python script across version

Author: serge_sans_paille Date: Mon Dec 3 04:12:48 2018 New Revision: 348127 URL: http://llvm.org/viewvc/llvm-project?rev=348127&view=rev Log: Portable Python script across version Have all classes derive from object: that's implicitly the default in Python3, it needs to be done explicilty in Py

r348126 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 04:11:21 2018 New Revision: 348126 URL: http://llvm.org/viewvc/llvm-project?rev=348126&view=rev Log: Portable Python script across Python version Python2 supports the two following equivalent construct raise ExceptionType, exception_value and

r302654 - Use clang++-3.5 compatible initializer_list constructor

Author: serge_sans_paille Date: Wed May 10 08:22:11 2017 New Revision: 302654 URL: http://llvm.org/viewvc/llvm-project?rev=302654&view=rev Log: Use clang++-3.5 compatible initializer_list constructor Otherwise, a warning is issued. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/SelectorExtr

r302588 - Fix CGObjCGNU::init bug introduced by r302572

Author: serge_sans_paille Date: Tue May 9 16:19:44 2017 New Revision: 302588 URL: http://llvm.org/viewvc/llvm-project?rev=302588&view=rev Log: Fix CGObjCGNU::init bug introduced by r302572 Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp URL: http

r302572 - Suppress all uses of LLVM_END_WITH_NULL. NFC.

Author: serge_sans_paille Date: Tue May 9 14:31:30 2017 New Revision: 302572 URL: http://llvm.org/viewvc/llvm-project?rev=302572&view=rev Log: Suppress all uses of LLVM_END_WITH_NULL. NFC. Use variadic templates instead of relying on + sentinel. This enforces better type checking and makes cod