[PATCH] D89793: [libc++] Explicitly request new/delete in libc++ for Win to ARM Linux builds

broadwaylamb accepted this revision. broadwaylamb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89793/new/ https://reviews.llvm.org/D89793

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

broadwaylamb added a comment. In D83490#2177256 , @vvereschaka wrote: > - looks like `ssh.py` arguments have been changed since the diff file was > placed. Currently the correct string for `COMPILER_RT_EMULATOR` is the > following: ```

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added a reviewer: vvereschaka. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls, mgorny, dberris. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83490 Files:

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

This revision was automatically updated to reflect the committed changes. Closed by commit rG2899103108d3: [TimeProfiler] Emit clock synchronization point (authored by broadwaylamb). Changed prior to commit: https://reviews.llvm.org/D78030?vs=258061=259413#toc Repository: rG LLVM Github

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5bf02815d8b: [TimeProfiler] Emit real process ID and thread names (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. @russell.gallop thanks! I'll address your comments and commit the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5672 + // initializer. + SuppressAccessChecks diagsFromTag(*this); + This is for things like ``` template<> void X::f() {}

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb marked 3 inline comments as done. broadwaylamb added inline comments. Comment at: clang/include/clang/AST/Decl.h:3198 /// alias-declaration. -class TypeAliasDecl : public TypedefNameDecl { +class TypeAliasDecl : public TypedefNameDecl, public DeclContext { ///

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb updated this revision to Diff 258555. broadwaylamb added a comment. - Add more tests - Allow class template member explicit specializations - Inherit TypeAliasDecl from DeclContext (this is needed so that we could perform access checks when parsing 'using' declaration templates)

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb added a comment. In D78404#1990192 , @rsmith wrote: > ... please also test ... > > template class TemplateClass3 > varTemplate3{}; > > > ... which we should diagnose, because that's a primary variable template > definition, not a partial

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

broadwaylamb added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: I'm not sure we need a new feature

[PATCH] D78404: [clang] Implement P0692R1 from C++20 (access checking on specializations)

broadwaylamb created this revision. broadwaylamb added reviewers: asl, rsmith, doug.gregor, rjmccall, triton. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. This patch implements paper P0692R1

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:222 +J.attribute("pid", Pid); +J.attribute("tid", int64_t(Tid)); +J.attribute("ts", 0); MaskRay wrote: > This

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. Since we're adding a new attribute here that we won't ever be able to remove in the future, I'd still like to get a LGTM from some of the folks that are familiar with the time profiler. @russell.gallop @anton-afanasyev? CHANGES SINCE LAST ACTION

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb updated this revision to Diff 258061. broadwaylamb added a comment. A simpler generation of the beginning of time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 Files: clang/test/Driver/check-time-trace-sections.py

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb updated this revision to Diff 258059. broadwaylamb added a comment. Fix coding style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ https://reviews.llvm.org/D78027 Files: clang/test/Driver/check-time-trace.cpp lld/test/ELF/time-trace.s

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb marked 2 inline comments as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:77 +static std::string getThreadName() { + SmallString<64> Name; MaskRay wrote: > You can define ThreadName as `SmallString<0>` to

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added a comment. It'd be good if I had one more LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb updated this revision to Diff 257340. broadwaylamb added a comment. Indent patterns in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 Files:

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb updated this revision to Diff 257015. broadwaylamb added a comment. Explicitly specify argument types in `writeMetadataEvent` lambda. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ https://reviews.llvm.org/D78027 Files: clang/test/Driver/check-time-trace.cpp

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb created this revision. broadwaylamb added reviewers: anton-afanasyev, russell.gallop, espindola. Herald added subscribers: cfe-commits, MaskRay, hiraditya, emaste. Herald added a project: clang. broadwaylamb added a parent revision: D78027: [TimeProfiler] Emit real process ID and

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb updated this revision to Diff 256993. broadwaylamb added a comment. Remove unrelated changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78027/new/ https://reviews.llvm.org/D78027 Files: clang/test/Driver/check-time-trace.cpp lld/test/ELF/time-trace.s

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

broadwaylamb created this revision. broadwaylamb added reviewers: anton-afanasyev, russell.gallop. Herald added subscribers: cfe-commits, MaskRay, hiraditya, emaste. Herald added a reviewer: espindola. Herald added a project: clang. broadwaylamb added a parent revision: D78022: Introduce

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a6a696817bd: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux. (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added a reviewer: vvereschaka. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Now that D72687 has landed, we can enable this setting in our cache file. Repository:

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG03993f3b6f46: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb).

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249916. broadwaylamb added a comment. Use `CMAKE_CURRENT_LIST_DIR` instead of `CMAKE_SOURCE_DIR` for locating the llvm-project directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. @vvereschaka very interesting. I've downloaded CMake 3.10.2 and finally been able to reproduce the issue locally. So it //is// a CMake bug which does not appear in the latest versions. I'll update this patch to use `CMAKE_CURRENT_LIST_DIR` and add a comment.

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249779. broadwaylamb added a comment. Add one more libc++abi header search path when building libc++ @vvereschaka this is supposed to fix the buildbot failure. It's more of a sweep under the rug type of fix. The real problem is that the value of the

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. Reverted this because it broke our buildbot: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4704/steps/build-llvm-project/logs/stdio. Going to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG801627ee490e: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, aorlov, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. D69169 , which was necessary

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb planned changes to this revision. broadwaylamb added a comment. In D72717#1848509 , @ldionne wrote: > It's weird to mix Clang and libc++ test options because they test > fundamentally different things. But I don't mind about this patch since

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ff4eac1db: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake… (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb added a comment. In D72717#1824858 , @vvereschaka wrote: > I think it is optimal to pass this parameter directly in the builder > configuration only for libcxx as '-DLLVM_LIT_ARGS="--param > enable_filesystem=False"'. You mean, instead of

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, aorlov, andreil99. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Depends on D72847 Repository: rG LLVM Github Monorepo

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb created this revision. broadwaylamb added reviewers: aorlov, vvereschaka, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. `filesystem` tests are not yet supported when running tests on a

[PATCH] D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file

This revision was automatically updated to reflect the committed changes. Closed by commit rGe44dedd3631c: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72459: [CMake] Support running libc++abi tests in CrossWinToARMLinux cache file

broadwaylamb created this revision. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. broadwaylamb edited the summary of this revision. broadwaylamb edited reviewers, added: andreil99, vvereschaka, aorlov;

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

broadwaylamb added a comment. LGTM Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:88-91 +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI OFF CACHE BOOL "") +set(LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX OFF CACHE BOOL "") +set(LIBCXX_LINK_TESTS_WITH_SHARED_LIBCXX

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb added a comment. Can you commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, andreil99. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. The comment was slightly misleading. Repository: rG LLVM Github Monorepo

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. Can someone please commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 ___ cfe-commits mailing list

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. In D66834#1685260 , @sepavloff wrote: > In D66834#1653334 , @broadwaylamb > wrote: > > > In D66834#1652756 , @compnerd > > wrote: > > > > > I

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

broadwaylamb added a comment. In D66981#1651897 , @phosek wrote: > LGTM Can you please commit this? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. In D66834#1652756 , @compnerd wrote: > I think that this is pretty easy to forget. Fortunately, last argument wins. > Why not sink this into the `%clang` substitution in lit? That ensures that > we run with an empty

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

broadwaylamb created this revision. broadwaylamb added reviewers: phosek, rnk, mcgrathr, vitalybuka, beanz, hans, filcab, rsmith, compnerd. Herald added subscribers: javed.absar, srhines. Herald added a project: clang. broadwaylamb edited the summary of this revision. Some Driver tests relied on

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb updated this revision to Diff 217991. broadwaylamb added a comment. Remove unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 Files: clang/test/Driver/darwin-sdkroot.c

[PATCH] D66834: Driver tests: set `--sysroot` to "" to support toolchains with default sysroot

broadwaylamb updated this revision to Diff 217987. broadwaylamb added a comment. Herald added subscribers: atanasyan, jrtc27. Add `--sysroot=""` to some driver regression tests These tests otherwise fail if clang is configured with DEFAULT_SYSROOT. Repository: rG LLVM Github Monorepo

[PATCH] D66834: Driver tests: set `--sysroot` to "" to support toolchains with default sysroot

broadwaylamb created this revision. broadwaylamb added reviewers: rsmith, sfantao, sepavloff. Herald added a project: clang. Herald added a subscriber: cfe-commits. When testing clang that has been compiled with `-DDEFAULT_SYSROOT` set to some path, the test `VFSGCCInstallation` would fail,