[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant. Can we revert this patch until then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. What if CLANG_DEFAULT_LINKER=ld? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 ___ cfe-commits mailing list

[PATCH] D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bee4d4e8f54: Revert [LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by bgraur, committed by SureYeaah).

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373472: [Clangd] ExtractFunction: Dont extract body of enclosing function. (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373471: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153) (authored by SureYeaah, committed by

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

SureYeaah updated this revision to Diff 222815. SureYeaah marked an inline comment as done. SureYeaah added a comment. Added assert and removed fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68245/new/ https://reviews.llvm.org/D68245 Files:

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222585. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files:

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch disable extraction of the body of the enclosing function. `void f() [[{}]]`

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222499. SureYeaah added a comment. Moved Unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files:

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 93. SureYeaah added a comment. Added llmv_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files:

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls. Herald added a project: clang. SureYeaah edited the summary of this revision. We weren't always checking if

[PATCH] D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

SureYeaah accepted this revision. SureYeaah added a comment. This revision is now accepted and ready to land. Herald added a subscriber: usaxena95. Sorry about the delay. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66872/new/

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

This revision was automatically updated to reflect the committed changes. Closed by commit rL370455: [Clangd] ExtractFunction Added checks for broken control flow (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 218053. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217881. SureYeaah added a comment. Added null statement check in TraverseStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217865. SureYeaah added a comment. Removed selectionTree Visitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files:

[PATCH] D65526: [Clangd] First version of ExtractFunction

This revision was automatically updated to reflect the committed changes. Closed by commit rL370249: [Clangd] Initial version of ExtractFunction (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:119 + case SelectionTree::Selection::Partial: +// Treat Partially selected VarDecl as completely selected since +// SelectionTree doesn't always select VarDecls

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217701. SureYeaah marked 14 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:165 +else + SR.setEnd(ChildFileRange->getEnd()); + } kadircet wrote: > I suppose this relies on the fact that "AST contains the nodes ordered by

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217620. SureYeaah added a comment. NFC: Whitespace formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217619. SureYeaah marked 45 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Added a SelectionTreeVisitor to check for broken control flow - Added unittests Repository: rG

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217108. SureYeaah added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 216831. SureYeaah marked 2 inline comments as done. SureYeaah edited the summary of this revision. SureYeaah added a comment. Removed extra code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:360 + +CapturedSourceInfo::DeclInformation & +CapturedSourceInfo::getDeclInformationFor(const Decl *D) {

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:214 +bool IsConst; +Parameter(std::string Name, std::string Type, bool IsConst) +: Name(Name), Type(Type), IsConst(IsConst) {} sammccall

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

SureYeaah accepted this revision. SureYeaah added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/SourceCode.cpp:284 + return SM.getComposedLoc(IncludingFile, Offset); +if (Buf[Offset] == '\n' || Offset == 0) // no

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216805. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216669. SureYeaah marked 33 inline comments as done. SureYeaah added a comment. Herald added a subscriber: mgrang. Addressed Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215615. SureYeaah added a comment. Fixed semicolon bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215574. SureYeaah added a comment. Fixed bug in getLocType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215131. SureYeaah added a comment. Better Naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215098. SureYeaah added a comment. Removed debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215089. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215077. SureYeaah marked 11 inline comments as done. SureYeaah added a comment. Refactored design and added unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

This revision was automatically updated to reflect the committed changes. Closed by commit rL368743: [Refactor] Moving SourceExtraction header from lib to include (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

This revision was automatically updated to reflect the committed changes. Closed by commit rL368267: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

SureYeaah updated this revision to Diff 213973. SureYeaah added a comment. Added endif comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65878/new/ https://reviews.llvm.org/D65878 Files:

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

SureYeaah updated this revision to Diff 213925. SureYeaah added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65883/new/ https://reviews.llvm.org/D65883 Files: clang/lib/Tooling/Refactoring/Extract/SourceExtraction.cpp

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

SureYeaah updated this revision to Diff 213909. SureYeaah added a comment. Removed Do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65883/new/ https://reviews.llvm.org/D65883 Files: clang/lib/Tooling/Refactoring/Extract/SourceExtraction.cpp

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for Do and Switch Stmt

SureYeaah created this revision. SureYeaah added reviewers: arphaman, sammccall. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65883 Files:

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

SureYeaah created this revision. SureYeaah added a reviewer: arphaman. Herald added subscribers: cfe-commits, kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. - Moved the SourceExtraction header from lib to include so that it can be used in clangd. Repository: rG LLVM

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

This revision was automatically updated to reflect the committed changes. Closed by commit rL368058: Fixed toHalfOpenFileRange assertion fail (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213614. SureYeaah added a comment. use fileID instead of hash in map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213599. SureYeaah marked 8 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/ https://reviews.llvm.org/D65754 Files:

[PATCH] D65804: Fixed toHalfOpenFileRange assertion fail

SureYeaah created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Added new function that gets Expansion range with both ends in the same file. - Fixes the crash at https://github.com/clangd/clangd/issues/113

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah updated this revision to Diff 213583. SureYeaah added a comment. Implemented function to get expansion range such that ends are both in the same file id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65754/new/

[PATCH] D65754: Fix toHalfOpenFileRange assertion fail

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Removed assumption that begin and end need to be in same file id. - Fixes the crash at

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah marked 2 inline comments as done. SureYeaah added a comment. In D65526#1612117 , @sammccall wrote: > I guess you're looking for design review at this point. > > But the most important part of that is the documentation of the high-level >

[PATCH] D65574: Added hack to prevent toHalfOpenFileRange assertion fail

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:314 while (!FileRange.getBegin().isFileID()) { -assert(!FileRange.getEnd().isFileID() && - "Both Begin and End should be MacroIDs.");

[PATCH] D65574: Added hack to prevent toHalfOpenFileRange assertion fail

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. - Still need to investigate why this is happening. - Fixes the crash described at

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah created this revision. SureYeaah added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. - Prototype version; Only looking for a high level review. - Only works for extraction from

[PATCH] D65486: [clangd] Ignore semicolons, whitespace, and comments in SelectionTree.

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:50 + S.StartOffset = SM.getFileOffset(Tok.location()); + S.EndOffset = S.StartOffset + Tok.length(); + if (S.StartOffset >= SelBegin && S.EndOffset <= SelEnd)

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:329 while(a < [[1]]) -[[a++]]; +a++; // do while Change to a=[[1]];? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

SureYeaah added a comment. What was the bug in getCallExpr() ? Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:391 +return false; + Outer->dumpColor(); + // Blacklist the most common places where an expr can appear but be unused.

[PATCH] D65332: [Clangd] Disable ExtractVariable for all types of assignments

This revision was automatically updated to reflect the committed changes. Closed by commit rL367113: [Clangd] Disable ExtractVariable for all types of assignments (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65332: [Clangd] Disable ExtractVariable for all types of assignments

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65332 Files:

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:448 + + // Binary subexpressions + {R"cpp(void f() { sammccall wrote: > SureYeaah wrote: > > Can we have some tests with macros as well? > Added a

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:50 // Generate Replacement for declaring the selected Expr as a new variable - tooling::Replacement insertDeclaration(llvm::StringRef VarName) const; +

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:50 // Generate Replacement for declaring the selected Expr as a new variable - tooling::Replacement insertDeclaration(llvm::StringRef VarName) const; +

[PATCH] D65139: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:210 +// - we don't look inside macro expansions in the subexpressions +// - we only adjust the extracted range, so references in the unselected parts +//of the AST

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0ed5bea8812: [Clangd] Fixed ExtractVariable for certain types of Exprs (authored by SureYeaah). Changed prior to commit: https://reviews.llvm.org/D64717?vs=210803=211423#toc Repository: rG LLVM

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:427 R"cpp(void f(int a) { auto dummy = 1; label: [ [gsl::suppress("type")] ] for (;;) a = dummy; })cpp"}, kadircet

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210803. SureYeaah marked an inline comment as done. SureYeaah added a comment. Added test for label Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210800. SureYeaah marked 5 inline comments as done. SureYeaah added a comment. Minor changes and disabled extraction from label statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL366566: [Clangd] Fixed SelectionTree bug for macros (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 210783. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Updated comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210590. SureYeaah added a comment. Merged with trigger on non empty selection only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

This revision was automatically updated to reflect the committed changes. Closed by commit rL366451: [Clangd] Changed ExtractVariable to only work on non empty selections (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210577. SureYeaah added a comment. Added SelectionBegin and SelectionEnd to Tweak::Selection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210560. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Fixed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:292 + Target = llvm::make_unique(TargetNode, SM, Ctx); + return true; +} kadircet wrote: > `return Target->InsertionPoint`? Changed to checking if target

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210545. SureYeaah added a comment. Refactored code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah marked 5 inline comments as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:208 const SelectionTree::Node *N = Inputs.ASTSelection.commonAncestor(); - if (!N) -return false; - Target =

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210537. SureYeaah added a comment. Fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210536. SureYeaah added a comment. Added selectionend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +/// The Length of the selection +unsigned SelectionLength; /// The AST nodes that were selected. kadircet wrote: >

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah updated this revision to Diff 210526. SureYeaah added a comment. Added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64912/new/ https://reviews.llvm.org/D64912 Files: clang-tools-extra/clangd/refactor/Tweak.cpp

[PATCH] D64912: [Clangd] Changed ExtractVariable to only work on non empty selections

SureYeaah created this revision. SureYeaah added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - For now, we don't trigger in any case if it's an empty selection - Fixed unittests Repository:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210047. SureYeaah added a comment. Fixed crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 210045. SureYeaah added a comment. Fixed wrong function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209922. SureYeaah added a comment. Added fix for selecting the callExpr of a MemberExpr/Function DeclRefExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added a comment. In D64717#1585632 , @sammccall wrote: > In D64717#1585542 , @SureYeaah wrote: > > > In D64717#1585512 , @sammccall > > wrote: > > > > > Are you

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209853. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:323 while(a < ^1) -^a++; +[[a++]]; // do while kadircet wrote: > I thought extractor didn't

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added a comment. In D64717#1585512 , @sammccall wrote: > Are you sure we want to disable extraction here, rather than just do the > extraction at a higher level? > > E.g. if `bar(1,2,3, f[[o]]o(4,5));` seems like it should extract the call too

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209844. SureYeaah marked 5 inline comments as done. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:299 // return statement return ^1; } kadircet wrote: > left out this one ? Since that's an IntegerLiteral, this patch doesn't apply to it?

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah updated this revision to Diff 209809. SureYeaah added a comment. Fixed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64717/new/ https://reviews.llvm.org/D64717 Files:

[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Modified ExtractVariable to stop extraction for MemberExprs and Assignment Expr - Fixed unittests

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209506. SureYeaah added a comment. Added a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

This revision was automatically updated to reflect the committed changes. Closed by commit rL365894: [clangd] Fixed toHalfOpenFileRange (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:410 +// Test for functions toHalfOpenFileRange and getHalfOpenFileRange +// FIXME: Need better testing support to be able to check more than just Decls. +TEST(SourceCodeTests,

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209363. SureYeaah marked 12 inline comments as done. SureYeaah added a comment. Added comments and minor changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209229. SureYeaah added a comment. Changed a breaking test in ExtractVariable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D64329 Files:

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209199. SureYeaah marked 6 inline comments as done. SureYeaah added a comment. Changed claimRange to use toHalfOpenFileRange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209193. SureYeaah added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Fixed toHalfOpenFileRange to work for macros as well as template instantiations - Added unit tests

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187 + std::string ExtractedVarDecl = std::string("auto ") + VarName.str() + " = " + + ExtractionCode.str() + "; "; + return

  1   2   >