[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337045 , @atanasyan wrote: > In D120305#3337019 , @MaskRay wrote: > >> @atanasyan A few mips test/Driver tests will fail. Wonder if you have time >> making them more

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

atanasyan added a comment. In D120305#3337019 , @MaskRay wrote: > @atanasyan A few mips test/Driver tests will fail. Wonder if you have time > making them more portable... Otherwise I'll just add `UNSUPPORTED: > default-pie-on-linux` to them. > >

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2edcde00cb39: [MIPS] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass (authored by Random06457, committed by atanasyan). Changed prior to

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116238/new/ https://reviews.llvm.org/D116238 ___

[PATCH] D116238: [mips] Add -mfix4300 flag to enable vr4300 mulmul bugfix pass

atanasyan requested changes to this revision. atanasyan added a comment. This revision now requires changes to proceed. Thanks for the patch. Some notes are below. Comment at: llvm/lib/Target/Mips/MipsMulMulBugPass.cpp:16 +static cl::opt +EnableMulMulFix("mfix4300",

[PATCH] D112158: mips: fix search path for multilib o32

This revision was automatically updated to reflect the committed changes. Closed by commit rG284c2ebc5e05: [clang][MIPS] Fix search path for Debian multilib O32 (authored by wzssyqa, committed by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112158: mips: fix search path for multilib o32

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112158/new/ https://reviews.llvm.org/D112158 ___ cfe-commits mailing list

[PATCH] D112158: mips: fix search path for multilib o32

atanasyan added a comment. - Does this problem exist on all versions of Debian or starting from specific version only? - This fix needs test cases. Take a look at "Check linker invocation on Debian 6 MIPS 32/64-bit" in the `clang/test/Driver/linux-ld.c` for example. Repository: rG LLVM

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

atanasyan updated this revision to Diff 367472. atanasyan retitled this revision from "[WIP][mips] Use pc-relative relocations in .eh_frame" to "[mips][mc][clang] Use pc-relative relocations in .eh_frame". atanasyan edited the summary of this revision. atanasyan edited reviewers, added: emaste,

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM AFAIK the MIPS LLVM-based toolchain mentioned in D13340 have not been implemented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

atanasyan added a comment. My bad, I missed that you implemented passing the option to backend. Could you add some improvements to the patch? 1. As far as I know GCC does not accept `-mmips3d` option. It uses `-mips3d`. We need do the same. 2. Add test cases. For the reference you might take

[PATCH] D90570: [mips] Add a -mmips3d command line option to clang

atanasyan added a comment. What's a goal of this change? Do you want to suppress an error message when the option provided to Clang? If so, is it a real-life case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90570/new/

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

atanasyan added a reviewer: atanasyan. atanasyan added a comment. 1. Please include as much context as possible with your diff. This instruction helps to do that. 2. Such patch needs test case(s). Maybe it's

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. Looking good to me as-is. - Current naming is okay. But what do you think about reducing name of //quarter// intrinsics: `__builtin_msa_ldr_w` instead of `__builtin_msa_ldrq_w`? Will

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. I see, thanks. Is there the same or similar functionality in GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73644/new/ https://reviews.llvm.org/D73644 ___ cfe-commits

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

atanasyan added a comment. Is it possible to emulate these new intrinsics using existing ones and some additional code? Is code generated in this case much larger/slower then the code generated by the new intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan closed this revision. atanasyan added a comment. Closed by commit rG27f93515 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan updated this revision to Diff 239333. atanasyan added a reviewer: mbrkusanin. atanasyan added a comment. - Add `llvm-exegesis` note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73108/new/ https://reviews.llvm.org/D73108 Files:

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan added a comment. In D73108#1831442 , @mstojanovic wrote: > Initial MIPS support was also added to `llvm-exegesis`. Oh, sorry. Good point, I'll add this note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73108: [docs][mips] 10.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, ruiu, Petar.Avramovic, mstojanovic, arichardson. Herald added subscribers: jfb, sdardis. Herald added projects: clang, LLVM. MIPS specific part of LLVM 10.0 Release notes for LLVM, Clang and LLD. Repository: rG LLVM Github

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d32ae75bf5: [mips] Check that features required by built-ins are enabled (authored by atanasyan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70808/new/

[PATCH] D70808: [mips] Check that features required by built-ins are enabled

atanasyan created this revision. atanasyan added a reviewer: Petar.Avramovic. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: clang. Now Clang does not check that features required by built-in functions are enabled. That causes errors in the backend reported in

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

atanasyan accepted this revision. atanasyan added a comment. LGTM. But before commit get more approvals. For example, from echristo, code owners of other targets, etc. I would keep the as-is. In that case a target of such huge modifications looks a bit more clear. CHANGES SINCE LAST ACTION

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added a comment. I hope the rL360825 fixes the problem so this patch can be switch to the `abandoned` state. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702

[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes

atanasyan added a comment. I do not see any problem from MIPS targets point of view. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60967/new/ https://reviews.llvm.org/D60967 ___ cfe-commits mailing list

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added a comment. I'm sorry for delay with handling this issue. The **160** constant in the `FIRST_32_SECOND_64(144, 104)` depends on the following fragment from the `cmake/modules/HandleLLVMOptions.cmake` file introduced by the rL301171 . If

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added a comment. How do you build compiler-rt? What OS do yo use? Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 ___ cfe-commits mailing list

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added inline comments. Comment at: lib/sanitizer_common/sanitizer_platform_limits_linux.cc:31 #include -#if defined(__x86_64__) || defined(__mips__) +#if defined(__x86_64__) #include Why do you need this change? Comment at:

[PATCH] D58165: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the _Unwind_Word / _Unwind_SWord definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rC353965: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the… (authored by atanasyan, committed by ). Changed prior to commit: https://reviews.llvm.org/D58165?vs=186585=186694#toc

[PATCH] D58165: [Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the _Unwind_Word / _Unwind_SWord definitions

atanasyan created this revision. atanasyan added reviewers: rnk, thakis, craig.topper. Herald added subscribers: jrtc27, arichardson, sdardis. Herald added a project: clang. The rationale of this change is to fix _Unwind_Word / _Unwind_SWord definitions for MIPS N32 ABI. This ABI uses 32-bit

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352675: [docs][mips] Clang 8.0 Release notes (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57458: [docs][mips] Clang 8.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, petarj, abeserminji, smaksimovic. Herald added subscribers: arichardson, sdardis. MIPS specific part of Clang 8.0 Release notes. Feel free to add more notes if I miss something. Repository: rC Clang

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. In D56836#1362967 , @abeserminji wrote: > As an option, we can provide necessary flags for the test to finish > successfully instead of not testing it. Agreed. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: lib/Driver/ToolChains/Clang.cpp:1720 + CmdArgs.push_back("-mllvm"); +

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. In D56836#1361528 , @abeserminji wrote: > I am not sure if -static option passed as --cflag to lnt runtest enters the > LDFLAGS. I guess it doesn't. > But if there is a way to check which options are passed as --cflags, we >

[PATCH] D56836: [mips] Include whole lpthread when using both -pthread and -static

atanasyan added a comment. Now I'm not sure that we really need to make this code more complicated. As to the `stdthreadbug` test case, maybe we can just exclude this test if LDFLAGS contains the `-static` option. As to this patch, is it possible to implement the following algorithm? Will it

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:160 +if (ToolChain.getTriple().getOSMajorVersion() >= 9) + CmdArgs.push_back("--hash-style=gnu"); CmdArgs.push_back("--enable-new-dtags"); MaskRay wrote: > I can't find

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan abandoned this revision. atanasyan added a comment. Commits rL348934 and rL348935 enable using of integrated assembler for MIPS targets in all cases. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan added a comment. In https://reviews.llvm.org/D52418#1294699, @brad wrote: > Simon? The testing continues. Unfortunately I do not have access to an appropriate hardware so cannot control the process. But the task is not abandoned. Repository: rC Clang

[PATCH] D53984: [mips] Fix broken MSA test

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D53984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan added a comment. In https://reviews.llvm.org/D52418#1271779, @brad wrote: > How is it going with regard to N32 fixes / testing? I'm in the process of building/testing LLVM/Clang binaries for N32 ABI. Repository: rC Clang https://reviews.llvm.org/D52418

[PATCH] D50850: clang: Add triples support for MIPS r6

This revision was automatically updated to reflect the committed changes. Closed by commit rL344608: [driver][mips] Support MIPS R6 target triples (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. https://reviews.llvm.org/D50850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please rebase this patch against the trunk? Comment at: lib/Driver/ToolChains/Linux.cpp:717 + const StringRef MIPS64R6ELMultiarchIncludeDirs[] = { + "/usr/include/mipsisa64r6el-linux-gnu", +

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

This revision was automatically updated to reflect the committed changes. Closed by commit rC344570: [mips] Fix handling of GNUABIN32 environment in a target triple (authored by atanasyan, committed by ). Changed prior to commit: https://reviews.llvm.org/D51464?vs=168116=169763#toc

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. https://reviews.llvm.org/D51464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added a comment. I'm going to test current MIPS N32 ABI implementation. Maybe we are ready to enable integrated assembler for it. In that case both `Generic_GCC::IsIntegratedAssemblerDefault()` and `MipsMCAsmInfo` ctor can be simplified. https://reviews.llvm.org/D51464

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan added a comment. In https://reviews.llvm.org/D52418#1256189, @brad wrote: > Simon, and what about lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp? Good point. In fact, integrated assembler for GNUABIN32 was enabled in the `MipsMCAsmInfo` ctor by me and by mistake. I have another

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. In https://reviews.llvm.org/D50850#1250285, @wzssyqa wrote: > This is really for Clang. I guess you mean that compiler-rt directory also > need to be patched. If you take a look at the previous version of this patch https://reviews.llvm.org/D50850?id=167419, you

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added a comment. Please run test suite before sending a patch to review. After applying this patch the following tests failed: - test/CodeGen/target-data.c - test/Driver/mips-cs.cpp https://reviews.llvm.org/D51464 ___ cfe-commits

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:85 if (ABIName.empty() && (Triple.getVendor() == llvm::Triple::MipsTechnologies || Is possible to rewrite this piece of code (lines 85-114) as follows? ``` if

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at https://reviews.llvm.org/rL343185 already. Could you attach an actual patch brings https://reviews.llvm.org/source/compiler-rt/ support to the Clang driver?

[PATCH] D52619: Fix greedy FileCheck expression in test/Driver/mips-abi.c

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang https://reviews.llvm.org/D52619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please update the patch against the current trunk? Repository: rC Clang https://reviews.llvm.org/D50850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

This revision was automatically updated to reflect the committed changes. Closed by commit rL343169: [driver][mips] Adjust target triple accordingly to provided ABI name (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan added a comment. Thanks for review. Repository: rC Clang https://reviews.llvm.org/D52290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan added inline comments. Comment at: lib/Driver/Driver.cpp:492 + .Case("64", Target.get64BitArchVariant()) + .Default(Target); + rnk wrote: > We should emit a diagnostic for invalid -mabi=values. We already do that: $

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan updated this revision to Diff 167091. atanasyan edited the summary of this revision. atanasyan added a comment. Always adjust target triple (explicitly and implicitly provided) accordingly to ABI name. Repository: rC Clang https://reviews.llvm.org/D52290 Files:

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan added a comment. In https://reviews.llvm.org/D52290#1245222, @rnk wrote: > Should `--target=mipsZZZ -mabi=n64` be meaningful? What does `clang > --target=i686-linux-gnu -m64` do? If this matches that, then let's do it. Thanks. Initially I thought that providing different target

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D52290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan created this revision. atanasyan added reviewers: rsmith, rnk, zturner. Herald added subscribers: jrtc27, arichardson, sdardis, srhines. Enable integrated assembler for MIPS64 targets except N32 ABI explicitly selected by the `-mabi=n32` command line option or

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan requested changes to this revision. atanasyan added a comment. This revision now requires changes to proceed. This patch fails the following test cases: - tools/clang/test/CodeGen/target-data.c - tools/clang/test/Driver/mips-cs.cpp Comment at:

[PATCH] D52290: [driver][mips] Adjust target triple accordingly to provided ABI name

atanasyan created this revision. atanasyan added reviewers: rsmith, rnk, zturner. Herald added subscribers: jrtc27, arichardson, sdardis. All MIPS target architectures can be divided into four categories: 32-bit little-endian, 32-bit big-endian, 64-bit little-endian, and 64-bit big-endian. If,

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you please include more context to patches sent for review? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/Driver/ToolChains/Linux.cpp:46 TargetTriple.getEnvironment(); +

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added a comment. Could you please include more context to patches sent for review? https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:109 + if (ABIName.empty() &&

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

atanasyan added a comment. Thanks for review. Repository: rL LLVM https://reviews.llvm.org/D51356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL341201: [docs][mips] Clang 7.0 Release notes (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

atanasyan closed this revision. atanasyan added a comment. Fixed by https://reviews.llvm.org/rL340845. Repository: rC Clang https://reviews.llvm.org/D51358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

atanasyan created this revision. atanasyan added reviewers: echristo, ruiu. The "-flavor old-gnu" option were introduced to enable old version of LLD ELF linker implementation. This option has been removed from the linker since LLD 3.9. I do not think that there is a real case when the latest

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

atanasyan created this revision. atanasyan added reviewers: hans, petarj, smaksimovic, abeserminji. Herald added subscribers: arichardson, sdardis. MIPS specific part of Clang 7.0 Release notes. Feel free to add more notes if I miss something. Repository: rC Clang

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

atanasyan added a comment. In https://reviews.llvm.org/D51234#1213813, @ruiu wrote: > If this piece of code used to be working correctly, there is another piece of > code that adds `-flavor ld` to the command line. But if that's the case, this > change wouldn't work because it constructs

[PATCH] D51234: [Driver] Change MipsLinux default linker from "lld" to "ld.lld"

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D51234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx

atanasyan added inline comments. Comment at: lib/Basic/Targets/Mips.cpp:141 + Twine(32 / (FPMode == FP64 || IsSingleFloat ? 1 : 2))); if (IsMips16) What do you think about this variant of the code? It's longer, but imho looks more

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Could you add test cases to cover these changes? Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:115 + if (ABIName.empty() && (Triple.getEnvironment() == llvm::Triple::GNUABIN32)) +ABIName = "n32"; + It looks like this change is

[PATCH] D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx

atanasyan added a comment. Any test cases? Comment at: lib/Basic/Targets/Mips.cpp:62 +unsigned MipsTargetInfo::getISARev(const std::string& CPU) const { + return llvm::StringSwitch(getCPU()) The CPU argument looks unused. We can either remove it or make

[PATCH] D49289: [mips64][clang] Provide the signext attribute for i32 return values

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49143: Fix a typo/regression in r335495.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48982: [mips] Add '-mvirt', '-mno-virt', '-mginv', '-mno-ginv' options

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49143: Fix a typo/regression in r335495.

atanasyan added a comment. It would be nice to have a test for this regression. Repository: rC Clang https://reviews.llvm.org/D49143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD.

atanasyan accepted this revision. atanasyan added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:197 +CmdArgs.push_back("-m"); +CmdArgs.push_back("elf64ltsmip_fbsd"); +break; bsdjhb

[PATCH] D48499: [mips] Use more conservative default CPUs for MIPS on FreeBSD.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48515: [mips][ias] Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.

atanasyan added a comment. LGTM, but before commit please add a test case into the freebsd.c. Repository: rC Clang https://reviews.llvm.org/D48515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48507: [mips] Explicitly specify the linker emulation for MIPS on FreeBSD.

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:197 +CmdArgs.push_back("-m"); +CmdArgs.push_back("elf64ltsmip_fbsd"); +break; Does it make a sense to handle N32 ABI case here? Repository: rC Clang

[PATCH] D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM. the only minor nit Comment at: lib/Driver/ToolChains/FreeBSD.cpp:321 // back to '/usr/lib' if it doesn't exist. - if ((Triple.getArch() == llvm::Triple::x86

[PATCH] D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE

atanasyan accepted this revision. atanasyan added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Driver/Options.td:2214 HelpText<"Disable SVR4-style position-independent code (Mips only)">; +def mno_crc : Flag<["-"], "mno-crc">,

[PATCH] D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE

atanasyan added inline comments. Comment at: include/clang/Driver/Options.td:2214 HelpText<"Disable SVR4-style position-independent code (Mips only)">; +def mno_crc : Flag<["-"], "mno-crc">, Group, + HelpText<"Disallow use of CRC instructions (Mips only)">;

[PATCH] D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting

atanasyan added a comment. Committed at https://reviews.llvm.org/rL331856. Thanks for the patch. Repository: rL LLVM https://reviews.llvm.org/D46450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting

This revision was automatically updated to reflect the committed changes. Closed by commit rL331856: [driver] Add mips_Features_Group to Options to improve documentation sorting (authored by atanasyan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46450: [Driver] Add mips_Features_Group to Options to improve documentation sorting

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Do you have commit access? Repository: rC Clang https://reviews.llvm.org/D46450 ___ cfe-commits mailing list

[PATCH] D44447: Treat libclang_rt.* as normal library if the user uses --sysroot=

atanasyan added a comment. Will it work on Windows? If sysroot is provided, `Prefix` is "-l", but I'm not sure that link.exe accepts "-l" notation. Repository: rC Clang https://reviews.llvm.org/D7 ___ cfe-commits mailing list

[PATCH] D43487: [mips] Spectre variant two mitigation for MIPSR2

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D43487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42416: [Driver] Add support for mips32 and scudo

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

This revision was automatically updated to reflect the committed changes. Closed by commit rL310614: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36551?vs=110562=110586#toc Repository:

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL310613: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36550?vs=110561=110585#toc Repository: rL LLVM

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > atanasyan wrote: >

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s sdardis wrote: > Can you put this in

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan updated this revision to Diff 110562. atanasyan added a comment. - Addressed review comments. Repository: rL LLVM https://reviews.llvm.org/D36551 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/Mips.cpp test/Driver/mips-features.c

  1   2   >