Author: Simon Atanasyan
Date: 2022-02-22T20:24:21+03:00
New Revision: cedc23bc8612feea61c0a7d92ccaae1ce51520ce
URL:
https://github.com/llvm/llvm-project/commit/cedc23bc8612feea61c0a7d92ccaae1ce51520ce
DIFF:
https://github.com/llvm/llvm-project/commit/cedc23bc8612feea61c0a7d92ccaae1ce51520ce.dif
Author: Random
Date: 2021-12-31T15:59:44+03:00
New Revision: 2edcde00cb396cc17d8d8b171a6ebaa97fd30e59
URL:
https://github.com/llvm/llvm-project/commit/2edcde00cb396cc17d8d8b171a6ebaa97fd30e59
DIFF:
https://github.com/llvm/llvm-project/commit/2edcde00cb396cc17d8d8b171a6ebaa97fd30e59.diff
LOG: [
Author: YunQiang Su
Date: 2021-10-28T10:23:06+03:00
New Revision: 284c2ebc5e057a0fda23257b899260d274e69a27
URL:
https://github.com/llvm/llvm-project/commit/284c2ebc5e057a0fda23257b899260d274e69a27
DIFF:
https://github.com/llvm/llvm-project/commit/284c2ebc5e057a0fda23257b899260d274e69a27.diff
L
Author: Simon Atanasyan
Date: 2019-11-29T00:23:00+03:00
New Revision: f4d32ae75bf515f443a2c99dce5c882f460c82bd
URL:
https://github.com/llvm/llvm-project/commit/f4d32ae75bf515f443a2c99dce5c882f460c82bd
DIFF:
https://github.com/llvm/llvm-project/commit/f4d32ae75bf515f443a2c99dce5c882f460c82bd.dif
Author: Simon Atanasyan
Date: 2019-11-05T12:10:58+03:00
New Revision: e578d0fd295a67bce1e1fc922237f459deb49c7e
URL:
https://github.com/llvm/llvm-project/commit/e578d0fd295a67bce1e1fc922237f459deb49c7e
DIFF:
https://github.com/llvm/llvm-project/commit/e578d0fd295a67bce1e1fc922237f459deb49c7e.dif
Author: Simon Atanasyan
Date: 2019-11-05T12:10:58+03:00
New Revision: 0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef
URL:
https://github.com/llvm/llvm-project/commit/0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef
DIFF:
https://github.com/llvm/llvm-project/commit/0d14656b9d8ca38b8ea321c7047eaeec43c5b2ef.dif
Author: atanasyan
Date: Wed Oct 9 03:38:03 2019
New Revision: 374154
URL: http://llvm.org/viewvc/llvm-project?rev=374154&view=rev
Log:
[mips] Set default float ABI to "soft" on FreeBSD
Initial patch by Kyle Evans.
Fix PR43596
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
cfe/
Author: atanasyan
Date: Wed Sep 18 05:24:57 2019
New Revision: 372220
URL: http://llvm.org/viewvc/llvm-project?rev=372220&view=rev
Log:
[mips] Pass "xgot" flag as a subtarget feature
We need "xgot" flag in the MipsAsmParser to implement correct expansion
of some pseudo instructions in case of usi
Author: atanasyan
Date: Wed May 29 07:59:32 2019
New Revision: 361967
URL: http://llvm.org/viewvc/llvm-project?rev=361967&view=rev
Log:
[mips] Check argument for __builtin_msa_ctcmsa / __builtin_msa_cfcmsa
The `__builtin_msa_ctcmsa` and `__builtin_msa_cfcmsa` builtins are mapped
to the `ctcmsa` a
Author: atanasyan
Date: Tue Apr 2 11:03:31 2019
New Revision: 357506
URL: http://llvm.org/viewvc/llvm-project?rev=357506&view=rev
Log:
[driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`
In case of N64 ABI toolchain paths migth have `mips-linux-gnuabi64`
or `mips-linu
Author: atanasyan
Date: Tue Apr 2 11:03:15 2019
New Revision: 357505
URL: http://llvm.org/viewvc/llvm-project?rev=357505&view=rev
Log:
[driver] clang-format. Fix indentation, split long lines. NFC
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
cfe/t
Author: atanasyan
Date: Wed Feb 13 10:27:09 2019
New Revision: 353965
URL: http://llvm.org/viewvc/llvm-project?rev=353965&view=rev
Log:
[Headers][mips] Add `__attribute__((__mode__(__unwind_word__)))` to the
_Unwind_Word / _Unwind_SWord definitions
The rationale of this change is to fix _Unwind_
Author: atanasyan
Date: Wed Dec 12 07:32:25 2018
New Revision: 348935
URL: http://llvm.org/viewvc/llvm-project?rev=348935&view=rev
Log:
[mips] Enable using of integrated assembler in all cases.
Modified:
cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cp
Hi Galina,
a) "llvm-mips-linux" buildbot is active now. There are some failed
tests but I'm working to make the buildbot "green".
b) For now "clang-cmake-mips" and "clang-cmake-mipsel" can be removed.
Later we probably restore these buildbots.
On Sat, Nov 3, 2018 at 11:26 AM Simon Atanasyan wro
Hi Galina,
I will try to find owners of these buildbots. I hope to get results on
the next week.
On Sat, Nov 3, 2018 at 1:48 AM Daniel Sanders
wrote:
>
> Hi Galina,
>
> I'm sad that they appear to have been abandoned but no objections from me as
> I'm not the admin for any of these anymore. A c
Author: atanasyan
Date: Tue Oct 16 07:29:27 2018
New Revision: 344608
URL: http://llvm.org/viewvc/llvm-project?rev=344608&view=rev
Log:
[driver][mips] Support MIPS R6 target triples
This change adds support for the following MIPS target triples:
mipsisa32r6-linux-gnu
mipsisa32r6el-linux-gnu
Author: atanasyan
Date: Tue Oct 16 03:19:06 2018
New Revision: 344603
URL: http://llvm.org/viewvc/llvm-project?rev=344603&view=rev
Log:
[driver][mips] Adjust target triple's environment accordingly to provided ABI
name
For MIPS we need to adjust not only architecture name accordingly to ABI
prov
Author: atanasyan
Date: Mon Oct 15 22:18:36 2018
New Revision: 344583
URL: http://llvm.org/viewvc/llvm-project?rev=344583&view=rev
Log:
[mips] Group similar commands in the test case. NFC
Modified:
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/test/CodeGen/target-data.c
URL:
http
Author: atanasyan
Date: Mon Oct 15 15:43:23 2018
New Revision: 344570
URL: http://llvm.org/viewvc/llvm-project?rev=344570&view=rev
Log:
[mips] Fix handling of GNUABIN32 environment in a target triple
The `GNUABIN32` environment in a target triple implies using the N32
ABI. This patch adds support
Author: atanasyan
Date: Wed Sep 26 22:04:50 2018
New Revision: 343169
URL: http://llvm.org/viewvc/llvm-project?rev=343169&view=rev
Log:
[driver][mips] Adjust target triple accordingly to provided ABI name
Explicitly selected MIPS ABI using the `-mabi` option implies
corresponding target triple. F
Author: atanasyan
Date: Wed May 9 01:42:30 2018
New Revision: 331856
URL: http://llvm.org/viewvc/llvm-project?rev=331856&view=rev
Log:
[driver] Add mips_Features_Group to Options to improve documentation sorting
Move all of the MIPS-only options into a new m_mips_Features_Group.
Nearly all other
Author: atanasyan
Date: Wed Sep 6 23:05:06 2017
New Revision: 312701
URL: http://llvm.org/viewvc/llvm-project?rev=312701&view=rev
Log:
[mips] Replace Triple::Environment check by the isGNUEnvironment() call. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
cfe/trunk/lib/Driver
Author: atanasyan
Date: Mon Aug 21 07:08:29 2017
New Revision: 311334
URL: http://llvm.org/viewvc/llvm-project?rev=311334&view=rev
Log:
[mips] Remove checking of the redundant condition. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arc
Author: atanasyan
Date: Thu Aug 10 08:42:31 2017
New Revision: 310615
URL: http://llvm.org/viewvc/llvm-project?rev=310615&view=rev
Log:
[mips] Group all `-mabicalls` related checks in the single place. NFC
Removed:
cfe/trunk/test/Driver/mips-longcalls-warning.c
Modified:
cfe/trunk/test/Dr
Author: atanasyan
Date: Thu Aug 10 08:42:16 2017
New Revision: 310613
URL: http://llvm.org/viewvc/llvm-project?rev=310613&view=rev
Log:
[mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI
The -mabicalls option does not make sense in the case of non position
independent code for the
Author: atanasyan
Date: Thu Aug 10 08:42:25 2017
New Revision: 310614
URL: http://llvm.org/viewvc/llvm-project?rev=310614&view=rev
Log:
[mips] Show warning in case of mixing -mlong-calls and -mabicalls options
While we do not support `-mshared / -mno-shared` properly, show warning
and ignore `-ml
Author: atanasyan
Date: Tue Aug 8 14:17:33 2017
New Revision: 310418
URL: http://llvm.org/viewvc/llvm-project?rev=310418&view=rev
Log:
[mips] Enable `long_call/short_call` attributes on MIPS64
This change enables `long_call/short_call/far/near` attributes on
MIPS64 targets.
Differential revisio
On Thu, Jul 20, 2017 at 5:04 PM, Simon Dardis via cfe-commits
wrote:
> Reland "[mips] Teach the driver to accept -m(no-)gpopt."
>
> This patch teaches the driver to pass -mgpopt by default to the backend when
> it
> is supported, i.e. we are using -mno-abicalls.
[...]
> Modified: cfe/trunk/lib/
Author: atanasyan
Date: Fri Aug 4 01:25:15 2017
New Revision: 310038
URL: http://llvm.org/viewvc/llvm-project?rev=310038&view=rev
Log:
[mips] Fix typo (missed space) in the warning message
Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
cfe/trunk/test/Driver/mips-gpopt-w
Author: atanasyan
Date: Fri Aug 4 01:25:09 2017
New Revision: 310037
URL: http://llvm.org/viewvc/llvm-project?rev=310037&view=rev
Log:
[mips] Code formatting fix. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
URL:
http:/
Author: atanasyan
Date: Fri Jul 21 01:10:57 2017
New Revision: 308719
URL: http://llvm.org/viewvc/llvm-project?rev=308719&view=rev
Log:
[mips] Add `short_call` to the set of `long_call/far/near` attributes
MIPS gcc supports `long_call/far/near` attributes only, but other
targets have the `short_c
Author: atanasyan
Date: Thu Jul 20 13:34:18 2017
New Revision: 308667
URL: http://llvm.org/viewvc/llvm-project?rev=308667&view=rev
Log:
[CodeGen][mips] Support `long_call/far/near` attributes
This patch adds support for the `long_call`, `far`, and `near` attributes
for MIPS targets. The `long_cal
Author: atanasyan
Date: Mon Jul 10 23:19:01 2017
New Revision: 307627
URL: http://llvm.org/viewvc/llvm-project?rev=307627&view=rev
Log:
[mips] Create the correct profiling symbol on Linux MIPS
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/CodeGen/mcount.c
Modified: cfe/trunk/l
Author: atanasyan
Date: Fri Jul 7 03:35:33 2017
New Revision: 307386
URL: http://llvm.org/viewvc/llvm-project?rev=307386&view=rev
Log:
[driver][mips] Pass long-calls feature flag to the MIPS backend
Check the `-mlong-calls` command line option and pass the `long-calls`
feature flag to the backen
Author: atanasyan
Date: Wed Jul 5 05:57:37 2017
New Revision: 307152
URL: http://llvm.org/viewvc/llvm-project?rev=307152&view=rev
Log:
[driver][mips] Use AddTargetFeature to check arguments and add feature flags.
NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/tru
Author: atanasyan
Date: Wed Jul 5 05:57:32 2017
New Revision: 307151
URL: http://llvm.org/viewvc/llvm-project?rev=307151&view=rev
Log:
[driver][mips] Remove redundant curly brackets. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/M
On Mon, May 22, 2017 at 3:57 PM, Aaron Ballman wrote:
> On Mon, May 22, 2017 at 8:47 AM, Simon Atanasyan via cfe-commits
> wrote:
>> Author: atanasyan
>> Date: Mon May 22 07:47:43 2017
>> New Revision: 303546
>>
>> URL: http://llvm.org/viewvc/llvm-project?
Author: atanasyan
Date: Mon May 22 10:53:34 2017
New Revision: 303565
URL: http://llvm.org/viewvc/llvm-project?rev=303565&view=rev
Log:
[mips] Add one more check to the micromips attribute test case. NFC
Modified:
cfe/trunk/test/Sema/attr-micromips.c
Modified: cfe/trunk/test/Sema/attr-microm
Author: atanasyan
Date: Mon May 22 10:53:31 2017
New Revision: 303564
URL: http://llvm.org/viewvc/llvm-project?rev=303564&view=rev
Log:
[mips] Quote command line options with `` in the micromips attribute
description. NFC
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/tru
Author: atanasyan
Date: Mon May 22 07:47:43 2017
New Revision: 303546
URL: http://llvm.org/viewvc/llvm-project?rev=303546&view=rev
Log:
[mips] Support `micromips` attribute
This patch adds support for the `micromips` and `nomicromips` attributes
for MIPS targets.
Differential revision: https://r
Author: atanasyan
Date: Tue Jul 19 02:23:15 2016
New Revision: 275951
URL: http://llvm.org/viewvc/llvm-project?rev=275951&view=rev
Log:
[driver][mips] Remove empty folder from test inputs
Removed:
cfe/trunk/test/Driver/Inputs/basic_android_tree/lib/gcc/mipsel-linux-android/4.4.3/mips-r6/
__
Author: atanasyan
Date: Tue Jul 19 02:09:48 2016
New Revision: 275949
URL: http://llvm.org/viewvc/llvm-project?rev=275949&view=rev
Log:
[driver][mips] Support MIPS targets in modern Android NDK
Initial patch provided by Duane Sand.
Added:
cfe/trunk/test/Driver/Inputs/basic_android_ndk_tree/
Author: atanasyan
Date: Wed Jun 22 15:30:26 2016
New Revision: 273471
URL: http://llvm.org/viewvc/llvm-project?rev=273471&view=rev
Log:
[driver] Remove one more bunch of empty 'test inputs' folders. NFC
Removed:
cfe/trunk/test/Driver/Inputs/basic_nacl_tree/
cfe/trunk/test/Driver/Inputs/m
Author: atanasyan
Date: Wed Jun 22 15:20:51 2016
New Revision: 273468
URL: http://llvm.org/viewvc/llvm-project?rev=273468&view=rev
Log:
[driver] Remove empty folders from the Inputs folder for the driver's tests. NFC
Removed:
cfe/trunk/test/Driver/Inputs/android_triple_version/
cfe/trunk
Author: atanasyan
Date: Wed Jun 22 15:00:50 2016
New Revision: 273465
URL: http://llvm.org/viewvc/llvm-project?rev=273465&view=rev
Log:
[driver][mips] Factor out findMIPSMultilibs code into separate functions. NFC
The findMIPSMultilibs is too long. One more reason for splitting is to
escape redun
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: atanasyan
Date: Sat May 28 04:44:15 2016
New Revision: 271110
URL: http://llvm.org/viewvc/llvm-project?rev=271110&view=rev
Log:
[driver][mips] Fix local variable naming. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
http://llvm.
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM with some nits
Comment at: lib/Driver/Tools.cpp:1446
@@ +1445,3 @@
+CmdArgs.push_back(Args.MakeArgString("-mips-compact-branches=" + Val));
+
+ } else
atanasyan added a comment.
In http://reviews.llvm.org/D20679#442121, @dsanders wrote:
> Just to double-check: Do you still agree we should kill this now that the
> number of tests covering EABI-specific behaviour is non-zero?
>
> I think we should on the basis that we still have no backend tests
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple:
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Tools.cpp contains the following code. We need to remove `eabi` here too.
if (CPUName.empty()) {
// Deduce CPU name from ABI name.
C
atanasyan added inline comments.
Comment at: lib/Basic/Targets.cpp:6986
@@ +6985,3 @@
+ : TargetInfo(Triple), CPU((getTriple().getArch() == llvm::Triple::mips ||
+ getTriple().getArch() == llvm::Triple::mipsel)
+
I hope r270842 fixes the problem.
Thanks a lot for your help.
On Thu, May 26, 2016 at 11:28 AM, Ismail Donmez wrote:
> Indeed the problematic option is -DCLANG_DEFAULT_CXX_STDLIB=libc++ ,
> thanks Jonas!
>
> On Thu, May 26, 2016 at 11:19 AM, Hahnfeld, Jonas
> wrote:
>> Hi,
>>
>> Have you also s
Author: atanasyan
Date: Thu May 26 06:32:19 2016
New Revision: 270842
URL: http://llvm.org/viewvc/llvm-project?rev=270842&view=rev
Log:
[driver][mips] Specify stdlib used in the tests explicitly
That allows to pass the tests even if default stdlib is not libstdc++.
Modified:
cfe/trunk/test/D
Sounds reasonable. I will check this idea and fix the tests accordingly.
On May 26, 2016 11:03 AM, "Ismail Donmez" wrote:
> Hi,
>
> I think this is because I enable libc++ by default with
> -DLLVM_ENABLE_LIBCXX=ON , so this tests need an explicit
> -stdlib=libstdc++
>
> ismail
>
>
> On Thu, May 2
I'm trying to reproduce the problem but without success yet. And all
buildbots available to me are green. So no ideas right now.
By the way, as far as I can see you use some sort of build system
probably to get rpm package. Right? Could you try to build Clang by
hand (http://clang.llvm.org/get_sta
Hi,
Thanks for the information. One more question. Does the following folder exist?
/home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/Inputs/mips_img_v2_tree/lib/gcc/mips-img-linux-gnu/4.9.2/../../../../mips-img-linux-gnu/include/c++/4.9.2
On Wed, May 25, 2016 at 9:55 AM, Ismail Donmez w
Hi,
On Tue, May 24, 2016 at 12:37 PM, Ismail Donmez wrote:
>
> On Sun, May 22, 2016 at 9:18 PM, Simon Atanasyan via cfe-commits
> wrote:
>> Author: atanasyan
>> Date: Sun May 22 13:18:07 2016
>> New Revision: 270373
>>
>> URL: http://llvm.org/viewvc/
ot;Renato Golin" wrote:
>>
>> On 22 May 2016 at 19:18, Simon Atanasyan via cfe-commits
>> wrote:
>> > Author: atanasyan
>> > Date: Sun May 22 13:18:07 2016
>> > New Revision: 270373
>> >
>> > URL: http://llvm.org/viewvc/llvm-proje
Author: atanasyan
Date: Sun May 22 17:06:19 2016
New Revision: 270380
URL: http://llvm.org/viewvc/llvm-project?rev=270380&view=rev
Log:
[driver][mips] Follow-up to r270373. Add missed folder.
Added:
cfe/trunk/test/Driver/Inputs/mips_img_v2_tree/mips-img-linux-gnu/lib/mipsel-r6-soft/
cfe
Hi Renato,
Strange error. Unfortunately I am far from my computer right now. I was
sure in my changes. Could you please revert the commit?
On May 22, 2016 11:23 PM, "Renato Golin" wrote:
> On 22 May 2016 at 19:18, Simon Atanasyan via cfe-commits
> wrote:
> > Author: atana
Author: atanasyan
Date: Sun May 22 13:18:41 2016
New Revision: 270374
URL: http://llvm.org/viewvc/llvm-project?rev=270374&view=rev
Log:
[driver][mips] clang-format the code. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
http://llvm.org/
Author: atanasyan
Date: Sun May 22 10:28:34 2016
New Revision: 270368
URL: http://llvm.org/viewvc/llvm-project?rev=270368&view=rev
Log:
[driver][mips] Use target triple mips-mti-linux-gnu for toolchain detection
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/test/Driver/mips-fsf.
Author: atanasyan
Date: Sun May 22 10:27:58 2016
New Revision: 270367
URL: http://llvm.org/viewvc/llvm-project?rev=270367&view=rev
Log:
[driver][mips] Rename some variables to better reflect their purpose. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolC
Author: atanasyan
Date: Thu May 19 10:05:22 2016
New Revision: 270067
URL: http://llvm.org/viewvc/llvm-project?rev=270067&view=rev
Log:
[driver][mips] Hardcode triple name in case of CodeSourcery toolchain. NFC
CodeSourcery toolchain is a standalone toolchain which always uses
the same triple nam
Author: atanasyan
Date: Thu May 19 10:07:00 2016
New Revision: 270068
URL: http://llvm.org/viewvc/llvm-project?rev=270068&view=rev
Log:
[driver] Do not pass target triple to the MultilibSet include dirs callback
No one callback uses target triple so we can escape passing the unused
argument.
Mod
Author: atanasyan
Date: Thu May 19 10:07:21 2016
New Revision: 270069
URL: http://llvm.org/viewvc/llvm-project?rev=270069&view=rev
Log:
[driver] Do not pass install dir to the MultilibSet include dirs callback
All additional include directories are relative to the toolchain install
folder. So let
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: atanasyan
Date: Mon Oct 12 09:32:57 2015
New Revision: 250043
URL: http://llvm.org/viewvc/llvm-project?rev=250043&view=rev
Log:
[Driver] Remove `else` after `return`
Modified:
cfe/trunk/lib/Driver/Multilib.cpp
Modified: cfe/trunk/lib/Driver/Multilib.cpp
URL:
http://llvm.org/viewvc/l
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
atanasyan added inline comments.
Comment at: lib/Driver/Driver.cpp:2225
@@ -2219,1 +2224,3 @@
TC = new toolchains::HexagonToolChain(*this, Target, Args);
+ else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) &&
+ !Target.hasEnvironment())
--
atanasyan added inline comments.
Comment at: lib/Driver/Driver.cpp:2225
@@ -2219,1 +2224,3 @@
TC = new toolchains::HexagonToolChain(*this, Target, Args);
+ else if ((Target.getVendor() == llvm::Triple::MipsTechnologies) &&
+ !Target.hasEnvironment())
--
atanasyan added inline comments.
Comment at: include/clang/Driver/ToolChain.h:92
@@ -91,2 +91,3 @@
MultilibSet Multilibs;
+ Multilib SelectedMultilib;
This field is used by the `MipsToolChain` class only. If so, move it to that
class.
Comm
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: include/clang/Driver/ToolChain.h:253
@@ -252,1 +252,3 @@
+ virtual SmallString<128> getCompilerRT(const llvm::opt::ArgList &Args,
+
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
re, and I cannot escape to use llvm-readobj because
>> "-emit-llvm" produces correct code.
>>
>> > FYI, update CLANG_TEST_DEPS in clang/test/CMakeLists.txt, if it would
>> > remain
>> > in clang/test.
>>
>> Thanks. Will update it soon.
>>
ine
assembler there, and I cannot escape to use llvm-readobj because
"-emit-llvm" produces correct code.
> FYI, update CLANG_TEST_DEPS in clang/test/CMakeLists.txt, if it would remain
> in clang/test.
Thanks. Will update it soon.
> On Mon, Sep 14, 2015 at 8:24 PM Simon Ata
Author: atanasyan
Date: Mon Sep 14 06:23:02 2015
New Revision: 247548
URL: http://llvm.org/viewvc/llvm-project?rev=247548&view=rev
Log:
[mips] Add test case to check ABI flag emissions in case of inline assembler
Follow up to r247546. The test case reproduces the problem fixed by this commit.
Ad
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D12234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
84 matches
Mail list logo