[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

2020-01-14 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a subscriber: merge_guards_bot. tycho added a comment. In D72404#1820461 , @merge_guards_bot wrote: > {icon times-circle color=red} Unit tests: fail. 61858 tests passed, 1 failed > and 781 were skipped. > > failed: Clang.CodeGen/thinlto-deb

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

2020-01-15 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a comment. I did some local work to make this build and pass almost all tests on Linux as well, not to make use of the multi-process features but just to avoid having a separate "for Windows only" branch, and to ensure tests pass across platforms. Unfortunately my change is not at a

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-08-06 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a comment. Two things: - I'm curious why we would want to force `-O2`/`-O3` instead of just allowing `-Os`/`-Oz` to be used with LTO. Is optimizing for size combined with LTO really that unusual? I've built several projects using GCC with `-Os -flto` and the size reduction over pla

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-08-06 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a comment. OK, that makes sense. So this change would not enforce `-O2`/`-O3` for the bitcode emission, but would enforce one of the two for the LTO phase. This may be a stupid question, but aren't there some optimization passes that can emit functions during the LTO phase that were

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

2019-09-13 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a comment. I rebased this myself on the release_90 branch and I was pleasantly surprised that I got the merge right on the first try (?!), and it actually works well without any significant changes (other than merge conflict resolutions). I've run into two problems with it though:

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

2019-09-13 Thread Steven Noonan via Phabricator via cfe-commits
tycho added a comment. OK, those two problems were actually easy enough to fix. diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp index 2f98cf9e04..93e974842f 100644 --- a/lib/Driver/Driver.cpp +++ b/lib/Driver/Driver.cpp @@ -3241,8 +3241,8 @@ void Driver::BuildActions(Compilat