I see. agreed. Will upload shortly From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Tuesday, December 26, 2017 19:52 To: reviews+d41583+public+5c6eea8282599...@reviews.llvm.org Cc: cfe-commits@lists.llvm.org; Tayree, Coby <coby.tay...@intel.com>; mgo...@gentoo.org Subject: Re: [PATCH] D41583: [x86][icelake][vaes]
I meant if the command line says “-mvaes -mno-aes” we should make sure to disable vaes On Tue, Dec 26, 2017 at 9:47 AM coby via Phabricator <revi...@reviews.llvm.org<mailto:revi...@reviews.llvm.org>> wrote: coby added inline comments. ================ Comment at: lib/Basic/Targets/X86.cpp:573 setMMXLevel(Features, AMD3DNowAthlon, Enabled); } else if (Name == "aes") { if (Enabled) ---------------- craig.topper wrote: > Shouldn't -aes imply -vaes? how come? perhaps i'm missing here something? why would the first imply the latter? following this road an atom z8XXX should be capable of supporting vaes, for example (where it lacks avx, for example, https://www.intel.com/content/www/us/en/processors/atom/atom-z8000-datasheet-vol-1.html) also, in that sense, pclmul is implying vpclmulqdq Repository: rC Clang https://reviews.llvm.org/D41583 -- ~Craig --------------------------------------------------------------------- Intel Israel (74) Limited This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
