[PATCH] D158409: [WebAssembly] Add multiple memories feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86ed8cb8fabe: [WebAssembly] Add multiple memories feature (authored by ashleynh, committed by tlively). Changed prior to commit:

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"],

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added a comment. The other file to update here is clang/test/Driver/wasm-features.c. It looks like we haven't been as consistent about updating that one. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"],

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

tlively added a comment. In D151820#4385512 , @dschuff wrote: > I seem to recall that @tlively and I spent a bunch of time with XNNpack > chasing down some kind of subtle error that I suspect had to do with > alignment, but maybe he remembers that

[PATCH] D150833: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD

This revision was automatically updated to reflect the committed changes. Closed by commit rGc672c3fe05ad: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150833/new/

[PATCH] D150833: [WebAssembly] Add wasm_simd128.h intrinsics for relaxed SIMD

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, jgravelle-google, sbc100. Herald added a project: All. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. It looks like the LLVM-side changes are generally moving Wasm type classification functions to a more global location. Since no other backend should care about these things, it would be better if we could get away without these changes. Comment at:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. Thanks for the ping, will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___ cfe-commits mailing list

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. In D139010#4158540 , @aaron.ballman wrote: > Roping in @jfb because I know he's been heavily involve in WebAssembly in the > past and he may have ideas/opinions. > > High-level question: are externref, funcref, and table types

[PATCH] D144169: [WebAssembly] Fix simd bit shift intrinsics codegen

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144169/new/ https://reviews.llvm.org/D144169

[PATCH] D133574: [C2x] reject type definitions in offsetof

tlively added a comment. FWIW I had to patch the musl used by Emscripten to work around this: https://github.com/emscripten-core/emscripten/pull/18510 The fix was simple and I don't have a strong opinion about the right way forward, but this change was slightly disruptive and I imagine other

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

tlively accepted this revision. tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-shuffle.ll:1-2 +; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM % comment. Thanks for taking this! Comment at: llvm/test/CodeGen/WebAssembly/simd-intrinsics.ll:159-160 ; CHECK-NEXT: return $pop[[R]]{{$}} -declare <16 x i8>

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

This revision was automatically updated to reflect the committed changes. Closed by commit rGae96b5bd2dd0: [WebAssembly] Update relaxed-simd instruction names (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138249/new/

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively updated this revision to Diff 476490. tlively added a comment. - Fix type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138249/new/ https://reviews.llvm.org/D138249 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 TARGET_BUILTIN(__builtin_wasm_relaxed_min_f64x2, "V2dV2dV2d", "nc", "relaxed-simd") -TARGET_BUILTIN(__builtin_wasm_relaxed_max_f64x2, "V2dV2dV2d", "nc", "relaxed-simd")

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively created this revision. tlively added reviewers: aheejin, maratyszcza. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`

This revision was automatically updated to reflect the committed changes. Closed by commit rGac3b8df8f2f4: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32` (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133428/new/

[PATCH] D133428: [WebAssembly] Prototype `f32x4.relaxed_dot_bf16x8_add_f32`

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

tlively added a comment. It would be good to add tests for more error conditions like in the externref patch and also additional errors like trying to apply __funcref to types that aren't function pointers. Comment at: clang/include/clang/Basic/Attr.td:4053 + let Spellings

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

tlively added a comment. Very nice! This LGTM with all these small comments addressed. Sorry for the long delay in reviewing. Comment at: clang/include/clang/AST/ASTContext.h:1149 #include "clang/Basic/RISCVVTypes.def" +#define WASM_TYPE(Name, Id, SingletonId) CanQualType

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

tlively added a comment. For reference, the existing error from the backend is something like this: test.cpp:9:5: error: WebAssembly 'tail-call' feature not enabled int foo(int x) { ^ Note that it points to the beginning of the callee rather than the specific line containing the tail

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

tlively added a comment. Oops, sorry about that. Will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 ___ cfe-commits mailing list

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

tlively created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a reviewer: aaron.ballman. Herald added a project: All. tlively requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

tlively added a comment. In D128282#3601100 , @asb wrote: > In D128282#3600355 , @tlively wrote: > >> I think the lines still differ in that one tests wasm32 and the other tests >> wasm64 (the triples are

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

tlively accepted this revision. tlively added a comment. I think the lines still differ in that one tests wasm32 and the other tests wasm64 (the triples are different). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGaff679a48c43: [WebAssembly] Implement remaining relaxed SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127170/new/

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively updated this revision to Diff 434968. tlively added a comment. - dot_add takes three operands Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127170/new/ https://reviews.llvm.org/D127170 Files:

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively planned changes to this revision. tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190 +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd")

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

tlively added a comment. No concerns about the WebAssembly changes. Will the default installation for folks who don't touch `LLVM_DISTRIBUTION_COMPONENTS` change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/

[PATCH] D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e8913d775ca: [WebAssembly] Fix names of SIMD instructions containing _zero (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

tlively added a comment. @dyung, this should be fixed by https://reviews.llvm.org/rGc01ec3083026f7e24e6c06f48a05d413e2c697d4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121014/new/ https://reviews.llvm.org/D121014

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3be9e0ba972c: [WebAssembly] Check bulk-memory when adjusting lang opts (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121014: [WebAssembly] Check bulk-memory when adjusting lang opts

tlively created this revision. tlively added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang.

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb67f3d96980: [WebAssembly] Add prototype relaxed float to int trunc instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112186/new/ https://reviews.llvm.org/D112186

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

tlively added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18373-18374 +llvm::Type *SrcT = Vec->getType(); +llvm::Type *TruncT = +FixedVectorType::get(llvm::IntegerType::get(getLLVMContext(), 32), 4); +Function *Callee =

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

tlively added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1fb13401e1b: [WebAssembly] Add prototype relaxed float min max instructions (authored by ngzhian, committed by tlively). Repository: rG LLVM

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112146/new/ https://reviews.llvm.org/D112146

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice! Just a couple nits but I think this is good to go. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1478-1479 + } else { +GA =

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2542bfa43a97: [WebAssembly] Add prototype relaxed swizzle instructions (authored by ngzhian, committed by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks! I'll go ahead and land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112022/new/ https://reviews.llvm.org/D112022

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1365 + +def wasm_relaxed_swizzle : SDNode<"WebAssemblyISD::RELAXED_SWIZZLE", wasm_swizzle_t>; + ngzhian wrote: > @tlively i'm not 100% sure if this is needed or the

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

tlively added a comment. This is looking good! I'll take a more thorough pass through tomorrow so we can get this landed. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1455 + const SDValue , +

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

tlively closed this revision. tlively added a comment. I forgot to include the revision URL in the commit message, but this has been landed as rGda07942834fe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Awesome, thanks! I'll go ahead and land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111914/new/ https://reviews.llvm.org/D111914

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f519825ba56: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

tlively updated this revision to Diff 374606. tlively added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110295/new/ https://reviews.llvm.org/D110295 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

tlively created this revision. tlively added reviewers: aheejin, ngzhian. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1552179ac019: [WebAssembly] Add relaxed-simd feature (authored by ngzhian, committed by tlively). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Great, thanks! I will take care of landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

tlively added a comment. Nice! Thanks for writing this :D Do you know what happens when you actually try to compile some code with `-mrelaxed-simd`? I'm concerned that it will throw an error because the "relaxed-simd" target feature has not yet been defined in the backend (specifically in

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

tlively added a comment. In D108464#2960623 , @rjmccall wrote: > + JF, who knows something about Web Assembly, or can at least drag in the > right people > > In D108464#2959591 , @wingo wrote: > >> In

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

This revision was automatically updated to reflect the committed changes. Closed by commit rG88962cea4680: [WebAssembly] Restore builtins and intrinsics for pmin/pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108387/new/

[PATCH] D108415: [WebAssembly] Make shift values unsigned in wasm_simd128.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG64a9957bf7b6: [WebAssembly] Make shift values unsigned in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108415/new/

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2456e11614c1: [WebAssembly] Add SIMD intrinsics using unsigned integers (authored by tlively). Changed prior to commit:

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd3bd63df26a: [WebAssembly] Make bitmask instructions return unsigned ints (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D108401?vs=367591=367653#toc Repository: rG LLVM

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

tlively added a comment. Thanks! Will move the relevant test changes up from https://reviews.llvm.org/D108412 to here before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108401/new/ https://reviews.llvm.org/D108401

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

tlively added a comment. In D108412#2955996 , @craig.topper wrote: > Did you read this twitter thread too or just coincidence? > https://twitter.com/rygorous/status/1428207170403725316?s=20 Yes I did :D Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108415: [WebAssembly] Make shift values unsigned in wasm_simd128.h

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On some platforms, negative

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For each SIMD intrinsic

[PATCH] D108401: [WebAssembly] Make bitmask instructions return unsigned ints

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since they are bitmasks, it

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D106724: [WebAssembly] Codegen for extmul SIMD instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33786576fd3a: [WebAssembly] Codegen for extmul SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106724: [WebAssembly] Codegen for extmul SIMD instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85157c007903: [WebAssembly] Codegen for pmin and pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), aheejin wrote: >

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481084f669e1: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9 (authored by tlively). Repository: rG LLVM Github Monorepo

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D106611: [WebAssembly][NFC] Update test expectations labels after db7efcab7dd9

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit db7efcab7dd9

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8af333cf1a77: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-unsupported.ll:13 ; CHECK-LABEL: ctlz_v16i8: -; CHECK: i32.clz +; CHECK: i8x16.popcnt declare <16 x i8> @llvm.ctlz.v16i8(<16 x i8>, i1) aheejin wrote: > Aren't these now...

[PATCH] D106500: [WebAssembly] Remove clang builtins for extract_lane and replace_lane

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb7efcab7dd9: [WebAssembly] Remove clang builtins for extract_lane and replace_lane (authored by tlively). Repository: rG LLVM Github Monorepo

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D106500: [WebAssembly] Remove clang builtins for extract_lane and replace_lane

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These builtins were added to

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a57ee1276ed: [WebAssembly] Codegen for v128.load{32,64}_zero (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

tlively updated this revision to Diff 360485. tlively added a comment. - Add aligment tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106400/new/ https://reviews.llvm.org/D106400 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a comment. In D104797#2879855 , @pmatos wrote: > @tlively once D105423 lands, is it enough > to test and reland it under this revision or shall i open a new one? You can just reland it under this

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a4229f70f81: [WebAssembly] Codegen for v128.storeX_lane instructions (authored by tlively). Changed prior to commit:

[PATCH] D106019: [WebAssembly] Codegen for v128.storeX_lane instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG970e0900104d: [WebAssembly] Codegen for v128.loadX_lane instructions (authored by tlively). Changed prior to commit:

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:324 + PatFrag<(ops node:$ptr, node:$vec, node:$idx), + (vector_insert $vec, (i32 (extloadi8 $ptr)), $idx)>; +def load16_lane : aheejin wrote: > Why are i8

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively updated this revision to Diff 358668. tlively marked 2 inline comments as done. tlively added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105950/new/ https://reviews.llvm.org/D105950 Files:

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc",

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbabfc63b1be: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc",

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively updated this revision to Diff 357983. tlively added a comment. - Check types of splats as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105755/new/ https://reviews.llvm.org/D105755 Files:

[PATCH] D105675: [WebAssembly] Custom combines for f64x2.promote_low_f32x4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5220104d070: [WebAssembly] Custom combines for f64x2.promote_low_f32x4 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105675: [WebAssembly] Custom combines for f64x2.promote_low_f32x4

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -?

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -:

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -:

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a subscriber: aeubanks. tlively added a comment. The opaque pointers project is documented here: https://llvm.org/docs/OpaquePointers.html. It's been making very slow progress for the past few years but has recently been picking up steam under the direction of @aeubanks. Search

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added a comment. Unfortunately I don't think In D104797#2836475 , @pmatos wrote: > @tlively Do you think it would be ok to re-add the code removed in `ac81cb7e` > but only error if the pointer is to an **opaque** non-integral type?

  1   2   3   4   5   >